Commit Graph

33073 Commits

Author SHA1 Message Date
Shauren
22a3cb4432 Core/Auction House: Fixed sorting in non-equipment categories 2020-06-18 10:57:26 +02:00
TDB Release
6e62bf5a1e TDB 830.20061 - 2020/06/17 TDB830.20061 2020-06-17 17:09:48 +00:00
Shauren
574ee17d6d Core: Updated allowed build to 8.3.0.34769 2020-06-17 10:01:19 +02:00
Carbenium
f387673aa3 CMake: Use target_precompile_headers instead of cotire with CMake >= 3.16.0 2020-06-16 09:29:31 +02:00
Carbenium
18ad767226 CMake: Remove guards around CMP0043 and CMP0054
We require CMake >= 3.8 which includes the policies.
CMP0043 OLD behaviour is still required by cotire.
2020-06-16 09:29:31 +02:00
jackpoz
c3a7a604f4 Build/CMake: Increase minimum version to 3.8
(cherry picked from commit 965ac6fb08)
2020-06-16 09:29:31 +02:00
Giacomo Pozzoni
0f390606a1 Build/CMake: Set some policies to NEW (#23779)
* Build/CMake: Set CMP0005 to NEW

See https://cmake.org/cmake/help/v3.2/policy/CMP0005.html

* Build/CMake: Set CMP0043 to NEW

See https://cmake.org/cmake/help/v3.2/policy/CMP0043.html

* Build/CMake: Set CMP0074 to NEW

See https://cmake.org/cmake/help/v3.12/policy/CMP0074.html

(cherry picked from commit 18cc36bc67)
2020-06-16 09:29:31 +02:00
Shauren
c715e635cf Merge pull request #24554 from funjoker/cherry-picks 2020-06-15 00:26:08 +02:00
Carbenium
abff505a6e common: Add a missing include guard 2020-06-15 00:22:12 +02:00
Aokromes
cf88f0a973 DB/Misc: Remove one startup error
(cherry picked from commit d6fbe99432)
2020-06-14 23:49:05 +02:00
Killyana
43f771a4f0 DB/Creature: Add some Ziggurat Defender spawns
(cherry picked from commit a87bc7826a)
2020-06-14 23:49:05 +02:00
ariel-
7c2e83604c Core/Scripts: moved Wild Growth calculation to script and fixed formula
Thanks ccrs for the formula

(cherry picked from commit 96ee23487f)
2020-06-14 23:49:05 +02:00
ariel-
8e44a6a381 Core/AI: restore old check forcing PetAI on Pets using SmartAI
includes more template love

Closes #19837

(cherry picked from commit 9c24ec5c96)
2020-06-14 23:49:05 +02:00
Aokromes
8cddf0d2c7 DB/Misc: Fix some startup errors
(cherry picked from commit 67115eda7e)
2020-06-14 23:49:05 +02:00
ForesterDev
15609a197e Scripts/Gossip: fix go_ahune_ice_stone (#19835)
(cherry picked from commit f9a01c4b69)
2020-06-14 23:49:05 +02:00
ariel-
3cf5db1831 Core/Globals: add more AIName and MovementType checks to ObjectMgr
- Ninja fix AI factories (restores prev behaviour of not selecting stuff with PERMIT_BASE_NO)

Closes #19831

(cherry picked from commit d56a28afee)
2020-06-14 23:49:05 +02:00
Keader
e50a95839c Core/Scripts: Fixed some events that not should triggered by non-players on Illidan encounter
(cherry picked from commit 0c6829f7f2)
2020-06-14 23:49:05 +02:00
Aokromes
cdf591f6f0 DB/Creature: Fix 2 incorrect MovementType
Updates #19831

(cherry picked from commit 877749cf3f)
2020-06-14 23:49:05 +02:00
Shauren
1fd59700d7 Core/Groups: Fixed calculating canReset attribute
Broken in d6df19cd99.

(cherry picked from commit 0222d9fc1a)
2020-06-14 23:49:05 +02:00
Shauren
042418cf26 Revert "Core/Groups: fix wrong query for loading group instance data. canReset attribute was calculated in the wrong way"
This reverts commit 0c1dd398bd.

Closes #19745

(cherry picked from commit 023d252155)
2020-06-14 23:49:05 +02:00
Keader
c9c178db19 Core/Spells: Removed duplicated check again followup 3a0417f712
to send some info to client

(cherry picked from commit ed43883160)
2020-06-14 23:49:05 +02:00
Keader
19602c2e83 Core/Spells: Removed duplicated check
unitTarget was checked twice in Spell::EffectTaunt

(cherry picked from commit 3a0417f712)
2020-06-14 23:49:05 +02:00
ariel-
1881088744 Core/AI: Factory functions cleanup
- Get rid of fugly void pointers
- Streamlined AI selection code, using Permissible as it should've been instead of harcoded checks on the selector code
- Moved IdleMovementGenerator singleton to factory code

(cherry picked from commit ce3787f190)
2020-06-14 23:49:05 +02:00
ariel-
43339e6840 Core/Players: fix null dereference crash
(cherry picked from commit c3176a8143)
2020-06-14 23:49:04 +02:00
treeston
57e3a67c94 Fix an issue where CanSpawn would never get invoked on creatures without per-guid script.
(cherry picked from commit aeaa8ecfab)
2020-06-14 23:49:04 +02:00
treeston
803012cc40 Add another helper to ScriptedGossip.h for resolving listId -> action.
(cherry picked from commit 302a039b7c)
2020-06-14 23:49:04 +02:00
sirikfoll
c99963b023 Core/Scripts Properly set Freya's BossState do DONE and avoid some loot exploits
Closes #19823

(cherry picked from commit 1cc0458b11)
2020-06-14 23:49:04 +02:00
Treeston
aa811d57b6 Partial revert of 15a207f, which was causing issues (ref #4943 and #19768). Instead, fix the underlying issue from 15a207f one level further down - Unit::getAttackerForHelper() shouldn't return units that we aren't in combat with (victim can be such a unit for players/player pets, which can startattack from a distance without entering combat). (#19814)
Fixes the following issues:
- Player pets would aggro neutral mobs as soon as they start autocasting (Imp's Firebolt) if they're in react range (due to victim != null, autocast counts as autoattack and sets victim)
- Neutral mobs would randomly evade when aggro switched between targets.

Closes #19768, #19485 and #10921.

(from PR #19814)

(cherry picked from commit 69fd6245dc)
2020-06-14 23:49:04 +02:00
Dr-J
e782799c30 DB/Conditions: Charles Worth
Correct conditions for gossip

closes #19516

(cherry picked from commit 607686a912)
2020-06-14 23:49:04 +02:00
Killyana
c8901a52ee DB/Creature: Remove double spawns from Death Knights area
(cherry picked from commit 7f1315f77d)
2020-06-14 23:49:04 +02:00
Dr-J
800d664502 DB/SAI: Add some missing charmed flags
DB/SAI: Add missing charmed flags to blight geists which is required for when they are charmed as part of it roll's downhill.

(cherry picked from commit f2c351158b)
2020-06-14 23:49:04 +02:00
ForesterDev
7211c6e51d Scripts/Command: implement .debug play music command
Closes #19809

(cherry picked from commit dd4ff1fe54)
2020-06-14 23:49:04 +02:00
Killyana
3f83c9dd1d DB: Add some missing Broadcast Text
(cherry picked from commit 60a69bcd3d)
2020-06-14 23:49:04 +02:00
Treeston
496263fccb Fix evade issues when a spell hits the target just before evading. (#19815)
- Creatures should no longer get stuck in evade mode following a target if a spell hits the creature just as it's entering evade mode.
- Fixes and closes #4943. Finally.

(cherry picked from commit 1945874f96)
2020-06-14 23:49:04 +02:00
ariel-
b1f1cc4514 Core/Spell: in case of immunity, check all effects to choose correct procFlags, as none has technically hit
(cherry picked from commit 63e502a67d)
2020-06-14 23:49:04 +02:00
treeston
6f73960480 Instances/Ulduar: Fix a super edge case bug where Algalon would evade if his tank successfully tanked a Cosmic Smash and got knocked up. Shadow priests everywhere rejoiced.
(cherry picked from commit b6a4e9f3f9)
2020-06-14 23:49:04 +02:00
ariel-
444754e65a Core/SmartAI: allow SMART_ACTION_SEND_GOSSIP_MENU to override default gossip
Closes #19769

(cherry picked from commit f2b0819e53)
2020-06-14 23:49:04 +02:00
treeston
250aef5186 Quickfix a bug introduced by 2f19d97 which prevented GTAoE from being cast.
(cherry picked from commit 1c528c30f8)
2020-06-14 23:49:04 +02:00
ariel-
f1eb73001c Core/Spell: fixed some problems with per caster aura states
- Update clients whenever target has more than one application of an aura that applies such aurastate
- Update again when one application gets removed
- Fixed Fire and Brimstone computing damage if any warlock applied the Immolate (should only count for own)

Closes #19790

(cherry picked from commit e27c385b48)
2020-06-14 23:49:04 +02:00
ariel-
6fa8b8e1d5 Core/Creature: fix _DespawnAtEvade saving wrong respawn time
Closes #19557

(cherry picked from commit 47d387d6b0)
2020-06-14 23:49:04 +02:00
ariel-
25f47e4680 Core/Spell: abort channeling if no valid targets are found after searching
Closes #17624

(cherry picked from commit 2f19d97d21)
2020-06-14 23:49:03 +02:00
ariel-
b161447b47 Scripts/VioletHold: fix stack overflow when reflecting 'Splash'
Closes #19514

(cherry picked from commit d9a1c82ab4)
2020-06-14 23:49:03 +02:00
Keader
a3439b6555 DB/Spells: Fixed Paladin T8 Holy 2P Bonus proc
Close #19796

(cherry picked from commit 4fcea41519)
2020-06-14 23:49:03 +02:00
Killyana
8c6d28f72d DB/GamObject: Sons of Hodir Gameobject quest givers Visibility
Closes #19787

(cherry picked from commit 66bd3459e4)
2020-06-14 23:49:03 +02:00
Aokromes
ce1dc8b3de Fix build
(cherry picked from commit 195db7c7bb)
2020-06-14 23:49:03 +02:00
Dr-J
e9dc775686 DB/SAI: Tormenting the softknuckles
Fix script so that if player does not sucessfully kill the hardknuckle matriach it does not remain hostile as an invisible mob to players doing damage to players who get in agro range.

(cherry picked from commit a261056f58)
2020-06-14 23:49:03 +02:00
ariel-
412af93a28 Core/Player: update interaction checks, some info taken from client
(cherry picked from commit d03e97d53f)
2020-06-14 23:49:03 +02:00
Aokromes
282e1f152d DB/Commands: Typo in account set gmlevel help field
Closes #19448 by Heaven31415

(cherry picked from commit 3b8f85fd81)
2020-06-14 23:49:03 +02:00
ForesterDev
c34b83a467 Core/Defines: define faction templates and replace magic numbers from scripts
(cherry picked from commit abea8bf4cb)
2020-06-14 23:49:03 +02:00
Killyana
607c5ad554 DB/Creature: Blightguard spawns
(cherry picked from commit d96482b2d4)
2020-06-14 23:49:03 +02:00