Commit Graph

109 Commits

Author SHA1 Message Date
Shauren
8396dabdad Core/Misc: Fixed coverity issues
Uninitialized fields: CID 1354593, 1354595, 1354738
Unchecked return value: CID 1354558
Out of bounds access: CID 1352989, 1352993
Null pointer dereference: CID 1296286
2016-06-06 09:16:59 +02:00
Shauren
d59bba3c5d Core/Misc: Fixed uninitialized field
Coverity CID 1354596
2016-06-06 08:51:42 +02:00
Naios
be90932eda Core/Common: Move the query callback header to the database project
* Also renames the header to it's correct name QueryCallback

(cherry picked from commit d4d199d765)
2016-05-10 18:20:52 +02:00
Trond B Krokli
d1aa171a7a Core/authserver.conf.dist: missing description line (#17038)
This line is missing from authserver.conf.dist :
`#                     MySQL server and their own thread on the MySQL server.`

I have copied this description text line from the matching description in
`worldserver.conf.dist` (line 108 in the 3.3.5 worldserver source file).

This line is also missing in bnetserver.conf.dist , but the files are different
in line number, filename and folder, so bnetserver needs a separate commit.
(cherry picked from commit 329006d310)

# Conflicts:
#	src/server/authserver/authserver.conf.dist
2016-04-28 17:13:41 +01:00
Naios
51ec8d3b8c Core/Scripting: Use the path of the worldserver executable to search for the scripts dir
* Fixes issues when starting the worldserver not in the bin directory
  or the CMAKE_INSTALL_PREFIX directory using the -c option.

(cherry picked from commit 86b0fcf67a)
2016-04-18 23:03:24 +02:00
Shauren
c8b3ee3dd6 Core/Bnet: Fixed LoginREST.* address selection 2016-04-16 00:20:20 +02:00
Shauren
fa74fa1f4d Config: Extended description of LoginREST.*Address values 2016-04-12 00:13:30 +02:00
Gacko
b23a6aeaff Add missing configuration key LoginDatabase.SynchThreads. 2016-04-10 16:45:22 +02:00
Gacko
f5c46c78d3 Add missing configuration key BanExpiryCheckInterval. 2016-04-10 16:40:59 +02:00
Shauren
500d5db81e Renamed PublicKeyFile -> CertificatesFile 2016-04-10 14:05:30 +02:00
Gacko
7c3df3f5d3 Make private key and public key configurable.
Defaults to the files installed to the bin directory.
2016-04-10 13:31:39 +02:00
Shauren
4a3a178d7f Buildsystem: Initial changes to support building with vs clang toolset 2016-04-05 22:43:41 +02:00
Shauren
2babb00143 Core/Bnet: Add return LoginREST.ExternalAddress when LoginREST.LocalAddress is configured to localhost but client connects from a different machine in the network 2016-04-04 10:01:07 +02:00
Shauren
adc7b5e1f1 Core: Fixed VS 2013 build 2016-03-28 22:32:54 +02:00
Shauren
335a1e495c Clang build fixes 2016-03-28 19:32:33 +02:00
Shauren
ea652fbedd Build fixes 2016-03-28 18:47:13 +02:00
Shauren
dde620c402 Core: Updated to 6.2.4
* Rewrite bnetserver for new authentication protocol
2016-03-28 17:12:57 +02:00
DDuarte
b372935ce3 Typo fix 423bded9a6 2016-03-28 03:17:51 +01:00
DDuarte
423bded9a6 Core/Network: Change SocketMgr.StartNetwork to take the thread count by arg instead of config
AuthSocketMgr doesn't need "Network.Threads" config

Fixes "Missing name Network.Threads in config file authserver.conf"

Ref #16859

(cherry picked from commit 980f28d2ce)

# Conflicts:
#	src/server/authserver/Server/AuthSocketMgr.h
#	src/server/game/Server/WorldSocketMgr.cpp
2016-03-28 02:36:58 +01:00
Shauren
cfe8a6a58b Core/Misc: Moved RealmList to shared 2016-03-26 13:39:46 +01:00
Shauren
92e247b226 Core/Dep: Removed ZMQ dependency in preparation for future changes 2016-03-20 18:50:25 +01:00
Naios
a5c2c0c037 CMake: Use inherited dependencies in worldserver and authserver
* Closes #1679

(cherry picked from commit 03d249f063)
2016-03-19 23:19:55 +01:00
Naios
37dbbe22eb Dep/CppFormat: Update cppformat to cppformat/cppformat@5174b8c
(cherry picked from commit f52495c66b)
2016-03-16 16:12:04 +01:00
Naios
a8fe7f6eb7 Core/Database: Move singleton instances into compilation units
* Fixes issues when building shared libraries
  (prevents gcc and clang from providing several instance)
* Also instantiate the database worker pools in DatabaseEnv.cpp now.
2016-03-11 18:25:55 +01:00
Naios
30517cb1d3 Core/Common: Generalize platform specific includes in common/Platform 2016-03-11 18:25:55 +01:00
MitchesD
ce5def332f Core/Misc: fix build 2016-03-03 19:58:28 +01:00
Shauren
dea7d429ab Core/Debugging: Make abort() less bad on windows by forcing crash log generation 2016-03-03 17:29:48 +01:00
Naios
719159e207 Core/Common: Add a generic config helper to access built-in overwriteable paths.
* Adds CMAKE_COMMAND and CMAKE_BINARY_DIR to revision_data.h
* Move the source and mysql exe path handling out of the DBUpdater.
* Make some Config methods const for correctness.
* Remove C & CXX flags from revision_data.h
 (was unused and didn't capture all cxx vars)
* Reorder the link order to prevent `ld` from ignoring the file
* Ref #15671
2016-02-21 15:52:42 +01:00
Shauren
97a79af470 Core/Networking: Rewrite networking threading model
Each network thread has its own io_service - this means that all operations on a given socket except queueing packets run from a single thread, removing the need for locking
Sending packets now writes to a lockfree intermediate queue directly, encryption is applied in network thread if it was required at the time of sending the packet
2016-02-19 19:23:04 +01:00
Shauren
36a1b1ccd5 Core/Bnet: Moved expiring bans to background task running every minute by default (configurable) - no longer executed during login. 2016-02-16 00:14:59 +01:00
Vincent-Michael
478cc756eb Update copyright note for 2016
Happy new year (Again new year with idiots ...)
2016-01-01 00:34:25 +01:00
Gacko
6969bfc274 Config/BNetServer: Rename yet unused config key to match others. 2015-12-19 13:40:05 +01:00
Gacko
eebb47bc93 Config/BNetServer: Move Wrong.Password.Login.Logging to Auth Server Settings section. 2015-12-19 13:35:34 +01:00
Shauren
035a2b122e Core: Updated to 6.2.3.20726 2015-11-21 21:30:05 +01:00
Gacko
6b479e6c3e Server/Config: Fix typo in bnetserver.conf.dist 2015-11-16 21:46:41 +01:00
Shauren
783e8299cc Core/Misc: Fix for builds linked with libc++ instead of libstdc++ 2015-10-24 15:39:32 +02:00
Shauren
559c58f1c2 Core/Battle.net: Fixed warnings about uninitialized values 2015-10-12 17:14:26 +02:00
Naios
40e1fc0670 Core/Battle.net: Fix "comparison of integers of different signs" warning 2015-10-12 02:28:52 +02:00
Shauren
ee2b43e368 Core/Battle.net: Updated packet enums and added new build data 2015-10-10 20:19:41 +02:00
Sean Rhone
c28ee6a9a9 Update bnetserver.conf.dist
- New line for consistency
- Same as https://github.com/TrinityCore/TrinityCore/pull/15628 only for 6.x
2015-10-09 22:19:32 -04:00
Shauren
5743333e46 Core/Bnetserver: Fixed copypaste mistake for packet names 2015-10-07 23:48:50 +02:00
Naios
a2908719c0 Core/Bnetserver: Fix warnings caused through non virtual destructors. 2015-10-06 16:11:54 +02:00
Shauren
63def8aa32 Core/Battle.net:
* Changed packet structures to mirror client names
* Simplified ToString Building
* Removed deprecated structures

World: Cleaned up duplicate realm info 'realm' and 'realmHandle' variables (realmHandle was removed, that data is fully contained in realm)
2015-10-06 00:30:47 +02:00
Shauren
705e5ea5d9 Core/Battle.net
* Updated game account flags
* Fixed infinite loop in ReadFourCC if value in packet was 0
* Corrected ClosingReason enum in ConnectionClosing
2015-10-04 00:26:38 +02:00
StormBytePP
0bed9d56cb Core: Added ABORT() macro to prevent the usage of ASSERT(false) as a quick hack to crash the core misusing assert 2015-09-21 15:17:05 +02:00
Shauren
0fda78b679 Core/Bnetserver: Applied 375363ed08 to bnetserver - fixes a minor development annoyance where first login after startup is slow 2015-09-11 17:25:14 +02:00
StormBytePP
ba2e9fbe95 Core/BuildSystem: Merged crypto into common, cleaned include directory lists (to mimic 3.x buildsystem) 2015-08-24 03:35:19 +02:00
StormBytePP
1d2aafd39b Core/Build: Merge common library and move database out of shared 2015-08-21 17:52:42 +02:00
jackpoz
4617d65131 Merge pull request #15297 from StormBytePP/3.3.5_rename_Revision.h
Core/Build: Renamed Revision.h to GitRevision.h to avoid compile failure when old revision.h file is present
(cherry picked from commit 360cc93357)

Conflicts:
	src/server/authserver/Main.cpp
	src/server/database/Updater/DBUpdater.cpp
	src/server/game/Entities/Player/Player.cpp
	src/server/game/World/World.cpp
	src/server/shared/PrecompiledHeaders/sharedPCH.h
	src/server/worldserver/Main.cpp
2015-08-16 22:45:18 +01:00
StormBytePP
6a9fc63e41 Core/Build: Removed obsolete SystemConfig.h and made genrev be part of shared library, which allows cache hits to happen more likely
(cherry picked from commit 94f69fb1bc)
2015-08-16 17:50:40 +02:00