Commit Graph

5119 Commits

Author SHA1 Message Date
Keader
d825a06830 Core/Scripts: Razorscale Rewrite (#19828)
#MakeUlduarGreatAgain
2017-08-07 21:36:19 -03:00
Treeston
184c45cfe0 Core/Scripts: dynamic_spawning follow-up, I had forgotten JustRespawned existed.
- Rename JustRespawned to JustAppeared, which better matches its behavior anyway.
- Properly invoke JustAppeared for new (re-)spawns - fixes #20111.
- Fix Thaddius script to work with dynamic_spawning (mostly unrelated to the above) - Feugen/Stalagg should really be a summon group, but I don't have time to fix that right now.
- Fix default value for DynamicEscortNPC to match worldserver.conf.dist.
2017-08-06 16:07:30 +02:00
Treeston
759357049c Scripts/Commands: Fix some quirkiness and potential crashes with live DB modification commands (npc move and npc delete), which are horrible and should be deleted anyway.
Fixes #20104.
2017-08-02 22:05:40 +02:00
Treeston
c70b328eda more unneeded checks (follow-up 3b02029) 2017-08-01 18:14:55 +02:00
Treeston
3b02029cb6 remove an unused variable (follow-up fcd6fe0) 2017-08-01 17:58:17 +02:00
Treeston
fcd6fe0aac Scripts/Commands: New utility command: .list spawnpoints.
(I just needed it for dynspawn follow-up work, really.)
2017-08-01 03:42:11 +02:00
Aokromes
41721642f7 NoPCH Build fix 2017-07-31 22:56:21 +02:00
r00ty-tc
59db2eeea0 Dynamic Creature/Go spawning:
- True blizzlike creature spawn/respawn behavior - new creature = new object
 - Toggleable spawn groups (with C++/SAI/command options to use them)
 - Custom feature: dynamic spawn rate scaling. Accelerates respawn rate based on players in the zone.
 - Backward compatibility mode (set via group and for summons)
   to support creatures/gos that currently don't work well with this
   (this should be removed once the exceptions are fixed)

Fixes and closes #2858
Tags #8661 as fixable.
Fixes and closes #13787
Fixes #15222.
2017-07-31 21:21:04 +02:00
Treeston
7cbb6c101e Scripts/IcecrownCitadel: Prevent players from becoming inaccessible when killed by Lord Marrowgar's Impale spell (the initial damage, not the DoT). Also fix the underlying bug in vehicle logic. 2017-07-25 02:01:32 +02:00
Treeston
331e463de8 Core/PlayerAI: Some adjustments:
- Add a 2 second delay before the AI begins using spells. This should provide opportunity for counterplay before that rogue activates cloak and goes on an unstoppable rampage among your healers. (Sorry, guys.)
- Stopped the AI from attacking invalid targets under some conditions. It should now properly leash back and follow the charmer if we try to select an invalid target.
- Stopped the AI from constantly re-creating the follow movement generator (and thus spamming movesplines).
2017-07-21 23:00:14 +02:00
Treeston
c7896f3102 Core/Unit: For convenience, explicitly redirect CastSpell with nullptr as first argument to the Unit* overloads. No more ->CastSpell((Unit*)nullptr, ...) all over the place! 2017-07-21 18:02:48 +02:00
Treeston
42c993f8ad nopch fix 2017-07-21 17:36:04 +02:00
Treeston
d80d7c6685 Scripts/Auchindoun: Last one, hopefully. Remove reliance on large grid searchers by integrating with instance script. 2017-07-21 17:29:06 +02:00
Treeston
04dc47e7e2 Scripts/Auchindoun: Blackheart the Inciter fully fixed now. I had way too much fun with this one.
Two points of note:
1) Spawning 5 invisible triggers with 5 distinct factions which then MC one target each? Biggest. Hack. Ever. Best part? It's blizzlike.
2) For over ten years, I thought it was spelled "Auchinodoun". It's not. It's spelled "Auchindoun". TIL.
2017-07-21 16:07:27 +02:00
Treeston
068254d6b9 nopch fix 2 2017-07-21 05:29:39 +02:00
Treeston
777befaaa9 nopch fix 2017-07-21 05:27:39 +02:00
Treeston
a38141fd6c Scripts/Auchindoun: Replace the Blackheart the Inciter hack-filled script with a slightly less hack-filled script that actually mostly works. This should at least make the boss encounter possible to complete. No claims to correctness, of course. 2017-07-21 05:22:26 +02:00
Treeston
49aa8a2e59 Scripts/Spell: Port spell_generic.cpp to new script registration syntax wherever possible. No actual changes in functionality. (fb87ac8 follow-up) 2017-07-20 16:43:45 +02:00
Treeston
37f59f8850 Scripts/Item: Port spell_item.cpp scripts to new script registration syntax wherever possible. No actual changes in functionality. (fb87ac8 follow-up) 2017-07-20 01:26:15 +02:00
treeston
fb87ac8e8d Core/Scripts: Implement generic script loaders (and script registry macros) to greatly reduce code duplication (#19526) (cherry-picked from commit a9174d5). 2017-07-20 00:27:20 +02:00
treeston
02b1d8bb48 Scripts/Item: Change Nitro -> Boosts <- to use the correct knockup effect for their backfire. Also, script that knockup effect to work properly ("usually" deploy a rescue parachute). 2017-07-18 18:32:56 +02:00
treeston
125127ea73 Scripits/Item: Nitro. BOOSTS. 2017-07-18 14:11:12 +02:00
treeston
f953d85960 Scripts/Item: Fix Nitro Boosts to only fail in flyable areas. Also, it's called nitro _boosts_. Not _boots_. Nitro _boosts_. 2017-07-18 14:08:10 +02:00
treeston
e0194e4a2c Revert "Scripts/Commands: Fix a potential crash when summoning players that are just logging on." - the check was unnecessary (already done in extractPlayerTarget).
This reverts commit 05cdcdb230.
2017-07-17 23:23:54 +02:00
treeston
05cdcdb230 Scripts/Commands: Fix a potential crash when summoning players that are just logging on. 2017-07-17 23:00:46 +02:00
jackpoz
9cf4dd7345 Core/Misc: Fix static analysis issues 2017-07-16 18:20:29 +02:00
jackpoz
7d3291e804 Core/Misc: Fix static analysis issues 2017-07-15 16:31:07 +02:00
jackpoz
b2a341df6e Core/Misc: Fix static analysis issues 2017-07-15 16:22:32 +02:00
Regigicas
d9c83a6c01 Scripts/Commands: Fix a crash on summon when no group is avaible (#20029)
Closes #20027
2017-07-15 12:43:03 +01:00
treeston
3f8c0cb446 Some more script adjustments ported from #19930. 2017-07-11 12:52:53 +02:00
treeston
74af880217 Hi, I'm Treeston, and welcome to Combat PR Prep Refactors.
Today, we're moving UNIT_FLAG_IMMUNE_TO_PC and UNIT_FLAG_IMMUNE_TO_NPC to higher-level abstraction so combat manager can react to it.
New methods on Unit:
- void SetImmuneTo<All/PC/NPC>(apply, keepCombat = false);
- bool IsImmuneTo<All/PC/NPC>() const;
2017-07-09 02:07:29 +02:00
Keader
3aadb72eaa Build fix 2017-07-08 13:13:01 -03:00
Keader
e254ebebbe Core/Custom: Fixed SPELLMOD_COOLDOWN exploit on Duel Reset system
Followup 0048d4b618
Closes #17419
2017-07-08 13:08:50 -03:00
Nyeriah
746fce30d9 Scripts/Karazhan: Fix Attumen and Midnight not moving towards each other on phase transition after latest changes 2017-07-08 12:37:03 -03:00
treeston
2739a5c5f5 Some more refactoring prep for combat/threat (#19930). 2017-07-03 17:33:34 +02:00
Keader
0048d4b618 Core/Custom: Fixed Duel Reset Exploits
Close #17419
*Fixed exploit with SPELLMOD_COOLDOWN
*Fixed exploit with some items (like Sylvanas' Music Box)
*Little cleanup
2017-07-01 16:56:30 -03:00
Shauren
c8480f171a Nopch fix 5 and should be last 2017-07-01 21:47:00 +02:00
Shauren
235194bf54 typo fix 2017-07-01 21:37:07 +02:00
Shauren
7a72a170be Nopch fix 4 2017-07-01 21:33:34 +02:00
treeston
0f47868d34 nopch fix episode 3: revenge of that one boss in slabs that is borked anyway 2017-07-01 21:21:16 +02:00
Treeston
e2a1ccd118 [3.3.5] Combat/Threat rewrite - prep & refactor (#19966)
* Combat/Threat rewrite (PR #19930) prep work. Mostly refactors, and a compatibility layer on ThreatManager/HostileReference that allows scripts to be changed already.
2017-07-01 20:18:02 +02:00
Shauren
5879eb2198 Core/Spells: Add missing validate 2017-07-01 11:57:16 +02:00
treeston
e07a322a3e Combustion will now properly go on cooldown when the buff is manually cancelled. Fixes #19968. 2017-06-30 18:25:11 +02:00
treeston
e35092c6a1 Combat/threat rewrite prep - merge RBAC/DB changes. 2017-06-28 17:27:34 +02:00
Gildor
629095ae21 Warrior: Fix T10 Melee 4P Bonus (#19954) 2017-06-24 15:20:59 +02:00
Shauren
dcc43de72f Buildsystem: Exclude ScriptPCH from all targets when building dynamic scripts (except MSVC)
(cherry picked from commit 550c57a0df)
2017-06-22 02:37:09 -03:00
Shauren
da9de83454 Core/Scripts: Optimize PCH contents
(cherry picked from commit a9b64d737d)
2017-06-22 02:36:13 -03:00
Shauren
5024813fe3 Buildsystem: Minor PCH building changes
* *PCH.cpp are now only compiled with MSVC, other compilers use custom helper commands to generate the precompiled header
* Don't call the linker for pch helpertargets

(cherry picked from commit 137f5e7887)
2017-06-22 02:33:12 -03:00
ariel-
85a7d5ce9a Core: ported headers cleanup from master branch 2017-06-19 23:20:06 -03:00
Shauren
d6201e5dbb Core/Grids: Ported cmangos/mangos-wotlk@ea99457e50
(cherry picked from commit 9299e9bde0)
2017-06-19 13:16:13 -03:00