Commit Graph

21739 Commits

Author SHA1 Message Date
Treeston
0ae2afe307 Scripts/World: Rewrite air force trigger bots script, add hostility check along the way. Closes #23307. 2019-07-09 18:24:43 +02:00
ccrs
bec52dba3d Core/Movement: add missing parenthesis on MotionMaster::Size
pretty sure this can cause unexpected behaviour
2019-07-09 15:25:25 +02:00
Treeston
be96d8242c warning fix f2cd721 follow-up 2019-07-08 21:53:50 +02:00
Treeston
a1fd404b64 Core/Quest: Do not allow quests to be turned in if the player no longer satisfies level/skill/reputation requirements. Fixes #226. Yes, you read that issue tag right. 2019-07-08 21:35:57 +02:00
Treeston
f2cd721d53 Scripts/Naxxramas: Thaddius no longer evades on transition, and some general cleanup to that script. Fixes #23026. 2019-07-08 20:16:29 +02:00
Ianislav Vasilev
c71e36acae Scripts/Blood Furnace: Broggok improvements (#23300)
* 23285 Fixed lever respawn and future encounters after it respawns.

* Removed unnecessary additional container.
Made lever not to despawn and respawn but rather change flags only.

* Made one conditional branch easier to debug.
2019-07-08 19:53:08 +02:00
Treeston
a3c3526269 Scripts/Outland: Rewrite the Watch Commander Leonus event so it no longer starts exponentially more often if the grid remains loaded for over an hour. Closes #23348. 2019-07-08 16:04:32 +02:00
Sorikoff
a64d7df662 Scripts/Spells: Brittle Armor & Mercurial Shield (#23576) 2019-07-08 15:42:35 +02:00
ForesterDev
e71773140c Scripts/Commands: update .wp commands to use orientation field from DB (PR #23566)
Closes #23330
2019-07-08 14:16:10 +02:00
Treeston
671052575a Entities/Player: Properly restore PvP-enabled state on login 2019-07-08 14:09:57 +02:00
Aokromes
574a7c8d3d Core/Misc: More coding standards (#23519)
* Core/Misc: More coding standards

* revert part

* "void  " or more to "void "

* fix? reject

* remove more double whitespaces

* remove more double whitespaces

* more standards

* more coding standards

* More standards

* more coding

* more coding standards

* more coding standards

* And more standards
2019-07-08 12:51:42 +02:00
Treeston
84b7b2e08e Entities/Unit: Nuke Map::ForceRespawn from orbit, with the following implications:
- .npc respawn no longer causes stupid things to happen (Fixes #23014)
- ::DeleteFromDB methods on Creature and GameObject rewritten to be as sensible as such a colossally stupid method can ever be. They're static now.
- .npc delete and .gobj delete ported to new argument handling, and rewritten as per above. They can no longer crash the server when used in instances, too. Yay for that.
- Adjusted various dusty cobwebbed hacks around the core (why does waypoint visualization use permanent spawns *shudder*) to still work too.
2019-07-08 11:56:41 +02:00
ccrs
ec1a77bca2 Build: fix linking error
/home/circleci/project/src/server/game/Movement/MovementGenerators/RandomMovementGenerator.cpp:50:9: fatal error: use of undeclared identifier 'AddFlag'
        AddFlag(MOVEMENTGENERATOR_FLAG_TIMED_PAUSED);
        ^
2019-07-07 19:25:27 +02:00
Treeston
ded18a2690 Entities/Creature: Some asserts are now LOG_ERRORs that block spawning. Fix a group spawning bug exposed by the CoS merge. Improve some command output. 2019-07-07 19:18:32 +02:00
ccrs
b8c0aeaf14 Core/Movement: handle Resume/Pause on RandomMovementGenerator 2019-07-07 18:07:58 +02:00
ccrs
4fa3c04b72 Core/Unit: f869c49 followup
Movement Pause/Clear is already handled in Unit::SetCharmedBy and Unit::RemoveCharmedBy, respectively

TODO: missing PAUSE handling in RandomMovementGenerator
2019-07-07 17:41:36 +02:00
Wyrserth
f869c4969e Core/Vehicle: prevent creature vehicles from following their old movement generator when a player enters them in some cases.
Closes #21731 and #22368.
2019-07-07 17:12:22 +02:00
Wyrserth
9f6d3e93f9 Core/Quest: fix icon in gossip window for repeatable, non-autocomplete quests.
Closes #23572.
2019-07-07 15:43:02 +02:00
jackpoz
283ac3d374 Core/Misc: Fix no-pch build 2019-07-07 13:35:11 +02:00
Wyrserth
644910bdc1 DB/Trainer: remove required ability from Riding spells. The client should only show the required amount of skill.
Also comment out unused argument in previously committed script, thanks Aokromes for noticing!
2019-07-07 02:57:24 +02:00
Wyrserth
6199d458c3 Core/Misc: use Trinity's RandomShuffle() instead of soon-to-be-deprecated std::random_shuffle().
Thanks Riztazz for noticing!
2019-07-07 02:49:40 +02:00
Wyrserth
37862942ce Script/TheOculus: adapt Mage-Lord Urom's script to use EventMap, fix various issues with Teleport and Empowered Arcane Explosion, add missing heroic-mode spell Frost Buffet.
Closes #19452.
2019-07-07 02:32:53 +02:00
Wyrserth
1d1b77c3f0 Core/Spell: don't send duration for auras caused by dynobjects. 2019-07-07 00:06:49 +02:00
Wyrserth
6ef1b3e6c6 Script/BlackrockDepths: randomize timers for Ironhand Guardian's spell Gout of Flame. 2019-07-06 20:29:24 +02:00
Wyrserth
b87350807d Core/Spell: do not allow auras from dynamic objects to stack if they come from the same spell cast by the same caster. 2019-07-06 19:55:36 +02:00
Wyrserth
1bdbede7e0 Misc/Config: set decay timer for unlooted normal creatures to 5 minutes.
Now that respawns do not care about the previous corpse's state, there's no reason to force a very frustrating faster despawn.
2019-07-06 16:15:45 +02:00
Gooyeth
c30a27ef18 Core/Battleground: Implement previous opponent timer on Arena queue. (#21754) 2019-07-06 01:35:23 +02:00
Martin Topholm
4529a94e0d Script/BlackrockDepths: fix Ironhand Guardian's Gout of Flame spell cast. (#21816) 2019-07-05 23:46:55 +02:00
Wyrserth
8fcc82138f Script/Acherus: script out of combat event for Frost Death Knight trainer Amal'thazad. 2019-07-05 18:41:47 +02:00
Ovahlord
980047763a Core/Creature: Reworked creature aggro radius calculation (#20615)
* Core/Creatures: rewrote creature aggro radius calculation
* Formulas are taken from WoW Wiki
2019-07-05 18:21:00 +02:00
Wyrserth
30ba9c97fe Misc: explicitly mark fallthrough in switch statement as to avoid confusion. 2019-07-05 17:09:46 +02:00
Wyrserth
7fc1ecca8a Core/Player: fix crash happening when trying to send drunken state to nearby players while the character is loading. 2019-07-05 16:23:06 +02:00
Wyrserth
12e545f7e2 Core/Conditions: allow spellclick conditions to properly work for aura apply/remove (#23527) 2019-07-05 14:11:15 +02:00
ForesterDev
c44fb37f74 Core/Unit: Implement more helper methods (#23555) 2019-07-05 14:07:35 +02:00
SolarisSDK
ebfe5a637e Local-only mode fix (#23546)
* Local-only mode fix

In response to issue #21309

* Full patch also for boost 1.66 and newer
2019-07-04 19:18:44 +02:00
Giacomo Pozzoni
2cb4517303 Core/Quest: Fix repeatable quest mark (#23338) 2019-07-04 15:11:35 +02:00
Treeston
f44539b642 Entities/Unit: Properly unset engaged flag for creates that cannot have a threat list on combat exit. Fixes #23518. 2019-07-03 21:01:29 +02:00
Gildor
a0a64b10b5 Scripts/Icecrown Citadel: Ensure Deathbringer Saurfang cast Frenzy (#23559) 2019-07-03 19:32:27 +02:00
Treeston
4e767f1c7c Entities/Player: Fix an edge case where overlapping CCs could prevent player movement from being re-enabled. f6f1c48 follow-up. 2019-07-03 19:26:43 +02:00
Wyrserth
670085d8c0 Core/Quest: fix money reward for quests turned in at level cap. (#23495) 2019-07-03 17:42:23 +02:00
Wyrserth
858fa4d2dd Core/Reputation: don't allow quests to reward Honor Hold/Alliance Vanguard reputation to Horde players or Thrallmar reputation to Alliance players (#23552) 2019-07-03 16:09:21 +02:00
Treeston
f6f1c48aa5 Entities/Player: Clean up client control handling behavior around possession. Mind Control should no longer cause various weirdness. Closes #23539. 2019-07-02 11:58:12 +02:00
Wyrserth
a8b8a43b8d Script/HallsOfLightning: fix mistake related to Shattering Stomp in Volkhan's script, introduced in 3bb0abcd52.
Closes #23337.
2019-07-02 11:12:34 +02:00
ForesterDev
b47bb59e2a Core/Player: add helper methods GetNativeGender/SetNativeGender/SetGender (#23520)
* Core/Player: add helper methods GetNativeGender/SetNativeGender/SetGender and fix some cases, where we should get player gender, instead of modified by display gender

* fix merge

* Add virtual methods for Unit class
2019-07-02 10:17:02 +02:00
ccrs
401777d024 Core/Unit: rename several getters to follow codestyle
uint8 GetLevel()
        uint8 GetLevelForTarget(WorldObject const* /*target*/)
        void SetLevel(uint8 lvl)
        uint8 GetRace()
        uint32 GetRaceMask()
        uint8 GetClass()
        uint32 GetClassMask()
        uint8 GetGender()
2019-07-01 21:36:32 +02:00
Sorikoff
5c09ff51f7 Scripts/Spells: Dimensional Ripper - Everlook (#23547) 2019-07-01 20:55:30 +02:00
Wyrserth
028d16a812 Script/DarkmoonFaire: fix logical error in go_darkmoon_faire_music.
Closes #23548.
2019-07-01 14:39:52 +02:00
Wyrserth
c8289ada7f Core/Quest: do not send SMSG_QUESTGIVER_OFFER_REWARD right after SMSG_QUESTGIVER_QUEST_FAILED.
Allows the gossip window to close after the client receives a quest failed error (for example: not enough inventory space to store the reward).
2019-07-01 01:19:31 +02:00
ccrs
4c398743b9 Scripts/ICC: cleanup ReadSaveDataMore definition 2019-07-01 01:08:21 +02:00
ccrs
b19a23a5c6 Scripts/ICC: 3dbf3fe followup
repeat timer typo
2019-07-01 00:56:05 +02:00