Replace some unsafe WorldObject* class members and derived types in scripts with ObjectGuid.
Code cleanup.
(cherry picked from commit 2f92a2f58e)
Conflicts:
src/server/scripts/Northrend/Nexus/Nexus/boss_keristrasza.cpp
Remove some ToCreature() casts not needed anymore after 1ee90e1022 changes that moved IsPet() from Creature to Unit
(cherry picked from commit d243630acf)
Conflicts:
src/server/game/Entities/Player/Player.cpp
src/server/game/Spells/Spell.cpp
src/server/game/Spells/SpellEffects.cpp
* Category cooldown is stored with the spell that started the cooldown (and only resetting cooldown on that spell will clear cooldowns on entire category - this fully mirrors client behavior)
* This significantly reduces the amount of data saved to database for cooldowns
* Spell casts from items that have a different category specified than on spell will now check for cooldown during the cast
Closes#15349
Core/Build: Renamed Revision.h to GitRevision.h to avoid compile failure when old revision.h file is present
(cherry picked from commit 360cc93357)
Conflicts:
src/server/authserver/Main.cpp
src/server/database/Updater/DBUpdater.cpp
src/server/game/Entities/Player/Player.cpp
src/server/game/World/World.cpp
src/server/shared/PrecompiledHeaders/sharedPCH.h
src/server/worldserver/Main.cpp
Don't QQ because "OMG you're not testing any of your stuff", I can't build TC atm.
Memo: Meteor Flames have
```
[12] UNIT_CREATED_BY_SPELL: 74689/1.046616E-40
```
which isn't in DBCs, exists, but is not seen in sniffs.
Scripts/Ulduar: Fix a visual issue with Mimirons Rocket Strike and Fix Mimiron DB target attacking players
(cherry picked from commit 66bbdfb82c)
Conflicts:
sql/updates/world/2015_07_26_05_world.sql
Solves issues with the credit spells hitting the mount instead of the player itself.
(cherry picked from commit 5bbd7cff4c)
Conflicts:
sql/updates/world/2015_07_11_00_world.sql
Merge pull request #14776 from sirikfoll/SpellMidsummer
Core/Spells Add support for quest Torch Tossing/More Torch Tossing
(cherry picked from commit 8197467c87)
by sirikfoll
---
Rename 2015_08_29_00_world.sql to 2015_06_23_01_world.sql
(cherry picked from commit 352703e89b)
by MitchesD
---
Scripts/Spells: fix codestyle
thanks @whoami
(cherry picked from commit 0cba5558cf)
by MitchesD
---
Scripts/VioletHold: picked some things from pull request #11399 (thx MitchedD for initial work)
(cherry picked from commit 34a721ba84)
by joschiwald
---
Core/Scripts: Rework Violet Hold bosses adding missing spells/mechanics:
- Cyanigosa, Arcane Vacuum
- Ichoron, globules mechanic
- Moragg, optic link visuals
- Lavanthor, minor changes
- Zuramat, correctly implement void sentries
- Erekem, implement Windfury and correct management of Erekem Guards
- Script for the pre-event
Thx @ManuFe
(cherry picked from commit 0bb7f89e82)
Conflicts:
src/server/scripts/Northrend/VioletHold/boss_erekem.cpp
by mik1893
---
Rename 2015_06_08_01_world.sql to 2015_06_25_00_world.sql
(cherry picked from commit 8176902b17)
by MitchesD
---
Scripts/VioletHold: fixed non-pch build and codestyle
(cherry picked from commit e34f74dace)
by MitchesD
---
Scripts/VioletHold: Fix codestyle and unwanted crash in Violet/Hold
closes#14952 and #14953
(cherry picked from commit 49809bd404)
by mik1893
---
Scripts/VioletHold: fix a crash during Ichoron encounter
Closes#14962
(cherry picked from commit 7c01638d45)
by mik1893
---
Core/Misc: Fix build warnings
(cherry picked from commit 55681666b3)
Conflicts:
src/server/authserver/Main.cpp
by jackpoz
Fix Flame Leviathan instance lock not being granted to players because they were ejected from the vehicles as soon as boss died.
Players are now ejected some seconds later.
Close https://github.com/TrinityCore/TrinityCore/issues/15005
(cherry picked from commit b574c99549)
Add "line" optional parameter to ".mmap path" command to use raycast implementation of recast, useful to simulate charge paths.
(cherry picked from commit 37b157746e)
- removed some useless code (and some other random changes)
(cherry picked from commit 6680a7c331)
Conflicts:
src/server/scripts/Northrend/Nexus/EyeOfEternity/instance_eye_of_eternity.cpp
