Commit Graph

1951 Commits

Author SHA1 Message Date
ariel-
f7758954f7 Core/Scripts: add condition check for npc_wyrmrest_defender
minor code refactors

Closes #19299
2017-03-14 20:38:16 -03:00
Keader
bf5661e2fd Core/Scripts: Fixed Ingvar evade issue 2017-03-08 09:43:10 -03:00
xinef1
7567cafec8 Ensure that all actions are compared to fixed point in time (ie. world update start) (#18910)
- Actions will not be dependent on processing moment
- Increased GameObjects cooldown resolution to milliseconds, fixes arming time of traps to be exactly one second and not something from range (1000, 1999)
- Created GameTime namespace and UpdateTime class and moved there some code out of world
2017-03-01 22:19:25 -03:00
ariel-
12c680f9b1 Core/Scripts: Change null-check to assert
- ToPlayer() should never be null in this context
2017-03-01 19:35:39 -03:00
Keader
ecfb346d1a Core/Scripts: Fixed crash in Sindragosa
Closes #19227
2017-03-01 18:58:47 -03:00
ariel-
c69a7d1223 Core/Auras: reworked multiplicative AuraEffects calculation
- Splitted containers for flat modifiers and pct modifiers, as they now have different handling
- Amount is now multiplied only on apply; on unapply, iterate through auras and reset the counter
- Fixes many cases of rounding error due to applying/unapplying of small factors
- Allows amounts to be zeroed (ie with an AuraEffect of amount -100)
- Do a partial revert of 6dc37a9add, auras should update amounts only for items allowed (ie no more giving crit to a sword while having an axe in the other hand and being Poleaxe spec'd)
- SPELL_AURA_MOD_SCALE now scales additively, rather than multiplicatively (checked in sniffs)

Closes #18687
2017-02-27 14:24:20 -03:00
ariel-
ace2a75197 Core/Scripts: kill a warning 2017-02-25 05:17:33 -03:00
ariel-
01f5befcec Core/Scripts: Thrusting Hodir's Spear
- Everything is sniffed, enjoy this hell of a quest!

Closes #12808
2017-02-25 04:46:02 -03:00
Gustavo
4224259d83 Core/Unit: Correct speed calculus when affected by SPELL_AURA_MOD_MINIMUM_SPEED (#18136) 2017-02-24 12:20:20 +01:00
xinef1
b0ae5fadd1 Core/SmartAI: Various fixes and extensions for smart scripts: (#18673)
- Possible crashes fixed
- Memory leak fixed
- Implemented checking of vehicle conditions
- Extended eventphasemask to 12 bits (sql required to change DB field type)
- SMART_EVENT_GOSSIP_HELLO - added possibility to detect for gameobject reportUse call
- Renamed action SMART_ACTION_SET_FLY to SMART_ACTION_SET_DISABLE_GRAVITY (to reflect actual functionality)
- Added targetsLimit to action SMART_ACTION_CAST and SMART_ACTION_INVOKER_CAST to limit max amount of targets (selected randomly)
- Action SMART_ACTION_TALK corrected to always work as intended
- Properly call GroupEventHappens in action SMART_ACTION_CALL_GROUPEVENTHAPPENS if invoker was charmed or owned by the player
- Properly utilize followAngle in action SMART_ACTION_FOLLOW (db orientation should be in degrees), but keep backward compatibility
- Added action SMART_ACTION_SET_CAN_FLY (119) 0/1
- Added action SMART_ACTION_REMOVE_AURAS_BY_TYPE (120) AuraType, can be used to exit vehicle for example
- Added action SMART_ACTION_SET_SIGHT_DIST (121) sightDist
- Added action SMART_ACTION_FLEE (122) fleeTime
- Added action SMART_ACTION_ADD_THREAT (123) +threat, -threat
- Added action SMART_ACTION_LOAD_EQUIPMENT (124) equipmentId
- Added action SMART_ACTION_TRIGGER_RANDOM_TIMED_EVENT (125) minId, maxId
- Added action SMART_ACTION_REMOVE_ALL_GAMEOBJECTS (126), removes all owned gameobjects
- Added action SMART_ACTION_STOP_MOTION (127), stopMoving, movementExpired
- Extended target SMART_TARGET_HOSTILE_SECOND_AGGRO with following parameters maxdist, playerOnly, powerType + 1
- Extended target SMART_TARGET_HOSTILE_LAST_AGGRO with following parameters maxdist, playerOnly, powerType + 1
- Extended target SMART_TARGET_HOSTILE_RANDOM with following parameters maxdist, playerOnly, powerType + 1
- Extended target SMART_TARGET_HOSTILE_RANDOM_NOT_TOP with following parameters maxdist, playerOnly, powerType + 1
- Extended target SMART_TARGET_THREAT_LIST with maxdist
- Extended target SMART_TARGET_OWNER_OR_SUMMONER to be able to get charmer/owner of current owner
- Added new target SMART_TARGET_FARTHEST with maxDist, playerOnly, isInLos restrictions
- Added SpellHit hook to GameObjectAI and extended SmartGameObjectAI to call SMART_EVENT_SPELLHIT when gameobject is hit by spell
- Call GameObjectAI Reset hook on gameobject respawn (for ex. to reset one time events in smart scripts)
- Fixed some logic errors in code
- SmartAI Escorts properly despawn escortee if no players are in range
- Disable Evading while charming creature with SmartAI
- Don't call SMART_EVENT_RESPAWN for dead units before they actually respawn
- Don't call SMART_EVENT_RESPAWN for not spawned gameobjects
- Properly call SMART_EVENT_RESPAWN for gameobject respawn
- Allow action SMART_ACTION_SET_IN_COMBAT_WITH_ZONE to utilize targetlist
- Allow action SMART_ACTION_CALL_FOR_HELP to utilize targetList
- Allow action SMART_ACTION_SET_INVINCIBILITY_HP_LEVEL to utilize targetList
- Allow action SMART_ACTION_SET_VISIBILITY to utilize targetList
- Allow action SMART_ACTION_SET_ACTIVE to utilize targetList
- Allow action SMART_ACTION_ATTACK_START to select random attack target instead of first on the list
- Allow gameobjects to summon gameobjects with action SMART_ACTION_SUMMON_GO
- Properly store action invokers for action SMART_ACTION_WP_START, if no player invokers are found, distance despawn check won't be used
- Allow action SMART_ACTION_WP_RESUME to compensate for the state the unit actually is in (eg. combat)
- Allow action SMART_ACTION_MOVE_TO_POS to select random of the avaiable targets, not only the first one.
- Allow action SMART_ACTION_MOVE_TO_POS to utilize x, y, z parameters as an offset to calculated coordinates
- Action SMART_ACTION_RESPAWN_TARGET should never modify respawntime of already spawned gameobjects, use dedicated function
- Properly delete ontime events created by SMART_ACTION_CREATE_TIMED_EVENT
- If action could not be started because conditions were not satisfied, do not recalculate the waittime to action repeattime, use smaller value to recheck more frequently
- Allow target SMART_TARGET_CLOSEST_PLAYER to be used by gameobjects
- Allow target SMART_TARGET_OWNER_OR_SUMMONER to be used by gameobjects
- Fixed SMART_EVENT_COUNTER_SET to be only called for the id that was incremented
- Changed the way counters work
- Protect PhaseInc from surpassing maximum phase
- Added loading checks for missing NON_REPEATABLE flag if no repeatmin, repeatmax is set
- Added spell validation for SMART_ACTION_CROSS_CAST
2017-02-17 21:33:18 +01:00
Gustavo
4536846d7d Core/Scripts Update boss Skadi the Ruthless (#19114) 2017-02-12 05:43:55 -03:00
jackpoz
865a3a47ea Core/Misc: Fix static analysis issues 2017-02-11 21:01:11 +01:00
Keader
8f00aa92de Build fix and codestyle 2017-02-09 21:12:12 -03:00
Afgann
21b5a377e4 Core/Scripts: Moorabi encounter updated. (#19013) 2017-02-09 21:07:29 -03:00
xinef1
59ce3d6c9b Core/Misc: Moved CharacterInfo out of world to separate class
Closes #19030
2017-02-05 23:14:19 +01:00
Xinef
7c7b877c3f Core/Achievements: Optimized resetting achievement criteria by condition and changed the functionality to properly reset all possible criteria with given condition
Closes #18905
2017-02-05 16:41:45 +01:00
xinef1
e1f14215d8 Core/Creatures: Various fixes for creatures, regarding combat conditions, despawning, and few others (#18998)
* Made some changes to kiting mechanics, simplified code and made taunt auras prolong combat no matter the distance from the spawn
Unified some creature despawning code, removed some brutal direct calls in scripts
Don't play death anim on forced despawn
Removed some redundant visibility changes on creature despawn
Fixed possible problem with pet initializing template info from difficulty greater than normal
Properly keep UNIT_FLAG_IN_COMBAT on UpdateEntry call
Moved RegenerateMana function to general Regenerate(Power) function
Fixed increased health regeneration from polymorph for pets
Implemented CREATURE_TYPE_FLAG_GHOST_VISIBLE, those creatures will be properly seen when player is dead also
Removed hackfix from Gaeriyan and Franclorn Forgewright, fixed properly
Simplified ForcedRespawnTime code in ForcedDespawn
Do not allow to assist unit while evading or when enemy is evading
Do not allow to attack other units when evading or when the unit is evading
Corrected distance checking code before creature is allowed to evade, should fix some common problems
Properly return summon position for summoned creatures as their respawn position
Properly stop all moving units on gossip hello, no matter their npc flags
2017-02-05 15:39:22 +01:00
xinef1
86da1a19bb Core/Misc: Fix various crashes, also related to multithreading (#19012)
* When iterating groups we have to either do it not in multithreaded context (map updates) or start with checking maps (they are guaranteed to change in single thread update).
* Properly clear ComboPoint references on player remove 
* remove some possible references item may have when it is deleted during save. 
* Also clear all hostile references when unit is removed from map.
2017-02-04 22:37:16 +01:00
Keader
ce774918a7 Core/Scripts: Updated Ruby Sanctum instance model 2017-02-04 10:13:22 -03:00
Keader
c58dd6c166 Core/Ruby Sanctum: Improved General Zarithrian encounter
* Fixed spell timers
* Improved Codestyle
* Fixed minions number in 25 man
* Fixed movement
* Implemented DespawnAtEvade
*
2017-02-03 22:28:20 -03:00
ariel-
317efd51ec Core/Scripts: remove GMs from Sindragosa's Fury's targetlist
By Keader
Ref #18452
2017-01-28 01:42:50 -03:00
Keader
3c4dc3ec4f Core/Scripts: Removed double check of CheckRequiredBosses in Sindragosa 2017-01-27 23:42:25 -03:00
Gustavo
f57132b795 Core/Scripts Fix issue with Lady Deathwhisper's door 2017-01-26 00:17:46 +01:00
Keader
591a25500d Core/Scripts: Fixed Crok event not starting
[*] Fixed Svalna entering in combat with people ouside of room
Closes #8186
2017-01-21 11:03:26 -03:00
Rushor
a3c6880579 Revert "[3.3.5][master] Core/Movement: Smooth movement #13467 (#18020)" (#18888)
This reverts commit 28050f338d.

Conflicts:
	src/server/game/AI/SmartScripts/SmartAI.cpp
	src/server/game/AI/SmartScripts/SmartScriptMgr.cpp
2017-01-20 14:16:47 +01:00
Keader
55c3eb66d7 Core/Scripts: Removed unneeded check in Blood Prince Council 2017-01-13 17:07:03 -03:00
Keader
a884660d50 Core/Scripts: Fixed issues in Gal'darah fight
Closes #16219

* Added DespawnAtEvadeMethod
* Fixed Agro
* Implemented Stampede
* Fixed Rhino Spirit flags
* Updated codestyle
2017-01-09 11:36:51 -03:00
Keader
bef8a6dee5 Core/RubySanctum: Updates in Saviana Ragefire encounter
* Fixed Codestyle
* Fixed Spell timers
* Added DespawnAtEvade Method
2017-01-08 23:44:36 -03:00
Keader
ba1df45d36 Core/Scripts: Palehoof rewritten & Utgarde Pinnacle updated (#18712)
Closes #15405
2017-01-06 20:47:36 -02:00
Keader
cf6fc37771 Core/Scripts: Missing break and added ZBoundary in Blood Queen Lana Thel 2017-01-02 17:26:39 -03:00
Rushor
1551738c55 Scripts/TrialOfTheCrusader: Anub'Arak Enable Emerge Emote (#18721) 2017-01-02 17:37:35 -02:00
tkrokli
6a51a88767 Update Copyright notice for 2017
Happy new year!
2017-01-02 19:52:45 +01:00
Keader
be15beebdc Build Fix 2017-01-01 21:07:59 -03:00
Keader
64f6f2a0ae Core/Scripts: Blood Prince Council refactored and fixed reported issues (#18632)
Closes #7150
2017-01-01 21:19:25 -02:00
Keader
db426ed0f9 Core/Scripts: Fixed chase movement in Palehoof encounter
Closes #15405
2016-12-28 11:09:34 -03:00
sirikfoll
0b33a8281f Core/Ruby: Minor fixes in Halion encounter
* Some codestyle fixes
* Fixed wrong Halion summon with Hotswap system
* Fixed evade issue
* Fixed emblem frost exploit
2016-12-24 00:19:02 -03:00
Keader
554c28d56b Core/Ulduar: Fixed XT002 Heart phase
Closes #18557
Thanks to xinef1
* Fixed Heart Phase
* Fixed Combat bug with Heart after wipe
* Added DespawnAtEvadeMethod
2016-12-23 18:02:31 -03:00
Keader
dbd567799f Core/Scripts: Fixed Suppresser behavior in Valithria Dreamwalker encounter
Closes #18530
* Fixed range issue
* Fixed weave spawn when Summon Timmer Suppresser(70912) is casted
* Fixed spawn count
2016-12-22 17:40:24 -03:00
Keader
dd95c4450a Core/Scripts: Minor fixes in Baltharus The Warborn (#18550)
* Core/Scripts: Minor fixes in Baltharus The Warborn

* go away travis
2016-12-21 23:53:53 +01:00
Shauren
618cf0e1c2 Core/Units: Cleanup hardcoded magic numbers for byte field offsets
(cherry picked from commit ac1dc758b9)
2016-12-15 08:16:01 -03:00
Keader
973f6b04ed Core/Scripts: Professor Putricide - Fixed Tear Gas spell sometimes dont casted in phase transitions (#18425)
Closes: #7972
2016-12-07 16:45:39 +01:00
Gustavo
7e0a616657 Core/Misc Remove WhiteSpaces (#18379) 2016-12-02 02:23:02 +01:00
ccrs
4bc60e650d Scripts/BlackTemple: minor cleanup and corrections after recent PRs
plus a ninja tabs to spaces cleanup
2016-11-30 14:05:07 +01:00
Kittnz
2cac8e43a5 Fix build 2016-11-29 21:53:33 +01:00
Kittnz
1553cc02fb Core/Scripts: Drake Hunt
- Removed creature script
- Using a spell script for red dragonblood spell http://wotlk.openwow.com/spell=46620 from sunwell
- Updated the SAI scripts for the quest Drake Hunt also from sunwell and fixed by Kilyana
2016-11-29 21:44:23 +01:00
Riztazz
28050f338d [3.3.5][master] Core/Movement: Smooth movement #13467 (#18020)
Implement smooth movement for all waypoint pathing and escortai
2016-11-24 23:31:10 +00:00
Keader
ab4ec5bd01 Core/Scripts: Added Boundary in Forge of Souls (#18226)
Core/Scripts: Added Boundary in Forge of Souls
2016-11-23 15:45:21 +01:00
Aokromes
8a864fc085 Merge pull request #18094 from Staleness89/3.3.5
Script/Quest: Rivenwood Captives
2016-11-23 02:31:48 +01:00
Killyana
3cc89c32d5 Creature/script: Add area restriction for Freed Proto Drake
Closes #11754
Thanks to ariel-
2016-11-20 20:01:54 +01:00
ariel-
5b56c94e6d Core/Spell: restore old proc system behaviour on auras self proc.
- Use Spell::m_triggeredByAuraSpell and compare against trigger aura, it requires scripts to set triggeredByAura parameter.
- Fixed existing scripts lacking it

DB/Spell: Anger Capacitor (Tiny Abomination in a Jar) proc

Closes #18269
2016-11-19 03:05:44 -03:00