- remove hardcoded (and wrong) text from the script
- copy valid text from broadcast_text to gossip_menu_option
- gossip_menu / npc_text is already correct in TDB 335.61
- sort + clean up core script enum list and add new entries
- keep gossip handling unchanged in the script (low prio)
(cherry picked from commit 582af02509)
Core/Scripts/DB: move npc_gregan_brewspewer to DB
- Remove npc_gregan_brewspewer, thereby removing hardcoded text
`#define GOSSIP_HELLO "Buy somethin', will ya?"`
- Move all gossip handling to DB (gossip texts already exist in TDB)
(cherry picked from commit 3acf6f36d1)
Core/Scripts: npc_grandmother gossip text moved to DB
Removing one more hardcoded text line from core scripts.
Also adding correct gossip to the npc_grandmother script.
Gossip changes in this script:
- remove hardcoded text from core script
- use existing npc_text IDs in gossip enum
- add missing text rows to gossip_menu_option
- use values from gossip_menu_option in enum
- replace spawn coordinates 0.0f with GetPosition()
(cherry picked from commit c214f987d7)
Core/Scripts: remove hardcoded text from npc_locksmith
- remove hardcoded text from script
- move the gossip handling to DB SQL
- move the script conditions to DB SQL
- use correct gossip from broadcast_text
- remove options not existing in broadcast_text
- add Key to Searing Gorge option (related spell)
- add The Eye of Haramad option (related spell)
(cherry picked from commit e6ee6e2ae8)
2 more text lines removed in the ongoing series:
"Remove hardcoded text from core scripts".
Core script for boss Majordomo Executus:
- add missing gossip_menu_option entries
- link the options via the table gossip_menu
- remove hardcoded text from the script
- minor enum line order sorting cleanup
- replace OnGossipSelect() with sGossipSelect()
The scripted events are unchanged.
If the script is inaccurate, make a new PR.
(cherry picked from commit b6d43623a2)
Closes#17263 by SnapperRy
(cherry picked from commit 0e8f3e0810)
DB/Item: fix text for item "Lewis' Note"
Closes#17264 by SnapperRy
(cherry picked from commit 5a2726affb)
DB/Item: fix text for item "A Letter to Grelin Whitebeard"
Closes#17268 by SnapperRy
(cherry picked from commit 5a91e2cea0)
DB/Quest: fix prevquest for "Rejold's New Brew"
Closes#17269 by SnapperRy
(cherry picked from commit a932eb416e)
DB/Quest: fix RewardText for "Beer Basted Boar Ribs"
Closes#17275 by SnapperRy
(cherry picked from commit ce107f3fcd)
DB/Quest: fix chaining for quests related to Well Watcher Solanian
Closes#17282 by SnapperRy
(cherry picked from commit b14c5541b7)
DB/Quest: fix chaining for Blood Elves' training quests
Closes#17284 by SnapperRy
(cherry picked from commit de9c4237a5)
DB/locales_item: add missing localization for item "Bamboo Cage Key"
Closes#17285 by lyn1337
(cherry picked from commit ea12727b45)
DB/gameobject: close "Cage Door" (STV)
Close#17287 by lyn1337
(cherry picked from commit af03601f09)
DB/Creature: Plague Scientist spells
Closes#16729 by Gargarensis and Rushor
(cherry picked from commit 3cd66c90e9)
DB/Quest: Preparin' For Battle
Closes#9743 by Wylath
(cherry picked from commit 7f6b8ed458)
DB/Quest: Army of the Damned
Closes#7801 by sirikfoll
(cherry picked from commit 3bba685b2a)
DB/Creature: Fix pathing for A Cry For Help
Closes#15722 by Joslyn-Maddie
(cherry picked from commit a6e7c9873c)
(cherry picked from commit 0912df258d)
Rename spell_snakes_spray for spell_jormungars_snakes_spray and cleanup
(cherry picked from commit 2c9c8afc0f)
Fixing the issue
(cherry picked from commit 81083a8593)
Changing remove aura method
(cherry picked from commit b88d49be24)
changing creature_text (tk feedback)
(cherry picked from commit 9b444877dd)
Override and tkrokli again :D
(cherry picked from commit 7205b4dd65)
Fix SQL name
(cherry picked from commit cae19692ab)
Updates #16488
(cherry picked from commit 3feeecf76c)
DB/Quest: Fix required class for "You Have Served Us Well"
Closes#17245
By SnapperRy
(cherry picked from commit b451c931d3)
DB/Loot: Fix chance for contents of item "Fireproof Satchel"
Closes#17247
By SnapperRy
(cherry picked from commit 4b8f285c18)
DB/Loot: Fix drop chance for quest item "Burning Legion Gate Key"
Closes#17250
By SnapperRy
(cherry picked from commit e7ac0236fe)
DB/Quest: set required profession for quest "Gathering Leather"
Closes#17252
By SnapperRy
(cherry picked from commit 60835936c4)
DB/Quest: Add conditions related to certain kinds of quests
Closes#17255
By SnapperRy
(cherry picked from commit b1aca1d1cf)
Closes#17229
By SnapperRy
(cherry picked from commit 5161a830ea)
DB/Conditions: Add condition target for spell cast by item "Zorbin's Ultra-Shrinker
Closes#17228
By SnapperRy
(cherry picked from commit f177b81038)
DB/Creature: Frogger
Fix pathing and speed
Updates #16488
(cherry picked from commit 37d01859c2)
DB/Loot: item "Primed Key Mold" should not be droppable by any NPC
Closes#17224
By SnapperRy
(cherry picked from commit d455b77a51)
DB/Loot: Waterlogged Recipe
Closes#17222
By SnapperRy
(cherry picked from commit 6b95d0b667)
DB/Quest: Improvements to the Brood of Nozdormu rings quests
Closes#17220
By SnapperRy
(cherry picked from commit 51d100f4ba)
1) Fix http://www.wowhead.com/quest=1144/willix-the-importer so this quest does not complete as soon as taken so that players actually have to do the escort before been able to return quest
2) Remove XP at kill from several creatures which dont give xp on retail
3) Put alliance/horde versions of Reigns of the Grand War Mammoth (VOA) into seperate loot groups so chance for drop is actually 1% rather than been 1% chance of reference loot been called then been a 50/50 chance of which factions mount dropped which in fact reduced chance to 0.5% as if opposite factions dropped then not visible
4) Update to text target for one text from Rohin the Decaying
5) Move spell focus for http://www.wowhead.com/quest=12569/crocolisk-mastery-the-ambush so its on top of log and not behind it so position matches doing quest on retail
(cherry picked from commit f941dad158)
