Commit Graph

387 Commits

Author SHA1 Message Date
Shauren
3fefb13bd4 Scripts/Silithus: Fixed some int -> float casts, should fix invalid coord error
--HG--
branch : trunk
2010-12-20 12:03:23 +01:00
Shauren
e3e77aceab Scripts/Temple of Anh'Qiraj: Fixed possible crash in mob_anubisath_sentinel
--HG--
branch : trunk
2010-12-20 11:39:12 +01:00
Shauren
756ee5832b Core/Auras: Allow stacking of auras proced from different items
Closes issue #2296.

--HG--
branch : trunk
2010-12-20 11:04:48 +01:00
azazel
6ec717ed5b Scripts/HoL:
* fix Volkhan script: after losing 20% HP Volkhan is supposed to run back to his Anvil and smack it with his hammer. 3 Golems are supposed to fly out of it and spawn (by LethalInjectionX) Closes issue #3895
* fix instance doors to remain open after use (by msholto) Closes issue #4773
Both fixes tested and approved by Aokromes.

NOTE: Do not forget the DB part of the commit!

--HG--
branch : trunk
2010-12-20 14:59:39 +06:00
Shauren
85d69dc73d Scripts/Spells: Explicitly remove all other auras with the same id when applying Animal Blood (46221)
--HG--
branch : trunk
2010-12-19 20:03:56 +01:00
Shauren
c35947816c Scripts/Trial of the Crusader: Fixed possible crashes in announcer gossip
Closes issue #3850.

--HG--
branch : trunk
2010-12-19 14:46:13 +01:00
linencloth
59da698189 Core: Rename spell attributes, use more general names
--HG--
branch : trunk
2010-12-19 05:15:47 +01:00
Shauren
8d76329eff Scripts/Temple of Ahn'Qiraj: Its generally not a good idea to delete stuff before using it; fixed crash
Closes issue #4357.

--HG--
branch : trunk
extra : rebase_source : b829284f60e2b55f8e79db72751252cc6619e59a
2010-12-19 00:27:38 +01:00
Shauren
3ad400ad1a Scripts/Obsidian Sanctum: Removed unneeded code causing crashes
Closes issue #5191.

--HG--
branch : trunk
2010-12-18 22:22:25 +01:00
Supabad
8ce0abbbc8 Scripts/Obsidian Sanctum Add support for when encounter is in progress. thnx to kiper
--HG--
branch : trunk
2010-12-18 18:07:24 +01:00
Shauren
4a067d5095 Fixed build i broke
--HG--
branch : trunk
2010-12-17 20:48:55 +01:00
Shauren
ecd2fbb2b1 Scripts/Vault of Archavon: Cleaned and simplified scripts, fixed Toravon's Frozen Orb summon count
Closes issue #2857.

--HG--
branch : trunk
2010-12-17 20:37:20 +01:00
Machiavelli
57d72fa708 Core/Scripts: Prevent double call to mob_acolyte_of_shadronAI::Reset() which applies encounter-related aura´s to certain creatures. Reset() was called from AIM_Initialize and prior to that the AI factory selector
Update issue #5152
Please try to re-reproduce

--HG--
branch : trunk
2010-12-17 14:58:23 +01:00
Shauren
82f45966fc Core/Unit: Renamed addUnitState/hasUnitState/clearUnitState to AddUnitState/HasUnitState/ClearUnitState
Core/Vehicles: Allow the vehicle to always damage the passenger (removed unneded dbc hacks from scripts)

--HG--
branch : trunk
2010-12-17 13:43:24 +01:00
click
a7f3548259 Core: Prevent using uninitialized memory in Lazy Peon script - patch by ge0rg
--HG--
branch : trunk
2010-12-17 05:03:25 +01:00
Anubisss
b702bd8987 This not needed too, correctly checked with UpdateVictim().
--HG--
branch : trunk
2010-12-16 18:13:03 +01:00
Anubisss
6d9029c12e Make some cleanup.
My thank goes to Az@zel for the code analysis.

--HG--
branch : trunk
2010-12-16 18:08:23 +01:00
Machiavelli
bb7bd9ef45 Core/Spells: Fix a possible crash in spell_hun_readiness_SpellScript
--HG--
branch : trunk
2010-12-16 16:00:56 +01:00
Shauren
1bc9b905f6 Scripts/Icecrown Citadel: Removed WIP leftovers
--HG--
branch : trunk
2010-12-15 16:39:23 +01:00
Shauren
2db0c7c017 Scripts/Icecrown Citadel: Festergut's Gas Spore and Vile Gas should not happen at the same time
--HG--
branch : trunk
extra : rebase_source : dbb903afbfbfdee5c2c3ae0be7181508e0eca1b2
2010-12-15 16:36:59 +01:00
_manuel_
6f551d853f Core/Scripts: Novos the Summoner should only summon 4 Crystal Handlers.
--HG--
branch : trunk
2010-12-15 12:16:31 -03:00
Spp
382fef1958 Core: Some warning fixes
--HG--
branch : trunk
2010-12-15 10:44:06 +01:00
Shauren
9a806e63c1 Fixed compile
--HG--
branch : trunk
2010-12-14 16:31:01 +01:00
Shauren
314376e32c Scripts: Fixed uninitialized variables, unreferenced parameters and virtual overrides
--HG--
branch : trunk
2010-12-14 16:24:59 +01:00
Shauren
0c04b178db Scripts/Icecrown Citadel: Minor adjustments and compile warning fixes
--HG--
branch : trunk
2010-12-14 15:46:54 +01:00
click
2642894342 Core: Add new system for parallelizing client packet processing. Handle WorldSession updates in Map::Update() where we are safe to proceed. Patch by Ambal.
(And clean up tabs and whitespace while rummaging around in there)
Closes issue 5084.

--HG--
branch : trunk
2010-12-13 22:37:56 +01:00
Shauren
dd2602d3ec Fixed line endings in 10623_world_spell_bonus_data
Scripts/Naxxramas: Fixed a possible crash in instance script

--HG--
branch : trunk
2010-12-12 17:32:26 +01:00
azazel
d2d62eab50 Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
NOTE: Initially I just wanted to fix some warnings, but noticed that there is no common method for percentage calculation and various formulas are used many time in the code making it difficult to read and understand what the code actually does. So, I introduced several template methods for calculating percent values and adding those values to the original base. I replaced all the raw calculations throughout the code where found, but I could have missed something or could have made a mistake. So, please report any strange behaviour after this commit.
If you ask me why I did it: for the sake of consistency and exact understanding what code means. If you see CalculatePct method, you clearly understand, that it find the value of x percent of y. And you can easily express, for example, spell behviour "reduces smth by x%" by the means of a method instead of recalling school maths.

--HG--
branch : trunk
2010-12-11 20:37:38 +06:00
azazel
08f205722a Scripts/Quest: implement dummy effects for spells 43882, 50133 and aura 43874 for quests 11396/11399 Bring Down Those Shields (based on code by NoFantasy)
--HG--
branch : trunk
2010-12-10 12:01:57 +06:00
Shauren
e4e048ed57 Core/Scripts: Fixed possible crashes in instance scripts (Icecrown Citadel and Naxxramas)
Scripts/Sunwell Plateau: Fixed crash in Kil'jaeden
Scripts/Icecrown Citadel: Fixed crash in Blood-Queen Lana'thel

Closes issue #5051.
Closes issue #5050.
Closes issue #5035.

--HG--
branch : trunk
2010-12-08 17:24:31 +01:00
Shauren
703835ee94 Core/Quests: Fixed Unholy Infusion (24749), Blood Infusion (24756) and added partial support for Frost Infusion (24757)
--HG--
branch : trunk
2010-12-06 22:54:19 +01:00
Spp
408fce1de6 Core: Some optimizations
- Declare some functions const
- Fix some mem leak
- Fix some resource leak
- Remove unused variables and functions
- Remove duplicate functions
- Reduce the scope of some variables
- Remove unused file

--HG--
branch : trunk
2010-12-06 02:07:53 +01:00
QAston
59c1a238f5 Scripts/AuraScript: Make AuraApplication in OnEffectPeriodic never be NULL.
Scripts: remove some unnecessary NULL checks from scripts.

--HG--
branch : trunk
2010-12-05 21:38:52 +01:00
leak
6fe19b5a86 Core/Scripts: Split OnCreatureCreate() and OnGameObjectCreate() into two virtual functions each.
Note to scripters: be aware that you will need to hook into the Remove functions if you want to do stuff at GO/creature removal.
Closes issue 5011.

--HG--
branch : trunk
2010-12-05 18:04:10 +01:00
Spp
e621f5fe98 Core/Dungeon Finder: Code cleanup and minor optimizations
- Extend LfgState to keep control of the state of group and players using LFG
- Move scripts to its own class and initialize only if Dungeon finder is enabled
- Updated comments to doxygen format
- Use constructor initialization list
- All variables are declared in the inner most scope
- Fix some mem leaks
- Remove no longer needed code (Cleaner)
- Normalize handler function names

--HG--
branch : trunk
2010-12-05 17:50:26 +01:00
Shauren
04b4364908 Scripts/Icecrown Citadel: Fixed crash in Blood-Queen Lana'thel script
Closes issue #5017.

--HG--
branch : trunk
2010-12-04 12:53:01 +01:00
Liberate
526c15336d Scripts/Pit of Saron: Fix a crash at Scourgelord Tyrannus.
Closes issue #4601

--HG--
branch : trunk
2010-12-04 02:20:32 +01:00
_manuel_
51a66dc427 Core/Scripts: Implemented core script for quest "Stunning Defeat at the Ring" (11300), original code from ScriptDev2 thanks to kiper for porting, also for a full functionality for this quest you need the DB scripts made by him.
--HG--
branch : trunk
2010-12-03 17:36:07 -03:00
Shauren
e0c992a8ba Scripts/Icecrown Citadel: Added script for Blood Queen Lana'Thel
Scripts/Icecrown Citadel: Fixed Invocation of Blood announcement emote for Blood Prince Council
Scripts/Icecrown Citadel: Fixed intro for Lady Deathwhisper
Scripts/Icecrown Citadel: Fixed Bone Spike for Lord Marrowgar

--HG--
branch : trunk
2010-12-03 17:47:33 +01:00
Shauren
892f56c37d Fixed compile, missed these changes
--HG--
branch : trunk
2010-12-03 14:14:08 +01:00
Shauren
96ab1a102f Scripts/Trial of the Crusader: Fixed crashes in Gormok the Impaler
Closes issue #4515.

--HG--
branch : trunk
2010-12-03 14:02:41 +01:00
Shauren
3badf69b63 Core/Spells: Fixed bad Z coordinate for Spell::EffectBind with location stored in database
Core/Scripts: Corrected few mistakes in misc scripts

--HG--
branch : trunk
2010-12-03 13:54:00 +01:00
_manuel_
651ff8565a Core/Scripts: Implemented script for quest The hunt is on (11794).
--HG--
branch : trunk
2010-12-01 15:29:35 -03:00
Spp
25ac835507 Core/Groups: Move all function definition from .h to .cpp
Core/Groups: Remove Group.h dependency from any .h file

--HG--
branch : trunk
2010-11-29 07:50:31 +01:00
Shauren
eb0a5467c2 Scripts/Icecrown Citadel: Fixed possible exploits in Deathbringer Saurfang's script
--HG--
branch : trunk
2010-11-26 22:46:09 +01:00
Spp
fa97598594 Core/Dungeon Finder: Move vote kick initialization from Group code to Scripts
--HG--
branch : trunk
2010-11-23 20:49:57 +01:00
Spp
d3c9478153 Core/Groups: Add kicker and kick reason to RemoveMember
--HG--
branch : trunk
2010-11-23 20:49:36 +01:00
click
d1ade6f6b8 Revert r5dcfc475b8 (we're still investigating why it does what it does though)
--HG--
branch : trunk
2010-11-22 16:07:32 +01:00
Spp
6b5ff1ca25 Core: Fix some warnings
--HG--
branch : trunk
2010-11-22 10:10:46 +01:00
click
ea9e88a48c Core/Scripts: Add support for questID 25444 (Da Perfect Spies)
--HG--
branch : trunk
2010-11-21 23:43:44 +01:00