Commit Graph

26857 Commits

Author SHA1 Message Date
ariel-
400a69bf9e Core/Gameobject: fixed sometimes not found linked trap
Closes #18256
2016-11-16 04:59:43 -03:00
ariel-
56beec8aaf Core/Spell: Fixed irregular handling of SPELLMOD_DOT
- Applied twice for some dots
- Missing for Health Leech Periodic
- Missing in a few scripts

Closes #17463
2016-11-16 04:06:32 -03:00
ariel-
b6a8045adc Core/Unit: fix some SPELL_AURA_MOD_DAMAGE_PERCENT_DONE effects being applied more than once
No more overpowered dps for you

Closes #16755
2016-11-16 02:26:18 -03:00
ariel-
f3bdd705c0 Core/Unit: fix build
Ctrl-S failure
2016-11-15 22:50:28 -03:00
ariel-
ca1c4525c7 Core/Unit: damage immune improvements (9f5df023b7 follow up)
- Handling checked in sniffs: Spell 63710 Void Barrier vs 49143 Frost Strike
  * Send spell miss immune only if spell consists of damage effects
- Checked with 348 Immolate:
  * No packets sent if damage immune, aura is applied normally

Also... who the fuck uses 0 to compare against pointers
2016-11-15 22:39:15 -03:00
Killyana
524d6637ad DB/GameObjects: Cursed Egg
Add missing spawns with pooling and replace a hack script: d90a161619
2016-11-15 17:24:39 +01:00
ariel-
64304d8b2b Core/Spell: fix a potential null dereference crash 2016-11-15 12:02:31 -03:00
ariel-
cdd7461d25 DB/Spell: Vampiric Embrace proc
Closes #18250
2016-11-14 21:25:02 -03:00
ariel-
9f5df023b7 Core/Unit: don't use damage immunity to calculate hit result for the whole spell. Should be used only for damage 2016-11-14 20:40:17 -03:00
ariel-
425f6c3c34 Core/Spell: perform charmer check against player controlling unit. Fixes spellcasts while charmed 2016-11-14 15:22:41 -03:00
ariel-
1ad9c7d3fd Core/Spell: fix typo
Closes #18248
2016-11-14 13:59:32 -03:00
Duarte Duarte
674ac56303 Update THANKS file (#18247)
* Added missing names in THANKS file

* filter by nick/email and sorted

* Oops

* duplicates

* laze mind

* :)
2016-11-14 12:15:40 +00:00
Keader
fa0604223b :) 2016-11-14 09:31:01 -02:00
ariel-
a7259cef4f DB/Creature: correct 2 npc walk/run speed
Closes #18207
2016-11-14 04:57:25 -03:00
ariel-
352c84943c Core/Unit: improved handling of some spell attributes
- SPELL_ATTR1_UNAFFECTED_BY_SCHOOL_IMMUNE
- SPELL_ATTR2_UNAFFECTED_BY_AURA_SCHOOL_IMMUNE
- SPELL_ATTR3_IGNORE_HIT_RESULT
2016-11-14 04:04:30 -03:00
ariel-
f060efbdb4 Core/Spell: fix typos 2016-11-14 04:02:43 -03:00
ariel-
20cdf1a830 Core/Utils: build fix 2016-11-14 02:36:33 -03:00
ariel-
3f1d020a2c Core/GameObject: use a friendly trigger for positive spells.
Fixes an issue with Skadi Harpoons.

Note to self: should actually implement GameObject casting already :/
2016-11-14 02:12:41 -03:00
ariel-
361b185ef7 Core/Scripts: add checks to Master's Call script
Closes #8403
2016-11-14 02:12:38 -03:00
ariel-
5daabe303e Core/Spell: do not fail triggered Charge effects in case a root is present.
Fixes Master's call when pet is rooted
2016-11-14 02:12:35 -03:00
ariel-
5aa0228df9 Core/Spell: Fix warrior Enrage stacking with Wrecking Crew and Imp. Defensive Stance 2016-11-14 02:12:33 -03:00
ariel-
b99ca19eea Core/Globals: Load spellspecific and aurastate after loading spell ranks
Was breaking functionality (eg: stacking scroll auras)
2016-11-14 02:12:19 -03:00
ariel-
fd3423245c Core/Spell: use SpellEntry to select implicit targets in case RadiusEntry wasn't set for the current effect.
Closes #15388
2016-11-14 02:06:33 -03:00
ariel-
fc6844173f Core/Spell: Fixed immunities for some spells (they were broken before rewrite too)
- Warlord's Presence, Uncontrollable Frenzy, Free Friend
- Overload, Lightning Tendrils
- Fervor, Berserk
- Determination
2016-11-14 02:06:30 -03:00
ariel-
699e22cb4c Core/Unit: consider creatures with same faction to be on the same party/raid for the purposes of spell/aura targets
Ref #18233
2016-11-14 02:06:18 -03:00
ariel-
aa21137aeb Core/SpellScript: allow optional parameters to be passed to FinishCast
followup of 50a3ce5703
2016-11-14 02:05:54 -03:00
ariel-
cbb5c073ce Core/ScriptMgr: use vector instead of list to contain Spell and Aura scripts and hooks 2016-11-14 02:05:51 -03:00
ariel-
58c5011499 Core/Battleground: Fix issue reported by static analysis 2016-11-14 02:05:48 -03:00
Keader
33e7519dc3 laze mind 2016-11-14 00:28:31 -03:00
Keader
66028259a8 duplicates 2016-11-14 00:21:30 -03:00
Keader
24135903eb Oops 2016-11-14 00:11:05 -03:00
Keader
3a55105423 filter by nick/email and sorted 2016-11-14 00:08:44 -03:00
Keader
caeb357855 Added missing names in THANKS file 2016-11-13 21:18:18 -03:00
ariel-
c98ab6bd94 Core/Misc: codestyle fixes in GridNotifiers.h
- Removed dead code, outdated comments
- Fixed indentation
- Explicitly delete copy ctors
- const'd the operator() definitions
2016-11-13 19:13:10 -03:00
Killyana
bf5799fce5 DB/Misc: Dark portal Event
Original work: 2f2f8a6110/sql/events/stair_of_destiny.sql
2016-11-13 20:26:53 +01:00
Keader
81edee5648 Core/Scripts: Cleanup in instance_black_temple and added missing datas (#18246)
* Core/Scripts: Cleanup in instance_black_temple and added missing datas

* Fixed door timing issue

* Remove redundant call
2016-11-13 20:23:52 +01:00
Shauren
08057b6d8b Core/Auras: Fixed removing auras triggered by aurastates
Closes #17868

(cherry picked from commit f94e6cee38)
2016-11-13 00:43:13 +01:00
ariel-
83afc5d9f1 DB/Spell: require spellmod consumption for Clearcasting
- Mage, Shaman and Druid flavors

Closes #18240
2016-11-12 18:36:54 -03:00
ariel-
7943150dcb Core/Unit: misc codestyle
use typedef for constant reference
2016-11-12 18:12:26 -03:00
ariel-
3588ff894b Core/Spell: fix warning 2016-11-12 18:04:45 -03:00
ariel-
50a3ce5703 Core/Spell: revamp of immunities system
- Spell attributes research
- Container optimization
- Do not skip damage immunity checks on SPELL_ATTR0_UNAFFECTED_BY_INVULNERABILITY present
- Added additonal arguments support to SendCastResult / CheckCast, spells can now send proper error messages
- Loads spell immune masks/states/effects at startup.
- This cached info is used whenever a spell cast requires immunities to be known beforehand (to see if an aura could be applied for example)

Closes #16658
Closes #16901
Closes #18114
2016-11-12 17:58:00 -03:00
ariel-
5cb8409f1e Core/Spell: move attribute helpers to spellInfo
- Renamed CheckEffectExecuteData to AssertEffectExecuteData and made const, better reflects its purpose
- Added missing attribute check to IsNextMeleeSwingSpell
- Reworked SPELL_ATTR4_CAST_ONLY_IN_OUTLAND attr check (researched behavior)
2016-11-12 17:12:42 -03:00
tkrokli
8c9d061110 DB/gameobject: set positive spawntimesecs for 2 quest objects
176088 Scarlet Crusade Forward Camp (quest 5096 Scarlet Diversions)
180659 Drop-Off Point (for quest 8606 Decoy!)

by offl

Closes #18205
2016-11-12 06:27:01 +01:00
Chaosvex
ed2cd6b34f Core/Auth: Resolved authentication bypass 2016-11-10 23:00:58 +01:00
Keader
c4dd6d1676 Core/Scripts: Fixed a typo and removed randtime of Shade of Akama events (#18231) 2016-11-10 13:00:57 -03:00
ariel-
d8b0a2ecb2 DB/Spell: add attribute for Stoneclaw Totem Effect, should not brask stealth
Closes #18215
2016-11-09 23:51:08 -03:00
ariel-
9822b46995 DB/Spell: Mage armor procs
Closes #18216
2016-11-09 23:31:42 -03:00
ariel-
ff36cfa442 DB/Spell: change phaseMask to finish for Deathchill and Killing Machine
So that they affect Threat of Thassarian'd Frost Strikes
2016-11-09 12:23:01 -03:00
ariel-
bb9fdb1b8a DB/Spell: kill some startup errors 2016-11-09 11:30:57 -03:00
ariel-
70a867531d Core/SpellMgr: overwrite dbc range for Unleashed Souls
Closes #17968

By sirikfoll
2016-11-09 00:58:46 -03:00