Commit Graph

12615 Commits

Author SHA1 Message Date
Naios
433bc289c2 Core/Misc: Fix some issues detected by static analysis
* Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
  -> This argument is passed by value, it makes no sence so set it to null here.

* Member variable 'instance_violet_hold_InstanceMapScript::bWiped' is not initialized in the constructor.

* Mismatching allocation and deallocation: Data
2015-03-18 20:20:04 +01:00
Naios
a610dea85c Core/RemoteAccess: Remove an unused define in RASession
* probably fixes gcc compile after adding cppformat
2015-03-18 16:32:19 +01:00
Naios
d64e6ffade Core/Log: Readd include of <stdarg.h> to fix compile issues under gcc 2015-03-18 15:29:56 +01:00
Nayd
a4b5b41a9b Core/LFGMgr: Fix compiler error 2015-03-18 00:53:39 +00:00
Duarte Duarte
ec640e3840 Merge pull request #14370 from Kittnz/realm_achievement
Core/Condition: Realm Achievement condition
(cherry picked from commit 769acfbd02)
2015-03-18 00:36:17 +00:00
click
cc3387d984 Merge pull request #14371 from Kittnz/movecirclepath_003
Core: Move FillCirclePath function to MotionMaster
Closes #14371
(cherry picked from commit cf14e9051d)
2015-03-18 00:35:39 +00:00
click
3a1c778d54 Core/AHBot: Remove a lingering warning that annoyed me for all too long
(cherry picked from commit 7c8f7f6f8f)
2015-03-18 00:35:24 +00:00
jackpoz
61e0ff3208 Revert "*Do not allow players to use vehicles to go further than 1st boss in Ulduar."
This reverts commit a009e53049.
Remove hackfix for Ulduar vehicles, it should be handled in Ulduar script

(cherry picked from commit f1ae2c7b73)
2015-03-18 00:35:05 +00:00
jackpoz
38c23495b3 Core/Dungeon Finder: Fix Vote Kick breaking LFG queue
Fix Vote Kick started with party in queue breaking the whole LFG queue. The status of Vote Kick is now storing in a bool variable in LfgGroupData, separated from LfgState of the group/members.
If a Vote Kick started with party in queue, the members were not removed from queue correctly and would cause LFG matching system to match these "broken" players but not allowing to start a dungeon.

Closes #10191

(cherry picked from commit 22403121fe)
2015-03-18 00:34:51 +00:00
click
812e117b30 Core/Script: INFO->DEBUG notification changes in ToC
(cherry picked from commit 0c7c25d6ed)
2015-03-18 00:34:00 +00:00
click
5a1c4fca7c Core/Scripts: INFO-DEBUG changes in scripts (gawd)
(cherry picked from commit a8a5fae4f9)
2015-03-18 00:33:50 +00:00
click
b0ee48370d Core: INFO->DEBUG level changes - forgot one in Map.cpp
(cherry picked from commit ad7b33a47f)
2015-03-18 00:33:40 +00:00
click
49f4ffc2c8 Core: More INFO -> DEBUG changes
(cherry picked from commit 781edbe46a)
2015-03-18 00:33:31 +00:00
click
be078fd8a9 Core: WARN instead of INFO - this is actually something we'd want to be informed of...
(cherry picked from commit d5718f3372)
2015-03-18 00:33:20 +00:00
click
aec29478d3 Core: And yet more INFO->DEBUG logging
(cherry picked from commit 6f961ba138)

Conflicts:
	src/server/game/Entities/Object/Object.cpp
2015-03-18 00:32:58 +00:00
click
fb9b203be9 Core: Pet.cpp - INFO -> DEBUG level notifications...
(cherry picked from commit a31bc08e44)

Conflicts:
	src/server/game/Entities/Pet/Pet.cpp
2015-03-18 00:32:57 +00:00
click
cbe97cc37d Core: More INFO -> DEBUG (Unit.cpp this time)
(cherry picked from commit 64584e9e7a)

Conflicts:
	src/server/game/Entities/Unit/Unit.cpp
2015-03-18 00:32:56 +00:00
click
b3b7b53003 Core: INFO->DEBUG cleanups in Player.cpp
(cherry picked from commit 6e509cf7c1)

Conflicts:
	src/server/game/Entities/Player/Player.cpp
2015-03-18 00:32:55 +00:00
click
2bc44a2fb1 Core: More INFO -> DEBUG/WARN/ERROR mangling
(cherry picked from commit 15e56ed0b3)
2015-03-18 00:32:54 +00:00
Carbenium
cc0c9add5a Merge pull request #14317 from Naios/typesafelog
Type safe logging
2015-03-18 01:25:38 +01:00
click
aec6353297 Core: More INFO -> DEBUG changes (WorldSession/WorldSocket)
(cherry picked from commit 132d4ede37)

Conflicts:
	src/server/game/Server/WorldSession.cpp
	src/server/game/Server/WorldSocket.cpp
2015-03-18 00:18:20 +00:00
click
59b6c4dbbb Core: Move LOG_INFO -> LOG_DEBUG level for achievements
(cherry picked from commit 8562be602b)

Conflicts:
	src/server/game/Achievements/AchievementMgr.cpp
2015-03-18 00:17:21 +00:00
click
ff50abca8a Core: Move some MMAPS-related INFO-messages to DEBUG
(cherry picked from commit a854e17690)
2015-03-18 00:16:29 +00:00
click
c235835827 Core: Change some map-specific INFO-messages over to to DEBUG or ERROR
(cherry picked from commit ec6bec6bc4)

Conflicts:
	src/server/game/Maps/Map.cpp
2015-03-18 00:16:21 +00:00
click
4df9f46214 Core: Move some more INFO-level logentries to DEBUG
(cherry picked from commit db302c28c2)

Conflicts:
	src/server/game/Spells/Spell.cpp
	src/server/game/Spells/SpellEffects.cpp
2015-03-18 00:15:52 +00:00
jackpoz
a20905598d Core/PacketLog: Avoid unneeded calls with disabled packet logs
Avoid calling GetOpcodeNameForLogging() when packet logs are disabled.

(cherry picked from commit 5e7d4a44e0)

Conflicts:
	src/server/game/Server/WorldSocket.cpp
2015-03-18 00:13:05 +00:00
jackpoz
22d655451c Shared/Logs: Add support to .server set loglevel command after 003d67708b
Update the lowest log level when using ".server set loglevel" command.

(cherry picked from commit 43f74fd8cf)
2015-03-18 00:10:19 +00:00
jackpoz
064b6a4c84 Shared/Logs: Improve log performances
Improve Log::ShouldLog() performances by saving the lowest log level across all loggers and discarding any log with lower level than that.

(cherry picked from commit 003d67708b)
2015-03-18 00:10:02 +00:00
jackpoz
034dbe267d Core/Player: Optimize Player::HaveAtClient() performance
Change m_clientGUIDs from std::set to std::unordered_set to reduce by 2.7x times the cpu usage in Player::HaveAtClient()

(cherry picked from commit 49ececf038)
2015-03-18 00:09:32 +00:00
jackpoz
f3f44c468d Core/Collision: Fix crash when loading invalid vmap data
Fix array overflow when loading Models from vmap tiles with wrong/outdated/bad data.
Try extracting again vmaps if you see this error.
Closes #14255

(cherry picked from commit 3035a4218b)
2015-03-18 00:09:07 +00:00
jackpoz
1a583703c5 Core/CrashHandler: Fix char[] without '\0' handling
Fix char[] without a NULL character '\0' in the array reading over the char[] bounds

(cherry picked from commit fd844e3d7e)
2015-03-18 00:08:49 +00:00
Nyeriah
8b7dabab21 Scripts/Undercity: Update Lady Sylvanas' script and also implement few missing things to Journey to Undercity's quest end event
Closes https://github.com/TrinityCore/TrinityCore/pull/14094
Thanks to @Killyana @Rushor @jaredjones and all others who helped with this

(cherry picked from commit a76722ccef)
2015-03-17 20:22:55 -03:00
Duarte Duarte
c4499cf35d Merge pull request #14386 from Gigi1237/SpeedAck
Core/PacketIO: Updated and enabled _SPEED_CHANGE_ACK
2015-03-17 12:42:14 +00:00
Vincent-Michael
4ee22e3c5e Core/Packets: Enable opcode CMSG_BANKER_ACTIVATE / SMSG_SHOW_BANK 2015-03-16 20:39:01 +01:00
Luzifix
40809ebfec Core/PacketIO: update & enable CMSG_QUESTGIVER_HELLO 2015-03-16 19:22:08 +01:00
Gigi1237
5a8db92e62 Core/PacketIO: Updated and enabled _SPEED_CHANGE_ACK
Added packet structure for MovmentAck
2015-03-15 17:26:19 +01:00
Duarte Duarte
bb1f61bb1f Merge pull request #14377 from DJScias/opcodes4
Core/Packets: update and enable SMSG_SUPPRESS_NPC_GREETINGS
2015-03-15 13:16:46 +00:00
Duarte Duarte
e1129d0877 Merge pull request #14372 from DJScias/opcodes2
Core/Packets: update CMSG_QUESTLOG_REMOVE_QUEST and enabled some quest o...
2015-03-15 13:16:23 +00:00
Vincent-Michael
fe971b9048 Core/Enums: Update TutorialAction for 6.1.0 2015-03-15 13:54:04 +01:00
Luzifix
41641eb907 Core/PacketIO: Update and enable delete character for 6.1 2015-03-15 13:30:10 +01:00
Vincent-Michael
6dd6fa04ef Core/Enums: Update ResponseCodes for 6.1.0 2015-03-15 13:06:09 +01:00
Vincent-Michael
8366ed5a72 Core/Packets: Fix typo 2015-03-15 06:12:52 +01:00
Vincent-Michael
afaa487c6c Core/Packets: Update some opcodes and enable this 2015-03-15 05:59:55 +01:00
Vincent-Michael
a99d7303cd Core/Packets: Update some opcodes and enable this 2015-03-15 05:01:15 +01:00
Vincent-Michael
aa0feb41ae Fix typo in MovementStatus (read/write)
todo 6.x use this infos
2015-03-15 04:16:54 +01:00
Vincent-Michael
fb8a169d46 Core/Packets: Added SMSG_TRANSFER_ABORTED / SMSG_TRANSFER_PENDING opcodes for 6.1.0 and enable this 2015-03-15 03:36:45 +01:00
Vincent-Michael
f2cb963565 Core/Packets: Update some opcodes and enable this 2015-03-15 03:09:34 +01:00
Vincent-Michael
d86298cde4 Core/Packets: Update some opcodes and enable this 2015-03-15 02:36:56 +01:00
Vincent-Michael
ae76ee8eca Core/Packets: Enable CMSG_SET_ACTIONBAR_TOGGLES opcode for 6.1.0 2015-03-15 01:44:11 +01:00
DJScias
6fb2dba273 Core/Packets: update and enable SMSG_SUPPRESS_NPC_GREETINGS 2015-03-15 01:13:57 +01:00