Commit Graph

2278 Commits

Author SHA1 Message Date
Killyana
4d89da56c1 Spell/Script: Move the spell "Flame Sphere Spawn Effect" from the DB to the cpp 2019-12-16 21:17:10 +01:00
Keader
58b5ea9f95 Scripts/Azjol-Nerub: Fixed Gatewatcher pets evading when kill a player
Making Aokromes happy
2019-12-15 12:35:41 -03:00
Killyana
366ec08160 DB/Spawns: Rampart of skulls
Closes #23966
2019-12-13 21:28:58 +01:00
Gildor
f661bc6c39 Scripts/VioletHold: Minor improvements (#23961)
* Scripts/VioletHold: Minor improvements
* Now we can teleport inside with gossip if event is in progress
* Improve HavePlayers() check logic

* Remove a pointless comment
suggested by shauren

* Move CheckWipe function to execute every 3 seconds instead every map update
suggested by Riztazz

* I supose Riztazz forgot add this to repeat every 3 seconds
2019-12-11 15:01:27 +01:00
ccrs
a58ed271c9 Scripts/PoS: a7a96d4 followup
cause edge cases may exist
ty Aokromes
2019-10-27 02:28:28 +01:00
ccrs
fcbcb43b2b Scripts/PoS: a7a96d4 followup
we cant despawn all summons since vehicle spawn their passengers as regular summons
ty Aokromes
2019-10-24 10:51:27 +02:00
ccrs
40116f1025 Scripts/PoS: a7a96d4 followup 2019-10-23 17:39:25 +02:00
ccrs
a7a96d4271 Scripts/PoS: little implementation cleanup in boss_krickandick with, you guessed it, movement related corrections
also, never forgetti  -->
                                     ¨¨Ç*^¿?_:;_^!"·Ç!Ñ·$%/(/)/()(=)(=]]{
Unit::StopMoving() is evil, and so is MotionMaster::Clear()

the first can really mess up existing movement generators
the second can interrupt "controlled" movements... can do it literally mid-air
2019-10-23 17:29:34 +02:00
ccrs
8fd33dfd79 Build: fix nopch - add missing declaration 2019-10-23 14:06:17 +02:00
ccrs
d27fd717c1 Scripts/PoS: move boss_krickandick into new script definition 2019-10-23 12:53:46 +02:00
ccrs
a71c5f4c7f Core/AI: 06443e3 followup
cause its not "that" horrible
2019-10-21 16:43:39 +02:00
jackpoz
30823f9b79 Core/Misc: Fix C++17 build errors 2019-10-13 20:12:36 +02:00
ForesterDev
c03c88d0c0 Core/Defines: define UNIT_FLAG_SWIMMING (#23630) 2019-10-13 17:43:23 +02:00
Giacomo Pozzoni
fed030da19 Scripts/Kologarn: Fix "stuck in combat" issues (#23866)
Fix players stuck in combat with NPC_ARM_SWEEP_STALKER and/or both arms after killing the boss.
2019-10-13 17:37:52 +02:00
Keader
a108f2ba61 Scripts/ICC: Fixed some issues with Rotface Oozes (#23845) 2019-10-04 09:35:22 -03:00
Keader
8210b4a539 Scripts/ICC: Fixed Death Plague (Frost Giant) (#23847) 2019-10-04 09:33:14 -03:00
Keader
34ee2effc8 Scripts/Forge of Souls: Fixed spell Soul Sickness (#23843) 2019-10-03 08:49:05 -03:00
Keader
16fde1ffad Scripts/ICC: Fixed Tear Gas not getting removed of Abomination in phase change of PP (#23846) 2019-10-02 16:50:45 -03:00
Giacomo Pozzoni
ef694cc251 Scripts: Fix crossfaction combat issue (#23818)
* Scripts/PitOfSaron: Fix Martin Victus combat in crossfaction groups

Fix Martin Victus attacking players in crossfaction groups because it was spawned as summon of the boss, triggering DoCombatInZone()

* Scripts/ForgeOfSouls: Fix guards combat in crossfaction groups

Fix Devourer of Souls guardians attacking players in crossfaction groups because they were spawned as summons of the boss, triggering DoCombatInZone()

* Scripts/Misc: Fix no PCH build
2019-09-28 15:45:25 +02:00
Killyana
8e3862cfbd Instance/Script: Gorkun Ironskull & Martin Victus 2019-09-21 21:52:33 +02:00
Gildor
a392216d20 Scripts/Icecrown Citadel: Remove duplicated Spell enum (#23810) 2019-09-21 13:17:45 +02:00
Artamedes
88e74ac385 Scripts/PitOfSaron: Make sure ick stops moving when casting Explosive Barrage (#23768) 2019-09-06 21:47:34 +02:00
Artamedes
a17c83bde8 Scripts/PitOfSaron: Fix Krick sometimes stuck in combat after finish kill Ick (#23767) 2019-09-06 21:47:10 +02:00
Artamedes
876a848730 Scripts/Ulduar: Fix Stormcaller Brundir walking into walls (#23755)
* Scripts/Ulduar: Fix Stormcaller Brundir walking into walls

* Cleanup and fix logic + review

* Review: remove autos
2019-09-06 20:09:47 +02:00
Treeston
23fd193e4e Scripts/ICC: Professor Putricide no longer tries to add threat on units it cannot add threat on because of immunity flags. Instead, its AI manually controls the engagement state. Should close #23727. 2019-08-30 01:04:11 +02:00
ForesterDev
448facc5e7 Core/Spells: Fixed warlock's Banish cancel if target was already banished (#23697)
* Core/Spells: Add SpellMissInfo argument to BeforeHit hooks and call them also when the spell doesn't hit. (#17613)

(cherry picked from commit 8ff5b35be1)

# Conflicts:
#	src/server/game/Spells/Spell.cpp
#	src/server/scripts/Northrend/IcecrownCitadel/boss_the_lich_king.cpp
#	src/server/scripts/Spells/spell_warlock.cpp

* Core/Spells: Fixed warlock's Banish cancel if target was already banished (#17614)

(cherry picked from commit 4587b5d880)

# Conflicts:
#	src/server/scripts/Spells/spell_warlock.cpp
2019-08-23 19:24:56 +02:00
Keader
10f6e38185 nopch fix 2019-08-21 23:08:36 -03:00
Keader
cbc01f35b6 Core/Scripts: Proper fix Gal'Darah Puncture remove 2019-08-21 23:03:25 -03:00
Keader
1886507e7f Fix nopch build 2019-08-20 06:35:02 -03:00
Keader
130a3859ec Scripts/Gundrak: Fixed Puncture when Gal'darah die 2019-08-19 23:52:04 -03:00
Keader
61ad87d106 Scripts/Gundrak: Added a missing entry in Gal Darah Stampede Charge script
Noob Keader, Shame !
2019-08-18 13:07:18 -03:00
Treeston
a5e73e41c0 Core/Pooling: Quest pooling rewrite: (PR#23627)
- Split quest pooling from PoolMgr (into QuestPoolMgr)
- Proper saving/restoring on server restart
- No more hacking into sObjectMgr to insert/remove available quests
2019-08-04 12:22:57 +02:00
Treeston
4a219eda07 Core/Unit: Spell focusing now no longer nonsensical. HasSpellFocus always const. Error logs for various stuff. 2019-08-04 01:26:20 +02:00
ccrs
85ad0befc5 Core/Unit: rename more methods
Workaround prework till actual facing system rework arrives
2019-08-03 17:53:22 +02:00
ccrs
ec9f15a5ff Core/Unit: rename IsFocusing method
Workaround prework till actual facing system rework arrives
2019-08-03 17:45:06 +02:00
Treeston
7fa990edc6 Scripts/ICC: Prevent Professor Putricide from displaying weird behavior during the Rotface/Festergut encounters as a result of his boss boundary 2019-07-31 16:02:29 +02:00
ForesterDev
0c317498a5 Scripts/Defines: cleanup some magic numbers in factions (#23631) 2019-07-25 12:54:49 +02:00
Treeston
0e7c66cb4c Core/AI: Finally move the "is creature engaged" flag to be a property of the creature AI, where it honestly always belonged. Fixes #17981 and #23602 for real this time. 2019-07-21 01:50:52 +02:00
Wyrserth
e7cf24d263 Script/BoreanTundra: move Pile of Fake Furs' script (related to quest Unfit for Death) from ItemScript to SpellScript.
Closes #21890.
2019-07-17 19:57:21 +02:00
Treeston
d60082ae86 Core/Misc: Various dynspawn cleanup and refactors split off from pooling rewrite:
- Map::RemoveRespawnTime(SpawnObjectType, LowType, doRespawn) split into Map::Respawn and Map::RemoveRespawnTime, without the extra boolean
- Map::RemoveRespawnTime(RespawnInfo*) merged into Map::DeleteRespawnInfo(RespawnInfo*) and is now private
- Map::DeleteRespawnInfo(void) renamed to Map::UnloadAllRespawnInfos to properly describe what it does
- Map::ProcessRespawns now actually saves the delayed respawn time to DB if the respawn was delayed
- Map::AddRespawnInfo now takes const reference, and returns success as a boolean
- Map::AddRespawnInfo no longer offers an unused "replace" parameter
- Map::DeleteRespawnInfo no longer offers a variety of unused private overloads
- Map::SaveRespawnTime no longer offers a tantalizing writeDB parameter. Parameter is now called "startup" to properly describe what it does.
- Map::SaveRespawnInfoDB now takes RespawnInfo reference instead of all the various fields. Still public because compatibility mode. QQ.
- Map::GetWorldObjectBySpawnId sanitized
- Map::GetXRespawnTime methods sanitized to all go through Map::GetRespawnTime
2019-07-15 17:14:58 +02:00
Treeston
be96d8242c warning fix f2cd721 follow-up 2019-07-08 21:53:50 +02:00
Treeston
f2cd721d53 Scripts/Naxxramas: Thaddius no longer evades on transition, and some general cleanup to that script. Fixes #23026. 2019-07-08 20:16:29 +02:00
jackpoz
283ac3d374 Core/Misc: Fix no-pch build 2019-07-07 13:35:11 +02:00
Wyrserth
644910bdc1 DB/Trainer: remove required ability from Riding spells. The client should only show the required amount of skill.
Also comment out unused argument in previously committed script, thanks Aokromes for noticing!
2019-07-07 02:57:24 +02:00
Wyrserth
6199d458c3 Core/Misc: use Trinity's RandomShuffle() instead of soon-to-be-deprecated std::random_shuffle().
Thanks Riztazz for noticing!
2019-07-07 02:49:40 +02:00
Wyrserth
37862942ce Script/TheOculus: adapt Mage-Lord Urom's script to use EventMap, fix various issues with Teleport and Empowered Arcane Explosion, add missing heroic-mode spell Frost Buffet.
Closes #19452.
2019-07-07 02:32:53 +02:00
Wyrserth
30ba9c97fe Misc: explicitly mark fallthrough in switch statement as to avoid confusion. 2019-07-05 17:09:46 +02:00
Gildor
a0a64b10b5 Scripts/Icecrown Citadel: Ensure Deathbringer Saurfang cast Frenzy (#23559) 2019-07-03 19:32:27 +02:00
Wyrserth
a8b8a43b8d Script/HallsOfLightning: fix mistake related to Shattering Stomp in Volkhan's script, introduced in 3bb0abcd52.
Closes #23337.
2019-07-02 11:12:34 +02:00
ccrs
401777d024 Core/Unit: rename several getters to follow codestyle
uint8 GetLevel()
        uint8 GetLevelForTarget(WorldObject const* /*target*/)
        void SetLevel(uint8 lvl)
        uint8 GetRace()
        uint32 GetRaceMask()
        uint8 GetClass()
        uint32 GetClassMask()
        uint8 GetGender()
2019-07-01 21:36:32 +02:00