Commit Graph

8936 Commits

Author SHA1 Message Date
Unholychick
52c0fc96bb Move pestilence to spellscripts
Fixes crash and warnings introduced in d4bbc26261
Fixes a bug that allowed dks to spread diseases using another dks diseases
Closes: https://github.com/TrinityCore/TrinityCore/issues/12245
2014-06-11 20:03:30 +02:00
jackpoz
5ebf24281c Core/NetworkIO: Adjust more packet throttling values
Ignore some opcodes that don't cause any trouble.
Remove old Allow/Disable Anti-DoS system since it's no longer required.
2014-06-09 23:11:10 +02:00
Shauren
b5278ef160 Core/Vehicles: Fixed channeled spells being interrupted for passengers when vehicle moves 2014-06-09 23:11:09 +02:00
Trisjdc
b96b7c291a Core/Handlers: Move a couple of logs to debug, they can appear without anything abnormal due to client latency 2014-06-09 23:11:07 +02:00
Lucas
d1e2768450 Fix Warnings 2014-06-09 23:11:06 +02:00
jackpoz
bd4be27aeb Core/Calendar: Sanitize calendar event parameters
Prevent events added in the past which in some conditions would cause an infinite loop in the client.
2014-06-09 23:11:05 +02:00
jackpoz
3c8503bea7 Revert "Core/Calendar: Fix memory leak when malformed CMSG_CALENDAR_ADD_EVENT is received"
This partially reverts commit 51e38872c7.
The stack-initialized variable calendarEvent would have called CalendarMgr::FreeEventId() when it went out of scope, marking the current event id as free and allowing next event to overwrite current event.
This doesn't fix the memory leak issue which still needs to be addressed in a proper way.
2014-06-09 23:11:04 +02:00
Gacko
ecbf6fdd6c Script: Minor optimization in spell_unlocking_zuluheds_chains 2014-06-09 23:11:03 +02:00
Vincent-Michael
3be5178304 Core/Misc: Kill Whitespace ... 2014-06-09 23:10:59 +02:00
jackpoz
6dc76223fb Core/Banks: Fix some bank exploits
Re-implement the cheat checks removed in a12501fb5e and check if Player can interact with the Banker when handling bank-related opcodes.
2014-06-09 23:10:58 +02:00
Aokromes
6afd62a6bd Core/Database: Update log for incorrect db structure 2014-06-09 23:10:57 +02:00
Unholychick
b651789cb0 Core/Spells: Implement Periodic mechanics
Change behaviour of single target periodic aura ticks to be more blizzlike
Also add some missing handling of SPELL_AURA_MOD_CREATURE_AOE_DAMAGE_AVOIDANCE
Fixes Deep wounds and Chimera Shot Serpent
Remove an ancient hack with Drain Soul, spell id 100001 can now be deleted from spell_dbc table
Allows Rolling dot mechanics and allows DK's to roll diseases with pestilence,
see link for info:

http://forums.elitistjerks.com/topic/82503-frost-dps-in-333this-will-be-a-day-long-remembered/page-88
2014-06-09 23:10:56 +02:00
Trisjdc
f80384a1f2 Core/Spells: Anti-Magic shell should give immunity to all spells that belong to SPELL_SCHOOL_MASK_MAGIC regardless of dispel type 2014-06-09 23:10:55 +02:00
aletuna
77c29e8feb Scripts/Blackrock Depths: Converted to eventmap+minor coding style changes
Closes #11730
2014-06-09 23:10:54 +02:00
Trisjdc
3aa5b01d4d Core/GOs: When unlinking Fishing Bobber from player to prevent despawning, unlink from spell as well to prevent removing unwanted auras 2014-06-09 23:10:53 +02:00
joschiwald
be518159bf Core/Spells: add missing spellradius to spell "Achievement Check" (fixes hor achievments) 2014-06-09 23:10:52 +02:00
Vincent-Michael
2897476517 Core: Fix non pch build 2014-06-09 23:10:50 +02:00
Michael
eac01c3f2a Core/NetworkIO: Added latency info for opcodes overflow log 2014-06-09 23:10:49 +02:00
Trisjdc
f14be42e0c Core/Utils: Move EventMap to Util.h 2014-06-09 23:10:48 +02:00
Trisjdc
78f1cbfba5 Scripts/Items: Imp in a Ball 2014-06-09 23:10:47 +02:00
Trisjdc
46c7524084 Core/Players: Improve quest item adding/removal checks, solves cases where quest item removal (under specific conditions) incorrectly incompletes quests 2014-06-09 23:10:46 +02:00
jackpoz
9c240c14ec Core/Talents: Align server checks to Client limits
Set the max amount of talents to process in CMSG_LEARN_PREVIEW_TALENTS_PET to 30 ( 24 talents rounded up ).
2014-06-09 23:10:44 +02:00
jackpoz
1e545eaa70 Core/Talents: Align server checks to Client limits
Set the max amount of talents to process in CMSG_LEARN_PREVIEW_TALENTS to 150 ( 44 talents for 3 trees rounded up ).
2014-06-09 23:10:43 +02:00
Trisjdc
281527a9c3 Core/Spells: *Properly* solve the Disarm vs Bladestorm issue 2014-06-09 23:10:42 +02:00
Trisjdc
3dce4fabae Core/Spells: Swift Retribution should be reapplied when needed to be able to gain spellmods 2014-06-09 23:10:42 +02:00
Trisjdc
e3b8cd5c7e Scripts/ToCr: Bosses shouldn't despawn so quickly 2014-06-09 23:10:41 +02:00
Trisjdc
e0d08f5afb Core/Spells: Corpse Explosion should not be able to pick the Ghoul out of implicit targets 2014-06-09 23:10:40 +02:00
Trisjdc
fbae790c1d Warning fix 2014-06-09 23:10:39 +02:00
jackpoz
3a9c730083 Core/Tickets: Don't try to save the same sub-survey more than once 2014-06-09 23:10:38 +02:00
Trisjdc
ca6e9112e9 Core/WorldSession: After sudden disconnects, session should persist for a minute
- With this change, if a player alt-f4, he'll only fade from world after a minute
2014-06-09 23:10:37 +02:00
Trisjdc
94b6c1b544 Core/Maps: Allow logging players to enter in instances that have an encounter in progress 2014-06-09 23:10:36 +02:00
Trisjdc
c755a51ce0 Core/Auras: Update model overwriting rules for SPELL_AURA_TRANSFORM 2014-06-09 23:10:35 +02:00
Trisjdc
95a94f89b2 Core/Spells: Fix Cheat Death formula 2014-06-09 23:10:34 +02:00
Trisjdc
eb414532fe Core/CreatureAI: Implement CreatureAI::TalkToMap for all your map-wide talking needs. Could also replace Battleground::SendChatMessage 2014-06-09 23:10:33 +02:00
Golrag
8769207854 Core/Spells: Fixed Shadowstep taking the caster out of combat while it shouldn't 2014-06-09 23:10:31 +02:00
Shauren
84d0094ffa Core/Tickets: Sprinkled some transaction magic on HandleGMSurveySubmit 2014-06-03 23:24:00 +02:00
Sebastian Valle Herrera
409a19e623 Merge pull request #12201 from Unholychick/patch-2
Core/Spells: Implement SPELL_ATTR4_FIXED_DAMAGE
2014-06-02 18:23:17 -05:00
Sebastian Valle Herrera
d41779f8fa Merge pull request #12135 from Trisjdc/event_map_extension
Core/Util: A couple useful new functions for EventMap
2014-06-02 18:10:08 -05:00
Trisjdc
8db02c52ac Core/Util: A couple useful new functions for EventMap, as well as getting rid of some old junk 2014-06-02 23:59:35 +01:00
Sebastian Valle Herrera
d097a5ec97 Merge pull request #12182 from Xter/rbac
Core/RBAC: fix RBAC_PERM_COMMANDS_BE_ASSIGNED_TICKET and RBAC_PERM_LOG_G...
2014-06-02 17:47:40 -05:00
Sebastian Valle Herrera
f5e6292b48 Merge pull request #12032 from Trisjdc/haste_formula
Core/Players: Fix haste rating formulas
2014-06-02 17:23:16 -05:00
jackpoz
0c1ddc970d Core/Misc: Kick player in case of multiple CMSG_PLAYER_LOGIN
Kick player in addition to logging an error in case of multiple CMSG_PLAYER_LOGIN.
2014-06-02 17:03:31 +02:00
Lucas
82cefb661d Core/Spells: Implement SPELL_ATTR4_FIXED_DAMAGE
Spells with this attribute will ignore damage taken auras except for mechanic damage taken (trauma, etc) and will ignore resilience because the damage caused by those spells is based off another spell' damage
2014-06-02 15:41:02 +02:00
Gacko
26370223a0 Script/Shadowmoon Valley: Remove hack in npc_shadowmoon_tuber_node.
This script will be converted to SAI (if possible) later.
2014-06-01 19:39:57 +02:00
Gacko
8ef34535a4 Scripts: Remove unused variables (kept as comment) 2014-06-01 19:34:34 +02:00
Shauren
9fcd607e78 Core/Misc: Added utility method for checking is two sorted containers have a common element 2014-06-01 19:20:49 +02:00
jackpoz
282a7cad7d Core/Misc: Code cleanup
Remove old unused opcode handler WorldSession::HandlePageQuerySkippedOpcode() for CMSG_PAGE_TEXT_QUERY since it's already handled by WorldSession::HandlePageTextQueryOpcode()
2014-06-01 16:15:27 +02:00
jackpoz
70bd70080d Core/QuestPOI: Mitigate possible DoS with CMSG_QUEST_POI_QUERY
Avoid sending POIs for same quest if the client somehow sent duplicates quest id in same CMSG_QUEST_POI_QUERY packet. This also reduce the effects of possible DoS and increases the difficulty to cause it.
Fix a typo which caused no quest POIs to be sent at all if the client queried data for 25 quests.
2014-06-01 13:33:46 +02:00
jackpoz
6a54ed88c6 Core/NetworkIO: Fix performance loss when handling bad packets
Revert f9cb4280bd which retrieved the callstack each time a ByteBufferPositionException or a ByteBufferSourceException occurred, for example with bad packet structure.
2014-06-01 00:29:33 +02:00
xter
19c56cbc0e Core/RBAC: fix RBAC_PERM_COMMANDS_BE_ASSIGNED_TICKET and RBAC_PERM_LOG_GM_TRADE permissions 2014-05-31 14:04:37 +02:00