Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-19 17:05:44 +01:00
Code Issues Packages Projects Releases Wiki Activity
13,894 Commits 4 Branches 146 Tags
5b034ee631822f71c6504944963aaa17c6a29b68
Commit Graph

301 Commits

Author SHA1 Message Date
megamage
5b034ee631 Revert 81fea2d7b5. 2011-11-28 14:34:30 -05:00
megamage
1f70fd2851 Delete DynamicObject if AddToMap fails. 2011-11-28 14:19:29 -05:00
megamage
81fea2d7b5 Fix some memory leak from CreateTamedPetFrom. 2011-11-28 14:10:56 -05:00
Shauren
358b33239a Core: Fixed remaining C6246: Local declaration of 'x' hides declaration of the same name in outer scope. from previous commit 2011-11-23 19:17:33 +01:00
Machiavelli
c67af87eda Core/Spells: Fix SPELL_EFFECT_SEND_EVENT handler being executed more than once when targets != (0, 0). Closes #3934 2011-11-16 19:09:51 +01:00
tobmaps
70aafbda94 Core/Spells: Partially fix RP-GG 2011-11-12 02:36:18 +07:00
Bootz
d1334624da Core: Codestyle clean-up 
"pl"->"player"

 Note: codestyle methods needs maintained, Player* player.
still to do properly clean-up chat.cpp.
 2011-11-07 11:18:00 -06:00
Bootz
f75ec5ba2b Core: Codestyle clean-up 
"plr"->player

Note: codestyle methods needs maintained, Player* player.
 2011-11-07 11:06:39 -06:00
tobmaps
8fd7720318 Core/Misc: Rename Spell::CalcCastTime to Spell::GetCastTime as it does not calculate anything 2011-11-05 05:33:52 +07:00
tobmaps
935527eebe Core/Spells: Use dbc flag to check if channeled spell can be interrupted 
Closes #2292
 2011-11-05 05:21:37 +07:00
tobmaps
37abe2528c Core/Spells: Remove not needed check added in 9229b878f2 2011-11-03 17:08:30 +07:00
tobmaps
9229b878f2 Core/Spells: Fix Runic Healing/Mana Injector bonus for engineers 2011-11-02 19:23:59 +07:00
tobmaps
c0c6000a44 Core/Misc: Fix spelling typo 2011-11-02 19:13:51 +07:00
ille
5514523a7c use effectMask to calculate mechanicMask in ModSpellDuration 2011-10-20 18:28:37 +02:00
Liberate
ddec56b3e0 Core/Spells: Fix shadowfiend. 
Fixes #3285
 2011-10-19 23:30:25 +02:00
Liberate
b268b51d0e Core/Spells: Add Block Value cap to Shield Slam and Shield of Righteousness. 
Fixes #599
Fixes #2119
 2011-10-19 13:00:22 +02:00
Spp
ee69fc940e Core/Items: Split SetSoulboundTradeable in two functions (Set and Clear) 
Note: this is mostly for clarify action being done: ClearSoulboundTradeable better than SetSoulboundTradeable(..., ..., false)
 2011-10-18 10:44:45 +02:00
megamage
3ba22d0d06 Rename Map::Add to Map::AddToMap, Map::Remove to Map::RemoveFromMap for better management. 2011-10-10 17:39:34 -04:00
megamage
d156e066cf Rename "SetPosition" to "UpdatePosition". 
Replace CreatureRelocation in scripts with new Creature::SetPosition.
 2011-10-10 17:08:01 -04:00
Bootz
5b4c7783c2 REPO: Code-style clean-ups 
* Fixed pMap->map
* Fixed pInstance->instance
* Fixed pInsta->instance
* Fixed pQuest->quest
* Fixed pWho->who
* Fixed pTarget->target
* Fixed pGo->go

~DEVNOTES: Handlers/QuestHandler.cpp still needs to be cleaned...
 2011-10-07 19:45:43 -05:00
Bootz
81c0a3a847 REPO: code-style clean-up 
* Fixed pPlayer->player
* Fixed pCreature->creature

~DevNote: codestyle for Player should be (*player), not *plr or *p...
same goes for Creatures (*creature)... more cleaning needed.
We've way too many codestyles happening here.
 2011-10-07 11:08:09 -05:00
Bootz
96d7a1e970 REPO: code-style clean-up 
* Fixed pGuild->guild
* Fixed pGroup->group
* Fixed pOwner->owner
 2011-10-07 10:54:53 -05:00
Shauren
8919b9cb4c Core/Spells: Fixed typo breaking SPELL_AURA_MOD_AOE_DAMAGE_AVOIDANCE and SPELL_AURA_MOD_CREATURE_AOE_DAMAGE_AVOIDANCE 2011-10-06 14:22:11 +02:00
Shauren
5d37116ea6 Core/Spells: Allow ProcessEvent hook to run in EffectSendEvent when spell caster is a player 2011-09-30 18:41:30 +02:00
Shauren
da54fb92d5 Core/Movement: Fixed knockback visibility for other players (no more "teleport") and knockback strength from creature spells (this does not fix knocking creatures back) 2011-09-30 18:24:12 +02:00
Spp
b16d2245bb Cosmetic: Multiple cosmetic changes 
- Added missing space to 'if', 'for', 'while' and 'switch' when it's followed by '('
- Added missing space after a comma and remove space before comma (with some exceptions)
- Remove trailing spaces
- Convert tab to spaces

Note: Only affects files with extension "cpp" and "h" under /src/server
 2011-09-29 12:43:05 +02:00
QAston
8dd88fa43c Core/Spells: fix a typo which caused to display unneeded error message (invalid target) during cast of some spells (like warrior charge). 2011-09-28 18:59:55 +02:00
QAston
a409cc226c Core/Spells: Fix Vanish's stealth trigger and Demonic Empowerment's invisibility trigger 
Those spells were failing to pass default effect trigger spell due to their custom implementation (changing triggered_spell_id instead of adding serverside spells with proper targeting).
 2011-09-27 00:36:23 +02:00
QAston
e949ad3adb Core/Spells: spell effect handling improvements 
* Call spell effect handlers in 4 modes:
   - SPELL_EFFECT_HANDLE_LAUNCH - called when spell is launched (cast just finished)
   - SPELL_EFFECT_HANDLE_LAUNCH_TARGET - called when spell is launched for each target in spell target map
   - SPELL_EFFECT_HANDLE_HIT - called when spell hits its destination
   - SPELL_EFFECT_HANDLE_HIT_TARGET - called when spell hits it's target from spell target map
*Correctly implement SPELL_EFFECT_TRIGGER_SPELL, SPELL_EFFECT_TRIGGER_SPELL_WITH_VALUE, SPELL_EFFECT_TRIGGER_MISSILE_SPELL_WITH_VALUE, SPELL_EFFECT_TRIGGER_MISSILE_SPELL
*Remove spell system hacks which became obsolete with this commit
Core/SpellScripts:
add OnEffectLaunch, OnEffectLaunchTarget, OnEffectHit, OnEffectHitTarget hooks for new effect handle modes and remove OnEffect hook.
A generic rule of thumb how to update your scripts (will work for nearly all cases) for spell system noobs:
if your spell script used GetHitXXXX function, you need to use OnEffectHitTarget, otherwise use
OnEffectHit
 2011-09-25 13:29:50 +02:00
QAston
d01a761f53 Core/Spells: Drop EFFECT_IMPLICIT_TARGET_PET and use EFFECT_IMPLICIT_TARGET_EXPLICIT instead. 2011-09-24 02:02:39 +02:00
Shauren
154c7ce79c Core/Spells: Fixed Brewfest - Attack Keg spell damage 2011-09-22 20:16:47 +02:00
QAston
c0b1823524 Core/Entities: Replace Unit::canAttack usage with more accurate Unit::IsValidAttackTarget 2011-09-16 23:49:31 +02:00
Shauren
732e27f1e8 Core/Spells: Spells having the same effect types on multiple effects will now select them at the same time (except targets selected by entry) to ensure correct behavior with MaxAffectedTargets use 2011-09-16 11:40:53 +02:00
Shocker
7afb179185 Misc/Util: Add a template function for returning a random element from any container 2011-09-15 21:28:40 +03:00
Nay
791acfebac Core/Spells&GOs: Fix Ritual of Doom. 
Thanks QAston and Shocker for helping.
Closes #2535
 2011-09-15 17:52:35 +01:00
Spp
af05915b9e [Cosmetic] Apply codestyle "XXX * " and "XXX *" changed to "XXX* " (with some exceptions) 2011-09-15 14:12:57 +02:00
Spp-
33ce07bdde Core: Minor cleanups (here and there) 
- Fix warning
- Fix some typos
- Correct upper 'for' limit in LoadSkillLineAbilityMap
- Remove use of magic number in a query related to security levels
 2011-09-13 14:15:35 +02:00
Spp-
327fe7c247 Core: Define helper functions to know if an account is Player, Moderator, GM, Admin or Console 2011-09-08 15:11:55 +02:00
kaelima
6078eebc45 Fix typo in 9d90c8245b and unintended change in b08900d033b51632e9adef8cb227a71a1061be5f. 2011-09-07 15:09:53 +02:00
kaelima
9d90c8245b Core/Spells: Deep freeze should do damage instead of freezing on targets with permanent stun immunity. 2011-09-07 00:19:40 +02:00
Nay
152f446c60 DB/BGs: Fix capturing of Snowball GY - AV 
Counter-hack a hack with a hack. Closes #222
 2011-09-06 21:20:14 +01:00
Shauren
f13f32c972 Core/Achievements: Award normal mode achievements when instance was done on heroic mode 2011-09-05 15:21:37 +02:00
Spp-
3fac9914be Core: Code cleanup (here and there) 2011-09-05 14:01:50 +02:00
Nay
fd5ab97774 Core/Spells: Fix Distract. Closes #155 2011-09-04 01:58:44 +01:00
Chaplain
bea649d045 Core: cleanup. 
*remove some garbage
*little bit moore const func
*fix process of args in vmap3_extractor
 2011-09-01 22:38:32 +03:00
QAston
8e392440cf Core/Spells: Fix a regression of 7f30ac5a95 - spells with TARGET_SELECT_CATEGORY_CHANNEL target type (like mind sear) should be triggered by triggering spell caster 2011-08-26 12:39:50 +02:00
QAston
7f30ac5a95 Core/Spells: Add a generic way of selecting spell explicit targets. Make explicit targets independant of calling convention in core - this makes targets sent to client to be much more blizzlike than before (for example CastSpell(Unit*) won't set TARGET_FLAG_UNIT for spells which are not using explicit unit target) for SMSG_SPELL_START packets. Also remove hacks, which became obsolete with this commit. 2011-08-24 08:08:33 +02:00
Chaplain
fb27848510 Core: Clean up here and there. 
*replase postfix iterator increment\decrement with prefix in cycles
*replase strlen(*char) != 0 with *char[0] != '\0'
*replase strlen(rStr.c_str()) with rStr.length()
 2011-08-23 18:09:08 +03:00
QAston
e2d8faea09 Core/Spells: move Cannibalize and Carrion Feeder cast checks to SpellScripts. 2011-08-20 00:30:38 +02:00
tobmaps
cd03dadb7f Core/Misc: Minor code cleanup and code style fix 2011-08-20 04:43:01 +07:00