Commit Graph

33141 Commits

Author SHA1 Message Date
Treeston
643b9209f8 Common/Misc: Clean-up a GCC sign comparison warning 2020-08-20 02:22:23 +02:00
Peter Keresztes Schmidt
4286e7aa02 Core/ChatCommands: Check whether a passed numeric enum value is valid (#25285) 2020-08-20 00:46:52 +02:00
Peter Keresztes Schmidt
9c9e8c7d58 Scripts/Commands: Convert argument parsing of gm commands to new system (#25279) 2020-08-19 14:53:04 +02:00
Peter Keresztes Schmidt
1aadf6c6d1 Scripts/Commands: Convert argument parsing of remaining go command to new system (#25284) 2020-08-19 14:49:29 +02:00
NoName
01c7663bdd Core/PacketIO: Update SMSG_QUESTGIVER_OFFER_REWARD (#25251)
Co-authored-by: Carbenium <carbenium@outlook.com>
2020-08-19 14:47:55 +02:00
Carbenium
515a34f64f Scripts/Commands: Convert argument parsing of honor commands to new system 2020-08-19 00:29:31 +02:00
Treeston
f04f4e91ff Core/Warden: Add .debug warden force, allowing you to force specific warden checks to be sent 2020-08-19 00:25:44 +02:00
offl
24a494398f DB/Creature: Remove incorrectly added event from Thule Ravenclaw
Ref ad2552d04a

This event belongs to Ravenclaw Apparition only, also removes permanent SetActive
2020-08-18 23:32:30 +03:00
Peter Keresztes Schmidt
c952cb7f71 Scripts/Commands: Convert argument parsing of deserter commands to new system (PR #25276) 2020-08-18 22:27:24 +02:00
offl
20ca00ebdb DB/Quest: Add correct action type to give quest credit for 'Escorting Erland'
Closes #25280 Ref eea3cf1401
2020-08-18 22:50:31 +03:00
Jildor
7dbbc50fc4 DB/SAI: Remove unnecessary SetActive in DK start zone
Closes #25278
2020-08-18 21:59:52 +03:00
Peter Keresztes Schmidt
4707e05938 Scripts/Commands: Convert argument parsing of cheat commands to new system (PR #25277) 2020-08-18 15:22:09 +02:00
offl
3ba563acce DB/Areatrigger: Add correct teleport positions from world safe locs to more areatriggers
Probably last part. 30 areatriggers requires updates (all without VerifiedBuild) but we can't use positions for most of them from WSL since they were changed in Cata. Positions for some of them can be found in 3.x.x sniffs
2020-08-18 02:52:42 +03:00
Cerveciento
d751cbe0be DB/Locale/esES+esMX quest_greeting_locale
Closes #25272
2020-08-18 02:50:48 +03:00
Cerveciento
5a5d5b25e2 DB/Locale/esES+esMX Texts missing in quests (Part 21)
Closes #25271
2020-08-18 02:50:24 +03:00
Treeston
5ecbe93f7d [[maybe_unused]] to make CIs happy, 0b13fc1 follow-up 2020-08-17 23:13:41 +02:00
Treeston
0b13fc1926 Scripts/Commands: Revert e18f7aa, re-add .debug asan outofbounds, move bodies to #ifdef 2020-08-17 22:54:39 +02:00
Peter Keresztes Schmidt
76f309b4e8 Scripts/Commands: Convert argument parsing of most debug commands to new system (PR #25260) 2020-08-17 22:45:09 +02:00
Treeston
e18f7aaa4d Scripts/Commands: Remove .debug asan outofbounds, because having reachable code that essentially says __builtin_unreachable in the core is making me twitchy. 2020-08-17 22:25:11 +02:00
Peter Keresztes Schmidt
426513ec8e Scripts/Commands: Convert argument parsing of ahbot commands (PR #25264) 2020-08-17 22:04:44 +02:00
Shauren
a9a4f05a28 Core/Pets: Fix loading pet data
Closes #25269
2020-08-17 20:01:48 +02:00
Peter Keresztes Schmidt
9df61fd111 Core/ChatCommands: Parse SpellInfo also from enchant, glyph, talent and trade links (PR #25270) 2020-08-17 18:26:41 +02:00
Carbenium
fa6a8e8f64 Scripts/Commands: Convert argument parsing of bf commands to new system 2020-08-17 15:51:46 +02:00
Peter Keresztes Schmidt
dfeaa2e81f Core/ChatCommands: Add Variant.get<typename> overload (PR #25267)
Co-authored-by: Treeston <treeston.mmoc@gmail.com>
2020-08-17 14:45:32 +02:00
Treeston
66491dbfb3 make compilers happy 2020-08-17 14:42:27 +02:00
Shauren
bbcf00257e Core/Spells: Fix summoning warlock pets in case that pet has never been summoned before 2020-08-17 11:52:44 +02:00
Shauren
9c5876d8ab Core/Spells: Fix summoning SUMMON_PET type pets
Closes #25265
2020-08-17 09:19:43 +02:00
illfated
a9d493c456 DB/Text: Add correct text to Sylvanas (Lament of the Highborne)
Closes #25262
2020-08-17 03:57:18 +03:00
offl
e084d9e37a DB/Areatrigger: Add correct teleport positions from world safe locs to more areatriggers 2020-08-17 03:57:00 +03:00
Treeston
ffc3e355fe Core/ChatCommands: Move Trinity::ChatCommands::Variant from boost::variant to std::variant (for real this time) 2020-08-17 02:23:38 +02:00
Treeston
7bceff1b2a revert 1aeb7a0 and f9e7dbd until I can work around GCC being silly 2020-08-17 01:05:09 +02:00
Treeston
1aeb7a0980 How did this even build in VS???? (don't kill me shauren) (f9e7dbd follow-up) 2020-08-17 00:55:19 +02:00
Treeston
f9e7dbd8b4 Core/ChatCommands: Move Trinity::ChatCommands::Variant from boost::variant to std::variant, which means we no longer need visitors 2020-08-17 00:49:07 +02:00
Peter Keresztes Schmidt
30a825e2ac Core/ChatCommands: Add support for std::array-type arguments (#25261) 2020-08-17 00:15:53 +02:00
offl
68557e9ca3 DB/Gameobject: Remove gameobjects with negative respawn time from dynamic scaling spawn group 2020-08-16 23:38:39 +03:00
offl
c5b303ef56 DB/Areatrigger: Add correct teleport positions from world safe locs to some areatriggers 2020-08-16 23:37:59 +03:00
offl
aae38bec11 DB/SAI: Remove SMARTCAST_INTERRUPT_PREVIOUS from nearly all scripts
No longer needed after ca25e8d019

Explained in https://github.com/TrinityCore/TrinityCore/issues/24914

Some event types not affected because requires tests, events with No Repeat event flag skipped
2020-08-16 23:37:05 +03:00
offl
e8e3626073 DB/Creature: Add missing cosmetic channeled spell in Ahn'kahet
Closes #12024
2020-08-16 23:36:29 +03:00
Cerveciento
6bd104e0aa DB/Locale esES+esMX Texts missing in quets (Part 20)
Closes #25250
2020-08-16 23:36:03 +03:00
Shauren
5c1fc5e387 Core/Pets: Pet management refactoring (#25191)
* Core/Pets: Pet management refactoring

* Preload basic pet data on character login with async query
* Load additional pet data (declined names/auras/spells/cooldowns) using async query after we are sure pet loading will succeed
* Remove all select queries related to pet stable/unstable
* Remove all silent pet deletions except explicit UI-triggered abandons
* Fixed displaying stable master content when current pet is not summoned
* Allow to stable/swap unsummoned current pet

Closes #3610
Closes #21266
2020-08-16 21:39:25 +02:00
Peter Keresztes Schmidt
7edad0d601 Core/ChatCommands: Do not parse partial strings for numeric paramters (PR #25259)
Check if integral/floating point type arguments were parsed successfully.

std::stoull will happily parse floating point strings until the decimal separator and return the value.
Make sure for all parsing methods that we actually parsed the whole token.

This allows to use handler arguments like Variant<uint32, float> which will be populated with the right type
depending on the token value (e.g "10" vs "10.0").
2020-08-16 21:32:31 +02:00
Giacomo Pozzoni
ca25e8d019 Core/SAI: Spell casts that cannot be executed because the unit is currently casting another spell will be retried asap with priority over other events (#25238)
* Core/SAI: Spell casts that cannot be executed because the unit is currently casting another spell will be retried asap with priority over other events

* Core/SAI: Re-sort the events only when needed

* Fix some priority reset and wrong mEventSortingRequired handling

* Code cleanup.
Sort only events loaded from db (not stored events, not timed action list).

* Code cleanup.
Raise priority of failed casts so they are retried before other spells

* Keep priority of the action fails and is rescheduled on next update

* Don't try recasting a spell in SMART_ACTION_CAST if there are multiple targets and at least 1 was successful
2020-08-16 16:50:04 +02:00
Peter Keresztes Schmidt
df29f60595 Core/ChatCommands: Honor exact matches during enum arg parsing (PR #25255) 2020-08-16 16:27:19 +02:00
Peter Keresztes Schmidt
86dc58974a Scripts/Commands: Use enum type arg for HandleDebugAnimCommand (PR #25256)
* Core/Shared: Make Emote enum smart
* Scripts/Commands: Use enum type arg for HandleDebugAnimCommand
2020-08-16 16:26:47 +02:00
Treeston
b74dc4754d Core/DB: Move every gameobject that uses the spawntimesecs < 0 hack into the legacy spawn group 2020-08-16 16:02:26 +02:00
scizzydo
4125a81bb1 Core/Warden: Fix for LUA_STR_CHECK (#25247)
The check above is what I use to actually get a real result for LUA_STR_CHECK, which when I used variables that would have a string to them it actually fails the check. When checking for items like a function if it exists of course it won't work... In addition, fixing the Unk2 to Unk3 causes people to be able to adjust the address of the check to the address 0x00419210 to make warden perform the FrameScript__Execute to run lua on the client. This seems to be the big request like in https://github.com/TrinityCore/TrinityCore/issues/23035
2020-08-16 14:50:08 +02:00
Peter Keresztes Schmidt
5e40eb20e2 Core/ChatCommands: Add support for enum type arguments (PR #25242) 2020-08-16 14:11:21 +02:00
Peter Keresztes Schmidt
6c7837f947 Core/Unit: Make HandleEmoteCommand typesafe (#25249)
* Scripts/ScarletMonastery: Fix wrong emote during Headless Horseman encounter

* Scripts/HoR: Fix wrong emote during escape event

* Core/Unit: Make improve type safety of HandleEmoteCommand

Change argument type to the expected enum type Emote

* Scripts/CoS: Use SetUInt32Value to set UNIT_NPC_EMOTESTATE

UNIT_NPC_EMOTESTATE is no flag field
2020-08-15 15:29:43 +02:00
Peter Keresztes Schmidt
34d403e83f Core/Spells: Mark constructors of Spell/AuraScript handlers as explicit (#25248)
Mostly to make clang-tidy happier
2020-08-15 13:50:26 +02:00
Peter Keresztes Schmidt
87211d9f4d Core/PacketIO: Update SMSG_QUESTGIVER_QUEST_DETAILS (#25232)
* Core/PacketIO: Update SMSG_QUESTGIVER_QUEST_DETAILS

* Core/PacketIO: Name RewardFactionFlags field of QuestInfo struct
2020-08-15 13:25:23 +02:00