Commit Graph

4998 Commits

Author SHA1 Message Date
tkrokli
6953e06c4b Core/Scripts: simplified npc_pet_trainer gossip script
This is what the script changes should have been in PR #17746
(also updates issue #14719 with a correct solution).

- remove OnGossipHello() to use DB conditions
- replace OnGossipSelect() with sGossipSelect()
- focus script on the confirming gossip option
- let the other gossip menus be handled in DB
2016-09-18 07:38:25 +02:00
Treeston
226762216a Map/Instances: Greatly simplify PermBindAllPlayers logic. (#17940) 2016-09-18 07:38:06 +02:00
treeston
72a76d6226 Instance/UtgardePinnacle: Fix Svala Sorrowgrave timings (from sniff). 2016-09-14 14:32:03 +02:00
SnapperRy
9b89458cc8 Script/Quest: fix and use proper serverside summon spell for quest "Red Snapper - Very Tasty!". 2016-09-10 14:26:36 +02:00
SnapperRy
e9b2feba4f Script/Quest: replace wrong test spell used for quest "Red Snapper - Very Tasty!" with actual summoning.
The spell does not appear in sniffs, and the summoned NPC's spawn time was far too short to be appropriate (15 seconds).
2016-09-10 14:26:18 +02:00
Rochet2
19ed813f6b Core/Scripts: Enhance quest status hook by making it catch more status changes (#17865) 2016-09-10 14:25:57 +02:00
Aokromes
dc4657218e Core/Scripts: Implement Flag of Ownership
Core/Spells: Implemented TARGET_CORPSE_SRC_AREA_ENEMY.
2016-09-10 03:53:34 +02:00
Aokromes
a1fdfe9259 Typo fix, fix compile 2016-09-04 15:03:40 +02:00
Aokromes
8284afd5a6 Core/Spells / Scripts: Fix Lock and Load 2016-09-04 11:47:54 +02:00
Aokromes
ed41de566f Core/Scripts: Implement Glyph of Backstab 2016-09-04 11:34:09 +02:00
Aokromes
d09c1712cd Core/Misc: Build fix 2016-09-04 00:55:58 +02:00
Vincent-Michael
95a7a88ef0 Core/Commands: Fixed build 2016-09-04 00:19:29 +02:00
xjose93
882453253f Core/Commands: Implement .neargraveyard (find nearest graveyard from dbc). 2016-09-04 00:19:13 +02:00
treeston
77631a8cde Drycoding is bad, mmkay? 2016-09-03 17:30:37 +02:00
treeston
9a829b4761 Scripts/Events: Globally fix all ExecuteEvent loops to check UNIT_STATE_CASTING after each iteration, instead of just checking it once initially 2016-09-03 17:26:20 +02:00
Aokromes
3e00b379f3 Scripts/Misc: Delete no longer used files 2016-08-31 08:44:01 +02:00
treeston
109d87d3c3 Entities/Gossip: The Big One™ that gets rid of all uses of The Bad™ and The Ugly™, e.g. gossip preprocessor macros, and replaces them with the new-and-shiny gossip functions. 2016-08-31 08:39:33 +02:00
tkrokli
ffc47e0c4c Core/Scripts: remove forgotten #define in boss_kalecgos.cpp
This #define was originally supposed to be removed in my PR #17832,
but for some reason it remained undeleted. This commit corrects it.

Also aligned all the enum values to the same column for readability,
based on a common multiple of 4 spaces.
2016-08-31 08:18:51 +02:00
Aokromes
df2c6972c4 Whitespace clean-up 2016-08-29 01:20:31 +02:00
ariel-
4acebe6c91 Core/Scripts: Professor Putricide oozes, reapply passive proc auras on reset, and register them as PP summons since they're summoned by a trigger. (f183ed3c50 follow-up) 2016-08-28 10:20:14 +02:00
ariel-
9b8a4b5fea Core/Scripts: fix math error that would not select points on the entire circle 2016-08-25 15:01:16 +02:00
ariel-
0c3e061b2b Update boss_kelthuzad.cpp 2016-08-25 15:00:25 +02:00
Aokromes
8aaea40f03 travis is lazy 2016-08-25 14:59:54 +02:00
Gustavo
3b2e9d4ca4 Core/Scripts Boss Skadi the Ruthless rework 2016-08-25 14:59:21 +02:00
Aokromes
5de3f3c59f Core/Scripts: move npc_experience hardcoded text to DB 2016-08-25 14:59:00 +02:00
tkrokli
1c80212429 Core/Scripts: move #define to enum in boss_kalecgos.cpp 2016-08-25 14:54:11 +02:00
tkrokli
8d1a2284f5 Core/Scripts: move forge_of_souls gossip to DB 2016-08-25 14:53:46 +02:00
Gustavo
f7667cdda6 Core/Scripts Implement Pit of Saron Cavern event 2016-08-25 14:53:14 +02:00
Gustavo
49d4e22c6a Scripts/Pet Implemented Argent Squire/Gruntling and Argent Pony Bridle 2016-08-25 14:52:56 +02:00
Aokromes
99a5df07e3 Missing overrides 2016-08-24 19:23:13 +02:00
Aokromes
332feace2c Scripts/Naxxramas: Full Kel'thuzad rework.
- Sniffed timers
- Sniffed spawn behavior
- Sniffed everything else
- Sniffed sniff. Mmmm
 - In all seriousness though:
    - Fixed P2 cast behavior, now obeys category cooldowns as intended
    - Fixed P1 pathing and abomination behavior
    - Fixed P1 passive minion aggro logic
    - Fixed P1->P2 transition logic
    - Fixed P3 guardian spawn/despawn logic
    - Fixed all minions' cast behavior
    - Fixed melee hitbox for Kel'thuzad, abominations, banshees and guardians
    - Fixed reset behavior
    - Fixed post-Sapphiron event to no longer open the KT door for a few seconds before slamming it closed again by treeston
2016-08-24 19:20:37 +02:00
treeston
a7c88b1d6b Scripts/HallsOfLightning: Fix Volkhan healing. 2016-08-24 10:25:30 +02:00
tkrokli
5301e4578e Core/Scripts: set correct unit_flags on Scarlet Mine Car (#17844)
Closes #17816
2016-08-24 10:25:08 +02:00
SnapperRy
506b2a4f2a Event/Brewfest: implement relay race (#17603) 2016-08-23 13:54:57 +02:00
tkrokli
efa7a0639c Core/Scripts: npc_wormhole #define text moved to DB (#17805)
Another core script hardcoded text removal:
- removed #define text from script
- added the text to gossip_menu_option
- added and renamed enum to match DB entries
- minor additional adjustments and comments

Closes #6841
2016-08-23 13:54:38 +02:00
Gustavo
83de75e31b Improve scripts for quests Breakfast Of Champions and A Bear of an Appetite (#17780)
Properly despawn the related GameObjects after use of the quest item, avoiding multiple use and summon
2016-08-23 13:54:24 +02:00
SnapperRy
1cd71ca5cd Scripts/ArgentTournament: improve training dummy script
Now the ranged and charge target dummies will cast their spells and behave correctly for the related quests
2016-08-23 13:54:10 +02:00
Aokromes
4433501213 Core/Misc: Fix static analysis issues 2016-08-22 14:22:56 +02:00
Treeston
a29913187b Core/Spells: Fix orientation- and targeting-related issues if the creature isn't currently engaged in combat. (#17120)
Also disable spell focus system for vehicle control auras.

Closes #16572
Closes #17016
2016-08-21 13:16:30 +02:00
Alan Deutscher
372ef5e5a2 Scripts: UNIT_FLAG_REMOVE_CLIENT_CONTROL no longer used as a method for preventing a unit from moving
UNIT_FLAG_REMOVE_CLIENT_CONTROL (formerly UNIT_FLAG_DISABLE_MOVE) is a client-only feature that should not be used for NPC scripting. All applications of this flag in scripts/ have been replaced with applications/removals of the UNIT_STATE_ROOT state.

Closes #17311
2016-08-21 13:16:10 +02:00
jackpoz
58e4568c36 Core/Commands: Code cleanup
Remove commented out code
2016-08-21 13:14:27 +02:00
Aokromes
5023384dab Update boss_jedoga_shadowseeker.cpp 2016-08-20 12:33:28 +02:00
Aokromes
56b3f461fe Core/Scripts: move Pet Trainer gossip to DB
SQL content based  on issue 14719 by Killyana,
conditions output from Malcrom's Condition Creator

- remove hardcoded #define gossip options
- enum gossip menu IDs from DB
- remove outdated SD comments at the top of the file
2016-08-20 12:22:58 +02:00
treeston
190ef9fc54 Pet/DK: Make Risen Ghoul and Bloodworms no longer suicidally charge into not-yet-engaged mob packs. 2016-08-20 06:22:42 +02:00
ariel-
30e0460306 Core/Scripts: allow ".debug arena" and ".debug battleground" commands to be issued in the console 2016-08-16 12:26:33 +02:00
Aokromes
960c22e602 Core/Scripts: remove script npc_timothy_daniels
The core script `npc_timothy_daniels` is no longer needed,
all the gossip handling is already present in the database.

- remove core script npc_timothy_daniels
- remove ScriptName from c_t entry in DB
2016-08-14 23:57:06 +02:00
tkrokli
d847bcdac4 Core/Scripts: move npc_mortog_steamhead to DB
Move core script npc_mortog_steamhead to database
- script contains gossip handling + 1 condition
- both actions can be handled in DB settings
2016-08-14 10:16:43 +02:00
Aokromes
31dea6b435 Compile fix 2016-08-12 12:46:28 +02:00
ForesterDev
f59e00b85c Core/Command: Check account password max length 2016-08-12 12:19:19 +02:00
tkrokli
c425b91368 Core/Scripts: remove 2 unused scripts (#17759)
These scripts are no longer in use:
- generic_creature
- trigger_death
2016-08-12 12:19:02 +02:00