Commit Graph

2337 Commits

Author SHA1 Message Date
Carbenium
6a8c12587e Core/Misc: Create new enum for AreaIds
Move Wintergrasp BF related values there
2020-06-24 15:09:57 +02:00
jackpoz
54e30d4eba Scripts/VioletHold: Limit the number of current summons before the waves start 2020-06-20 14:12:47 +02:00
Peter Keresztes Schmidt
418c3b1fd5 game/AI: Convert SelectAggroTarget to enum class (#24818)
* game/AI: Convert SelectAggroTarget to enum class

* game/AI: Rename SelectAggroTarget to SelectTargetMethod
2020-06-16 23:08:56 +02:00
Gildor
aeb41e67a9 Scripts/Naxxramas: Fix Kel'thuzad evade mode when he dies (#24763) 2020-06-07 12:55:38 +02:00
ForesterDev
e3b232fe0e Core/AI: refactor SpellHit and SpellHitTarget. (#24691)
* Core/AI: refactor SpellHit and SpellHitTarget.

- now caster/target is WorldObject instead of Unit
- remove SpellHitByGameObject / SpellHitTargetGameObject (handled by SpellHit / SpellHitTarget)
- rename parameters in scripts according parent methods

* Restore logic in Algalon script

* Changed check for REMORSELESS_WINTER hit to avoid dublicate call, because it has TARGET_UNIT_CASTER for effects 0/1 and TARGET_GAMEOBJECT_SRC_AREA for effect 2

* Fix build after merge
2020-06-07 10:22:13 +02:00
Gildor
1181b636c0 Scripts/Naxxramas: Noth the Plaguebringer improvements (#24724) 2020-06-06 14:22:19 +02:00
Keader
d81a9e5bc3 Core/Misc: Fixed resistance calculate for Mutated Transformation and Twilight Bloodbolt (#24717)
Ref: 9f7b464a6a
- Implemented a new SpellScript hook that allow control Resistance/Absorb amount of a damage spell.
2020-06-03 22:05:08 -03:00
Giacomo Pozzoni
8c09b6e58b Cherry-pick some cmake commits (#24720)
* Build system: Support  new in cmake 3.17 Ninja Multi-Config generator

(cherry picked from commit 369b618d4f)

* Build system: Fixed PCH with MSVC & Ninja generator

(cherry picked from commit d669f46b6d)

* Core: Fix clang 10 warnings

(cherry picked from commit 7272508cb4)

# Conflicts:
#	src/common/Utilities/Util.h
#	src/server/bnetserver/REST/LoginRESTService.cpp
#	src/server/game/Entities/Object/Position.h
#	src/server/game/Entities/Player/Player.cpp
#	src/server/game/Guilds/GuildFinderMgr.h
#	src/server/game/Movement/Spline/MoveSplineFlag.h
#	src/server/shared/Dynamic/LinkedList.h

* Build system: Set -Wno-deprecated-copy only for clang 10

(cherry picked from commit 7fdeb259ba)

* Core/Misc: GCC build and warning fixes

(cherry picked from commit 4d69cc1c56)

# Conflicts:
#	src/common/Utilities/Util.cpp
#	src/server/database/Database/MySQLConnection.cpp
#	src/server/game/Battlefield/Zones/BattlefieldTB.cpp
#	src/server/game/DataStores/M2Stores.cpp
#	src/server/game/DungeonFinding/LFGMgr.cpp
#	src/server/game/DungeonFinding/LFGPlayerData.cpp
#	src/server/game/Entities/GameObject/GameObject.cpp
#	src/server/game/Entities/Item/Item.cpp
#	src/server/game/Entities/Object/Updates/UpdateFields.h
#	src/server/game/Entities/Player/Player.cpp
#	src/server/game/Entities/Player/RestMgr.cpp
#	src/server/game/Entities/Unit/Unit.cpp
#	src/server/game/Handlers/PetHandler.cpp
#	src/server/game/Server/Packets/GuildPackets.h
#	src/server/game/Spells/Auras/SpellAuraEffects.cpp
#	src/server/game/Spells/Auras/SpellAuras.cpp
#	src/server/game/Spells/Spell.cpp
#	src/server/game/Spells/SpellInfo.cpp
#	src/server/game/Spells/SpellMgr.cpp
#	src/server/scripts/Argus/AntorusTheBurningThrone/boss_garothi_worldbreaker.cpp
#	src/server/scripts/Kalimdor/HallsOfOrigination/instance_halls_of_origination.cpp
#	src/server/scripts/Northrend/IcecrownCitadel/instance_icecrown_citadel.cpp
#	src/server/scripts/Northrend/Ulduar/Ulduar/boss_mimiron.cpp
#	src/server/scripts/Northrend/zone_sholazar_basin.cpp
#	src/server/scripts/Outland/BlackTemple/instance_black_temple.cpp
#	src/server/scripts/Outland/GruulsLair/instance_gruuls_lair.cpp
#	src/server/scripts/Outland/HellfireCitadel/BloodFurnace/instance_blood_furnace.cpp
#	src/server/scripts/Outland/HellfireCitadel/ShatteredHalls/shattered_halls.cpp
#	src/tools/vmap4_extractor/gameobject_extract.cpp
#	src/tools/vmap4_extractor/model.cpp
#	src/tools/vmap4_extractor/vec3d.h

* Build system: Print found git version when warning about it being too old

(cherry picked from commit 1ae72db201)

* Build system: Removed hard requirement on BOOST_ROOT being set as environment variable, it can now be also passed as command line argument to cmake and fix compile warning with boost 1.73

(cherry picked from commit 161944b764)

# Conflicts:
#	dep/boost/CMakeLists.txt

* Remove some code that was already removed from 335 and then cherry-picked into master

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2020-05-31 14:17:26 +02:00
Keader
a72197911e Scripts/Ulduar: Codestyle fix
* Making jackpoz happy xD
2020-05-30 13:13:02 -03:00
Keader
05eeaade3e Scripts/Ulduar: Fixed XT002 Heart health regeneration 2020-05-30 11:47:43 -03:00
Gildor
6c1a874e57 Scripts/Trial Of The Crusader: Fixed Anub'arak Pursuing Spikes movement (#24715) 2020-05-30 08:50:33 -03:00
Gildor
3ab970aa47 Scripts/Ulduar: Fix Flame Leviathan movement (#24673) 2020-05-26 13:20:38 +02:00
Gildor
dd3fbf426c Scripts/Icecrown Citadel: Fix Sindragosa movement when Wipe in fly phase (#24665) 2020-05-24 20:38:24 +02:00
Keader
99c457c270 Scripts/ICC: Fixed duplicated call of reputation spell 2020-05-19 11:45:12 -03:00
Keader
d1e1b8753c Scripts/ICC: Fixed Deathbringer/Valithria reputation handler + codestyle fixes
* Added correct reputation spell for both bosses
* Fixed debuffs remove when deathbringer dies (it also fix recount)
* Changed all DoCast(me, xxx) -> DoCastSelf(xx)
* Removed old reputation hack in DB
* Fixed my OCD with spells enum :)
2020-05-19 11:42:11 -03:00
Shauren
1d43003cfa Scripts/Icecrown Citadel: Fixed Professor Putricide oozes not moving during their channel 2020-05-15 18:16:03 +02:00
Metalaka
e2434e4f47 Core/CreatureAI: Shambling Horror re-cast Enrage as soon as it is not stun (#24618) 2020-05-14 21:17:00 +02:00
NoName
22aaf32a79 Scripts/IcecrownCitadel: Adding IsAlive check to avoid possible crash in Event (#24514) 2020-04-29 21:14:27 +02:00
NoName
45993428f5 Core/Spells: Crystallize should not use DIMINISHING (#24502)
and also correcting spelling in script

by Rushor and wotlk-enthusiast
2020-04-26 21:40:57 +02:00
Gildor
6c7c2c6cd2 Scripts/Naxxramas: Fix Heigan Eruption spell (#24470) 2020-04-17 22:54:36 +02:00
Keader
77dd751499 Scripts/Ulduar: Little improvements in Auriaya
* Removed DespawnAtEvade
* Fix Feral Defender Damage
2020-04-15 11:28:46 -03:00
Keader
78dff46bf2 Scripts/Trial of Crusader: Fixed issue with Snobold Vassal and some achiev criteria resets
* Fixed snobold behavior when gormok dies
* Fixed UPPER_BACK_PAIN Archiev reset
* Fixed THREE_SIXTY_PAIN_SPIKE Archiev reset
2020-04-15 09:53:46 -03:00
Killyana
d0f9ace679 Creature: Gorkun Ironskull & Martin Victus in The Pit of Saron
Still some events are missing in this instance
2020-04-10 20:05:26 +02:00
Shauren
f57b1e27d0 Scripts/Eye of Eternity: Fixed The Focusing Iris not respawning on wipe
Closes #22948
2020-04-10 17:08:25 +02:00
jackpoz
caae3886d2 Core/Misc: Remove whitespace at the end of lines 2020-04-05 19:11:00 +02:00
Jozef Dúc
936ff574c5 Fixes #22884 (#24338)
Fix issue 22884 with non stacking necrotic plague debuff after dispell//death
2020-04-04 15:30:55 +02:00
Shauren
635b8d52d5 Core/DBLayer: Prevent committing transactions started on a different database
(cherry picked from commit f6e2b8cdc1)

# Conflicts:
#	src/server/bnetserver/REST/LoginRESTService.cpp
#	src/server/database/Database/DatabaseWorkerPool.cpp
#	src/server/database/Database/DatabaseWorkerPool.h
#	src/server/database/Database/Implementation/HotfixDatabase.h
#	src/server/database/Database/MySQLConnection.h
#	src/server/database/Database/Transaction.cpp
#	src/server/database/Database/Transaction.h
#	src/server/game/Achievements/AchievementMgr.cpp
#	src/server/game/Achievements/AchievementMgr.h
#	src/server/game/AuctionHouse/AuctionHouseMgr.cpp
#	src/server/game/AuctionHouse/AuctionHouseMgr.h
#	src/server/game/BattlePets/BattlePetMgr.cpp
#	src/server/game/BattlePets/BattlePetMgr.h
#	src/server/game/BlackMarket/BlackMarketMgr.cpp
#	src/server/game/BlackMarket/BlackMarketMgr.h
#	src/server/game/Entities/Creature/Creature.cpp
#	src/server/game/Entities/Item/Item.cpp
#	src/server/game/Entities/Item/Item.h
#	src/server/game/Entities/Player/CollectionMgr.cpp
#	src/server/game/Entities/Player/CollectionMgr.h
#	src/server/game/Entities/Player/Player.cpp
#	src/server/game/Entities/Player/Player.h
#	src/server/game/Garrison/Garrison.cpp
#	src/server/game/Garrison/Garrison.h
#	src/server/game/Groups/Group.cpp
#	src/server/game/Guilds/Guild.cpp
#	src/server/game/Guilds/Guild.h
#	src/server/game/Guilds/GuildFinderMgr.cpp
#	src/server/game/Handlers/BlackMarketHandler.cpp
#	src/server/game/Handlers/CalendarHandler.cpp
#	src/server/game/Handlers/CharacterHandler.cpp
#	src/server/game/Handlers/MailHandler.cpp
#	src/server/game/Handlers/PetHandler.cpp
#	src/server/game/Handlers/PetitionsHandler.cpp
#	src/server/game/Mails/Mail.cpp
#	src/server/game/Pools/PoolMgr.cpp
#	src/server/game/Quests/QuestObjectiveCriteriaMgr.cpp
#	src/server/game/Quests/QuestObjectiveCriteriaMgr.h
#	src/server/game/Scenarios/InstanceScenario.cpp
#	src/server/game/Server/WorldSession.cpp
#	src/server/game/Server/WorldSession.h
#	src/server/game/Spells/SpellHistory.cpp
#	src/server/game/Support/SupportMgr.cpp
#	src/server/game/Tools/PlayerDump.cpp
#	src/server/scripts/Commands/cs_misc.cpp
2020-03-31 13:42:01 +00:00
sirikfoll
7a4409b51f Creature/Script: npc_ruby_emerald_amber_drake
Closes #24220
2020-03-13 16:55:26 +01:00
Shauren
e10313b380 Core/Maps: Citizens of Dalaran! Raise your eyes to the skies and observe! Any non-map-default light can now be overriden!
Closes #24250
2020-03-06 17:44:10 +01:00
jackpoz
7a57029d8f Core/Movement: Add support to cyclic splines to GenericMovementGenerator
GenericMovementGenerator sets the _duration to the return value of spline.Launch(). For cyclic splines, this is the duration of 1 single cycle, while the spline itself never ends.
To support this edge case in GenericMovementGenerator we just never update the _duration timer for cyclic splines.
2020-02-23 22:07:40 +01:00
dr-j
92ac6ca0fe DB/Quest: Reconnaissance Flight
Closes #23792
2020-02-17 00:25:23 +01:00
Killyana
7450be4cfd DB/Text: Fix and remove some npc_text 2020-02-10 22:33:38 +01:00
Treeston
9304e496cb Core/Misc: Some refactoring, #23603 prep: (#23676)
- Split SpawnMetadata off from SpawnData
- No longer allocate Creature/Gameobject objects in ObjectGridLoader just to check their typeid and delete them afterwards

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-02-08 20:22:37 +01:00
Sorikoff
8c443ae39f Scripts/Borean Tundra: Iruk (#24117)
* Scripts/Borean Tundra: Iruk

* Apply suggestions from code review

Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

* Update 9999_99_99_99_world.sql

* Rename 9999_99_99_99_world.sql to 2020_02_01_01_world.sql

Co-authored-by: Trond B. Krokli <38162891+illfated@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-02-01 14:41:44 +01:00
Killyana
c86d4404c8 DB/Creature: Plagued Dragonflayer Tribesman & Plagued Dragonflayer Rune-Caster & Plagued Dragonflayer Handler
Closes #24122
2020-01-30 21:11:29 +01:00
Sorikoff
552a638e31 Scripts/Borean Tundra: Plug the Sinkholes (#24085)
* Scripts/Borean Tundra: Plug the Sinkholes

* Scripts/Borean Tundra: Improve SQL

* Scripts/Borean Tundra: Remove item script

* Rename 9999_99_99_99_world.sql to 2020_01_26_03_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-01-26 21:15:00 +01:00
Killyana
c1580108f6 DB/Quest: Convert Reports from the Field to SAI 2020-01-19 22:25:56 +01:00
NoName
50d9d9196d Core/Gameobject: Rename GO_STATE_ACTIVE_ALTERNATIVE to GO_STATE_DESTROYED (#24062)
* Step 1: Rename GO_STATE_ACTIVE_ALTERNATIVE to GO_STATE_DESTROYED

* Update src/server/shared/SharedDefines.h

Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

Co-authored-by: Trond B. Krokli <38162891+illfated@users.noreply.github.com>
2020-01-19 17:51:30 +01:00
Sorikoff
bfac09bbcf Scripts/Quests: Reports from the Field (#24075) 2020-01-19 16:45:05 +01:00
Sorikoff
07c0bfe11b Scripts/Violet Stand: Warmages (#24084)
* Scripts/Violet Stand: Warmages

* Rename 9999_99_99_99_world.sql to 2020_01_19_02_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-01-19 16:36:27 +01:00
Sorikoff
f20b147c71 Scripts/Transitus Shield: Warmages (#24082)
* Scripts/Transitus Shield: Warmage

* Scripts/Transitus Shield: SQL fix

* Scripts/Transitus Shield: improve SQL

* Rename 9999_99_99_99_world.sql to 2020_01_19_01_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-01-19 16:35:28 +01:00
jackpoz
c1df161e1d Scripts/Ulduar: Fix Ominous Clouds movements
Fix Ominous Clouds being only clockwise, now they move both clock and counter-clock wise.
Add a workaround for GenericMovementGenerator not handling correctly cyclic splines started by MoveCirclePath(), stopping the movement after a single round. The workaround code can be removed once the bug in GenericMovementGenerator is fixed.
2020-01-17 23:05:25 +01:00
Shauren
e660c8bc19 Scripts: Fix rbac permission for skipping default boss sequencing check 2020-01-14 23:53:08 +01:00
Giacomo Pozzoni
039534d1db Scripts/Ulduar: Attempt to fix Yogg-Saron not evading on wipe (#24055) 2020-01-14 19:57:16 +01:00
ccrs
330cbb55fb Scripts/ICC: include missing call from UnitAI::JustExitedCombat override in npc_green_dragon_combat_trigger 2020-01-12 00:14:45 +01:00
Shauren
c188d4db85 Scripts/Icecrown Citadel: Removed unneccessary combat hacks from Valithria Dreamwalker 2020-01-11 23:49:33 +01:00
jackpoz
33e4d4cd05 Scripts/Misc: Fix static analysis issues. 2020-01-11 22:56:08 +01:00
Killyana
a149261e94 Quest/Scripts: Remove some hacks from "Trolls Is Gone Crazy!" 2020-01-09 23:10:46 +01:00
Aokromes
ed93932537 New year
Say bye bye to every year changing dates
2020-01-02 06:25:50 +01:00
ccrs
7ffe018571 Scripts/ICC: little bit of cleanup in Valithria after the "recent" changes 2020-01-02 01:06:38 +01:00