Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-22 18:15:31 +01:00
Code Issues Packages Projects Releases Wiki Activity
36,634 Commits 4 Branches 146 Tags
6f45e88396b14435ee0bc7485de652e042d2513d
Commit Graph

26379 Commits

Author SHA1 Message Date
ccrs
6ae0a6ba22 Core/Movement: add missing parenthesis on MotionMaster::Size 
pretty sure this can cause unexpected behaviour

(cherry picked from commit bec52dba3d)
 2021-12-15 00:17:32 +01:00
Treeston
fc9908d163 warning fix f2cd721 follow-up 
(cherry picked from commit be96d8242c)
 2021-12-15 00:17:32 +01:00
Treeston
925aaecbc0 Core/Quest: Do not allow quests to be turned in if the player no longer satisfies level/skill/reputation requirements. Fixes #226. Yes, you read that issue tag right. 
(cherry picked from commit a1fd404b64)
 2021-12-15 00:17:32 +01:00
Treeston
9491650401 Scripts/Naxxramas: Thaddius no longer evades on transition, and some general cleanup to that script. Fixes #23026. 
(cherry picked from commit f2cd721d53)
 2021-12-15 00:17:32 +01:00
Ianislav Vasilev
fa9683fc68 Scripts/Blood Furnace: Broggok improvements (#23300) 
* 23285 Fixed lever respawn and future encounters after it respawns.

* Removed unnecessary additional container.
Made lever not to despawn and respawn but rather change flags only.

* Made one conditional branch easier to debug.

(cherry picked from commit c71e36acae)
 2021-12-15 00:17:32 +01:00
Treeston
fdb43e41a8 Scripts/Outland: Rewrite the Watch Commander Leonus event so it no longer starts exponentially more often if the grid remains loaded for over an hour. Closes #23348. 
(cherry picked from commit a3c3526269)
 2021-12-15 00:17:32 +01:00
Sorikoff
a947a0e85e Scripts/Spells: Brittle Armor & Mercurial Shield (#23576) 
(cherry picked from commit a64d7df662)
 2021-12-15 00:17:32 +01:00
ForesterDev
61cc88731c Scripts/Commands: update .wp commands to use orientation field from DB (PR #23566) 
Closes #23330

(cherry picked from commit e71773140c)
 2021-12-15 00:17:13 +01:00
Treeston
a5d8807af8 Entities/Player: Properly restore PvP-enabled state on login 
(cherry picked from commit 671052575a)
 2021-12-14 23:31:56 +01:00
Aokromes
3ad5bc1e15 Core/Misc: More coding standards (#23519) 
* Core/Misc: More coding standards

* revert part

* "void  " or more to "void "

* fix? reject

* remove more double whitespaces

* remove more double whitespaces

* more standards

* more coding standards

* More standards

* more coding

* more coding standards

* more coding standards

* And more standards

(cherry picked from commit 574a7c8d3d)
 2021-12-14 23:04:29 +01:00
Treeston
2532de6acb Entities/Unit: Nuke Map::ForceRespawn from orbit, with the following implications: 
- .npc respawn no longer causes stupid things to happen (Fixes #23014)
- ::DeleteFromDB methods on Creature and GameObject rewritten to be as sensible as such a colossally stupid method can ever be. They're static now.
- .npc delete and .gobj delete ported to new argument handling, and rewritten as per above. They can no longer crash the server when used in instances, too. Yay for that.
- Adjusted various dusty cobwebbed hacks around the core (why does waypoint visualization use permanent spawns *shudder*) to still work too.

(cherry picked from commit 84b7b2e08e)
 2021-12-14 22:42:22 +01:00
ccrs
8be3d33eae Build: fix linking error 
/home/circleci/project/src/server/game/Movement/MovementGenerators/RandomMovementGenerator.cpp:50:9: fatal error: use of undeclared identifier 'AddFlag'
        AddFlag(MOVEMENTGENERATOR_FLAG_TIMED_PAUSED);
        ^

(cherry picked from commit ec1a77bca2)
 2021-12-14 22:24:34 +01:00
Treeston
2225cb1201 Entities/Creature: Some asserts are now LOG_ERRORs that block spawning. Fix a group spawning bug exposed by the CoS merge. Improve some command output. 
(cherry picked from commit ded18a2690)
 2021-12-14 22:24:24 +01:00
ccrs
f21599dc5d Core/Movement: handle Resume/Pause on RandomMovementGenerator 
(cherry picked from commit b8c0aeaf14)
 2021-12-14 22:19:40 +01:00
ccrs
ff11e95071 Core/Unit: f869c49 followup 
Movement Pause/Clear is already handled in Unit::SetCharmedBy and Unit::RemoveCharmedBy, respectively

TODO: missing PAUSE handling in RandomMovementGenerator
(cherry picked from commit 4fa3c04b72)
 2021-12-14 22:19:13 +01:00
Wyrserth
24c07367f1 Core/Vehicle: prevent creature vehicles from following their old movement generator when a player enters them in some cases. 
Closes #21731 and #22368.

(cherry picked from commit f869c4969e)
 2021-12-14 22:19:01 +01:00
Wyrserth
004602f3e4 Core/Quest: fix icon in gossip window for repeatable, non-autocomplete quests. 
Closes #23572.

(cherry picked from commit 9f6d3e93f9)
 2021-12-14 22:17:47 +01:00
Shauren
d249a2a98a Warning fixes 2021-12-14 22:15:04 +01:00
Wyrserth
569660a933 Script/TheOculus: adapt Mage-Lord Urom's script to use EventMap, fix various issues with Teleport and Empowered Arcane Explosion, add missing heroic-mode spell Frost Buffet. 
Closes #19452.

(cherry picked from commit 37862942ce)
 2021-12-14 22:13:56 +01:00
Wyrserth
2efb6b6187 Core/Spell: don't send duration for auras caused by dynobjects. 
(cherry picked from commit 1d1b77c3f0)
 2021-12-14 22:03:20 +01:00
Wyrserth
756325bc84 Script/BlackrockDepths: randomize timers for Ironhand Guardian's spell Gout of Flame. 
(cherry picked from commit 6ef1b3e6c6)
 2021-12-14 22:02:52 +01:00
Wyrserth
55611104be Core/Spell: do not allow auras from dynamic objects to stack if they come from the same spell cast by the same caster. 
(cherry picked from commit b87350807d)
 2021-12-14 22:02:25 +01:00
Wyrserth
2c55730a01 Misc/Config: set decay timer for unlooted normal creatures to 5 minutes. 
Now that respawns do not care about the previous corpse's state, there's no reason to force a very frustrating faster despawn.

(cherry picked from commit 1bdbede7e0)
 2021-12-14 22:00:53 +01:00
Shauren
776298207a Core/Entities: Regenerate updatefields 2021-12-14 21:26:44 +01:00
Martin Topholm
dc0728b9a0 Script/BlackrockDepths: fix Ironhand Guardian's Gout of Flame spell cast. (#21816) 
(cherry picked from commit 4529a94e0d)
 2021-12-14 21:19:01 +01:00
Wyrserth
f31d8f7ffb Script/Acherus: script out of combat event for Frost Death Knight trainer Amal'thazad. 
(cherry picked from commit 8fcc82138f)
 2021-12-14 21:11:10 +01:00
Ovahlord
3fc20584bc Core/Creature: Reworked creature aggro radius calculation (#20615) 
* Core/Creatures: rewrote creature aggro radius calculation
* Formulas are taken from WoW Wiki

(cherry picked from commit 980047763a)
 2021-12-14 21:09:11 +01:00
Wyrserth
edf12fd6a1 Core/Conditions: allow spellclick conditions to properly work for aura apply/remove (#23527) 
(cherry picked from commit 12e545f7e2)
 2021-12-14 20:52:13 +01:00
ForesterDev
104ec7a81a Core/Unit: Implement more helper methods (#23555) 
(cherry picked from commit c44fb37f74)
 2021-12-14 20:42:32 +01:00
Shauren
dbb96e7717 Core/Spells: Fixed spells not doing damage after cherry-picking 83a9222c39 2021-12-14 16:13:41 +01:00
Giacomo Pozzoni
c5173aca15 Core/Quest: Fix repeatable quest mark (#23338) 
(cherry picked from commit 2cb4517303)
 2021-12-14 00:13:47 +01:00
Treeston
513b35ea2f Entities/Unit: Properly unset engaged flag for creates that cannot have a threat list on combat exit. Fixes #23518. 
(cherry picked from commit f44539b642)
 2021-12-14 00:07:37 +01:00
Gildor
e0f3255f90 Scripts/Icecrown Citadel: Ensure Deathbringer Saurfang cast Frenzy (#23559) 
(cherry picked from commit a0a64b10b5)
 2021-12-14 00:07:14 +01:00
Treeston
096269349c Entities/Player: Fix an edge case where overlapping CCs could prevent player movement from being re-enabled. f6f1c48 follow-up. 
(cherry picked from commit 4e767f1c7c)
 2021-12-14 00:06:51 +01:00
Treeston
bba4696de7 Entities/Player: Clean up client control handling behavior around possession. Mind Control should no longer cause various weirdness. Closes #23539. 
(cherry picked from commit f6f1c48aa5)
 2021-12-13 23:44:13 +01:00
Wyrserth
9cfa2ed71e Script/HallsOfLightning: fix mistake related to Shattering Stomp in Volkhan's script, introduced in 3bb0abcd52. 
Closes #23337.

(cherry picked from commit a8b8a43b8d)
 2021-12-13 00:42:20 +01:00
ForesterDev
27886c7f5d Core/Player: add helper methods GetNativeGender/SetNativeGender/SetGender (#23520) 
* Core/Player: add helper methods GetNativeGender/SetNativeGender/SetGender and fix some cases, where we should get player gender, instead of modified by display gender

* fix merge

* Add virtual methods for Unit class

(cherry picked from commit b47bb59e2a)
 2021-12-13 00:42:20 +01:00
ccrs
4e6c59dca7 Core/Unit: rename several getters to follow codestyle 
uint8 GetLevel()
        uint8 GetLevelForTarget(WorldObject const* /*target*/)
        void SetLevel(uint8 lvl)
        uint8 GetRace()
        uint32 GetRaceMask()
        uint8 GetClass()
        uint32 GetClassMask()
        uint8 GetGender()

(cherry picked from commit 5c09ff51f7)
 2021-12-13 00:42:20 +01:00
Sorikoff
b8d675eba7 Scripts/Spells: Dimensional Ripper - Everlook (#23547) 
(cherry picked from commit 5c09ff51f7)
 2021-12-13 00:42:20 +01:00
Wyrserth
819f8b1a2d Script/DarkmoonFaire: fix logical error in go_darkmoon_faire_music. 
Closes #23548.

(cherry picked from commit 028d16a812)
 2021-12-13 00:42:19 +01:00
Wyrserth
ecce30a807 Core/Quest: do not send SMSG_QUESTGIVER_OFFER_REWARD right after SMSG_QUESTGIVER_QUEST_FAILED. 
Allows the gossip window to close after the client receives a quest failed error (for example: not enough inventory space to store the reward).

(cherry picked from commit c8289ada7f)
 2021-12-13 00:42:19 +01:00
ccrs
2e4f38d949 Scripts/ICC: cleanup ReadSaveDataMore definition 
(cherry picked from commit 4c398743b9)
 2021-12-13 00:42:19 +01:00
ccrs
3bc4fc65b9 Scripts/ICC: 3dbf3fe followup 
repeat timer typo

(cherry picked from commit b19a23a5c6)
 2021-12-13 00:42:19 +01:00
Wyrserth
04b02f3672 Core/Spell: Challenge Flag should only hit one target. 
(cherry picked from commit 39aa91f982)
 2021-12-13 00:42:19 +01:00
ccrs
8be1927d31 Scripts/ICC: base support for Ymirjar Vrykuls AI 
(cherry picked from commit 3dbf3fed7c)
 2021-12-13 00:42:19 +01:00
ccrs
9d84b56df1 Scripts/ICC: 1eb2aef followup 
(cherry picked from commit 3e9b553618)
 2021-12-13 00:42:19 +01:00
Shauren
116285818b Core/Misc: Corrected file headers 2021-12-13 00:42:19 +01:00
ccrs
bb321ccb02 Scripts/ICC: move Sister Svalna to her own file 
I've almost guttered her, so lets try it more gently this time

(cherry picked from commit 1eb2aef179)
 2021-12-13 00:42:19 +01:00
ccrs
fce492d2e2 Core/Instance: 14788ce followup 
No need to repeat code

(cherry picked from commit b9a8095967)
 2021-12-13 00:42:19 +01:00
ccrs
5e3ba5e96f Scripts/ICC: 94b60ff followup 
(cherry picked from commit eb6ea57e7f)
 2021-12-13 00:42:19 +01:00