treeston
7310ce2bc0
Core/Combat: Fixed issues with creatures sometimes entering combat with friendly targets
...
Close #19980
2020-07-22 13:49:21 +02:00
treeston
618e604141
Two more refactors I missed for #19930 . Last ones for now, I promise.
2020-07-22 13:48:36 +02:00
treeston
f2592116ae
Some more refactoring prep for combat/threat ( #19930 ).
...
# Conflicts:
# src/server/game/Combat/ThreatManager.h
# src/server/scripts/Kalimdor/RuinsOfAhnQiraj/boss_moam.cpp
# src/server/scripts/Northrend/FrozenHalls/HallsOfReflection/halls_of_reflection.cpp
2020-07-22 13:48:18 +02:00
Shauren
6da0e00747
Nopch fix 5 and should be last
2020-07-22 13:46:32 +02:00
Shauren
73e7270673
typo fix
2020-07-22 13:46:28 +02:00
Shauren
cc1df2659e
Nopch fix 4
2020-07-22 13:46:24 +02:00
treeston
3645c382d9
nopch fix episode 3: revenge of that one boss in slabs that is borked anyway
2020-07-22 13:46:20 +02:00
Shauren
db5a6d2738
Nopch fix 2
2020-07-22 13:46:16 +02:00
Shauren
6ea79fd691
Nopch fix
2020-07-22 13:46:12 +02:00
Treeston
ec04d3b2cd
[3.3.5] Combat/Threat rewrite - prep & refactor ( #19966 )
...
* Combat/Threat rewrite (PR #19930 ) prep work. Mostly refactors, and a compatibility layer on ThreatManager/HostileReference that allows scripts to be changed already.
2020-07-22 13:43:23 +02:00
Ovahlord
f21877e00f
Core/GuildFinder: fixed a crash when trying to list a guild which was stored as listed but no longer exists
2020-07-22 10:26:27 +02:00
Ovahlord
9f116b86e9
Core/Movement: re-implement AbstractFollower as renamed version and index the pointers by following type (chase, follow, formation) for future access and improvements
2020-07-20 20:16:01 +02:00
Ovahlord
2c5b4a80d5
Core/World: fixed another gcc warning
2020-07-19 14:38:31 +02:00
Ovahlord
bd444eb6e1
Scripts/Items: fixed a warning reported by gcc
2020-07-19 14:36:37 +02:00
Ovahlord
e1d74d4dc6
Core/Misc: added more fallthrough attributes and added some missing breaks reported by CI
2020-07-19 12:24:58 +02:00
Giacomo Pozzoni
52d9bb2538
Core/Threads: Replace Boost TLS with C++11 one ( #15782 )
...
* Core/Threads: Replace Boost TLS with C++11 one
Replace boost::thread_specific_ptr<T> thread-local storage with C++11 thread_local to remove libboost_thread dependency from common project
* Fix no-pch build
2020-07-18 22:48:03 +02:00
Peter Keresztes Schmidt
cbd6fb2315
Build: Enable -Wimplicit-fallthrough on clang ( #25056 )
...
* Misc: Use [[fallthrough]] attribute instead of comment to mark intentional fallthroughs
Related: #25006
* Misc: Add some missing breaks (no-ops) to satisfy clang
Related: #25006
Closes #25055
* Build: Enable -Wimplicit-fallthrough on clang
Closes #25006
# Conflicts:
# src/server/game/Entities/Player/Player.cpp
# src/server/game/Spells/SpellInfo.cpp
# src/server/scripts/Battlefield/BattlefieldWG.cpp
# src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockSpire/instance_blackrock_spire.cpp
# src/server/scripts/EasternKingdoms/ScarletMonastery/boss_high_inquisitor_fairbanks.cpp
# src/server/scripts/Northrend/IcecrownCitadel/boss_rotface.cpp
# src/server/scripts/Northrend/Naxxramas/boss_thaddius.cpp
# src/server/shared/DataStores/DBCDatabaseLoader.cpp
2020-07-18 22:47:52 +02:00
Peter Keresztes Schmidt
a06e5d7d40
Misc: Use [[fallthrough]] attribute instead of comment to mark intentional fallthroughs
2020-07-18 22:43:24 +02:00
Giacomo Pozzoni
cbb0fe41de
Core/Misc: Replace boost::shared_mutex with std::shared_mutex ( #24328 )
...
* Core/Misc: Replace boost::shared_mutex with std::shared_mutex
* Remove std forward declarations
# Conflicts:
# src/server/game/Loot/LootItemStorage.h
2020-07-18 22:38:50 +02:00
Shauren
9d5848ec6e
Core/Maps: Use FindMap instead of CreateBaseMap in places where the intent was to check for a existing map (and a loaded grid on that map)
2020-07-18 12:07:02 +02:00
Ovahlord
405569dbff
Core/Spells:
...
* fixed Kill Command
* fixed Improved Kill Command crit chance bonus
* fixed Frenzy not triggering Focus Fire's visual effect correctly
closes #78
2020-07-17 16:21:37 +02:00
Ovahlord
fc4e2e4203
Core/Movement: followers will no longer get stuck behind obstacles
2020-07-17 13:10:58 +02:00
Ovahlord
40882b3f71
Core/Spells: define and implement SPELL_ATTR5_INCLUDE_MELEE_RANGE
...
*this attribute is being used to determine whenever a area targeting based spell shall include its melee range for target selection or not. This fixes many cases in which especially class abilities should hit targets that do not directly stand inside of the radius of a spell while maintaining that behaivior for spells without that attribute
2020-07-16 22:39:41 +02:00
Ovahlord
8fadb361eb
Fixed nopch build
2020-07-16 18:05:24 +02:00
Ovahlord
2a8fe49a73
Core/Packets: changed amount storage for aura update packets from vector to array to improve performance
2020-07-16 17:42:08 +02:00
Ovahlord
961144d82d
Core/Packets: converted SMSG_AURA_UPDATE and SMSG_AURA_UPDATE_ALL to packet class
2020-07-16 17:28:49 +02:00
Ovahlord
25006f9478
Fixed build
2020-07-16 15:37:38 +02:00
Ovahlord
d371c9d1f6
Core/Packets: converted MSG_MOVE_TELEPORT, MSG_MOVE_TELEPORT_ACK, CMSG_SET_ACTIVE_MOVER and SMSG_MOVE_UPDATE_TELEPORT to packet class and send SMSG_MOVE_UPDATE_TELEPORT for players after receiving MSG_MOVE_TELEPORT_ACK instead of sending it alongside MSG_MOVE_TELEPORT
2020-07-16 15:26:12 +02:00
Ovahlord
101f57c835
Core/Creatures: do not update animation tiers when updating movement flags
...
* Animation tiers are mostly involved in scripts so we do not handle them in generic movement updates
2020-07-15 18:50:56 +02:00
Warpten
d911a9bf74
Core/Players: implement Goblin's race entry discount bonus
2020-07-15 16:23:46 +02:00
Ovahlord
00a94593cd
Scripts/BWD: scripted Dwarven spirits
2020-07-15 16:03:45 +02:00
Ovahlord
322662ba69
Fixed nopch build
2020-07-15 00:45:51 +02:00
Ovahlord
d82c00c915
Core/Units: changed _formationFollowers from unit references to object guids to have a safer access to its stored units
2020-07-14 23:47:23 +02:00
Ovahlord
79dffad47f
Scripts/TotT: fixed a typo and build
2020-07-14 16:50:07 +02:00
Ovahlord
66069bcef1
Scripts/Misc: fixed instance teleporter for Throne of the Tides, The Stonecore and Blackrock Caverns
2020-07-14 16:42:30 +02:00
Ovahlord
f79a5a6938
Core/DBLayer: ported some field type corrections from 335
2020-07-14 13:58:01 +02:00
Ovahlord
71000befcc
Fixed clang warnings for real this time
2020-07-14 10:32:51 +02:00
Ovahlord
ff42bb7917
Fixed nopch build
2020-07-13 21:02:46 +02:00
Max Drosdo.www
cb4e7821e3
Core/Player: Introduce separate level caps for each expansion
2020-07-13 20:35:57 +02:00
Ovahlord
f8091d6aac
Core/Movement: made SetDisableGravity and SetHover virtual and handle anim tiers in their new override inside of the Creature class.
...
* no longer set anim tiers when the target is rooted
2020-07-13 14:07:59 +02:00
Ovahlord
86ef1745b5
Core/Spells: Phased Burn will now only hit a single target rather than every nearby player
2020-07-13 12:10:38 +02:00
Ovahlord
fac96b99b5
Scripts/TotFW: removed far visible and setActive calls as the new aoi types now handle this
2020-07-13 12:09:00 +02:00
Ovahlord
d46fb93657
Core/Pools: ported pooling updates from 335 branch
2020-07-13 11:17:19 +02:00
Ovahlord
404d8d6eaa
Scripts/BoT: scripted Twilight Phase Twister orbs
2020-07-12 18:04:20 +02:00
Ovahlord
a8d850ef00
Core/Spells: SPELL_EFFECT_KILL_CREDIT2 will follow the same target selection rules such as SPELL_EFFECT_KILL_CREDIT
2020-07-12 02:23:13 +02:00
Ovahlord
eedb17447a
Core/Spells: Combustion will no longer pick up other Combustion effects and the eligible aura effects will now have their amount devided
2020-07-11 20:35:40 +02:00
Ovahlord
791e42b2a7
Core/Spells: corrected Laser Strike's max radius entry
2020-07-11 19:26:30 +02:00
Ovahlord
2ad3201067
Core/Spells: fixed Improved Blood Presence benefits not having any effect
2020-07-11 14:06:38 +02:00
Ovahlord
1767197d8e
DB/BWD: scripted Golem Sentry trash npcs and increased the melee damage of heroic difficulty boss entries
2020-07-11 13:09:57 +02:00
Ovahlord
580e12e5a6
Scripts/BWD: scripted Drakonoid Chainwielder and Drakonoid Drudge trash npcs and scripted Magmaw's emote visual while chained
2020-07-10 22:20:48 +02:00