Commit Graph

19310 Commits

Author SHA1 Message Date
Shauren
9a1282aac6 Core/Spells: Fixed movement from SPELL_EFFECT_PULL_TOWARDS_DEST 2013-12-31 13:08:45 +01:00
jackpoz
64b42c75d2 Scripts/Misc: Code cleanup
Remove some NULL checks not needed anymore after 3744c14184 .
Fix an invalid Creature to TempSummon cast.
2013-12-30 23:36:49 +01:00
Subv
6ec7b03f9b Merge pull request #11386 from Nawuko/vincent-fix
Core: user defined literals need a space in front
2013-12-30 11:41:50 -08:00
Nawuko
6d21d33aac Core: user defined literals need a space in front 2013-12-30 20:35:37 +01:00
jackpoz
799daaae55 Core/Transports: Fix array overflow
Fix an array overflow in TransportMgr::GeneratePath() spline code.

Valgrind log:
 Invalid read of size 4
  at : G3D::Vector3::operator*(float) const (Vector3.h:650)
  by : Movement::C_Evaluate(G3D::Vector3 const*, float, G3D::Matrix4 const&, G3D::Vector3&) (Spline.cpp:103)
  by : Movement::SplineBase::SegLengthCatmullRom(int) const (Spline.cpp:171)
  by : Movement::SplineBase::SegLength(int) const (in /home/jackpoz/trinity/bin/worldserver)
  by : Movement::Spline<double>::initLengths() (SplineImpl.h:86)
  by : TransportMgr::GeneratePath(GameObjectTemplate const*, TransportTemplate*) (TransportMgr.cpp:125)
  by : TransportMgr::LoadTransportTemplates() (TransportMgr.cpp:78)
 Address 0x1d07d154  is 8 bytes after a block of size 300 alloc'd
2013-12-30 16:15:37 +01:00
yelvann
adf12d8a84 Core/Instances: Fix exploit too much players in instances/raids 2013-12-30 02:12:32 +01:00
jackpoz
5c64dade0f Scripts/Misc: Fix uninitialized values
Fix uninitialized values in scripts reported by valgrind.
Fix target and GetOwner() NULL dereferences .
2013-12-29 23:01:00 +01:00
jackpoz
c40cdc2968 Core/Chat: Fix assert triggered by .npc add
Fix an assert in Aura::_UnapplyForTarget() caused by ".npc add" changing the guid of the spawned Creature.
2013-12-29 19:37:20 +01:00
jackpoz
e016ef3dbd Merge branch 'master' of github.com:TrinityCore/TrinityCore 2013-12-29 16:27:25 +01:00
Malcrom
0e0b00cab6 Scripting/War Master Voone: Fix Cleave spell and minor cleanup. 2013-12-29 11:41:46 -03:30
jackpoz
90c63e4818 Scripts/Misc: Fix uninitialized values
Fix uninitialized values in scripts reported by valgrind.
2013-12-29 16:05:31 +01:00
Shauren
079905e29a Core/Transports
* Fixed transport orientation
* Fixed transport position desynchronization for stoppable transports
* Ignore spawnMask errors for objects spawned on transports
2013-12-29 14:59:06 +01:00
Malcrom
9af36d887b Merge branch 'master' of https://github.com/TrinityCore/TrinityCore 2013-12-28 20:52:49 -03:30
Malcrom
4c66a3f79d Scripting/Boss Jandice Barov: Fix wrong spell id. 2013-12-28 20:51:21 -03:30
jackpoz
3744c14184 Scripts/Misc: Ensure Creatures are in instances when required
Create ScriptedAIs that require a InstanceScript reference only if the InstanceScript exists, so if these Creatures are in an instance. ScriptedAIs that don't require a InstanceScript reference have not been modified.
This fixes many possible NULL dereference crashes happening when spawning a scripted Creature outside of an instance.
Fixed a GetOwner() and a ToPlayer() NULL dereference crashes too.
2013-12-29 01:19:52 +01:00
jackpoz
2a7f03039d Core/Misc: Fix warnings
Fix warnings appearing with -Wstrict-aliasing flag.
2013-12-28 17:24:43 +01:00
Shauren
533180f2a1 Core/Battlegrounds: Removed unneeded code 2013-12-28 13:02:05 +01:00
Shauren
29acf99ea6 Core/Transports: Fixed new spawned transports not being visible for players already present on map 2013-12-28 12:44:22 +01:00
MitchesD
3921f20c18 Scripts/ObsidianSanctum: added creature_formations for surrounding creatures and some clean up 2013-12-27 19:56:01 +01:00
jackpoz
e255d1d376 Core/Transports: Fix possible crash
Fix a crash happening when deleting an instance with transports. This case doesn't appear in current sources but could have happened in ICC and HoR.
2013-12-25 23:11:22 +01:00
jackpoz
9b88a789e6 Scripts/Blood Furnace: Fix crash in Broggok script
Fix a NULL dereference exception in Broggok npc id 17380 script, happening when spawning it outside of an instance.
Fixes #11344
2013-12-25 19:17:44 +01:00
Malcrom
01a43e6a30 Core/QuestDef: Well I clicked revert but Git didn't play along. 2013-12-25 14:31:28 -03:30
Malcrom
fe95371d9a Core/Scripting: Replace casted with cast as casted is not a word. 2013-12-25 14:16:55 -03:30
Malcrom
fa29ddc529 Db/Misc: Fix more dup aura messages. 2013-12-25 12:39:47 -03:30
Shauren
890b47c861 Build fix 2013-12-25 12:37:00 +01:00
Shauren
8bcde41538 Core/Quests: Added stuff missing in previous commit 2013-12-25 12:17:23 +01:00
Shauren
293915db39 Core/Quests: Fixed icon shown above questgivers with daily quests that have already been completed once by a character
Closes #11331
2013-12-25 02:08:05 +01:00
Malcrom
b8e626199c Scripting/Multi: Some cleanup. 2013-12-24 17:56:38 -03:30
Shauren
20a2b69178 Core/Chat: Fixed GM messages in chat channels after refactoring 2013-12-24 20:21:13 +01:00
Malcrom
54dbf870b8 Scripting: Some cleanup. Please keep broken English comments to yourself. 2013-12-24 14:45:45 -03:30
Malcrom
dbce8d93f3 Scripting/Hinterlands: Convert to TC style. 2013-12-24 13:40:27 -03:30
Malcrom
9d2d4ba921 Scripting/Hellfire: Moved some gossip to db and fix some magic numbers. 2013-12-24 12:15:41 -03:30
Malcrom
eacc165a12 Scripting/Ghostlands: Moved some gossip to db and fixed some magic numbers. 2013-12-24 08:39:35 -03:30
Shauren
5e8f829181 Core/SAI: Fixed a crash in call for help/flee for assist actions when they had an emote attached 2013-12-24 11:26:07 +01:00
Malcrom
8f4011cf6e Scripting/Zones: Some cleanup. 2013-12-24 00:56:15 -03:30
joschiwald
fd6167cf66 Scripts:
- cleanup obsidian sanctum script
- prevent yelling texts if non player died in some scripts
2013-12-23 23:55:15 +01:00
Malcrom
6858a234b3 Scripting/Borean Tundra: Fix some magic numbers. 2013-12-23 19:13:29 -03:30
Malcrom
7ef49db25d Scripting/Bloodmyst Isle: Moved Captured Sunhawk Agent gossip to db. 2013-12-23 16:20:04 -03:30
Malcrom
464632b0bc Scripting/Blasted Lands: Shouldn't have removed ScriptedGossip.h 2013-12-23 13:48:49 -03:30
Malcrom
59ac2437d8 Scripting/Blasted Lands: Fixed up gossip and teleport spell for quest 3628.
Can someone please test this. I can't do group testing locally.
Also snuck in a fix for zone_axshara.cpp
2013-12-23 13:36:36 -03:30
Malcrom
ab3eced989 Scripting/Misc: Some cleanup. 2013-12-23 12:12:31 -03:30
Malcrom
59eca906ef Scripting/Blades Edge: Moved gossip to db for Overseer Nuaar and Sai'kkal the Elder. 2013-12-23 11:19:21 -03:30
Shauren
a316b86a79 Core/Spells: Prevent adding sockets to items that have 3 sockets in item_template or already had a socket added to them 2013-12-23 14:25:34 +01:00
Shauren
107af52853 Core/Chat: Refactored building chat packets
* Moved everything into one specialized method instead of being scattered all over the place
* Allow localizing creature names in chat messages (when using $N)
* Send SMSG_GM_MESSAGECHAT for gm messages
2013-12-23 14:23:49 +01:00
Malcrom
6402fa02ac Scripting/Storm Peaks: A little work on Quest 13010 Krolmir, Hammer of Storms 2013-12-23 01:31:30 -03:30
Malcrom
d741335a02 DB/Creature_text: Updated more text from sniff. 2013-12-22 20:18:07 -03:30
Malcrom
8aef1748bf DB/Creature text: Added some missing text from sniff. 2013-12-22 18:38:46 -03:30
Malcrom
5055a8fde4 Scripting/Bloodmaul Brute: CombatAI moved to cpp for quest 10512. 2013-12-22 14:41:37 -03:30
Malcrom
34ce605a2c Scripting/DB: Fixed some npcs so they wouldn't have AIName & scriptname. 2013-12-22 11:43:10 -03:30
jackpoz
b0ffbb2179 Core/Auth: Fix expiring account bans
Fix a database race condition in authserver that would delay the account ban expiry by 1 login because the query that would have removed the ban was executed asynchronously.
2013-12-22 14:00:14 +01:00