Commit Graph

10641 Commits

Author SHA1 Message Date
Spp
89a33bbf61 Core/Dungeon Finder: Fix a crash in Join when there are no dungeons available for that group (And probably other random crashes that appear when having DF enabled)
Core/Dungeon Finder: Tab2spaces + remove trailing spaces in LFG* files.

Notes to self:
- assign NULL to a pointer parameter will not change the pointer value outside the scope of the function
- deleting a const_iterator can lead to mem corruption

--HG--
branch : trunk
2010-12-13 21:31:55 +01:00
Spp
865f35a637 Core/Dungeon Finder: Minor optimization in handler code
Note: LfgDungeonSet and LfgLockStatusMap were being used without using the existing typedef (to avoid including LFGMgr.h).
Now those functions use a struct as param that is forward declared so still LFGMgr.h is not needed and redefinition of LfgDungeonSet/LfgLockStatusMap is removed.

--HG--
branch : trunk
2010-12-13 21:28:36 +01:00
Spp
9815847511 Core/Dungeon Finder: Return a copy of cached dungeons set (to avoid being cleared later in code)
--HG--
branch : trunk
2010-12-13 21:28:33 +01:00
click
620cde80cd Core: Fix non-PCH build
--HG--
branch : trunk
2010-12-13 17:44:20 +01:00
Machiavelli
d5f5fa59ab Add missing declarations as of recent merge
--HG--
branch : trunk
2010-12-13 17:34:27 +01:00
Machiavelli
451159cac4 Fix possible compile error under linux
--HG--
branch : trunk
2010-12-13 17:21:06 +01:00
Machiavelli
bd77fb6d47 Fix a typo, thanks to sss.nevan
--HG--
branch : trunk
2010-12-13 17:05:01 +01:00
Machiavelli
d75eaf8e83 Core/Guild: More signed/unsigned comparison fixes. Should fix guild log loading.
--HG--
branch : trunk
2010-12-13 16:58:59 +01:00
Machiavelli
1a4fe4baca Core/Guilds: Fix logic in bank withdrawal method (unsigned comparison with signed value). Should fix certain guild bank related bugs.
--HG--
branch : trunk
2010-12-13 16:42:09 +01:00
Machiavelli
976225a9dd Core/DBLayer: Implement global ExecuteOrAppend methods to DatabaseWorkerPool for executing queries in a diverse context (transaction or non transaction) - instead of local to Guild.cpp
--HG--
branch : trunk
2010-12-13 16:27:14 +01:00
Machiavelli
426b28e344 Fix wrong vsprintf parameter added in merge.
--HG--
branch : trunk
2010-12-13 16:18:07 +01:00
Machiavelli
f1a73e89b8 Merge
--HG--
branch : trunk
2010-12-13 16:13:32 +01:00
Machiavelli
ea29d87dcc Backed out changeset: 8326a2411148
--HG--
branch : trunk
2010-12-13 09:18:49 +01:00
Shauren
dd2602d3ec Fixed line endings in 10623_world_spell_bonus_data
Scripts/Naxxramas: Fixed a possible crash in instance script

--HG--
branch : trunk
2010-12-12 17:32:26 +01:00
Shocker
4b0ffeb0bd Core/ChatHandler: Cleanup in HandleMessagechatOpcode. Now commands are parsed and security checks are made in all channels
--HG--
branch : trunk
2010-12-11 17:47:43 +02:00
azazel
d2d62eab50 Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
NOTE: Initially I just wanted to fix some warnings, but noticed that there is no common method for percentage calculation and various formulas are used many time in the code making it difficult to read and understand what the code actually does. So, I introduced several template methods for calculating percent values and adding those values to the original base. I replaced all the raw calculations throughout the code where found, but I could have missed something or could have made a mistake. So, please report any strange behaviour after this commit.
If you ask me why I did it: for the sake of consistency and exact understanding what code means. If you see CalculatePct method, you clearly understand, that it find the value of x percent of y. And you can easily express, for example, spell behviour "reduces smth by x%" by the means of a method instead of recalling school maths.

--HG--
branch : trunk
2010-12-11 20:37:38 +06:00
click
81db111ffd Core/Spells: Fix mage talent Frost Warding (and a little cleanup on CalcAbsorbResist) - patch by DrTenma
Fixes issue 2715.
Closes issue 3770.

--HG--
branch : trunk
2010-12-11 12:00:57 +01:00
click
0e33e73d39 Core/ChatHandler: Allow GM/server-commands to be executed through whisper-channels - patch by Ramus
Closes issue 5006.

--HG--
branch : trunk
2010-12-11 03:25:31 +01:00
Spp
a791df6415 Core/Dungeon Finder: Fix crash in Join
(trying to delete a const iterator)

Closes issue 5083

--HG--
branch : trunk
2010-12-10 14:58:45 +01:00
Machiavelli
4f468f9552 Core/RA: Calculate password hash internally instead of sending plaintext password to mysql.
Convert tabs to spaces.

--HG--
branch : trunk
2010-12-10 09:02:59 +01:00
azazel
e3c68e4ada Misc: fix CR/LF (my bad, sorry)
--HG--
branch : trunk
2010-12-10 12:06:28 +06:00
azazel
08f205722a Scripts/Quest: implement dummy effects for spells 43882, 50133 and aura 43874 for quests 11396/11399 Bring Down Those Shields (based on code by NoFantasy)
--HG--
branch : trunk
2010-12-10 12:01:57 +06:00
click
7e0dee8cb1 Fix build
--HG--
branch : trunk
2010-12-10 01:44:34 +01:00
click
456f29c089 Core/Worldserver: Remove external dependency to sockets-library after RemoteAccess being converted to ACE, and fix one minor hiccup on non-PCH builds
--HG--
branch : trunk
2010-12-10 00:33:55 +01:00
Derex
ef768a8307 Rewrite remote access console using ACE
--HG--
branch : trunk
2010-12-10 01:01:44 +02:00
Rat
b5e24cbb9c Core/SmartAI: ACTION_CALL_CASTEDCREATUREORGO can now be used with GameObjects too
--HG--
branch : trunk
2010-12-09 22:21:11 +01:00
leak
855b8bcd20 Core/Spells: Prevent Mind Sear from damaging the target itself. Patch by PrinceCreed.
Fixes issue 2534

--HG--
branch : trunk
2010-12-09 21:45:04 +01:00
Spp
be73926ab3 Core/Dungeon Finder: Fix incorrect Lfg state after multiple actions.
- Clear state after get out DF system
- Fix player not getting reward after finish a random dungeon
- Remove OnDisband Hook, it's already handled by OnRemoveMember

--HG--
branch : trunk
2010-12-09 19:13:11 +01:00
Spp
4914ca575b Core/Dungeon Finder: Fix a crash in Join
After a random dungeon is expanded to the corresponding dungeons and checked compatible dungeons of players joining. We have no dungeons and no lockmap.

This may only happen when a random dungeon is expanded to no dungeon. And this may be impossible to happen

Closes issue 5066

--HG--
branch : trunk
2010-12-09 14:25:48 +01:00
Spp
4537ba2766 Core/Dungeon Finder: Fix a possible crash in rolechecks when not success
--HG--
branch : trunk
2010-12-09 13:49:04 +01:00
azazel
e7eb4e22e2 Core/Mechanics: cleanup shapeshift form code (by VladimirMangos)
--HG--
branch : trunk
2010-12-09 17:03:42 +06:00
azazel
8c2ce7f86d Core/Auras: fix AuraType 138 to not affect ranged haste, and rename to SPELL_AURA_MOD_MELEE_HASTE (by michalpolko)
--HG--
branch : trunk
2010-12-09 14:40:59 +06:00
Spp
b434273ed8 Core/Dungeon Finder: Some optimizations
- Reduce core dependencies with LFGMgr
- Remove reduntant calculations in RoleCheck code
- Remove no longer needed functions
- Fix some packet data (Missing 0 when arrays were null)
- Add some debug msgs

closes issue 5042

--HG--
branch : trunk
2010-12-08 21:29:43 +01:00
Shauren
e4e048ed57 Core/Scripts: Fixed possible crashes in instance scripts (Icecrown Citadel and Naxxramas)
Scripts/Sunwell Plateau: Fixed crash in Kil'jaeden
Scripts/Icecrown Citadel: Fixed crash in Blood-Queen Lana'thel

Closes issue #5051.
Closes issue #5050.
Closes issue #5035.

--HG--
branch : trunk
2010-12-08 17:24:31 +01:00
Shauren
611dc153b0 Core/Units: Corrected PLAYER_FIELD_BYTES2 invisibility/stealth flags, by VladimirMangos
--HG--
branch : trunk
2010-12-08 14:51:50 +01:00
Rat
cebf8590e3 Core/SmartAI: some error checks for actionlists, and enabled lists for GOs
--HG--
branch : trunk
2010-12-07 20:25:45 +01:00
Rat
bb09a4a50f Core/SmartAI: all actions regarding to TIMED_ACTIONLIST will now use targeting:
you can now 'send' a list of timed actions to any targeted creature if it has SmartAI

NOTE: already made script with timed actions should be remade to use self as target

--HG--
branch : trunk
2010-12-07 18:31:34 +01:00
Shauren
703835ee94 Core/Quests: Fixed Unholy Infusion (24749), Blood Infusion (24756) and added partial support for Frost Infusion (24757)
--HG--
branch : trunk
2010-12-06 22:54:19 +01:00
leak
20cc4ace5d Core/OutdoorPvP: Fixed a crash that occured on accessing CapturePoints after GO removal
--HG--
branch : trunk
2010-12-06 20:55:26 +01:00
Machiavelli
3ae225247a Core/Groups: Remove unused (and costly) return value from Group::RemoveInvite
--HG--
branch : trunk
2010-12-06 20:25:43 +01:00
Machiavelli
cac0664150 Fix linux compile.
Closes issue #5044

--HG--
branch : trunk
2010-12-06 20:06:31 +01:00
Machiavelli
f35c85acbe Core/DBLayer: Optimization in transaction code, and prevent a crash and memleak on shutdown.
--HG--
branch : trunk
2010-12-06 19:52:37 +01:00
Machiavelli
988a6f5c93 Core/DBLayer: Simplify template usage for DatabaseWorker
--HG--
branch : trunk
2010-12-06 19:28:05 +01:00
Spp
fbf525218b Core/Dungeon Finder: revert r14440b0b82 and fix it properly.
That msg was just for debugging purposed and its not needed anymore

--HG--
branch : trunk
2010-12-06 17:23:52 +01:00
Spp
2581c2f70f Core/Dungeon Finder: Fix console spam msg in Leave
--HG--
branch : trunk
2010-12-06 16:48:23 +01:00
Spp
7ef59e3872 Core/SmartScripts: Fix a typo in action 'set instance data (64)'
--HG--
branch : trunk
2010-12-06 06:38:50 +01:00
QAston
bb2a715afc Core/Scripts: Comment out code sanitizing hook type - will be fixed soon.
--HG--
branch : trunk
2010-12-06 07:16:39 +01:00
leak
59d12e3b4a Core/Entities: Fixed a crash by accessing the GameObjectAI of a GameObject before the next Update cycle. Patch by Rat. Thanks to Visagalis for testing.
Fixes issue 4863

--HG--
branch : trunk
2010-12-06 04:52:33 +01:00
leak
72d8b18c5c SQL error corrections.
Fixes issue 5021

--HG--
branch : trunk
2010-12-06 04:32:20 +01:00
Spp
090fb3572f Core: Fix non-PCH build
--HG--
branch : trunk
2010-12-06 02:35:28 +01:00