Commit Graph

18262 Commits

Author SHA1 Message Date
Machiavelli
8befbdcc56 Core/LFG: Fix a crash
Fix a crash in case a player is recognized as in a LFG dungeon, but without a valid group
2013-02-14 15:01:33 +01:00
Machiavelli
203cf7cbf0 Core/RA: Addition to previous crashfix
To make sure it also works for sessions that use more than 1 command
before closing.
2013-02-14 13:30:51 +01:00
Machiavelli
b4be224004 Core/RA: Fix a possible crash
Caused when RASocket::handle_close (event-driven) would delete the underlying object before RASocket::commandFinished callback was executed for that object. Dereferencing freed pointers is bad.
2013-02-14 11:57:43 +01:00
Shauren
944d7290ad Core/Loot: Minor change to previous commit, thanks Vincent_Michael for reminding me about this method in Map class 2013-02-14 11:41:20 +01:00
Shauren
ca280dbe05 Core/Loot: Only 3 items of the same entry can drop on 25 man raid difficulties and 1 everywhere else (non-raid or 10 man) 2013-02-13 20:24:23 +01:00
Shauren
d926ad63c0 Core/Spells: Fixed charge effects with non-explicit targets 2013-02-13 20:21:26 +01:00
Shauren
20cd6cfc61 Scripts/Icecrown Citadel: Fixed possible crash for Necrotic Plague (if cast outside of ICC)
Closes #9188
2013-02-12 12:39:48 +01:00
Shauren
1ff184dbab Buildsystem: Do not print warning that user needs to do a git pull with tags if configured to not use git at all 2013-02-12 12:21:24 +01:00
click
dfa56a33e0 Buildsystem/CMake: Correct a few mistakes regarding WITHOUT_GIT, and add a better warning during configure-phase. 2013-02-11 23:27:20 +01:00
click
3178fc4d96 Buildsystem/CMake: Forgot to change variable in main CMakeLists.txt 2013-02-11 20:11:15 +01:00
click
9bd8baf1ab Buildsystem/CMake: Fix an issue with MSVC not finding git-binary when updating the revisionhash/revisiondate + rename DISABLEGITCHECK parameter to WITHOUT_GIT (to adhere to our standard)
Also cleaned up the checks slightly + moved git-specific testing to its own macro (minor changes to shaurens original patch applied)
2013-02-11 20:04:27 +01:00
click
620a43b4ef Buildsystem/CMake: Allow building the core without the gitchecks, this is done in the GUI, or through the DISABLEGITCHECK parameter on *nix-platforms.
DO NOTE THAT WE WILL NOT GIVE SUPPORT ON ANY CORE-VERSION COMPILED WITH THIS FLAG, AS WE CAN NOT EFFECTIVELY FIND OUT WHAT REVISION YOU ARE ON
2013-02-11 14:51:26 +01:00
Nay
db0b81e8e7 Core/RealmSocket: Remove a not required #ifndef MSG_NOSIGNAL / #define MSG_NOSIGNAL 0
Somewhere in ACE overloads of send(), flags are default'ed  to 0 if not provided
2013-02-11 03:33:02 +00:00
Nay
12359b993d DB/NPCs: Set trigger flags_extra to a bunch of quest credit markers
God damn Aokromes, always making me do work and stuff...
2013-02-11 03:10:02 +00:00
Nay
42e660e2a2 Core/Sockets: Always try to send MSG_NOSIGNAL in peer().send()
Fixes RASocket::authenticate crash

"MSG_NOSIGNAL:
If you send() to a remote host which is no longer recv()ing, you'll typically get the signal SIGPIPE. Adding this flag prevents that signal from being raised."

Closes #5040
Thanks to @derex for the hint
2013-02-11 02:59:37 +00:00
click
2cf8cdaa80 Buildsystem/CMake: Drop a FATAL_ERROR-message if the git binary is not found or outdated.
Allow for it to be pointed to through the ADVANCED settings in the CMake GUI if the above is true.
2013-02-11 01:56:25 +01:00
Kinzcool
1b4a610976 DB/Triggers: Added anti-exploration in Hellfire Ramparts 2013-02-10 13:05:53 -05:00
Vincent_Michael
92573c4fb5 DB/Factionchange: Add a missing spell (Teleport: Darnassus / Teleport: Thunder Bluff) at player_factionchange_spells 2013-02-10 04:53:48 +01:00
Kinzcool
8e58779d91 DB/Triggers: Fixed access to Duskwither Spire 2013-02-09 19:36:29 -05:00
Vincent_Michael
caf70ee40d DB/Creature: Fix Onyxian Lair Guard equipment 2013-02-10 00:00:53 +01:00
Shauren
38eb090e9a Core/Objects: Rewritten UpdateMask class to perform bit operations faster at the cost of higher memory use and moved building the mask for packet to a separate method.
Closes #9127
2013-02-09 23:59:09 +01:00
zwerg
e5e970baec Core/Spells: Fix cooldown problems for Val'anyr, Hammer of Ancient Kings
Closes #9162
2013-02-09 23:19:18 +01:00
Shauren
985de41421 Core/SAI: Rewrite SmartAI::RemoveAuras in a safer way 2013-02-09 17:57:27 +01:00
Gacko
a7eef6a598 Script/Quest: Kodo Roundup
Closes #943
2013-02-09 16:24:31 +01:00
Nay
e33f70c002 DB/Quests: Fix quest The Collapse and Deploy the Shake-n-Quake
Ref #1005
Ref #2034
Ref ae30704847
Closes #3595
2013-02-09 15:13:49 +00:00
Nay
f902362ad1 Core/DBLayer: Avoid a crash when calling mysql_get_server_version if connection was not open 2013-02-08 23:06:25 +00:00
Kinzcool
8066e43dd8 DB/Triggers: Added areatriggers in Shadowfang - when you'll try to jump out of the dungeon walls, you will be teleported 2013-02-08 17:51:55 -05:00
Nay
c4d285828a Merge pull request #9166 from thomas33/typo
Core/Scripts: Coding style
2013-02-08 10:07:05 -08:00
Shauren
97e876209e Core/Players: Fixed crash when mute expired while player was ingame 2013-02-08 18:18:26 +01:00
Shauren
d6c0afa71c Core/AI: Fixed merge error 2013-02-08 14:15:24 +01:00
Shauren
b6e56e42ea Core/Auth: Reverted part of fb43a92cc2 - session key is still needed after logging in to be able to switch realms 2013-02-08 01:03:56 +01:00
Shauren
fb43a92cc2 Core/Accounts: sessionkey field in account table is only a temporary storage to pass data from authserver to worldserver and should only be used as such. Clearing sessionkey from database after a successful login to prevent possible exploits. 2013-02-07 16:15:23 +01:00
thomas33
82c31e50bb typo 2013-02-07 16:10:10 +01:00
Vincent_Michael
5b45a87da5 Core: More clean up whitespace 2013-02-07 00:24:00 +01:00
click
75994b3dd3 Core: Clean up whitespace, and remove a silly warning in boss_lurker_below.cpp 2013-02-07 00:19:19 +01:00
Shauren
fdffb3ebd0 Core: Fixed some compile warnings 2013-02-06 22:18:41 +01:00
w1sht0l1v3
f27a83e98f Fix up previous commit. 2013-02-06 18:39:09 +02:00
w1sht0l1v3
d42dac4cee DB/Misc: Fixup quest Hot On The Trail (A:24849 H:24851) 2013-02-06 18:32:28 +02:00
Nay
0b3170c228 Core/Player: Fix a query that was wrongly deleting items
CHAR_DEL_ITEM_INSTANCE deletes by item guid but in Player::DeleteFromDB the guid being used was player's guid.
That means that if player with guid 100 was deleted, the item with guid 100 would also be deleted. This item could or could not belong to the player.

Closes #8883
Closes #9136

Thanks to @vlad852 for finding the issue
2013-02-06 13:17:21 +00:00
Gacko
32546a64c9 Add comment to f205613eb5 2013-02-06 09:08:56 +01:00
Kinzcool
2fa8d06b25 DB/Items: Added Heart-Shaped Box, missing for Love in the Air event
Closes: #9130
2013-02-05 22:30:34 -05:00
click
00d299f12f Core/SQL: Explicitly set the auth.account-table to use the INNODB-engine (to allow foreign keys and transactions)
If you have an OLD database (auth), and RBAC SQL-alterations, make SURE that it's InnoDB, otherwise run this (it can be run multiple times anyway)
(The only change added is to alter the table to explicitly be an InnoDB-table)
2013-02-05 22:20:55 +01:00
Gacko
f205613eb5 DB/Disable: Ignore LOS for Krakles Thermometer
Closes #5560
2013-02-05 19:40:20 +01:00
Gacko
745eb9732e Core/Spell: Consider disables for LOS check 2013-02-05 19:39:51 +01:00
click
ede65fb60c Core/Remote: Adjust logentries to accomodate separation of info- vs debug-output, using Info-level as default unless it's REAL debugoutput 2013-02-05 15:45:18 +01:00
Spp
dd0658e675 Warning fix 2013-02-05 11:12:00 +01:00
Spp
fedc26a115 Typo fix 2013-02-05 09:26:52 +01:00
Spp
f210ab0d47 Core/RBAC: Allow custom security levels for commands. (Before this change any command with seclevel > 3 had the same permissions than player commands)
Note: This is still a workaround till command system is moved to RBAC
2013-02-05 09:11:56 +01:00
Kinzcool
630ad4b0b5 DB/Creature: Updated Unseen template 2013-02-04 20:03:04 -05:00
m7nu3l
f9654d52e0 Core/AI: Removed Scripted_NoMovementAI which has become obsolete. Use ScriptedAI::SetCombatMovement(false); to get the same functionality. 2013-02-04 19:18:48 -03:00