Commit Graph

5023 Commits

Author SHA1 Message Date
Ianislav Vasilev
908fbf48d2 Scripts/Blackrock Depths: High Priestess of Thaurissan (#23230)
* Initial fix suggestion for 22660.

* Removed todo related to the work done in this branch.

* Removing obsolete braces and added failfast check.

* Refactored the logic about having the quest.

* Removing obsolete braces.

* Adding reference to incomplete type.

* Switching from forward declaration to header where type is defined.

* Including Player type definition in order to work with nopch.

* Update src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockDepths/instance_blackrock_depths.cpp

Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

* Update src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockDepths/instance_blackrock_depths.cpp

Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

* Reverted mistakenly deleted todo
2019-05-17 14:50:27 +02:00
Wyrserth
4d04344b41 Core/Spell: add proper cooldowns to some spells used by vehicles (#23260)
* Core/Spell: add proper cooldowns to some spells used by vehicles, thanks to jackpoz and sirikfoll.

* Add Wing Buffet and Stampy's Stompy-Stomp.

* Add Tag Greater Felfire Diemetradon and Touch of Darkness.

* Rename 9999_99_99_99_world.sql to 2019_05_17_00_world.sql
2019-05-17 12:08:20 +02:00
Killyana
9435caa8d1 Instance/Script: Blood Furnace
Ref #23285
2019-05-16 19:31:54 +02:00
ccrs
7025b00656 Scripts/Northrend: couple cosmetic corrections after 552720a 2019-05-14 22:07:23 +02:00
Wyreth
552720a993 Scripts/Northrend: improvements for quest Get Me Outa Here! (11673) (#20753)
* Script/Quest: improvements for quest Get Me Outa Here! (11673).

* Happiness for our Travis overlord

* Update 9999_99_99_99_world_quest_get_me_outa_here.sql

* Update zone_borean_tundra.cpp

* Update 9999_99_99_99_world_quest_get_me_outa_here.sql

* Update 9999_99_99_99_world_quest_get_me_outa_here.sql

* Fix hook that got renamed

* Update 9999_99_99_99_world_quest_get_me_outa_here.sql

* Rename 9999_99_99_99_world_quest_get_me_outa_here.sql to 2019_05_11_08_world.sql
2019-05-11 19:39:03 +02:00
Keader
a639a99c6c Scripts/Icecrown Citadel: Fixed a edge case in Blood Quickening quest
killer can be a pet
2019-05-08 21:12:56 -03:00
Demonid
d1c5b3c897 Scripts/Icecrown Citadel: The Lich King's Last Stand quest kill credit (#23239)
Closes #8919
2019-05-08 18:43:33 -03:00
Killyana
fe311260f7 Remove deprecated code 2019-05-04 16:52:59 +02:00
sirikfoll
fe3bf57aba Core/Scripts: Fix Skadi dismount issue
Closes #23005
2019-05-02 15:46:46 -03:00
Giacomo Pozzoni
20772dbf5d Scripts/Spells: Fix implementation of #22332 (#23228)
Change the way #22332 moved spell damage calculations from SpellEffectDMG to scripts, using OnEffectLaunchTarget and SetEffectValue instead
2019-05-02 14:34:23 +02:00
Killyana
14445088ea Quest/Script: Breakfast Of Champions
Set both Earthshaker Drum Events to 50%
2019-04-30 02:23:23 +02:00
jackpoz
3f0ce98f7c Core/Commands: Fix heap-use-after-free in ".ticket delete" command
Reported by Address Sanitizer
2019-04-28 18:56:45 +02:00
jackpoz
26b6cb0584 Core/Misc: Fix some GCC 8 warnings 2019-04-28 15:59:34 +02:00
jackpoz
71d15ea25b Scripts/Commands: Add .debug asan commands
Add ".debug asan memoryleak" and ".debug asan outofbounds" commands to trigger Address Sanitizer warnings at runtime (or other dynamic analysis tools)
2019-04-27 20:11:48 +02:00
jackpoz
844e7ee926 Scripts/Guards: Fix infinite loop in npc_air_force_bots
Fix infinite loop in npc_air_force_bots happening when aura 38067 was removed, triggering MoveInLineOfSight() that would add back the aura. Only 1 aura add/remove for guard for player is allowed now.
2019-04-27 16:32:41 +02:00
Jozef Dúc
32e1de39a2 Core/Object: Range check (#23179)
* Should solve #23062. All credits to @xvwyh

* Remove unused variables

* Remove unused variable

* Cast int32 to uint32

* Remove G3D headers from core header file

* Change door distance

* Update GameObject.cpp

Add newline

* Update GameObject.h

Indentation
2019-04-24 20:39:01 +02:00
ForesterDev
ae8750716f Scripts/Commands: add some missing checks for .guild create command (#23201)
* Core/Conditions: implement CONDITION_GAMEMASTER

* Scripts/Commands: add some missing checks for .guild create command
2019-04-24 16:58:55 +02:00
Keader
f163c2f96a Scripts/Trial of the Crusader: Fixed Resilience will Fix achievement
Broken by 2362e9c794
2019-04-24 11:55:58 -03:00
Sorikoff
4468a538ff Scripts/Scarlet Enclave: Unworthy Initiate (#23195) 2019-04-22 11:25:17 -03:00
Sorikoff
90d4254a87 Scripts: Minor improvements to recently migrated scripts (#23189)
Ref: 2cfaeb1400
2019-04-21 11:22:39 -03:00
Keader
961bc9d829 Scripts/Spells: Fixed a console error inspell_dru_lifebloom
Closes #23192
2019-04-21 11:01:59 -03:00
Killyana
c318b3e16d Spell/Script: Kill logs spam for spell_ioc_parachute_ic
Closes #23163
2019-04-17 16:40:25 +02:00
Sorikoff
2cfaeb1400 Scripts/Spells: Migrate Some Scripted Spells to Scripts (#23185)
* Migrate spells to scripts

* Simplify code

* I need to sleep

* Update chapter1.cpp

* Use actual damage

* No need in null check here
2019-04-16 09:49:39 +02:00
Gustavo
cc3293c002 Core/Scripts: Fix Blood summon position (#23088)
* Core/Scripts: Fix Blood summon position

Updates #13162
2019-04-04 00:30:25 -03:00
Gustavo
50f122de77 Core/Misc: Warning fixes (/W4) (#23149)
* Core/Misc: Warning fixes (/W4)
2019-04-03 23:36:26 -03:00
jackpoz
750d89beed Core/Misc: Fix static analysis issues
Fix static analysis issues spotted by Coverity Scan
2019-04-02 21:40:30 +02:00
jackpoz
1d04a3b216 Core/Misc: Fix GCC 8 warnings 2019-03-31 17:34:28 +02:00
Trond B. Krokli
a040d48443 Scripts/Wailing Caverns: make Disciple of Naralex say Mutanus, not $n (#23122)
* Scripts/Wailing Caverns: make Disciple of Naralex say Mutanus the Devourer

Disciple of Naralex should say
"This Mutanus the Devourer is a minion from Naralex's nightmare no doubt!"
instead of using $n caused by a missing target in the Talk() script command.
2019-03-22 12:09:41 +01:00
Trond B. Krokli
7cb31aa482 Scripts/Borean Tundra: link gossip content for NPC Iruk from DB (#23118)
- remove hardcoded text (deprecated method)
- add already existing DB gossip content to enum
- correct spell enum from spell_creature_ to spell_create_
- replace case switch with if statement (only one boolean case)

Extra script file update:
- remove SD comment line 22 (outdated info, replaced by SAI)
2019-03-17 20:02:05 +01:00
ccrs
a006362615 Scripts/Northrend: 482e0da followup
add a little bit of tolerance
2019-03-08 15:25:13 +01:00
Langerz82
e840d4967e Spell/Script: Guard's Mark
Closes #16888
2019-03-08 15:13:32 +01:00
PolarCookie
ec3cb05d7f Core/Spell: SpellAura Redux (#22794)
* typo and correction

* spell aura no longer shared between targets

_spellAura isolated

* SPELL_AURA_CONTROL_VEHICLE is not strictly single target spell

Steam Tank Control and Wyrmrest Commander

units can reseat themselves again

* Rename 9999_99_99_99_world.sql to 2019_03_08_00_world.sql
2019-03-08 08:34:16 +01:00
ccrs
3eecadcebf Scripts/Northrend: 482e0da followup 2019-03-07 22:26:22 +01:00
Killyana
e5470ab1ee Spell/Script: Specify a target for Azure Dragon: On Death Force Cast Wyrmrest Defender to Whisper to Controller - Random 2019-03-07 17:37:03 +01:00
Keader
482e0dad30 Creature/Script: Daegarn
Remove the incorrect SAI and move it to cpp
2019-03-06 16:15:03 +01:00
ccrs
e69570dd76 Core/Misc: use/implement/portfrommaster InitWorldState packet definition
WorldPackets::WorldState::InitWorldStates
2019-03-04 16:33:08 +01:00
Keader
e1aafddc2e Scripts/Trial of the Crusader: Fixed Slime Pool visual effect
Closes #21660
2019-03-03 23:19:03 -03:00
Keader
990ad000f8 Spell/Script: Freezing Circle
Closes #11312
See the original issue before cherry pick
2019-03-02 19:57:38 +01:00
Sorikoff
dbadb6369c Core/Movement: Allow using walk when chasing v2 (#23073)
* Allow walk when chasing
2019-03-02 15:04:01 +01:00
sirikfoll
4ea09dfcd4 Fix nopch 2019-02-25 18:12:19 -03:00
sirikfoll
a803342029 Scripts/Ulduar: Mimiron improvements
Closes #23043

Fix Aerial hover
Some visual issues
2019-02-25 17:50:24 -03:00
Sorikoff
c2f2db08aa Allow walk when chasing (#23069) 2019-02-25 09:36:36 +01:00
jackpoz
f17120cc78 Core/Commands: Don't re-add active quests with ".quest add" command 2019-02-24 18:46:35 +01:00
DanVS
054914a83b Glyph of Holy Light (#22198) 2019-02-23 20:22:37 +01:00
Keader
c8dfab7761 Scripts/Spells: Fixed Demonic Pact not increasing spell healing
Closes #23019
2019-02-22 10:25:11 -03:00
Ovah
c10c8c6bba Scripts/MGT: Kael'thas intro can now be skipped when not killing the trash pack in his room
Scripts/MGT: Kael'thas will now despawn at evade

Cherry picked from
f6e9ff5ca4
ed8c1830f5
2019-02-20 17:43:56 -03:00
Keader
a617cc4097 Scripts/Illidan: Fixed Parasitic shadowfiends reproducing like rabbits 2019-02-20 10:40:19 -03:00
jackpoz
78f70cbff2 Core/Misc: Fix static analysis issues
Fix static analysis issues reported by Coverity
2019-02-16 13:40:39 +01:00
Sorikoff
f0f4d0280d Scripts/Scarlet Enclave: Stable Master Kitrik's spell Repo (#23023) 2019-02-16 13:28:31 +01:00
Shauren
813f693768 Core/Misc: Added lambda support to EventProcessor
Closes #22909
2019-02-15 21:34:56 +01:00