Commit Graph

32572 Commits

Author SHA1 Message Date
Killyana
9683ce99eb DB/Creature: Remove Ossirian Crystal Trigger as spawned by script
Closes #24681
2020-05-24 21:06:09 +02:00
NoName
89193c3548 Scripts/RuinsOfAhnQiraj: Crystal handling (#24679)
+ make crystal usable with animation and despawn after use;
+ small code update;
+ spell rearrange;
+ define some magic numbers;
+ update crystal coordinates from sniffed data
2020-05-24 20:45:28 +02:00
Gildor
dd3fbf426c Scripts/Icecrown Citadel: Fix Sindragosa movement when Wipe in fly phase (#24665) 2020-05-24 20:38:24 +02:00
NoName
2efaf1dda8 Entities/Player: Restore old checks for UpdatePvPFlag (#24372)
Partly revert 671052575a
+ implemented timer reset to 300s after relog never worked, therefore removing that part;
+ reverting other parts with 300s timer changes, as not needed;
2020-05-24 20:35:34 +02:00
Killyana
e0b0586afc DB/Quest: Birds of a Feather
Closes #24687
2020-05-24 19:23:55 +02:00
Killyana
73d55f6968 DB/Spell: Fix rampart of skulls and upper spire teleport orientation 2020-05-23 23:53:52 +02:00
jackpoz
cbd6c89822 CI/GitHub: Remove PR GitHub Action because of current limitations
GitHub Actions triggered when creating a Pull Request receive a read-only token that makes them useless when trying to do anything on GitHub.
Useful links:
- https://github.com/actions/first-interaction/issues/10
- https://github.com/actions/labeler/issues/12
- https://github.com/actions/labeler#pull-request-labeler

(cherry picked from commit 59e8b98bef)
2020-05-23 18:44:18 +02:00
jackpoz
f46c84fd9e CI/GitHub: Add action to label issues
(cherry picked from commit ce10a9482a)

CI/GitHub: Add action to label pull requests

(cherry picked from commit 92a289e455)

CI/GitHub: Fix github actions syntax

(cherry picked from commit 0435ecc8f5)

CI/GitHub: Rename jobs

(cherry picked from commit 58013167de)
2020-05-23 18:15:28 +02:00
Killyana
fd66e291b5 DB/Quest: Convert "HELP!" & "Corki's Gone Missing Again!" & "Cho'war the Pillager" to SAI
Closes #24649
2020-05-23 02:44:18 +02:00
Killyana
5ba021844d DB/GameObject: Remove Jump-a-tron 4000 from the DB
Ref #24668
2020-05-22 01:37:37 +02:00
offl
2008cb7dd3 DB/Quest: Convert & update support for 'Prisoners of Wyrmskull' to SAI
Closes #24650
2020-05-22 00:32:06 +02:00
offl
0cfd63fd26 DB/GameObject: Convert & update support for Shrine of the Eagle / Falcon / Hawk to SAI
Closes #24647
2020-05-21 23:52:02 +02:00
offl
626aeb5817 DB/Creature: Convert Sayge to SAI
Closes #24663
2020-05-21 23:34:59 +02:00
jackpoz
013301088d Scripts/Misc: Fix issues reported by ASan 2020-05-21 22:17:13 +02:00
offl
9c1c34a794 DB/GameObject: Convert & update support for Tablet of Madness
Closes #24670
2020-05-21 21:21:38 +02:00
offl
b68f4d17d3 DB/Creature: Add conditions for Wazat's texts & option to restore key
Closes #24669
2020-05-21 20:13:35 +02:00
ForesterDev
84dad1b29b Core/Packets: updated CMSG_PLAYED_TIME, SMSG_PLAYED_TIME (#24674)
(cherry picked from commit 50b4a3a707)

# Conflicts:
#	src/server/game/Server/Packets/CharacterPackets.cpp
#	src/server/game/Server/Protocol/Opcodes.cpp
#	src/server/game/Server/WorldSession.h
#	src/server/scripts/Northrend/Nexus/Nexus/nexus.h

Co-authored-by: MitchesD <majklprofik@seznam.cz>
2020-05-21 14:55:30 +02:00
Giacomo Pozzoni
247564a7ab Core/Creature: Allow to disable HP regen in Raids even if the target is unreachable (#24646) 2020-05-21 14:48:09 +02:00
Killyana
6b9a14ca94 DB/GameObject: Convert & update support for Jump-a-tron 4000 to DB script
Closes #24668
2020-05-21 02:05:44 +02:00
offl
abd8140681 DB/Loot: Remove loot from creature Water Terror
Closes #24671
2020-05-21 01:29:29 +02:00
offl
cfe6b651bc DB/Quest: Convert Escape from Umbrafen to SAI
Closes #24648
2020-05-21 00:28:41 +02:00
dr-j
e80b66fd52 DB/Quest: With a little help from my friends
Closes #24639
2020-05-20 23:20:37 +02:00
offl
cc5bea023a DB/Quest: Convert & update support for 'Hypercapacitor Gizmo' to SAI
Closes #24640
2020-05-19 23:06:05 +02:00
offl
97319c7c19 DB/Creature: Remove static spawns of Arcane Fiend & Amani Bear Mount
Closes #24662
2020-05-19 22:56:48 +02:00
offl
c3e4420a2b DB/GameObject: Convert & update support for Fel & Bash'ir crystalforges
Closes #24643
2020-05-19 22:46:31 +02:00
offl
44aba5dcdf DB/Quest: Convert support for 'Strength of One' to SAI
Closes #24641
2020-05-19 22:21:37 +02:00
offl
ea05844c59 DB/Creature: Bogblossom Bunny
Closes #24623
2020-05-19 21:56:59 +02:00
Shauren
a26304478d Core/Quests: Add missing GO_DYNFLAG_LO_ACTIVATE to lootable chests related to quests but not having quest loot
Closes #24474
2020-05-19 21:21:39 +02:00
Shauren
449bd9058b Core/Quests: Fixed gameobject sparkle state for lootable quest items by moving ItemAddedQuestCheck/ItemRemovedQuestCheck after item is added/removed
This is neccessary so that GameObject::BuildValuesUpdate from BuildValuesUpdateBlockForPlayer picks up correct inventory state and sets GO_DYNFLAG_LO_ACTIVATE
2020-05-19 20:50:53 +02:00
Keader
99c457c270 Scripts/ICC: Fixed duplicated call of reputation spell 2020-05-19 11:45:12 -03:00
Keader
d1e1b8753c Scripts/ICC: Fixed Deathbringer/Valithria reputation handler + codestyle fixes
* Added correct reputation spell for both bosses
* Fixed debuffs remove when deathbringer dies (it also fix recount)
* Changed all DoCast(me, xxx) -> DoCastSelf(xx)
* Removed old reputation hack in DB
* Fixed my OCD with spells enum :)
2020-05-19 11:42:11 -03:00
NoName
868748007d Scripts/RazorfenDowns: quest "Extinguishing the Idol" (#24658) 2020-05-19 13:19:10 +02:00
NoName
d2b88fbd50 Core/Objects: Add GOSummonType argument to SummonGameObject accepting XYZ arguments instead of Position (#24655) 2020-05-19 11:40:50 +02:00
offl
2152293d88 DB/Quest: Finding the Survivors
Update the los event
Ref #24636
2020-05-19 00:34:08 +02:00
Killyana
2665fd5ab5 DB/SAI: Fel Guard Hound
Ref #24638
2020-05-18 00:56:52 +02:00
offl
049cba3ace DB/Quest: Convert & update support for 'Shizz Work' to SAI
Closes #24638
2020-05-18 00:08:58 +02:00
offl
2815db52a6 DB/Quest: Convert & update support for 'Finding the Survivors' to SAI
Closes #24636
2020-05-17 23:36:34 +02:00
offl
a2068cade5 DB/Creature: Convert & update support for Ashyen & Keleth to SAI
Closes #24635
2020-05-17 21:53:02 +02:00
offl
7b4b04653b DB/Loot: Remove item Carved Ivory Bone from creatures loot
Closes #24624
2020-05-17 21:36:09 +02:00
offl
73f7a78a33 DB/SAI: Fix event flags for "Discovering Your Roots" script
Closes #24622
2020-05-17 21:33:37 +02:00
dr-j
513cbd289a DB/Quest: Kill'em With Sleep Deprivation/Look At the Size of It
Closes #24621
2020-05-17 21:12:08 +02:00
Ovahlord
8a9f809093 DB/Creatures: corrected several movement template flight values for creatures all accross Northrend. No more raining Gargoyles, Frost Wyrms, Birds and other flying things 2020-05-16 21:22:30 +02:00
Ovahlord
fdcb7388a6 Core/Objects: fixed destination calculation for destination based spells casted by flying units
* Additionally he PathGenerator will now check for realtime movement flags instead of creature based template data only so scripted flying movement and players will now correctly get their path calculated
2020-05-16 17:40:08 +02:00
Shauren
75ab3619bd Core/Commands: Fixed .npc add overwriting existing spawns when used on transports 2020-05-16 11:23:34 +02:00
Giacomo Pozzoni
bd2d60c267 Fixes/3.3.5 aura infinite loop (#24631)
* Core/Auras: Attempt to fix infinite loop with aura 18950 on map unload

* Core/Auras: Log a detailed error and assert when failing to remove all auras after a few tries

* Code cleanup

* Fix build warnings

* Fix more build warnings
2020-05-16 11:06:03 +02:00
offl
8ad0ab362e DB/SAI: Black Morass - Infinite mobs
Closes #4613
2020-05-15 23:08:03 +02:00
joshwhedon
4db77bc913 Removing a duplicate item combat spell handling causing poisons (and others) to proc twice. (#24627)
https://github.com/TrinityCore/TrinityCore/issues/24608
2020-05-15 21:54:33 +02:00
Giacomo Pozzoni
c0b75bf40d Core/MMAPs: Adjust walkable climb and fix a lot of mmap raycast issues (#24539)
* Core/MMAPs: Adjust walkable climb

Adjust walkable climb as recast using walkableClimb also to find the poly from a position, giving priority to polys that are below the position but closer than walkableClimb.

* Temporarily disable static collision (the whole check should be removed)

* Core/Spells: removed deprecated mmap path check for TARGET_DEST_CASTER_FRONT_LEAP

* Core/Objects: allow flying units to use the helper as well (flying units casting radius based spells)

* Code refactor

* Handle raycasts that end in a point with no height in the mmap mesh as PATHFIND_NOPATH

* Walk back a bit from raycast hitpoints as sometime the 2D result point is outside of the polygons due to floating point errors.

* Remove whitespace

* Revert 4a197ba22a as a raycast point path should have the Z retrieved with getPolyHeight(). Raycast will only return a 2-point path with Start and Hitpoint/End

* Cleanup PathGenerator raycast case

* Fix PathGenerator raycast broken if start and end are on same poly.
Fix PathGenerator raycast broken if no wall is hit.
Remove unused case of using raycast with an existing previous path (can be added back properly if needed).
Remove forcing poly length to 2 when we actually have already the right number.

* Use closestPointOnPolyBoundary on the second try of finding a point on poly for raycast.
Note that in this case the mesh height is not used which might cause issues. The poly boundary height will be used instead.

* Handle cases where getPolyHeight() fails because the point is on polygon border (and caused by floating point imprecision)

* Add far from poly flags

* Set PATHFIND_INCOMPLETE in raycast case if startFarFromPoly or endFarFromPoly

* Fix blink close to walls with no valid polygon behind the wall

* Require to re-extract mmaps

Co-authored-by: Ovah <dreadkiller@gmx.de>
2020-05-15 20:43:12 +02:00
HelloKitty
43b595111d Further improve ChrRace DBC handling (#24508)
* Core/DBC: Added ChrRacesAllianceType for ChrRaces.dbc

* Core/Character: Check ChrRace DBC playable in HandleCharCreateOpcode

* Core/DBC: Implement ChrRacesFlags removing literals

Cannot take credit for this enum, derived from documentation in
https://wowdev.wiki/DB/ChrRaces

* Core/Character: Check CHRRACES_FLAGS_NOT_PLAYABLE on creation

* Core/DBC: Fix formatting of ChrRaces enums

* Core/DBC: Use ChrRaces CreatureType instead of hardcoded humanoid assumption

* Address enum style code changes
2020-05-15 20:41:16 +02:00
Shauren
1d43003cfa Scripts/Icecrown Citadel: Fixed Professor Putricide oozes not moving during their channel 2020-05-15 18:16:03 +02:00