Aokromes
74b7ac101a
Scripts/SmartAI: SMART_TARGET_INVOKER cleanup step 1. The core will n…
...
…ow log errors on start-up if SMART_TARGET_INVOKER abuse is found, but will continue to load the scripts as deprecated for now.
Note that a lot of these scripts may either not currently work, not work reliably, or may be prone to breaking unexpectedly when core internals change. SMART_TARGET_INVOKER is undefined behavior on any event that doesn't directly specify its invoker.
(We are considering options for allowing INVOKER to make sense in timed action lists in a reliable fashion, so they are exempted at this time.)
2018-02-16 02:08:56 +01:00
ariel-
bbe9aa23b0
Core/Spells: fix Vampiric touch dispel effect inheriting damage done pct twice
2018-02-16 01:57:08 +01:00
Wilcalaf
6d90944f02
Archaedas should properly start now when clicking on the altar. ( #21401 )
2018-02-16 01:40:15 +01:00
Aokromes
9f0f00257e
Core/Scripts: fix nopch
2018-02-16 01:38:48 +01:00
ariel-
3a4035bb8d
Core/Spells: add log on load about improper use of attribute PROC_ATTR_REQ_SPELLMOD
2018-02-16 01:26:26 +01:00
Treeston
daa7c79f7e
Revert "Scripts/ScarletEnclave: fix Massacre at Light's Point mine cart escort to work again (tag #20310 )"
...
This reverts commit 6ff71dffbb .
2018-02-16 01:25:02 +01:00
Treeston
c83d9d3a4b
Scripts/AzjolNerub: Hadronox is a big spider mommy, and needs more room to pet her spider pets properly. Hopefully this'll reduce the number of evades happening during the encounter. Tag #20310 .
2018-02-16 01:24:55 +01:00
Treeston
302599decd
Scripts/ScarletEnclave: fix Massacre at Light's Point mine cart escort to work again (tag #20310 )
2018-02-16 01:24:48 +01:00
ariel-
e6888f72e0
Core/Scripts: implemented Combined Toxins proc only from poisons
2018-02-16 01:22:39 +01:00
Aokromes
d5a77f6b79
Core/Auras: fix periodic ticks proc after previous commit
2018-02-16 01:21:15 +01:00
ariel-
2388415edd
Core/Spells: require phasemask set for periodic damage procflag
...
Closes #21379
2018-02-16 01:04:27 +01:00
jackpoz
bee461eda8
Core/Player: Add some asserts
...
Assert PlayerInfo for race/class pair in a few Player functions
2018-02-16 01:04:11 +01:00
jackpoz
46467499f3
Scripting/Obsidian Sanctum: Fix crash
...
Fix crash caused by calling Reset() in constructor (which is not allowed)
2018-02-16 01:03:56 +01:00
Jildor
53728216b6
Whitespace cleanup in Transaction.cpp
...
Removing white space after commit 54b0b8f5ea
2018-02-16 01:03:45 +01:00
jackpoz
d1df97db23
Shared/Database: Improve dead-lock error handling
...
Improve dead-lock error handling in async transactions by retrying the transaction for up to 60 seconds instead of just 5 times
2018-02-10 16:16:14 +01:00
Keader
563de5bf20
Scripts/Icecrown Citadel: Fixed Sindragosa spawn after grid unload
...
ty sirikfoll :)
2018-02-10 12:08:32 +01:00
Treeston
6363bc77b8
Game/AI: InvalidAIException internal cleanup
2018-02-10 12:08:24 +01:00
Keader
a162d421ce
Core/Scripts: Fixed tabs issues introduced in 5bef3e426a
2018-02-10 12:04:09 +01:00
Keader
2f8361d320
Core/Scripts: Fixed possible crashs related with JustDied
2018-02-10 12:03:59 +01:00
ariel-
9fdb4c0a4d
Core/Scripts: fix non-functional Celestial Planetarium Access GO
...
- Client only sends CMSG_GAMEOBJ_REPORT_USE for this one
Closes #19982
2018-02-10 11:52:22 +01:00
sirikfoll
855a0bbaf0
Scripts/Magisters Terrace: Removed not allowed ENSURE_AI call from constructor
...
Closes #20727
2018-02-10 11:52:11 +01:00
Shauren
bf2d223cc3
Build fix
2018-02-10 11:51:45 +01:00
Shauren
c385edb12d
Core/Scripts: Fixed ENSURE_AI assertion failures when used in Reset()/InitializeAI() hooks with hotswap
...
Updates #20727
2018-02-10 11:51:34 +01:00
Aokromes
6c62498517
pre-cp
2018-02-10 11:51:28 +01:00
ariel-
a97171c8c0
Core/ScriptSystem: AfterHit hook can't modify damage/healing, so log it
...
- Also added const to getter members
2018-02-10 11:49:40 +01:00
ariel-
afed7f0425
Core/Channel: properly notify client about invalid channel names
...
Closes #16190
2018-02-10 11:49:18 +01:00
ariel-
6dc6cc7608
Core/Spells: fix logic error causing near teleports to drop combat for players
...
Closes #21362
2018-02-10 11:37:00 +01:00
ariel-
23af4f93ba
Core/Spells: remove duplicated LowerPlayerDamageReq call on reflected spells
...
- It is already called at Unit::DealDamage
2018-02-10 11:36:50 +01:00
jackpoz
8e5c1d012d
Core/Misc: Fix no-pch build
2018-02-10 11:34:26 +01:00
jackpoz
57314740da
Core/AI: Fix assertion triggered with PetAI derived scripts ( #21254 )
...
* Core/AI: Fix assertion triggered with PetAI derived scripts
Fix an assertion triggered when spawning through ".npc add" or from SQL db table a Creature with AI set to a custom AI inheriting from PetAI.
2018-02-10 11:33:51 +01:00
Aokromes
3b1913a739
Revert "Core/Spells: fixed a logic mistake that was interrupting channeled spells due to movement"
...
This reverts merge request !107
2018-02-08 20:13:53 +00:00
Ovalord
23ff9e8d12
Core/Spells: fixed a logic mistake that was interrupting channeled spells due to movement
2018-02-07 11:15:02 +01:00
Aokromes
c904859682
Core/Spells: fix Spirit of Redemption
2018-01-27 16:27:52 +01:00
Aokromes
b705a16631
Core/Misc: 2 comment corrections in Language.h
2018-01-27 16:16:51 +01:00
Aokromes
ee54de51a8
Scripts/Outland: Fix logical error in Hellfire event in Honor Hold
2018-01-27 16:13:13 +01:00
Aokromes
8365119235
Core/Battleground: Dropped battleground texts from trinity_string and replaced them with proper BroadcastText
2018-01-27 16:00:38 +01:00
Aokromes
615a997035
Warnings fix
2018-01-27 13:49:25 +01:00
Aokromes
a6835c5872
missing part
2018-01-27 13:12:31 +01:00
Aokromes
aa1032bd17
missing part
2018-01-27 13:07:51 +01:00
Aokromes
7be6304306
Core/Spells: Removed outdated mechanic (spell downranking coef penalty)
2018-01-27 12:28:42 +01:00
ariel-
fd92fa7451
Core/Auras: fixed EquippedItemClass check
...
follow-up to 29c3b7d8f6
2018-01-21 12:57:07 +01:00
ariel-
c7a62f99d3
Core/Auras: Don't remove shield only dependant auras on disarm
...
Closes #19782
2018-01-21 12:56:14 +01:00
ariel-
f2a3a356be
Core/Auras: define and implement attribute SPELL_ATTR3_IGNORE_PROC_SUBCLASS_MASK
...
Closes #20148
2018-01-21 12:56:05 +01:00
Treeston
7997bebf9e
Scripts/AzjolNerub: Missing nullptr check in Hadronox. Closes #21258 .
2018-01-21 12:55:37 +01:00
Moein
d58ac3881c
Scripts/Spells: quest "That's Abominable" ( #21253 )
...
- scripted spell "Burst At The Seams" (59576)
- added Pet Bar
Closes #10876
2018-01-21 12:54:58 +01:00
Aokromes
13295bb200
Core/CombatAI: Npcs with TurretAI will be able to attack again
2018-01-21 12:54:46 +01:00
sirikfoll
3b5f3c2ebf
Scripts/Scarlet Enclave: Quest The Endless Hunger will work correctly after Unworthy Initiate Respawn
...
Due to dynamic spawns, we need to be able to update the Npc GUID after the respawn, otherwise the quest can only be completed by the first player
2018-01-21 12:39:39 +01:00
ariel-
49c861d064
Core/Unit: check remaining instead of full duration for Bounced by DR auras
2018-01-21 12:39:28 +01:00
Keader
2eb11c7b7c
Scripts/Pit of Saron: Tyrannus followup
...
fix new issue caused by 947cb6a453
2018-01-21 12:39:16 +01:00
Aokromes
ca4b8d9881
Scripts/Pit of Saron: Fixed Tyrannus not working after evade
2018-01-21 12:39:02 +01:00