Commit Graph

10251 Commits

Author SHA1 Message Date
jackpoz
bd4be27aeb Core/Calendar: Sanitize calendar event parameters
Prevent events added in the past which in some conditions would cause an infinite loop in the client.
2014-06-09 23:11:05 +02:00
jackpoz
3c8503bea7 Revert "Core/Calendar: Fix memory leak when malformed CMSG_CALENDAR_ADD_EVENT is received"
This partially reverts commit 51e38872c7.
The stack-initialized variable calendarEvent would have called CalendarMgr::FreeEventId() when it went out of scope, marking the current event id as free and allowing next event to overwrite current event.
This doesn't fix the memory leak issue which still needs to be addressed in a proper way.
2014-06-09 23:11:04 +02:00
Gacko
ecbf6fdd6c Script: Minor optimization in spell_unlocking_zuluheds_chains 2014-06-09 23:11:03 +02:00
Vincent-Michael
3be5178304 Core/Misc: Kill Whitespace ... 2014-06-09 23:10:59 +02:00
jackpoz
6dc76223fb Core/Banks: Fix some bank exploits
Re-implement the cheat checks removed in a12501fb5e and check if Player can interact with the Banker when handling bank-related opcodes.
2014-06-09 23:10:58 +02:00
Aokromes
6afd62a6bd Core/Database: Update log for incorrect db structure 2014-06-09 23:10:57 +02:00
Unholychick
b651789cb0 Core/Spells: Implement Periodic mechanics
Change behaviour of single target periodic aura ticks to be more blizzlike
Also add some missing handling of SPELL_AURA_MOD_CREATURE_AOE_DAMAGE_AVOIDANCE
Fixes Deep wounds and Chimera Shot Serpent
Remove an ancient hack with Drain Soul, spell id 100001 can now be deleted from spell_dbc table
Allows Rolling dot mechanics and allows DK's to roll diseases with pestilence,
see link for info:

http://forums.elitistjerks.com/topic/82503-frost-dps-in-333this-will-be-a-day-long-remembered/page-88
2014-06-09 23:10:56 +02:00
Trisjdc
f80384a1f2 Core/Spells: Anti-Magic shell should give immunity to all spells that belong to SPELL_SCHOOL_MASK_MAGIC regardless of dispel type 2014-06-09 23:10:55 +02:00
aletuna
77c29e8feb Scripts/Blackrock Depths: Converted to eventmap+minor coding style changes
Closes #11730
2014-06-09 23:10:54 +02:00
Trisjdc
3aa5b01d4d Core/GOs: When unlinking Fishing Bobber from player to prevent despawning, unlink from spell as well to prevent removing unwanted auras 2014-06-09 23:10:53 +02:00
joschiwald
be518159bf Core/Spells: add missing spellradius to spell "Achievement Check" (fixes hor achievments) 2014-06-09 23:10:52 +02:00
Vincent-Michael
2897476517 Core: Fix non pch build 2014-06-09 23:10:50 +02:00
Michael
eac01c3f2a Core/NetworkIO: Added latency info for opcodes overflow log 2014-06-09 23:10:49 +02:00
Trisjdc
f14be42e0c Core/Utils: Move EventMap to Util.h 2014-06-09 23:10:48 +02:00
Trisjdc
78f1cbfba5 Scripts/Items: Imp in a Ball 2014-06-09 23:10:47 +02:00
Trisjdc
46c7524084 Core/Players: Improve quest item adding/removal checks, solves cases where quest item removal (under specific conditions) incorrectly incompletes quests 2014-06-09 23:10:46 +02:00
jackpoz
9c240c14ec Core/Talents: Align server checks to Client limits
Set the max amount of talents to process in CMSG_LEARN_PREVIEW_TALENTS_PET to 30 ( 24 talents rounded up ).
2014-06-09 23:10:44 +02:00
jackpoz
1e545eaa70 Core/Talents: Align server checks to Client limits
Set the max amount of talents to process in CMSG_LEARN_PREVIEW_TALENTS to 150 ( 44 talents for 3 trees rounded up ).
2014-06-09 23:10:43 +02:00
Trisjdc
281527a9c3 Core/Spells: *Properly* solve the Disarm vs Bladestorm issue 2014-06-09 23:10:42 +02:00
Trisjdc
3dce4fabae Core/Spells: Swift Retribution should be reapplied when needed to be able to gain spellmods 2014-06-09 23:10:42 +02:00
Trisjdc
e3b8cd5c7e Scripts/ToCr: Bosses shouldn't despawn so quickly 2014-06-09 23:10:41 +02:00
Trisjdc
e0d08f5afb Core/Spells: Corpse Explosion should not be able to pick the Ghoul out of implicit targets 2014-06-09 23:10:40 +02:00
Trisjdc
fbae790c1d Warning fix 2014-06-09 23:10:39 +02:00
jackpoz
3a9c730083 Core/Tickets: Don't try to save the same sub-survey more than once 2014-06-09 23:10:38 +02:00
Trisjdc
ca6e9112e9 Core/WorldSession: After sudden disconnects, session should persist for a minute
- With this change, if a player alt-f4, he'll only fade from world after a minute
2014-06-09 23:10:37 +02:00
Trisjdc
94b6c1b544 Core/Maps: Allow logging players to enter in instances that have an encounter in progress 2014-06-09 23:10:36 +02:00
Trisjdc
c755a51ce0 Core/Auras: Update model overwriting rules for SPELL_AURA_TRANSFORM 2014-06-09 23:10:35 +02:00
Trisjdc
95a94f89b2 Core/Spells: Fix Cheat Death formula 2014-06-09 23:10:34 +02:00
Trisjdc
eb414532fe Core/CreatureAI: Implement CreatureAI::TalkToMap for all your map-wide talking needs. Could also replace Battleground::SendChatMessage 2014-06-09 23:10:33 +02:00
Golrag
8769207854 Core/Spells: Fixed Shadowstep taking the caster out of combat while it shouldn't 2014-06-09 23:10:31 +02:00
jackpoz
d52eb14bb6 Core/NetworkIO: Adjust more packet throttling values
Ignore some opcodes that don't cause any trouble.
Remove old Allow/Disable Anti-DoS system since it's no longer required.
2014-06-09 21:37:44 +02:00
Shauren
f81635ebe5 Core/Vehicles: Fixed channeled spells being interrupted for passengers when vehicle moves 2014-06-09 21:08:19 +02:00
Trisjdc
0b3e391ac4 Merge pull request #11739 from Golrag/master
Core/Spells: Fixed Shadowstep taking the caster out of combat while it shouldn't
2014-06-09 00:53:28 +01:00
Trisjdc
38e12321a5 Merge pull request #12069 from Trisjdc/cheat_death
Core/Spells: Fix Cheat Death formula
2014-06-09 00:45:12 +01:00
Trisjdc
551c565746 Core/Handlers: Move a couple of logs to debug, they can appear without anything abnormal due to client latency 2014-06-08 23:11:42 +01:00
leak
55dee85ed8 Remove ace/config-all.h and ancient WinXP defines which are actually commented out... 2014-06-08 23:28:01 +02:00
leak
daa5c0ad0d Use correct define for endianess 2014-06-08 23:25:40 +02:00
Lucas
5d40838207 Fix Warnings 2014-06-08 21:21:49 +02:00
Sebastian Valle Herrera
d0c9ac1d69 Merge pull request #12228 from Unholychick/patch_periodics
Core/Spells: Implement Periodic mechanics
2014-06-08 13:13:14 -05:00
leak
0dd10269d1 Replaced dependencies on ace/OS_NS_time.h 2014-06-08 20:08:43 +02:00
jackpoz
fc7062049f Core/Calendar: Sanitize calendar event parameters
Prevent events added in the past which in some conditions would cause an infinite loop in the client.
2014-06-08 17:33:17 +02:00
jackpoz
927f16de49 Revert "Core/Calendar: Fix memory leak when malformed CMSG_CALENDAR_ADD_EVENT is received"
This partially reverts commit 51e38872c7.
The stack-initialized variable calendarEvent would have called CalendarMgr::FreeEventId() when it went out of scope, marking the current event id as free and allowing next event to overwrite current event.
This doesn't fix the memory leak issue which still needs to be addressed in a proper way.
2014-06-08 17:18:07 +02:00
leak
fdd5e11a15 Fix for LockedQueue.h (clean rebuilds ftw.) 2014-06-08 16:05:23 +02:00
Gacko
d2d1b97cff Script: Minor optimization in spell_unlocking_zuluheds_chains 2014-06-08 15:56:28 +02:00
leak
ee4a3b9d59 Replaced mutex related code in Common.h 2014-06-08 15:30:57 +02:00
Trisjdc
91052574ac Core/Auras: Expanding functionality of SPELL_GROUP_STACK_RULE_EXCLUSIVE_SAME_EFFECT to be able to take care of aura effects inside their handlers
Currently handled:
- SPELL_AURA_MOD_RESISTANCE_PCT
- SPELL_AURA_MOD_STAT
- SPELL_AURA_MELEE_SLOW
- SPELL_AURA_MOD_MELEE_HASTE
- SPELL_AURA_MOD_DAMAGE_PERCENT_DONE

Necessary to allow stack rules such as BoK/BoS/Bok-Drums and others to be all in a target with all of the aura effects, yet with only the 'highest' effect active
2014-06-07 23:43:11 +01:00
Vincent-Michael
1d39db16b9 Core/Misc: Kill Whitespace ... 2014-06-07 23:58:08 +02:00
jackpoz
5fee5b0125 Core/Banks: Fix some bank exploits
Re-implement the cheat checks removed in a12501fb5e and check if Player can interact with the Banker when handling bank-related opcodes.
2014-06-07 22:47:50 +02:00
Aokromes
4ec84fd1ec Core/Database: Update log for incorrect db structure 2014-06-07 22:13:42 +02:00
Sebastian Valle Herrera
8304c09547 Merge pull request #12231 from Trisjdc/fishing_boober_link
Core/GOs: When unlinking Fishing Bobber from player to prevent despawning, unlink from spell as well to prevent removing unwanted auras
2014-06-07 14:24:30 -05:00