Commit Graph

738 Commits

Author SHA1 Message Date
Shauren
5d02739b98 Scripts: Fix rbac permission for skipping default boss sequencing check
(cherry picked from commit e660c8bc19)
2021-12-20 21:40:47 +01:00
Keader
174f4bad3d Scripts/Blood Furnace: Fixed Broggok reset issues and some little improvements
Closes #23658

(cherry picked from commit 1bdc792559)
2021-12-20 20:18:55 +01:00
Eridium
c96157cb95 Boss/Script: Fix Mechano-Lord Capacitus's Nether Charges (#23976)
* Boss/Script: Fix Mechano-Lord Capacitus's Nether Charges

Closes #23973

* Update boss_mechano_lord_capacitus.cpp

* Update boss_mechano_lord_capacitus.cpp

* Update boss_mechano_lord_capacitus.cpp

* Rename 2019_12_99_99_world.sql to 2019_12_19_00_world.sql

(cherry picked from commit efcbfa5c24)
2021-12-19 12:34:32 +01:00
jackpoz
d5d04a6c55 Core/Misc: Fix C++17 build errors
(cherry picked from commit 30823f9b79)
2021-12-18 22:51:50 +01:00
Keader
5d2b37634b Scripts/Tempest Keep: Fixed a typo in Nethermancer Sepethrea
Closes #23828
Ty Rizztazz

(cherry picked from commit 746a1d89b3)
2021-12-18 22:24:21 +01:00
Artamedes
e4607725dd Scripts/Outland: Change auto to TempSummon* (#23764)
(cherry picked from commit 1b095811b8)
2021-12-18 21:37:15 +01:00
Artamedes
913f0903a3 Scripts/Outland: Fix npc_ancestral_wolf not starting waypoint (#23763)
* Scripts/Outlands: Fix npc_ancestral_wolf not starting waypoint, and also add a way to not follow owner automatically in CreatureAI::JustAppeared() for tempsummons

* fix nopch

(cherry picked from commit 0b3a9e2a2b)
2021-12-18 21:37:02 +01:00
Giacomo Pozzoni
77eaa2c1ac Scripts/Blood Furnace: Fix infinite loop in Broggok encounter
Fix infinite loop in Broggok encounter caused by https://github.com/TrinityCore/TrinityCore/pull/23300

(cherry picked from commit 30a4aca266)
2021-12-17 21:52:33 +01:00
ForesterDev
529ca2dd5d Scripts/Defines: cleanup some magic numbers in factions (#23631)
(cherry picked from commit 0c317498a5)
2021-12-17 20:48:31 +01:00
Treeston
c13d83796f Core/AI: Finally move the "is creature engaged" flag to be a property of the creature AI, where it honestly always belonged. Fixes #17981 and #23602 for real this time.
(cherry picked from commit 0e7c66cb4c)
2021-12-17 00:23:33 +01:00
Wyrserth
3efc2caf96 Script/SethekkHalls: fix gossip text and quest event for NPC Lakka in Sethekk Halls.
(cherry picked from commit b8d86bba99)
2021-12-16 22:58:41 +01:00
Ianislav Vasilev
fa9683fc68 Scripts/Blood Furnace: Broggok improvements (#23300)
* 23285 Fixed lever respawn and future encounters after it respawns.

* Removed unnecessary additional container.
Made lever not to despawn and respawn but rather change flags only.

* Made one conditional branch easier to debug.

(cherry picked from commit c71e36acae)
2021-12-15 00:17:32 +01:00
Treeston
fdb43e41a8 Scripts/Outland: Rewrite the Watch Commander Leonus event so it no longer starts exponentially more often if the grid remains loaded for over an hour. Closes #23348.
(cherry picked from commit a3c3526269)
2021-12-15 00:17:32 +01:00
ccrs
4e6c59dca7 Core/Unit: rename several getters to follow codestyle
uint8 GetLevel()
        uint8 GetLevelForTarget(WorldObject const* /*target*/)
        void SetLevel(uint8 lvl)
        uint8 GetRace()
        uint32 GetRaceMask()
        uint8 GetClass()
        uint32 GetClassMask()
        uint8 GetGender()

(cherry picked from commit 5c09ff51f7)
2021-12-13 00:42:20 +01:00
Aokromes
30cec73c61 Coding standards (#23514)
* Coding standards

* revert part

(cherry picked from commit fe744977c9)
2021-12-13 00:42:17 +01:00
Treeston
38d7c1530a Combat/Threat: Split ThreatManager::NotifyDisengaged off from ThreatManager::ClearAllThreat. NotifyDisengaged signifies intent to clear the engagement flag, and should only be called from AI. Fixes #23490.
(cherry picked from commit 1158f267df)
2021-12-12 02:09:15 +01:00
Killyana
0993b491dd DB/Quest: A Visit With The Ancestors
Closes #23284

(cherry picked from commit a3dec9068b)
2021-12-11 16:32:05 +01:00
Wyrserth
9d865f7536 Core/Misc: don't allow players to use/activate/loot non-allowed gameobjects while under the effect of a damage immunity aura (#23319)
* Core/Misc: don't allow players to use/activate/loot non-allowed gameobjects while under the effect of a damage immunity aura.

* Forgot to change this in last-second rename.

* Apply suggested changes, thanks Shauren!

(cherry picked from commit 8bc5451864)
2021-12-09 00:13:59 +01:00
Killyana
8f1020ec78 DB/Creature: Hydross the unstable npc triggers
Update the correct channel spell SPELL_BLUE_BEAM and spawn triggers used to cast it

(cherry picked from commit 2829f5fb9c)
2021-12-08 20:36:43 +01:00
Giacomo Pozzoni
5f545f5402 3.3.5 gameobject summoner (#23289)
* Scripts/Misc: Change IsSummonedBy(Unit*) to IsSummonedBy(WorldObject*)

* Scripts/Misc: Fix build

* Core/TempSummons: Rename GetSummoner() to GetSummonerUnit()

* Core/TempSummons: Add support to TempSummons::GetSummoner() to return GameObject too

* Fix build

* Core/TempSummons: Allow GameObject to be owner of TempSummon

* Core/TempSummons: Add support to SAI for GameObject owner of TempSummon

* Scripts/Misc: Fix no-pch build

* Core/TempSummons: Implement PR comments

(cherry picked from commit 797fba98e9)
2021-12-07 00:02:03 +01:00
Killyana
cb9a1c38f1 Instance/Script: Blood Furnace
Ref #23285

(cherry picked from commit 9435caa8d1)
2021-12-05 18:39:09 +01:00
jackpoz
43a41caafb Core/Misc: Fix GCC 8 warnings
(cherry picked from commit 1d04a3b216)
2021-11-24 23:40:15 +01:00
Sorikoff
956158d299 Core/Movement: Allow using walk when chasing v2 (#23073)
* Allow walk when chasing

(cherry picked from commit dbadb6369c)
2021-11-24 20:34:54 +01:00
Sorikoff
b3f75852c2 Allow walk when chasing (#23069)
(cherry picked from commit c2f2db08aa)
2021-11-24 00:02:13 +01:00
Keader
dba7e2507f Scripts/Illidan: Fixed Parasitic shadowfiends reproducing like rabbits
(cherry picked from commit a617cc4097)
2021-11-23 23:16:43 +01:00
Keader
4af2894626 Scripts/Black Temple: Mother Shahraz fatal attraction need be random
Higher distance showed in my sniffs is 48 yards (rounding 50 yards). If someone find more then that, please let me know.
Ty killerwife

(cherry picked from commit fd69c133b1)
2021-11-22 23:57:54 +01:00
Keader
c3210798f0 Scripts/Black Temple: Fixed some issues in Illidari Council
Ty killerwife for all help :)

(cherry picked from commit ef6240312c)
2021-11-22 23:57:19 +01:00
Giacomo Pozzoni
fff0d174aa Scripts/Misc: Fix LoadMinionData() dynamic analysis issues
Fix issues reported by Address Sanitizer about LoadMinionData() calls on arrays that don't end with a {0, 0} pair.

(cherry picked from commit 08dcee0cf9)
2021-11-18 22:53:21 +01:00
Keader
c4eed6561c Scripts/The Steamvault: Fixed Chambers Access Panel and Main Chambers Door
Closes #21067
Ty Kittnz, killerwife, Aokromes (sniffs)

(cherry picked from commit b283565d8a)
2021-11-18 22:41:55 +01:00
Giacomo Pozzoni
4177030dcf Scripts/Nagrand: Fix crash added in PR #22806 (#22878)
Fix crash added in PR #22806 happening in quest "Ruthless Cunning and Returning the Favor"

(cherry picked from commit cb13638721)
2021-11-16 21:04:05 +01:00
PolarCookie
f377dc23f3 Quest: Ruthless Cunning and Returning the Favor (#22806)
* Ruthless Cunning and Returning the Favor

* no more magic numbers

* now with scripted ai and condition

* travis

* more travis

* jackpoz

* now with no banner spellscripts

* typo

* Rename 9999_99_99_99_world.sql to 2018_12_03_00_word.sql

(cherry picked from commit 9d93504f34)
2021-11-16 00:51:51 +01:00
Gildor
4a775c01e9 Core/Scripts - The Eye: Fix Kael'thas Sunstrider Mind Control, limit MaxAffectedTargets to 3 (#22828)
Closes: #22826
(cherry picked from commit 0ee8a77dce)
2021-11-16 00:07:15 +01:00
Keader
fe4da71f1d Scripts/Illidari Council: Changed urand to SelectRandomContainerElement
(cherry picked from commit 6cb754ca4e)
2021-11-15 00:15:39 +01:00
Keader
f69c8c2e60 Scripts/Black Temple: Fixed a crash on Illidari Council (#22652)
Ty Sirikfoll :)

(cherry picked from commit 9a443306fb)
2021-11-15 00:15:16 +01:00
Shauren
f2456ff319 Scripts/Areatriggers: Fixed all areatrigger scripts triggering both on enter and exit instead of only on enter 2021-11-10 00:01:50 +01:00
DanVS
28cb2af1c5 Core/Scripts: Unify Chrono Literals (#22420)
* Unify Chrono Literals

* Retire IN_MILLISECONDS

* Build fix

* Build fix (sequel)

* Retire urand()

* Edge cases

* Build

* Whitespaces

* More edge cases

* Additional cases

(cherry picked from commit 5b0f4009df)
2021-11-09 00:26:59 +01:00
ModoX
437fb2aaba Core/CreatureTexts: Added new field SoundPlayType to enable usage of ObjectSounds within creature_text (#27136)
* Also adjusted Vigilant Quoram texts to use ObjectSounds
2021-10-23 13:10:32 +02:00
Keader
37c9553372 Scripts/Black Temple: Fixed some issues on Illidan
(cherry picked from commit 0ebb315d6c)
2021-10-23 00:22:53 +02:00
Treeston
e4e8c1c59c Core/AI: Clean up charm AI handling, we now have two unique_ptr instead of a crapton of booleans
(cherry picked from commit 042f5515e4)
2021-10-22 23:47:51 +02:00
Treeston
3418a33a87 Misc: Pass std::chrono types by value everywhere.
(cherry picked from commit 2ef9d301f0)
2021-10-14 19:39:42 +02:00
Keader
f78c1bed5d Scripts/Black Temple: Removing double hook call in Spiritual Vengeance
(i realy dont remember why i did it lol)

(cherry picked from commit c9b09fc2cb)
2021-10-14 18:59:24 +02:00
illfated
550513ba65 Creature/Script: remove obsolete script npc_skywing (#22147)
- replaced with SAI script for the same quest and creature (Skywing)

Ref. https://github.com/TrinityCore/TrinityCore/issues/22078#issuecomment-399760597

(cherry picked from commit 0004531081)
2021-10-14 00:09:17 +02:00
Meji
5c287929b2 Core/Gossip: Update GossipOptionIcon enum (#26906) 2021-10-03 16:24:07 +02:00
Shauren
3af9be830d Core/Spells: Removed CastSpellExtraArgs constructors accepting ObjectGuid, they would become ambiguous with future changes 2021-10-03 14:58:35 +02:00
Shauren
3bf6698116 Core/Misc: Fix appleclang 12 warnings 2021-10-01 11:18:29 +02:00
sirikfoll
f507737ecf Scripts/TheSlavePens: Boss Ahune fixes and updates
Fixes some visual problems
Fixes encounter start
Updated codestyle

Closes #22071

(cherry picked from commit 35ba5aa138)
2021-09-29 21:01:25 +02:00
Gildor
b3f3dbc663 TheSlavePens/Ahune: Fix crash (#22070)
Closes: #22069
(cherry picked from commit eb6e240fd1)
2021-09-29 20:55:23 +02:00
ZenoX92
ecf2a0ef9f DB/Quest: Escaping the Tomb
Closes #22033

(cherry picked from commit 5f69a8de70)
2021-09-29 16:05:49 +02:00
ccrs
426f9f2f92 Core/Movement: MotionMaster reimplementation (#21888)
Internal structure and handling changes, nothing behavioural (or thats the intention at least).

(cherry picked from commit 982643cd96)
2021-09-28 00:15:13 +02:00
Keader
b91398fd28 Scripts/Magtheridon Lair: Fixed a case when channelers get hit kill and not start fight
It's needed for cataclysm+

(cherry picked from commit 65bad41144)
2021-09-26 23:04:18 +02:00