Commit Graph

25993 Commits

Author SHA1 Message Date
Vincent-Michael
aa0feb41ae Fix typo in MovementStatus (read/write)
todo 6.x use this infos
2015-03-15 04:16:54 +01:00
Vincent-Michael
fb8a169d46 Core/Packets: Added SMSG_TRANSFER_ABORTED / SMSG_TRANSFER_PENDING opcodes for 6.1.0 and enable this 2015-03-15 03:36:45 +01:00
Vincent-Michael
f2cb963565 Core/Packets: Update some opcodes and enable this 2015-03-15 03:09:34 +01:00
Vincent-Michael
d86298cde4 Core/Packets: Update some opcodes and enable this 2015-03-15 02:36:56 +01:00
Vincent-Michael
ae76ee8eca Core/Packets: Enable CMSG_SET_ACTIONBAR_TOGGLES opcode for 6.1.0 2015-03-15 01:44:11 +01:00
Carbenium
c24701523a Merge pull request #14376 from DJScias/opcodes3
Core/Packets: update and enable SMSG_HEALTH_UPDATE
2015-03-15 01:20:36 +01:00
DJScias
e6ad1c46d3 Core/Packets: update and enable SMSG_HEALTH_UPDATE 2015-03-15 00:57:09 +01:00
Duarte Duarte
70364a6b0c Merge pull request #14368 from DJScias/opcodes
Core/Packets: updated and enabled CMSG_QUESTGIVER_ACCEPT_QUEST
2015-03-14 21:43:44 +00:00
Duarte Duarte
1ab186070f Merge pull request #14352 from Luzifix/opcode-2
Core/PacketIO: updated and enabled CMSG_SET_TITLE
2015-03-14 21:43:28 +00:00
DJScias
0d050bb112 Core/Packets: updated and enabled CMSG_QUESTGIVER_ACCEPT_QUEST 2015-03-14 22:17:57 +01:00
Shauren
62f0847ebb Core/Player: Updated sending completed quests data to client 2015-03-14 19:47:07 +01:00
Luzifix
b3a8e13c1e Core/PacketIO: updated and enabled CMSG_SET_TITLE
Thx @DJScias for help
2015-03-14 15:09:44 +01:00
Vincent-Michael
291d23e5f5 Core/PacketIO: Enable some opcodes 2015-03-14 14:33:30 +01:00
Vincent-Michael
d9e4942a75 Core/PacketIO: Sync with wpp 2015-03-15 01:13:46 +01:00
Carbenium
c68449f49e Core/Emote: Fix an issue with EMOTE_STATE_READ, which persisted after closing the map 2015-03-13 22:44:23 +01:00
Vincent-Michael
04020e717c Core/SupportMgr: Fix static analysis issue 2015-03-13 21:12:18 +01:00
MitchesD
8c329aff72 Core/PacketIO: updated and enabled CMSG_CANCEL_CAST 2015-03-13 17:19:33 +01:00
Epicurus4
a860c62fed Core/Loot: Update and enable SMSG_LOOT_RESPONSE
Also correct SMSG_NOTIFICATION initializaiton.
2015-03-12 23:42:26 -04:00
Carbenium
5feee1e69b Merge pull request #14344 from DJScias/opcodes2
Core/Packets: Update & enable more opcodes (names inside)
2015-03-13 01:18:39 +01:00
DJScias
72e549be50 Core/Packets: updated and enabled SMSG_CANCEL_AUTO_REPEAT, SMSG_CANCEL_ORPHAN_SPELL_VISUAL, SMSG_CANCEL_SPELL_VISUAL, SMSG_COIN_REMOVED
Documentation used:
- Updated and enabled the before-mentioned opcodes.
- "SMSG_CANCEL_AUTO_REPEAT" also switched from PackedGuid to ObjectGuid as per @DDuarte's suggestion.
- Changed initial size of "SMSG_SELL_RESPONSE" packet and default initialized SellResult Reason. Thanks @Lordron.

Cleaning up latest commit.
2015-03-13 00:49:44 +01:00
Duarte Duarte
50be8a4f01 Merge pull request #14342 from DJScias/opcodes_emotes
Core/Packets: update & enable CMSG_RANDOM_ROLL, SMSG_RANDOM_ROLL, CMSG_E...
2015-03-12 23:45:01 +00:00
Duarte Duarte
ba2d06a71b Merge pull request #14333 from Naios/static1
Core/Log: Fix some issues detected by static analysis.
2015-03-12 23:43:22 +00:00
jackpoz
1275774646 Revert "Core/SupportMgr: Fix static analysis issue"
This reverts commit 04020e717c.

Initializing a std::string with nullptr is not allowed by C++11 standard
and trigger runtime exceptions.
2015-03-12 21:52:59 +01:00
DJScias
5dddfbdb7b Core/Packets: update & enable CMSG_RANDOM_ROLL, SMSG_RANDOM_ROLL, CMSG_EMOTE, CMSG_TEXT_EMOTE and SMSG_TEXT_EMOTE
Documentation used:
- Enabled CMSG_TEXT_EMOTE and SMSG_TEXT_EMOTE to 6.1
- Changed CMSG_EMOTE from "0x0B2B" to "0x0B2C". It sends an empty packet but it's meant to stop the current emote as per @Zedron's sniffs.
- Updated structure and enabled CMSG_RANDOM_ROLL and SMSG_RANDOM_ROLL. Thanks @rocverde for providing sniffs.

Cleaning up last commit
2015-03-12 16:51:39 +01:00
Epicurus4
ef54ee52e2 Core/Formatting: White space clean-up. 2015-03-12 10:52:46 -04:00
Epicurus4
b306c7c6cf Core/Loot: Enable setting AcquireReason, correct LootMethod definition, fix structure to match sniffs of retail and correct threashold and reason definitions. 2015-03-12 10:39:33 -04:00
Carbenium
ebc226cdac Merge pull request #14343 from DJScias/opcodes1
Core/Packets: updated and enabled SMSG_SELL_RESPONSE
2015-03-11 21:24:29 +01:00
jackpoz
b35578bac3 Revert "Core/Server: Catch exceptions in int main()"
This reverts commit e68ca82d4d.

Closes #14329
2015-03-11 21:07:08 +01:00
DJScias
30bef643fd Core/Packets: updated and enabled SMSG_SELL_RESPONSE
A typo that slipped in, damnit
2015-03-11 20:54:27 +01:00
Carbenium
62e2d8e971 Merge pull request #14334 from Naios/static2
Core/Game: & Core/Scripts: Fix some issues detected by static analysis.
2015-03-11 20:22:46 +01:00
MitchesD
c6718dc120 Core/PacketIO: updated and enabled SMSG_PLAY_MUSIC 2015-03-11 20:04:57 +01:00
Vincent-Michael
3439225f19 Core: Fix build 2015-03-12 19:44:01 +01:00
MitchesD
7b446a28cc Core/PacketIO: updated SMSG_ENVIRONMENTALDAMAGELOG and enabled some opcodes 2015-03-11 16:59:42 +01:00
Naios
1920e9c442 Scripts/Spells: Fix some issues detected by static analysis.
* Prefer prefix ++/-- operators for non-primitive types.
* Variable 'ownerBonus' is reassigned a value before the old one has been used.

* Fix a wrong type of ownerBonus, sometimes it is float sometimes uint32
2015-03-11 09:29:20 +01:00
Naios
9a61049f88 Core/Game: Fix some issues detected by static analysis.
* Possible inefficient checking for 'list' emptiness.

* Variable '_scheduledScripts' is assigned in constructor body.
  Consider performing initialization in initialization list.

* Variable 'Text' is assigned in constructor body.
  Consider performing initialization in initialization list.

* Possible inefficient checking for 'm_loadedScripts' emptiness.
2015-03-11 08:53:13 +01:00
Carbenium
163bd334d0 Core/Packets: Fix packet structure for RideTicket 2015-03-11 08:29:50 +01:00
Naios
8882a6ca78 Core/Log: Fix some issues detected by static analysis.
* Either inefficient or wrong usage of string::find(). string::compare() will
  be faster if string::find's result is compared with 0, because it will not scan the whole string.
  If your intention is to check that there are no findings in the string,
  you should compare with std::string::npos.

* C-style pointer casting detected. C++ offers four different kinds of casts as replacements:
  static_cast, const_cast, dynamic_cast and reinterpret_cast.
2015-03-11 08:20:12 +01:00
Epicurus4
678c307db6 Core/PacketIO: Update a few opcode enums to better match TrinityCore naming conventions. 2015-03-10 22:30:49 -04:00
Carbenium
4b60c137d7 Merge pull request #14169 from Carbenium/ticket-1
Core/Support: Update the support/ticket system to 6.x
2015-03-10 21:26:41 +01:00
Carbenium
37a14bc2d5 Core/Support: Update the support/ticket system to 6.x
Core/Mail: fix a logic error introduced in 829e11b662
2015-03-10 21:09:21 +01:00
Shauren
c8944d73b3 Core/Players: Set holy power decay timer to 20 seconds after leaving combat (also added OnCombatExit hook for stuff like this) 2015-03-10 20:53:29 +01:00
MitchesD
654d7fc7d5 Merge pull request #14327 from DJScias/opcode_emoteclient
Core/Packets: update & enabled CMSG_EMOTE
2015-03-10 18:51:09 +01:00
DJScias
7b9ec7101c Core/Packets: update & enabled CMSG_EMOTE
Documentation Used:
- Thank you @MitchesD for providing some extra information, much appreciated.

Core/Packets: Fix CMSG_EMOTE opcode handler

Documentation used:
- Thanks thumsoul from TC IRC for providing extra information.
2015-03-10 17:47:34 +01:00
MitchesD
47517b2128 Core/PacketIO: updated SMSG_CLEAR_TARGET and enabled some opcodes 2015-03-10 16:29:52 +01:00
Epicurus4
8a5edd1e13 Core/Enum: Fix typo 2015-03-10 10:38:49 -04:00
Carbenium
956c7105a6 Merge pull request #14323 from Carbenium/opcodes-1
Core/PacketIO: Sync with WPP
2015-03-10 09:38:04 +01:00
Carbenium
f107d2999f Core/PacketIO: Sync with WPP 2015-03-10 08:21:22 +01:00
Duarte Duarte
1fd3d03bec Merge pull request #14320 from DJScias/opcodes
Core/PacketIO: enable CMSG_DESTROY_ITEM, CMSG_INSPECT, SMSG_INSPECT_RESU...
2015-03-09 23:44:50 +00:00
DJScias
8c4afd2bcc Core/PacketIO: enable CMSG_DESTROY_ITEM, CMSG_INSPECT, SMSG_INSPECT_RESULT
Documentation used:
- Thanks @rocverde for providing sniffs through TC IRC.
- Each opcode checked and works positively, feel free to apply and check yourself.
2015-03-10 00:01:12 +01:00
Duarte Duarte
337bb8cb67 Merge pull request #14319 from DJScias/opcodes2
Core/Packets: update & enabled CMSG_SHOWING_CLOAK, CMSG_SHOWING_HELM
2015-03-09 22:20:58 +00:00