Commit Graph

26827 Commits

Author SHA1 Message Date
ariel-
aa21137aeb Core/SpellScript: allow optional parameters to be passed to FinishCast
followup of 50a3ce5703
2016-11-14 02:05:54 -03:00
ariel-
cbb5c073ce Core/ScriptMgr: use vector instead of list to contain Spell and Aura scripts and hooks 2016-11-14 02:05:51 -03:00
ariel-
58c5011499 Core/Battleground: Fix issue reported by static analysis 2016-11-14 02:05:48 -03:00
ariel-
c98ab6bd94 Core/Misc: codestyle fixes in GridNotifiers.h
- Removed dead code, outdated comments
- Fixed indentation
- Explicitly delete copy ctors
- const'd the operator() definitions
2016-11-13 19:13:10 -03:00
Killyana
bf5799fce5 DB/Misc: Dark portal Event
Original work: 2f2f8a6110/sql/events/stair_of_destiny.sql
2016-11-13 20:26:53 +01:00
Keader
81edee5648 Core/Scripts: Cleanup in instance_black_temple and added missing datas (#18246)
* Core/Scripts: Cleanup in instance_black_temple and added missing datas

* Fixed door timing issue

* Remove redundant call
2016-11-13 20:23:52 +01:00
Shauren
08057b6d8b Core/Auras: Fixed removing auras triggered by aurastates
Closes #17868

(cherry picked from commit f94e6cee38)
2016-11-13 00:43:13 +01:00
ariel-
83afc5d9f1 DB/Spell: require spellmod consumption for Clearcasting
- Mage, Shaman and Druid flavors

Closes #18240
2016-11-12 18:36:54 -03:00
ariel-
7943150dcb Core/Unit: misc codestyle
use typedef for constant reference
2016-11-12 18:12:26 -03:00
ariel-
3588ff894b Core/Spell: fix warning 2016-11-12 18:04:45 -03:00
ariel-
50a3ce5703 Core/Spell: revamp of immunities system
- Spell attributes research
- Container optimization
- Do not skip damage immunity checks on SPELL_ATTR0_UNAFFECTED_BY_INVULNERABILITY present
- Added additonal arguments support to SendCastResult / CheckCast, spells can now send proper error messages
- Loads spell immune masks/states/effects at startup.
- This cached info is used whenever a spell cast requires immunities to be known beforehand (to see if an aura could be applied for example)

Closes #16658
Closes #16901
Closes #18114
2016-11-12 17:58:00 -03:00
ariel-
5cb8409f1e Core/Spell: move attribute helpers to spellInfo
- Renamed CheckEffectExecuteData to AssertEffectExecuteData and made const, better reflects its purpose
- Added missing attribute check to IsNextMeleeSwingSpell
- Reworked SPELL_ATTR4_CAST_ONLY_IN_OUTLAND attr check (researched behavior)
2016-11-12 17:12:42 -03:00
tkrokli
8c9d061110 DB/gameobject: set positive spawntimesecs for 2 quest objects
176088 Scarlet Crusade Forward Camp (quest 5096 Scarlet Diversions)
180659 Drop-Off Point (for quest 8606 Decoy!)

by offl

Closes #18205
2016-11-12 06:27:01 +01:00
Chaosvex
ed2cd6b34f Core/Auth: Resolved authentication bypass 2016-11-10 23:00:58 +01:00
Keader
c4dd6d1676 Core/Scripts: Fixed a typo and removed randtime of Shade of Akama events (#18231) 2016-11-10 13:00:57 -03:00
ariel-
d8b0a2ecb2 DB/Spell: add attribute for Stoneclaw Totem Effect, should not brask stealth
Closes #18215
2016-11-09 23:51:08 -03:00
ariel-
9822b46995 DB/Spell: Mage armor procs
Closes #18216
2016-11-09 23:31:42 -03:00
ariel-
ff36cfa442 DB/Spell: change phaseMask to finish for Deathchill and Killing Machine
So that they affect Threat of Thassarian'd Frost Strikes
2016-11-09 12:23:01 -03:00
ariel-
bb9fdb1b8a DB/Spell: kill some startup errors 2016-11-09 11:30:57 -03:00
ariel-
70a867531d Core/SpellMgr: overwrite dbc range for Unleashed Souls
Closes #17968

By sirikfoll
2016-11-09 00:58:46 -03:00
ariel-
bb8763534e Core/Spell: reimplemented TRIGGERED_DISALLOW_PROC_EVENTS trigger flag
Triggered spells shouldn't chain-trigger other spells

Closes #18217
2016-11-09 00:39:49 -03:00
ariel-
51bd38a93b DB/Spell: Aspect of the Pack and Aspect of the Cheetah, proc on damage only
Closes #18173
2016-11-08 00:23:18 -03:00
ariel-
8455093708 Rename 2016_11_07_01_world_335.sql to 2016_11_08_00_world_335.sql 2016-11-08 00:10:18 -03:00
ariel-
44ea63e34d Core/Entities: add yet another utility overload to CastSpell, fixes AppVeyor build
Ninja NULL->nullptr cleanup
2016-11-08 00:08:11 -03:00
ariel-
ed49626c22 Core/Spell: fix interaction of on taken damage procs with triggered casts
DB/Spell: Seal of Righteousness proc
- Lightining and Water Shield should proc with triggered

Closes #18211
2016-11-07 23:50:18 -03:00
ariel-
471a8bccc3 DB/Spell: disable LoS checks for Death and Decay damage spell 2016-11-07 20:56:34 -03:00
ariel-
85143f305d Core/Spell: make a distinction between triggered flags with debugging purposes, and don't use them when casting triggered spells
Fixes #9721 (also other spells affected, example Threat of Thassarian, Stormstrike)
2016-11-07 20:36:23 -03:00
ariel-
1ae3da101c Core/Gameobject: remove immune flags from trigger used to cast GO spells
Spells were failing flags check in Unit::_IsValidAttackTarget

Closes #18206
2016-11-07 13:34:04 -03:00
ariel-
555fe2fe5b Core/SpellMgr: add some trap effect range overrides
Ref #18206
2016-11-07 13:31:40 -03:00
ariel-
2e457b3be4 Core/Spells: do not add PROC_HIT_NORMAL/PROC_HIT_CRITICAL flags if damage is fully nullified
- Aka: full absorbs/full resists/full blocks/immune
2016-11-05 01:52:38 -03:00
Dr-J
c70edcfcea DB/SAI: Misc Summon spells
Update some sql scripts to summon creatures via spell instead of just summoning and kill the startup errors caused by my last commit to fix the spells.
2016-11-04 19:02:18 +00:00
ariel-
4f1ef6985e Core/Spell: apply SPELLFAMILY_GENERIC mods to all spells by default
Closes #18160
2016-11-04 14:22:27 -03:00
Killyana
9ac22ef053 DB/Creature: Citadel Watcher 2016-11-04 18:13:51 +01:00
Richard
f5d3343f27 [3.3.5] Core/Loot: Fix conditional Master Loot (#17943)
* Core/Loot: Fix master looting of conditional items

follow_loot_rules was a flag intended to force certain quest items to be
master looted. It should not be used for the
NonQuestNonFFAConditionalLoot.

The flag was originally introduced in 869ea349
"Core/Loot: fix the way quest items are handled. so far ive only found 3
quest items that should be able to be masterlooted. added a new flag to
item_template.flagsCustom to allow for making a quest item always follow
loot rules. a bonus may be the fix of the handlelootmasteropcode crash!"

* Core/Loot: Rename QuestItem to NotNormalItem

QuestItem struct was being used for quest items, ffa items, and
conditional items. Renaming it to avoid confusion when working with ffa
and conditional items

* Core/Loot: Use existing AddAllowedLooter rather than reaching into allowedGUIDs directly

* Core/Loot: Rename NotNormalItem to NotNormalLootItem
2016-11-04 12:20:47 +01:00
ariel-
6214c7181d Core/Player: fix static analysis issue 2016-11-03 23:47:06 -03:00
ariel-
a77c94eb37 DB/Spell: Recklessness & Sweeping Strikes procs
Closes #18191
Closes #18192
2016-11-03 22:43:11 -03:00
ariel-
7a79443281 Core/SpellMgr: static analysis checks 2016-11-03 22:42:34 -03:00
Dr-J
256f6011a6 DB/Misc: Fix a lot of server side summon spells
Fixes Spell_dbc spells: -

Id,Comment
12694,Idol Room Spawn A
12949,Idol Room Spawn End Boss
14801,Idol Room Spawn C
14802,Idol Room Spawn B
16369,Bugs
16370,Maggots
16619,Quest - Temporal Parasite Death Summon
16630,Quest - Temporal Parasite Summon #2
16631,Quest - Temporal Parasite Summon #3
17408,Summon Freed Soul
19826,Summon Blackwing Legionnaire
19827,Summon Blackwing Mage
19828,Summon Death Talon Dragonspawn
20172,Summon Onyxian Whelp
20734,Black Arrow
21110,Summon Son of Flame B
21111,Summon Son of Flame C
21112,Summon Son of Flame D
21113,Summon Son of Flame E
21114,Summon Son of Flame F
21115,Summon Son of Flame G
21116,Summon Son of Flame H
21117,Summon Son of Flame A
21287,Conjure Lokholar the Usurper DND
22803,Dire Maul Trap - Summon
22821,Warpwood Spores
23118,Conjure Scourge Footsoldier DND
23119,Conjure Peasant DND
23121,Conjure Peasant DND
23209,Terrordale Haunting Spirit #2
23253,Terrordale Haunting Spirit #3
24081,Summon Spawn of Mar'li
24215,Create Heart of Hakkar Explosion
24250,Summon Zulian Stalker
24349,Summon Bloodlord's Raptor
25151,Summon Vekniss Drone
25708,Summon Hive'Zara Swarmer
26140,Summon Hook Tentacle
26144,Summon Eye Tentacle
26145,Summon Eye Tentacle
26146,Summon Eye Tentacle
26147,Summon Eye Tentacle
26148,Summon Eye Tentacle
26149,Summon Eye Tentacle
26150,Summon Eye Tentacle
26151,Summon Eye Tentacle
26191,Teleport Giant Hook Tentacle
26216,Summon Giant Hook Tentacles
26396,Summon Portal Ground State
26477,Summon Giant Portal Ground State
26538,Summon Hive'Zara Larva
26539,Summon Hive'Zara Larva
26577,Summon Toxic Slime
26617,Summon Ouro Mound
26768,Summon Giant Eye Tentacles
26837,Summon InCombat Trigger
27178,Defile
27643,Summon Spirit of Jarien
27644,Summon Spirit of Sothos
27690,Summon Bone Minion
27691,Summon Bone Minion
27692,Summon Bone Minion
27693,Summon Bone Minion
27884,Summon Trainee
27921,Summon Spectral Trainee
27932,Summon Spectral Knight
27939,Summon Spectral Rivendare
28008,Summon Knight
28010,Summon Mounted Knight
28175,(DND) Summon Crystal Minion, Ghost
28177,(DND) Summon Crystal Minion, Skeleton
28179,(DND) Summon Crystal Minion, Ghoul
28217,Summon Zombie Chow
28227,(DND) Summon Crystal Minion, finder
28289,(DND) Summon Crystal Minion, Ghoul Uncommon
28290,(DND) Summon Crystal Minion, Ghost Uncommon
28291,(DND) Summon Crystal Minion, Skeleton Uncommon
28421,Summon Type A
28422,Summon Type B
28423,Summon Type C
28454,Summon Type D
28561,Summon Blizzard
28627,Summon Web Wrap
29141,Marauding Crust Borer
29218,Summon Flame Ring
29329,Summon Sapphiron's Wing Buffet
29434,Summon Maexxna Spiderling
29508,Summon Crypt Guard
29857,Summon Astral Spark
30076,Summon Maexxna Spiderling
30083,Summon Root Thresher
30236,Summon Astral Flare NE
30239,Summon Astral Flare NW
30240,Summon Astral Flare SE
30241,Summon Astral Flare SW
30630,Debris
30737,Summon Heathen
30785,Summon Reaver
30786,Summon Sharpshooter
30792,Summon Ravager Ambusher
30825,Summon Siltfin Ambusher
30826,Summon Wildkin Ambusher
30827,Summon Bristlelimb Ambusher
30828,Summon Sunhawk Ambushers
30954,Free Webbed Creature
30955,Free Webbed Creature
30956,Free Webbed Creature
30957,Free Webbed Creature
30958,Free Webbed Creature
30959,Free Webbed Creature
30960,Free Webbed Creature
30961,Free Webbed Creature
30962,Free Webbed Creature
30963,Free Webbed Creature
30976,Summon Gauntlet Guards
31010,Free Webbed Creature
31318,Summon Infinite Assassin
31321,Summon Black Morass Rift Lord
31374,Summon Netherstorm Backlash
31391,Summon Black Morass Chrono Lord Deja
31392,Summon Black Morass Temporus
31393,Summon Black Morass Rift End Boss
31421,Summon Infinite Chronomancer
31528,Summon Gnome
31529,Summon Gnome
31530,Summon Gnome
31544,Summon Distiller
31545,Summon Distiller
31593,Summon Greater Manawraith
31995,Shattered Rumbler
32114,Summon Wisp
32151,Infernal
32283,Focus Fire
32360,Summon Stolen Soul
32579,Portal Beam
32632,Summon Overrun Target
33121,A Vision of the Forgotten
33229,Wrath of the Astromancer
33242,Infernal
33362,Summon Astromancer Adds
33363,Summon Infinite Executioner
33364,Summon Infinite Vanquisher
33367,Summon Astromancer Priest
33495,Summon Random Tractor
33514,Summon Random Tractor
33515,Summon Random Tractor
33516,Summon Random Tractor
33517,Summon Random Tractor
33518,Summon Random Tractor
33519,Summon Random Tractor
33520,Summon Random Tractor
33567,Summon Void Portal D
33636,Infernal
33677,Incite Chaos
33680,Incite Chaos
33681,Incite Chaos
33682,Incite Chaos
33683,Incite Chaos
33901,Summon Crystalhide Crumbler
33927,Summon Void Summoner
34064,Soul Split
34125,Spotlight
34175,Arcane Orb Primer
34810,Summon Mender 1
34817,Summon Reservist 1
34818,Summon Reservist 2
34819,Summon Reservist 3
35127,Summon Boom Bot Target
35128,Summon Boom Bot
35130,Summon Boom Bot
35136,Summon Captured Critter
35142,Drijya Summon Imp
35145,Drijya Summon Doomguard
35146,Drijya Summon Terrorguard
35153,Summon Nether Charge NE
35256,Summon Unstable Mushroom
35430,Infernal
35687,Summon Seeping Sludge Globule
35688,Summon Void Waste Globule
35737,Summon Deadsoul Orb
35861,Summon Nether Vapor
35862,Summon Nether Vapor
35863,Summon Nether Vapor
35864,Summon Nether Vapor
35904,Summon Nether Charge NW
35905,Summon Nether Charge SE
35906,Summon Nether Charge SW
35937,Summon Ambush
36026,Conjure Elemental Soul: Earth
36036,Summon Netherstorm Target
36042,Summon Farahlon Crumbler
36043,Summon Farahlon Crumbler
36044,Summon Farahlon Crumbler
36045,Summon Farahlon Shardling
36046,Summon Farahlon Shardling
36047,Summon Farahlon Shardling
36048,Summon Motherlode Shardling
36049,Summon Motherlode Shardling
36050,Summon Motherlode Shardling
36112,Conjure Elemental Soul: Fire
36168,Conjure Elemental Soul: Water
36180,Conjure Elemental Soul: Air
36221,Summon  Eye of the Citadel
36229,Summon Infinite Assassin
36231,Summon Infinite Chronomancer
36232,Summon Infinite Executioner
36233,Summon Infinite Vanquisher
36234,Summon Black Morass Rift Lord Alt
36235,Summon Black Morass Rift Keeper
36236,Summon Black Morass Rift Keeper
36379,Call Skitterers
36521,Summon Arcane Explosion
36579,Summon Netherock Crumbler
36584,Summon Netherock Crumbler
36585,Summon Netherock Crumbler
36595,Summon Apex Crumbler
36596,Summon Apex Crumbler
36597,Summon Apex Crumbler
36724,Summon Phoenix Egg
36818,Attacking Infernal
36865,Summon Gnome Cannon Channel Target (DND)
37177,Summon Black Morass Infinite Chrono-Lord
37178,Summon Black Morass Infinite Timereaver
37394,Summon Destroyed Sentinel
37457,Windsor Dismisses Horse DND
37545,Summon Phantom
37606,Summon Infinite Assassin
37735,Summon Inner Demon
37758,Bone Wastes - Summon Auchenai Spirit
37766,Summon Murloc A1
37772,Summon Murloc B1
37773,Summon Elemental A1
37774,Summon Elemental B1
37911,Summon Elemental A2
37912,Summon Elemental A3
37914,Summon Elemental B2
37916,Summon Elemental B3
37923,Summon Murloc A2
37925,Summon Murloc A3
37926,Summon Murloc A4
37927,Summon Murloc A5
37928,Summon Murloc B2
37929,Summon Murloc B3
37931,Summon Murloc B4
37932,Summon Murloc B5
37947,Summon Crazed Shardling
37948,Summon Crazed Shardling
37949,Summon Crazed Shardling
38019,Summon Wave A Mob
38111,Summon Horde Bat Rider Guard
38114,Summon Horde Rooftop Alarm Sensor
38118,Summon Area 52 Death Machine Guard
38124,Summon Horde Ground Alarm Sensor
38137,Summon Sky Marker
38179,Summon Alliance Ground Alarm Sensor
38180,Summon Alliance Rooftop Alarm Sensor
38181,Summon Alliance Gryphon Guard
38188,Summon Corrupted Spawn
38189,Summon Corrupted Spawn
38190,Summon Corrupted Spawn
38191,Summon Corrupted Spawn
38198,Summon Purified Spawn
38199,Summon Purified Spawn
38200,Summon Purified Spawn
38201,Summon Purified Spawn
38242,Summon Wave C Mob
38244,Summon Wave D Mob
38247,Summon Wave B Mob
38261,Summon Area 52 Rooftop Alarm Sensor
38266,Summon Stormspire Ethereal Guard
38268,Summon Scryer Dragonhawk Guard
38270,Summon Stormspire Rooftop Alarm Sensor
38271,Summon Scryer Rooftop Alarm Sensor
38278,Summon Aldor Gryphon Guard
38283,Summon Aldor Rooftop Alarm Sensor
38286,Summon Sporeggar Sporebat Guard
38287,Summon Sporeggar Rooftop Alarm Sensor
38288,Summon Toshley Guard
38291,Summon Toshley Rooftop Alarm Sensor
38402,Summon Cenarion Storm Crow Guard
38403,Summon Cenarion Expedition Rooftop Alarm Sensor
38489,Summon Wave E Mob
38490,Summon Wave E Mob
38492,Summon Wave E Mob
38493,Summon Wave E Mob
38512,Fiery Boulder
38587,Summon Spirit of Redemption
38651,Summon Rancid Mushroom
38854,Hatch Arakkoa
38865,Hatch Bad Arakkoa
38874,Summon Mushoom Creature
38888,Summon Morcrush Shardling
38889,Summon Morcrush Shardling
38890,Summon Morcrush Shardling
39080,Summon Mountain Shardling
39081,Summon Vortex Shardling
39110,Summon Phoenix Adds
39111,Summon Furious Nether-wraith
39186,Summon Random Tractor
39191,Sha'tari Flames
39302,Quest - The Exorcism, Summon Foul Purge
39305,Summon Flying Skull
2016-11-03 22:00:21 +00:00
treeston
aeb5762170 Core/Creature: Correctly reset pathfinding capability on respawn. Prevents evade chains on some bosses. Closes #18188. 2016-11-03 13:55:30 +01:00
ariel-
c428931860 DB/Spell: Maelstrom Weapon charge drop on cast
Closes #7068 (Again :P)
2016-11-03 03:06:24 -03:00
ariel-
ca1a050e8a Core/Globals: normalize DBC data for Maelstrom Weapon ranks 2016-11-03 03:06:23 -03:00
tkrokli
2b26894eb1 Core/Scripts: Archmage Arugal event script (#17922)
Implement boss script for Archmage Arugal
- add yells used in boss event to DB
- use proper spells instead of only melee fighting
- add DataType in shadowfang_keep.h
- add event scheduling in the script

By Riztazz
Closes issue #17916
2016-11-03 06:50:03 +01:00
ariel-
a94b8c83e2 DB/Spell: Savage Combat proc
Closes #16242
2016-11-02 22:27:06 -03:00
Killyana
ee52ba690d DB/Spell: Earthgrab Totem
http://www.wowhead.com/spell=8378/earthgrab-totem used by http://www.wowhead.com/npc=6066/earthgrab-totem
2016-11-02 18:30:17 +01:00
Killyana
7e07d99308 DB/Gameobject: Add two missing game object
Closes #18187
2016-11-02 18:14:11 +01:00
Killyana
322f1910fc DB/Creature: Earthgrab Totem and Tainted Earthgrab Totem
Closes #15651
2016-11-02 04:22:55 +01:00
Killyana
101b74b8b4 DB/SAI: Bloodscalp Beastmaster, Skullsplinter Beastmaster and Skullsplitter Hunter
Closes #18179
Closes #18185
By Staleness89
2016-11-02 03:25:24 +01:00
Killyana
b31eca151d DB/Event: Fix Day of the Dead spawns 2016-11-01 22:34:44 +01:00
SnapperRy
a38c094a11 Core/GameObject: spawn linked traps at gameobject creation instead of using DB spawns. (#18172)
Closes #11328.
2016-11-01 22:24:03 +01:00
Dr-J
1fc8e2d5f2 Remove reference to eastern plaguelands script 2016-11-01 13:10:16 +00:00