Commit Graph

25975 Commits

Author SHA1 Message Date
Seyden
b1eb4c2b3e Scripts/Spells: Implement Demon Hunter Base Spell "Glide" 2021-11-20 15:51:02 +01:00
Seyden
adb439fdfe Scripts/Spells: Predefine spell ids used for DH scripts 2021-11-20 15:51:02 +01:00
Seyden
e4630c5354 Core/Movement: Temporarily disable "no state change" checks in Unit::SetFeatherFall and Unit::SetCanTurnWhileFalling
Co-authored-by: Shauren <shauren.trinity@gmail.com>
2021-11-20 15:51:02 +01:00
Shauren
0175371730 Nopch build fix 2021-11-20 01:56:55 +01:00
Shauren
8cc6520b89 Core/Spells: SpellHistory updates
* Add duration override argument to StartCooldown (for cooldowns sent to client)
* Research new SMSG_SPELL_COOLDOWN flags
* Send interrupt school lockouts with newly defined SPELL_COOLDOWN_FLAG_LOSS_OF_CONTROL_UI
* Fixed packet structure of SMSG_MODIFY_COOLDOWN
* std::chorno-ification
2021-11-20 00:28:48 +01:00
acidmanifesto
d4d47b52e3 Core/Misc: Corrected function name in log message (#27288) 2021-11-19 20:07:07 +01:00
Meji
895367e69f Core/BattlePets: Journal lock improvements (#27178)
Co-authored-by: Shauren <shauren.trinity@gmail.com>
2021-11-19 15:37:21 +01:00
Meji
12cc779ab0 Core/BattlePets: BattlePetError enum class (#27286) 2021-11-19 14:01:22 +01:00
Shauren
f97deb3316 Core/Quests: Fixed loading quest greeting locales
Closes #27292
2021-11-19 13:54:32 +01:00
Rynem Storm
c7ad7d5e15 DB/Spell: fix mistake in Blood Draining's CheckProc and remove Attack Power scaling (#22862)
(cherry picked from commit a057d26f20)
2021-11-18 23:04:07 +01:00
Shauren
f24e16a460 Core/Spells: Fixed crash with some gameobject spell casters
(cherry picked from commit 755133d860)
2021-11-18 23:03:14 +01:00
Killyana
7fe844a1e8 Quest/Script: Kodo Roundup
Fix faction issue and handle the gossip correctly via the script

(cherry picked from commit 5e73647c84)
2021-11-18 22:58:52 +01:00
Giacomo Pozzoni
fff0d174aa Scripts/Misc: Fix LoadMinionData() dynamic analysis issues
Fix issues reported by Address Sanitizer about LoadMinionData() calls on arrays that don't end with a {0, 0} pair.

(cherry picked from commit 08dcee0cf9)
2021-11-18 22:53:21 +01:00
Keader
33a2d627dd Core/Spell: Fixed some negative spells showing as positive
Closes #22840
Revert 9ecce33192 and 7611242530
Update #22757

(cherry picked from commit a0de602d38)
2021-11-18 22:48:34 +01:00
Shauren
ba2586c92f Core/Spells: Fixed unapplying rockbiter weapon
Closes #22528

(cherry picked from commit f93a23adc5)
2021-11-18 22:41:57 +01:00
Keader
dd067390dc Scripts/Icecrown Citadel: Some fixes for Valithria Dreamwalker's encounter
Closes #22754 #21887 #17882
Ty sirikfoll for all help
Bonus fixes: Abomination letting worms when fight end, visual missing, archmages stop respawn if corpse despawn

(cherry picked from commit dd81978f43)
2021-11-18 22:41:57 +01:00
DanVS
3b1ed434ae Core/Scripts: Move some spells to scripts (#22332)
(cherry picked from commit 8051ff13df)
2021-11-18 22:41:57 +01:00
PolarCookie
19646a8363 That's Abominable for the 3 other quests, and knockbacks for all. (#22127)
(cherry picked from commit fb19f7be1f)
2021-11-18 22:41:57 +01:00
Keader
748e8463c7 Core/Spells: Malleable Goo need be negative
Closes #22757

(cherry picked from commit 9ecce33192)
2021-11-18 22:41:57 +01:00
Ghaster
f4d029b952 Core/Creature: Profession trainer fixes (PR #22904)
Closes #22903

(cherry picked from commit 19791a35df)
2021-11-18 22:41:57 +01:00
Keader
c4eed6561c Scripts/The Steamvault: Fixed Chambers Access Panel and Main Chambers Door
Closes #21067
Ty Kittnz, killerwife, Aokromes (sniffs)

(cherry picked from commit b283565d8a)
2021-11-18 22:41:55 +01:00
jackpoz
0b556d8a91 Core/Handlers: fix ".whisper on" with opposite faction/low level
Closes #22283

(cherry picked from commit f11117584d)
2021-11-18 15:59:31 +01:00
Giacomo Pozzoni
ff2cd4a032 Scripts/Commands: Fix crash caused by .set npc model (#22877)
* Scripts/Commands: Fix crash caused by .set npc model

Fix crash caused by .set npc model with invalid model id

(cherry picked from commit 20ea24bf5c)
2021-11-18 15:57:20 +01:00
Shauren
ce794f3978 Core/Spells: Fixed ErrorCube spell missiles
(cherry picked from commit 3b5014fdae)
2021-11-18 01:10:19 +01:00
PolarCookie
fa07f74db2 Spell/Script: Scourge Disguise and Haunting Phantoms (#22727)
(cherry picked from commit 66720e5fd9)
2021-11-16 22:00:58 +01:00
Shauren
3ba2547ec0 Core/Trainers: Remove unused define 2021-11-16 21:37:53 +01:00
Shauren
f8dc4da282 Core/Players: Partial port of baebb2d602 (just packet sending function)
(cherry picked from commit baebb2d602)
2021-11-16 21:35:11 +01:00
Treeston
549d5fea31 Core/Utils: some code style adjustments, 6d6077e follow-up
(cherry picked from commit 4c3af3b636)
2021-11-16 21:05:35 +01:00
Treeston
4f8fd56903 Core/Utils: Fix Unicode handling
(cherry picked from commit 6d6077e36f)
2021-11-16 21:04:53 +01:00
Giacomo Pozzoni
4177030dcf Scripts/Nagrand: Fix crash added in PR #22806 (#22878)
Fix crash added in PR #22806 happening in quest "Ruthless Cunning and Returning the Favor"

(cherry picked from commit cb13638721)
2021-11-16 21:04:05 +01:00
Shauren
9be92e218c Core/PacketIO: Fixed SMSG_BATTLE_PET_ERROR structure 2021-11-16 20:54:15 +01:00
Shauren
f3c1b27c26 Core/Units: Fixed crash happening when charm was removed by its own charmed AI during update
(cherry picked from commit c7445669e8)
2021-11-16 20:40:05 +01:00
jackpoz
9dcbccce26 Core/Misc: Fix vsnprintf usage in ASSERT()
Fix vsnprintf to follow standard definition and not some old VC++ behavior, not requiring to include the '\0' character in the count parameter

(cherry picked from commit eee1f2cadf)
2021-11-16 20:37:27 +01:00
Giacomo Pozzoni
d5c41d23e6 Core/Misc: Log more information in asserts (#22783)
* Core/Misc: Log more information in asserts

Add a new function GetDebugInfos() to types that could trigger an ASSERT() to easily include more useful information in crashlogs.
This is an initial commit that requires many more commits to implement the new GetDebugInfos() function in all required types.
If the type doesn't have the function, the global default one is picked which doesn't log anything.

* Core/Misc: Fix dynamic build

Add missing attribute for dynamic build

* Core/Misc: Fix gcc/clang build

* Core/Misc: Rename GetDebugInfos() to GetDebugInfo()

* Core/Misc: Fix FormatAssertionMessage() adding an extra '\0'

* Core/Misc: Add GetDebugInfo support to Unit

* Core/Misc: Add GetDebugInfo support to Creature

* Core/Misc: Add more info to GetDebugInfo for Creature

* Core/Misc: Add GetDebugInfo support to GameObject

* Core/Misc: Add GetDebugInfo support to Player

* Core/Misc: Add more GetDebugInfo info

* Core/Misc: Add GetDebugInfo support to Item

* Core/Misc: Add GetDebugInfo support to Bag

* Core/Misc: Add GetDebugInfo support to Transport

* Core/Misc: Add GetDebugInfo support to TempSummon, Minion, Guardian, Pet

* Core/Misc: Add GetDebugInfo support to Map, InstanceMap

* Core/Misc: Add GetDebugInfo support to Spell

* Core/Misc: Fix build warning

* Core/Misc: Add GetDebugInfo support to Aura

* Core/Misc: Add GetDebugInfo support to UnitAI

(cherry picked from commit 9a924fb9d5)
2021-11-16 20:36:58 +01:00
Treeston
5b45253f57 Core/Misc: Explicit typing for SpellAttrN enums, add nicer text to UNKs, and restore some relevant info from old comments. Final one of these.
(cherry picked from commit 3acba6dded)
2021-11-16 19:52:57 +01:00
Shauren
b981606575 Core/PacketIO: Fixed SMSG_LEVEL_UP_INFO structure 2021-11-16 15:53:40 +01:00
Meji
a832435b97 Core/Spells: Implemented SummonPropertiesFlags: UseSummonerFaction & IgnoreSummonerPhase (#27273) 2021-11-16 11:51:05 +01:00
Aokromes
8967f9ccf2 Update zone_borean_tundra.cpp
(cherry picked from commit 6851ba638d)
2021-11-16 00:52:24 +01:00
PolarCookie
f377dc23f3 Quest: Ruthless Cunning and Returning the Favor (#22806)
* Ruthless Cunning and Returning the Favor

* no more magic numbers

* now with scripted ai and condition

* travis

* more travis

* jackpoz

* now with no banner spellscripts

* typo

* Rename 9999_99_99_99_world.sql to 2018_12_03_00_word.sql

(cherry picked from commit 9d93504f34)
2021-11-16 00:51:51 +01:00
Aokromes
c44650502c Core/GameEvent: weekend xp rate (#17782)
* Core/GameEvent: weekend xp rate
by kline

* Update to recent code

* compile fix try
things of copy and paste 4 years old code xd

* more code update

* forgot to change this

* Update worldserver.conf.dist

* Added function to calculate weekend event xp rates

By greenbagels

* Cleaning using scripts

* Implement daymask and rename variables etc.

* Rename script file weekend -> boosted

* Update src/server/game/World/World.cpp

Co-Authored-By: Aokromes <Aokromes@users.noreply.github.com>

* Fix xp multiplier not applying to quest rewards

* Disable xp boost script when no boosted days selected

(cherry picked from commit 538c5b8687)
2021-11-16 00:50:23 +01:00
Shauren
a0de41af69 Core/Misc: Update description text for SpellAttr8-14 2021-11-16 00:38:33 +01:00
Treeston
65dc3d18e0 Core/Misc: Update description text for SpellAttr6 and SpellAttr7
(cherry picked from commit cd7b036485)
2021-11-16 00:22:08 +01:00
Treeston
b76daf0bc7 Core/Misc: Update description text for SpellAttr5 (I'm back, baby!)
(cherry picked from commit 9309988a05)
2021-11-16 00:13:07 +01:00
Gildor
4a775c01e9 Core/Scripts - The Eye: Fix Kael'thas Sunstrider Mind Control, limit MaxAffectedTargets to 3 (#22828)
Closes: #22826
(cherry picked from commit 0ee8a77dce)
2021-11-16 00:07:15 +01:00
Ovah
234a680d3a Core/Objects: properly use UPDATETYPE_CREATE_OBJECT2 when creating brand new objects in all cases. Closes #22419 (#22816)
(cherry picked from commit fb1d568fba)
2021-11-15 23:42:22 +01:00
Treeston
058f0edd86 Core/Misc: Update description text for SpellAttr4
(cherry picked from commit 8836fc3903)
2021-11-15 23:39:29 +01:00
Treeston
8464079ab8 Core/Misc: Update description text for SpellAttr3
(cherry picked from commit 50f78e686c)
2021-11-15 23:33:18 +01:00
Treeston
da68d7a191 Core/Misc: Update description text for SpellAttr2
(cherry picked from commit 9b4feaacfa)
2021-11-15 23:24:02 +01:00
Treeston
43d3d5bbb3 Core/Misc: Update description text for SpellAttr1
(cherry picked from commit 8cac5feb58)
2021-11-15 23:20:38 +01:00
Treeston
fe9ca742a3 Core/Misc: Update description text for SpellAttr0 to match actual behavior
(cherry picked from commit b69ee07d50)
2021-11-15 23:08:46 +01:00