Commit Graph

4521 Commits

Author SHA1 Message Date
Nay
b30aeb8d51 Core/Objects: Method to get nearest GO of type X, FindNearestGameObjectOfType
Thanks Subv for the idea
2012-09-08 23:16:35 +01:00
Subv
7dbc20626e Core/Entities: Fixed GameObject::FindNearestX for objects with the same coordinates.
closes #4581
2012-09-08 15:24:59 -05:00
Shocker
d33259e84e Core/Spells: Remove incorrect usage of SPELL_ATTR0_NEGATIVE_1 in CanDispelAura (which is used in SPELL_AURA_SCHOOL_IMMUNITY handling)
Closes #5940
2012-09-08 20:29:03 +03:00
Subv
cfd11b490b Core/Items: Fixed items with ITEM_MOD_BLOCK_VALUE ( Increases the block value of your shield by X )
Closes #716
2012-09-08 12:21:31 -05:00
Kiddie
9a962f86c9 Core\Characters: Consecutive letters validation for CheckPlayerName
Closes #7694
2012-09-08 17:29:27 +01:00
Subv
f9fdf03ec2 Core/Spells: Corrected Glyph of Blessing of Might and Glyph of Blessing of Wisdom.
They should not affect Greater Blessing of Might and Greater Blessing of Wisdom.
2012-09-08 07:59:21 -05:00
Subv
be181b2ccd Core/Spells: Use the UNIT_FIELD_CHANNEL_OBJECT field instead of Spell::m_targets to select the channel targets of a triggered spell.
Closes #7246
2012-09-08 07:51:57 -05:00
Nay
7532013b27 Fix a typo in SmartScript.cpp
I blame vincent!
2012-09-08 02:15:38 +02:00
Vincent-Michael
9fc30476ed Core/Spells: Fix Flash of Light proc only for Infusion of Light
Closes: #6274
2012-09-08 02:01:34 +02:00
Santiago
e3b9b15779 Core/SAI: Implement SMART_ACTION_SET_HOME_POS (101)
No parameters; allowed targets: self and position

Closes #7689
2012-09-08 00:55:47 +01:00
Subv
527ac7437d Core/Units: Check if a quest is disabled first in Player::CanTakeQuest before doing further checks.
closes #7654
2012-09-07 17:09:22 -05:00
Subv
20ca59fbc7 Core/Spells: Allow more aura types to use spell_group_stack_rules data. 2012-09-07 17:04:13 -05:00
Vincent-Michael
617f9e8fe8 Core/World: Fix AutoBroadcast time refresh with reload 2012-09-07 23:34:17 +02:00
w1sht0l1v3
15a9d4ddee Code/Dungeon Finding: Update Role Check timer to blizzlike interval(40 seconds).
Closes #6781.
2012-09-07 18:47:27 +03:00
Kiddie
c76a10d979 Core/SkillHandler: Fix exploit when sending modified values in CMSG_UNLEARN_SKILL
Closes #7663
2012-09-07 14:17:17 +02:00
kaelima
d0f4526d71 Core/Vehicle: Improved the position fix when changing vehicle from 5eb22e5b64
Thanks Shauren
2012-09-07 14:00:24 +02:00
Nay
21d43781ac Tabs to spaces... 2012-09-07 03:33:16 +01:00
kaelima
f685e9fb2a Core/Vehicle: Correction to 5eb22e5b64. Thanks joschiwald (and slap some others) for noticing 2012-09-07 03:31:46 +02:00
kaelima
5eb22e5b64 Core/Vehicles:
- Send proper triggering flag when casting spellclick spells on vehicles (should not be fully triggered)
- Only compute non-transport positions when not finalized. (Fixes changing seat on vehicles, or changing vehicle from vehicle)
2012-09-07 03:17:04 +02:00
Vincent-Michael
6f38fb1011 Core: Fix some code style 2012-09-07 02:21:38 +02:00
cyberbrest
aed0ecd2e4 Core/Conditions: Allow multiple condition for spellclick source type
Currently unused in 335 but required for some 434 spellclicks
2012-09-06 20:03:21 +01:00
Nay
340dc33b52 Fix some code style issues in previous PR merge 2012-09-06 19:59:27 +01:00
Nay
334c078184 Core/SmartAI: Tiny tiny optimization in an if 2012-09-06 19:58:43 +01:00
Nay
c66d254a39 Merge pull request #7658 from e000/creature-interrupt
[Core, Creature] Implement Creature/Pet Interrupts
2012-09-06 11:58:27 -07:00
Vincent-Michael
9f09713b3e Core/Spells: fix extra damage from crits for talents and equipment effects Closes #6647 2012-09-06 11:14:37 -04:00
tobmaps
fb3a360575 Core/Spells: fix intervening dead targets Closes #2090 2012-09-06 11:05:45 -04:00
Vincent-Michael
5954011a90 Core/Spells: clean up some code and move to spell script. Closes #7195 2012-09-06 11:00:37 -04:00
kaelima
bf84a0a97a Core/Misc: Fix typo from 7c971be3c5. Thanks Shauren 2012-09-05 17:34:25 +02:00
kaelima
7c971be3c5 Core/Misc: Fix some warnings and logic mistakes found by static code analysis 2012-09-05 17:18:05 +02:00
w1sht0l1v3
68a54e6d91 Core/SAI: Add condition to run SMART_ACTION_SET_INVINCIBILITY_HP_LEVEL code 2012-09-05 14:04:09 +03:00
e
89d6900f4b [CombatAI::SpellInterrupted] Fix Typo 2012-09-05 01:48:25 -04:00
e
98f5d4ef4a [Core, Creature] Implement Creature/Pet Interrupts 2012-09-04 23:04:59 -04:00
e
f9a1fabc7b [Spell::CleanupEffectExecuteData] Remove this confusing and potentially worthless function, use memset instead. 2012-09-04 22:38:59 -04:00
w1sht0l1v3
50cea6638b Core/SAI: Fix SMART_ACTION_SET_INVINCIBILITY_HP_LEVEL
Proper usage of params:
-param1: flat hp value
-param2: percent hp value
Note: only one of these params should be used(in case you set values in both,the script will chose percent)
2012-09-05 04:53:06 +03:00
kaelima
b8d55cc019 Core/BG: Refix cf711ffbe5 Thanks Kiddie 2012-09-05 00:08:22 +02:00
Shocker
ed6b58b17d Core/Spells: Avoid unnecessary code execution for SPELL_ATTR3_NO_DONE_BONUS 2012-09-05 00:13:43 +03:00
Vincent-Michael
de15f70501 Core: Fix build 2012-09-04 22:39:04 +02:00
kaelima
cf711ffbe5 Core/BG: Prevent players from using macro to exploit leaving BG queues when they already have entered.
- Cleanup and add some comments to MSG_BATTLEGROUND_PLAYER_POSITIONS
Closes #7633
2012-09-04 22:37:27 +02:00
Nay
b4bc78e24b Corrections to previous merged in PR 2012-09-04 19:48:29 +01:00
Nay
0ba06342dc Merge pull request #7644 from e000/master
[Unit::SetCharm] Restore original walking state when removing charm. Fixes mind control + walk bug.
2012-09-04 11:46:11 -07:00
Kandera
8afecc6572 Core/Gameobject: fix collision for gameobjects 2012-09-04 14:04:47 -04:00
e
1695f78c9f Fix codestyle per Vincent-Michael 2012-09-04 13:04:30 -04:00
e
1e2ee2d680 [Unit::SetCharm] Restore original walking state when removing charm. Fixes mind control + walk bug. 2012-09-04 13:00:08 -04:00
Vincent-Michael
a4c115a494 Core: Fix build 2012-09-04 18:21:00 +02:00
Kandera
26af8ac65a Core/Gameobject: another attempt at fixing collision. chest gameobject initial collision provided by vincent-michael 2012-09-04 12:08:12 -04:00
Nay
73172c67f0 Misc: Convert from CRLF to LF in cs_misc.cpp
Also cleanedup whitespace
2012-09-04 16:14:15 +01:00
Kandera
a1e3758484 Core/Reputation: fix forced reputation auras with neutral. closes #5790 2012-09-04 11:11:15 -04:00
Kandera
6d57bf7a75 Core/Battleground: fix unneeded log message 2012-09-04 11:11:14 -04:00
kaelima
a3f9eee4e5 Core/Spells: Fix memory leak when Load() fails from spell/aura-scripts 2012-09-04 17:03:30 +02:00
Shauren
1e9fc84a12 Core: Warning fixes
C4100: 'x' : unreferenced formal parameter
C4310: cast truncates constant value
C4389: '==' : signed/unsigned mismatch
C4668: 'x' is not defined as a preprocessor macro, replacing with '0' for '#if/#elif'
C4701: potentially uninitialized local variable 'x' used
C4826: Conversion from 'HMODULE' to 'DWORD64' is sign-extended. This may cause unexpected runtime behavior.
C6067: Parameter '3' in call to 'sprintf' must be the address of the string
C6387: 'argument 1' might be '0': this does not adhere to the specification for the function 'CloseHandle'
2012-09-04 14:40:41 +02:00