Commit Graph

32778 Commits

Author SHA1 Message Date
Golrag
b8c8dcdbfc Core/Object: Fix Line of Sight issue with object edges
Fixes: https://github.com/TrinityCore/TrinityCore/pull/15807#issuecomment-268077802
(cherry picked from commit 020a6b984d)
2020-04-24 17:18:48 +02:00
jackpoz
bfcb276781 Core/Crash: Refactor and fixes
Code cleanup.
Fix buffer overflow crash.
Fix type being truncated to 199 characters.

(cherry picked from commit 9226e21205)
2020-04-24 17:18:48 +02:00
ariel-
6098c4549c Core/Spell: add assert checks on SpellMgr::CheckSpellGroupStackRules
Ref #19319

(cherry picked from commit 36bb4cabae)
2020-04-24 17:18:48 +02:00
Killyana
8b8b6bf319 DB/Creature: Doctor Razorgrin
(cherry picked from commit 957d3cda1e)
2020-04-24 17:18:48 +02:00
ariel-
053d0cfda5 Core/Pet: load template immunities when creating (except for hunters)
Fixes #19275

(cherry picked from commit e33263c677)
2020-04-24 17:18:48 +02:00
ariel-
c16cebca64 Core/Unit: properly reset displayIds when having a shapeshift aura active
Closes #19309

(cherry picked from commit 7a38eaa5a1)
2020-04-24 17:18:48 +02:00
Aokromes
dbb21ea844 DB/Misc: Fix startup errors / typo fix
(cherry picked from commit 3d43a92fb3)
2020-04-24 17:18:48 +02:00
ariel-
1536f01a74 Core/Quests: fixed exclusivegroup interaction with prevquestId and nextQuestId.
- They should work as documented by wiki now.
- Add some consts to Player methods
- Fixed negative PrevQuestID to mean only active quest (ie not rewarded/complete, as those quests are required to complete another)

Closes #19300

(cherry picked from commit 3b27a06265)
2020-04-24 17:18:48 +02:00
ariel-
c03373c59f Core/Quests: changed quest_template_addon.NextQuestID to unsigned
- No reason to keep this anymore after 4349adf0f2, this is a broken functionality.

(cherry picked from commit dca276716f)
2020-04-24 17:18:48 +02:00
ariel-
feb8205d6a Core/Globals: some changes in quest loading
- Made load/reload associated quest tables data-driven, so removed a bunch of similar looking code from ObjectMgr (yay!)
- Codestyle and encapsulation for ExclusiveQuestGroups

(cherry picked from commit 076293f1f2)
2020-04-24 17:18:48 +02:00
ariel-
4472a3cbf3 Core/Globals: Fix Quest codestyle and member variable initialization
(cherry picked from commit 09701b0229)
2020-04-24 17:18:48 +02:00
ariel-
a098b454b8 Core/Entities: virtualize CheckAttackFitToAuraRequirement
- Should've been like this to begin with

(cherry picked from commit 21d95a1d76)
2020-04-24 17:18:47 +02:00
Killyana
f793a43cee DB/Creature: Fix a type on creature text related to Lord Thorval
Ref 80a0c3cfc7

(cherry picked from commit 63236f97af)
2020-04-24 17:18:47 +02:00
ariel-
5979f4f396 Core/Auras: fix more unused parameter warnings
(cherry picked from commit 7de5befbc3)
2020-04-24 17:18:47 +02:00
ariel-
1c4b1ba498 Core/Auras: fix comparison of integers of different signs warning
(cherry picked from commit 9047d8bd6f)
2020-04-24 17:18:47 +02:00
ariel-
e39ea201ce Core/Auras: fix unused parameter warning
(cherry picked from commit 40489b8d57)
2020-04-24 17:18:47 +02:00
ariel-
ebc06b1d04 Core/Auras: reworked multiplicative AuraEffects calculation
- Splitted containers for flat modifiers and pct modifiers, as they now have different handling
- Amount is now multiplied only on apply; on unapply, iterate through auras and reset the counter
- Fixes many cases of rounding error due to applying/unapplying of small factors
- Allows amounts to be zeroed (ie with an AuraEffect of amount -100)
- Do a partial revert of 6dc37a9add, auras should update amounts only for items allowed (ie no more giving crit to a sword while having an axe in the other hand and being Poleaxe spec'd)
- SPELL_AURA_MOD_SCALE now scales additively, rather than multiplicatively (checked in sniffs)

Closes #18687

(cherry picked from commit c69a7d1223)
2020-04-24 17:18:47 +02:00
ariel-
73ea9ecec1 Core/Misc: moved WeaponAttackType definition to SharedDefines to avoid including Unit.h
(cherry picked from commit 6d991e9361)
2020-04-24 17:18:47 +02:00
ariel-
de2cae6a58 DB/Spell: Recently Bandaged debuff shouldn't break stealth
Closes #18951
By Noryad

(cherry picked from commit 5f901d3d75)
2020-04-24 17:18:47 +02:00
Rushor
1abe7530df DB/Creature: Savage Hill Brute/Mystic/Scavenger
Closes #18922

(cherry picked from commit abed5e1586)
2020-04-24 17:18:47 +02:00
ariel-
cdbe16fabe Core/Scripts: implemented Gnomish Harm Prevention Belt
Updates #18542

(cherry picked from commit 2db3e86d9b)
2020-04-24 17:18:47 +02:00
Rushor
2d2cf2533e DB/Creature: Footman Rob, Footman Chuck and Footman George
Closes #18770

(cherry picked from commit 6732c1c2e1)
2020-04-24 17:18:47 +02:00
Rushor
49af1080aa DB/Creature: Bellinger and Bailey
Closes #18908

(cherry picked from commit b9bd4cd198)
2020-04-24 17:18:47 +02:00
Rushor
fb25fccefa DB: Janks's mine event
Closes #18907

(cherry picked from commit 7b578cb142)
2020-04-24 17:18:47 +02:00
Rushor
554a36ae24 DB/Creature: Torseg the Exiled
Closes #18902

(cherry picked from commit 2f19d78b2a)
2020-04-24 17:18:46 +02:00
Rushor
08870077ad DB/Creature: Zalduun
Closes #18886

(cherry picked from commit 5b46f5180c)
2020-04-24 17:18:46 +02:00
Rushor
52f6738cd1 DB/Creature: Gothik the Harvester 2
Closes #18884

(cherry picked from commit 5edd855793)
2020-04-24 17:18:46 +02:00
Rushor
70396c5ad7 DB/Creature: Gothik the Harvester
Closes #18881

(cherry picked from commit f86fa0f526)
2020-04-24 17:18:46 +02:00
Rushor
7597fda20a DB/Creature: Lord Thorval
Closes #18880

(cherry picked from commit 80a0c3cfc7)
2020-04-24 17:18:46 +02:00
Keader
f3d946cee9 Core/Spell: Fixed Val'kyr Target Search exploit
Closes #16347
by ariel-

(cherry picked from commit 28b955bd25)
2020-04-24 17:18:46 +02:00
Rushor
545f641425 DB: Instructor Razuvious - Event with Acherus Necromancer and Death Knight Initiate
Closes #6631

(cherry picked from commit 39b20b4431)
2020-04-24 17:18:46 +02:00
Rushor
a56970e99a DB/Creature: Warden Nork Bloodfrenzy & Son
Closes #18854

(cherry picked from commit 439654d1e8)
2020-04-24 17:18:46 +02:00
Rushor
b12cac5feb DB/Creature: Apprentice Trotter
Closes #18862

(cherry picked from commit 97c9dd24d2)
2020-04-24 17:18:46 +02:00
Rushor
c1738c8def DB/Creature: Initiate Vernon + Initiate Greer
Closes #18861

(cherry picked from commit fd1620a4e2)
2020-04-24 17:18:46 +02:00
Rushor
ba32944b00 DB/Creature: Librarian Hamilton - Add pathing and emotescript
Closes #18859

(cherry picked from commit 683157d771)
2020-04-24 17:18:46 +02:00
Rushor
d3c9f1d14f DB/Quest: Ore Cart - Questevent for "Fruits of Our Labor"
Closes #18858

(cherry picked from commit 3777971cf1)
2020-04-24 17:18:46 +02:00
Rushor
9d62d5afd3 DB/Creature: Karen I Don't Caribou the Culler
Closes  #18855

(cherry picked from commit 03c1769824)
2020-04-24 17:18:46 +02:00
Rushor
ac6f6e6371 DB/Creature: Wind Master To'bor & Warsong Wind Rider
Closes #18851

(cherry picked from commit 1ad4964fd2)
2020-04-24 17:18:46 +02:00
Rushor
0b00f70162 DB/Creature: Armorer Orkuruk
Closes #18849

(cherry picked from commit ae3b74f2e2)
2020-04-24 17:18:46 +02:00
Rushor
a6db440261 DB/Creature: Mordenai
Closes #18847

(cherry picked from commit bbc8e0ae5d)
2020-04-24 17:18:46 +02:00
Rushor
b5819cd715 DB/Creature: Chancellor Bloodleaf
Closes #18846

(cherry picked from commit ea9254137c)
2020-04-24 17:18:46 +02:00
Rushor
9aaa6c5977 DB/Creature: Painmistress Gabrissa
Closes #18845

(cherry picked from commit f085cc9ad9)
2020-04-24 17:18:46 +02:00
Killyana
7860ecf4e0 DB: Typo
(cherry picked from commit e76983c259)
2020-04-24 17:18:46 +02:00
Rushor
eaed0f77d7 DB/Creature: Eye of the Citadel
Closes #18844

(cherry picked from commit 3d3523078f)
2020-04-24 17:18:46 +02:00
Rushor
856acb3217 DB/Creature: Levixus
Closes #18843

(cherry picked from commit 6f918d2381)
2020-04-24 17:18:46 +02:00
Rushor
db9bf825d7 DB: Experimental Pilot - Conversation with Engineering Crewmember
Closes #18842

(cherry picked from commit bde8fe5a89)
2020-04-24 17:18:46 +02:00
Rushor
a3cd5f87cc DB/Creature: Consortium Nether Runner
Closes #18841

(cherry picked from commit 1142c247b7)
2020-04-24 17:18:45 +02:00
Rushor
661bcaee1e DB/Creature: Nurse Judith
Closes #18839

(cherry picked from commit 1e63e34eb9)
2020-04-24 17:18:45 +02:00
Shauren
bbfbb7d4bf Core/PacketIO: Implement building SMSG_UPDATE_OBJECT only for selected fields and use that to fix quest objects not glowing after accepting quests 2020-04-23 20:22:53 +02:00
Shauren
51e99de4c6 SQL: Fixed applying 2020_04_20_00_characters.sql 2020-04-23 18:48:43 +02:00