ariel-
bb7869b31f
Core/Scripts: fix some spells double dipping from done/taken bonuses
...
Closes #21007
(cherry picked from commit ab3307fc23 )
2021-06-16 11:22:10 +02:00
ariel-
3bc3b3eeeb
Core/Globals: revert back to unordered_map for templates
...
Partial revert of commit b64c504314
See discussion on b64c504314
(cherry picked from commit b75ff7d4bf )
2021-06-16 01:29:25 +02:00
ariel-
21556667c1
Core/Globals: throw some RAII into ObjectMgr, and load templates into vectors
...
Ref #14274
(cherry picked from commit b64c504314 )
2021-06-16 01:00:11 +02:00
sirikfoll
5b5bc4c5c7
Scripts/Scarlet Enclave: Quest The Endless Hunger will work correctly after Unworthy Initiate Respawn
...
Due to dynamic spawns, we need to be able to update the Npc GUID after the respawn, otherwise the quest can only be completed by the first player
(cherry picked from commit 72ff2e30c3 )
2021-06-15 23:43:17 +02:00
ariel-
d0fa8c72a3
Core/Unit: check remaining instead of full duration for Bounced by DR auras
...
(cherry picked from commit ccf0807be0 )
2021-06-15 23:42:10 +02:00
Keader
ca07b1a25d
Scripts/Pit of Saron: Tyrannus followup
...
fix new issue caused by 947cb6a453
(cherry picked from commit 0b09e9ee4e )
2021-06-15 23:41:11 +02:00
Keader
ed8d57e72d
Scripts/Pit of Saron: Fixed Tyrannus not working after evade
...
(cherry picked from commit 947cb6a453 )
2021-06-15 23:40:47 +02:00
Moein
172df39350
Core/SAI: Extended SMART_TARGET_VEHICLE_PASSENGER to allow specifying seat mask instead of single seat index (can now target all passengers) ( #21245 )
...
(cherry picked from commit 891bca934e )
2021-06-15 23:37:25 +02:00
Keader
6ba82b56dc
Scripts/Trial Of The Crusader: Lord Jaraxxus rework ( #21216 )
...
(cherry picked from commit a41cd41695 )
2021-06-15 23:32:57 +02:00
Treeston
56fcd8ba1d
Core/Threat: Fix a potential crash that would occur in specific edge cases of AI being a bit naughty.
...
(cherry picked from commit 1847555c8c )
2021-06-15 23:22:50 +02:00
ariel-
08ac27d959
Core/Auras: fix static analysis issues
...
CID 1384433
CID 1384436
(cherry picked from commit 5153f464d8 )
2021-06-15 23:22:01 +02:00
ariel-
bf4330bfb5
Core/Unit: fix mess-up with CalcArmorReducedDamage parameter order
...
(cherry picked from commit 01537e1dfb )
2021-06-15 23:08:27 +02:00
ariel-
431a326e69
Core/Entities: Port some refactors from f1986c6aaf
2021-06-15 00:48:02 +02:00
ariel-
6ab410b926
Core/Unit: allow miss chance to exceed 60% cap with certain auras
...
(cherry picked from commit 688e96fb4f )
2021-06-14 18:52:48 +02:00
ariel-
770367a514
Core/Unit: fix Sanctified Wrath (again)
...
- Actually only rank 1 was affected because of 50% reduction on rank 2
(cherry picked from commit 0e9b1635e0 )
2021-06-14 18:50:10 +02:00
ariel-
84a29d8077
Core/Unit: fixed crash
...
Closes #21231
(cherry picked from commit 22b24d8dae )
2021-06-14 01:19:38 +02:00
ariel-
bec829df0a
Core/Unit: simplified and arranged spell bonus calculation
...
- Remove duplicated SPELLMOD_BONUS_MULTIPLIER handling (both on done and taken)
- Handle properly bonus data, don't apply bonus by default, only player spells should take into account spell power
- Moved Earthliving Weapon coefficient to DB
- Refactored Avenging Wrath handling
Closes #13287
Closes #21230
(cherry picked from commit d570e2af3e )
2021-06-14 01:17:43 +02:00
ariel-
5fbddef85f
Core/Spell: SpellValueOverrides encapsulation
...
- No sense to let scripts use SpellValueOverrides, we already have modifiers in CastSpellExtraArgs struct
(cherry picked from commit 3b01cccd7e )
2021-06-14 00:19:50 +02:00
Kittnz
267aeddc05
Scripts/EasternKingdoms: implement Children of Goldshire event ( #20745 )
...
* Script: Implement Childeren of Goldshire
Notes: Need to update waypoints and default location of the childeren
http://wowwiki.wikia.com/wiki/Children_of_Goldshire
(cherry picked from commit a9c853ee3f )
2021-06-13 22:30:10 +02:00
Shauren
cc94c3eb50
Core/Sockets: Initialize _sessionKey variable in constructor
2021-06-13 01:00:22 +02:00
Shauren
bda948fc5c
Core/Auras: Implemented EstimatedPoints for SMSG_AURA_UPDATE
2021-06-13 00:59:15 +02:00
Shauren
31ef525ecd
Core/Misc: Add container utility function Trinity::Containers::EnsureWritableVectorIndex to replace if (i >= vec.size()) vec.resize(i + 1) copypaste everywhere
2021-06-13 00:59:15 +02:00
ariel-
fccf1a8c62
Core/Auras: removed caster dependency from core
...
- Decoupled Unit logic: split of spell critical chance into done (caster bonuses) and taken (target bonuses), this allows to precalculate caster bonuses on aura apply and then check victim's auras on damage/healing calc
- Made static a bunch of methods (they no longer have this pointer because they are now called from periodic handlers which may or may not have an active caster in world)
- Simplified all AuraEffect bonuses into AuraEffect::_amount, no more duplicated code
- Critical chance and whether or not caster is player owned unit (for resilience calcs) is now saved one level upper, on Aura itself (it's impossible as of 3.3.5 to have different effects with different critical chances)
- Minor cleanup of SPELL_DAMAGE_CLASS_NONE and Arcane Potency (#18813 ) crit handling
Closes #19876
(cherry picked from commit cb9e72e521 )
2021-06-13 00:59:13 +02:00
Shauren
fa4e2d3935
Core/Quests: Fixed quests that should have objectives immediately marked as complete
...
Closes #26566
2021-06-08 00:02:58 +02:00
Shauren
d0be92ec0a
Core/Achievements: Defined all modifier tree types and implemented many of them
2021-06-07 15:37:34 +02:00
Matan Shukry
626c8f5de1
Core/Player: Add helper function to determine if war mode can be enabled in area
2021-06-06 21:06:21 +02:00
Shauren
5134622a75
Core/DataStores: Load QuestLineXQuest.db2
2021-06-06 20:57:09 +02:00
Shauren
2f8e411ac7
Core/Reputation: Corrected sorting of friendship rep reactions
2021-06-06 19:22:47 +02:00
Shauren
8d5356cdea
Core/DataStores: Load PvpTier.db2
2021-06-06 19:06:08 +02:00
Shauren
b607bb0a93
Core/DataStores: Load ItemModifiedAppearanceExtra.db2
2021-06-06 17:56:11 +02:00
Shauren
c2751f9195
Core/Players: Add PlayerExtraFlags for tracking race change, level boost, and raf level grant usage
2021-06-06 14:19:28 +02:00
Shauren
b01fba4bd9
Core/Reputation: Implemented paragon reputation
2021-06-06 00:11:06 +02:00
Shauren
f6b919fafe
Core/Reputation: Named all reputation flags
2021-06-05 23:00:06 +02:00
Shauren
2bfa576b30
Core/DataStores: Fixed SpellLabelEntry structure
2021-06-05 13:24:46 +02:00
Shauren
19990a966b
Core/PacketIO: Named PVPInfo/bracket fields
2021-06-05 13:16:54 +02:00
Shauren
d1ef8f28b0
Core/Achievements: Implemented CRITERIA_TYPE_UPGRADE_GARRISON_BUILDING
2021-06-05 01:06:02 +02:00
Shauren
dd9913d7e3
Core/Players: Name unknown player flags and rename MENTOR to TIMEWALKING
2021-06-04 22:20:15 +02:00
Shauren
8aaf750be1
Core/Conditions: Implemented missing PlayerCondition columns - time and weather
2021-06-04 21:47:43 +02:00
Shauren
9542d221cb
Core/Units: Add std::function overloads to GetAura/GetAuraApplication
2021-06-04 21:20:55 +02:00
Shauren
e1f3f1254c
Core/Spells: Load spell label data for future use
2021-06-04 21:18:29 +02:00
Shauren
a0796179b3
Nopch build fix
2021-06-04 19:59:49 +02:00
Shauren
80a6347b7a
Core/Reputation: Implemented "friendship reputation"
2021-06-04 19:27:26 +02:00
Shauren
ad683a356a
Core/DataStores: Load Achievement_Category.db2
2021-06-03 21:42:12 +02:00
Shauren
239cf1b005
Core/Criteria: Refactor CriteriaTreeOperator as enum class
2021-06-01 22:17:49 +02:00
Shauren
5543908e52
Core/Criteria: Add all values of CriteriaTreeFlags
2021-06-01 22:13:07 +02:00
Shauren
2629015011
Core/Criteria: Add all values of CriteriaFlags
2021-06-01 21:29:00 +02:00
Shauren
0b2087ae41
Core/Criteria: Add all values of CriteriaStartEvent
2021-06-01 21:16:41 +02:00
Shauren
4b6ddfbbcc
Core/Criteria: Add all values of CriteriaFailEvent
2021-06-01 21:04:22 +02:00
KoNicks
cfd4f18885
Core/Misc: Fix build when using libstdc++-11 ( #26565 )
2021-05-30 20:00:34 +02:00
Shauren
b29cc8f31a
Fix build
2021-05-29 22:04:49 +02:00