Commit Graph

10666 Commits

Author SHA1 Message Date
Machiavelli
bb7bd9ef45 Core/Spells: Fix a possible crash in spell_hun_readiness_SpellScript
--HG--
branch : trunk
2010-12-16 16:00:56 +01:00
Spp
4671500172 Core/Dungeon Finder: Move all LFG data from Player and Group classes to internal LFG data classes.
--HG--
branch : trunk
2010-12-16 10:53:21 +01:00
Spp
451a6f40d4 Core/Dungeon Finder: Use full guid of players instead of lowguid
Note: This change is done in preparation of other changes that will come later.

--HG--
branch : trunk
2010-12-16 04:20:22 +01:00
Shauren
1bc9b905f6 Scripts/Icecrown Citadel: Removed WIP leftovers
--HG--
branch : trunk
2010-12-15 16:39:23 +01:00
Shauren
2db0c7c017 Scripts/Icecrown Citadel: Festergut's Gas Spore and Vile Gas should not happen at the same time
--HG--
branch : trunk
extra : rebase_source : dbb903afbfbfdee5c2c3ae0be7181508e0eca1b2
2010-12-15 16:36:59 +01:00
_manuel_
6f551d853f Core/Scripts: Novos the Summoner should only summon 4 Crystal Handlers.
--HG--
branch : trunk
2010-12-15 12:16:31 -03:00
Machiavelli
ad13cd89b5 Core/Items: Fix item duration saving (and loading at a later stage).
--HG--
branch : trunk
2010-12-15 15:00:52 +01:00
Spp
382fef1958 Core: Some warning fixes
--HG--
branch : trunk
2010-12-15 10:44:06 +01:00
azazel
ddf06c086e Core/Social: properly remove deleted character from social list of online players (by Emtec)
--HG--
branch : trunk
2010-12-15 14:44:41 +06:00
azazel
0fdea34a8a Core/Items: fix error in saving item's enchantments introduced in rev 022f3858fc (thanks Shauren for spotting the problem)
--HG--
branch : trunk
2010-12-15 14:44:02 +06:00
azazel
23e3909221 Core/Arena: avoid arena match loss when leaving queue before actual invitation to match (by VladimirMangos)
--HG--
branch : trunk
2010-12-15 14:25:10 +06:00
azazel
b39b8fdd0d DB Schema/Characters: removed columns auctionhouse.item_template, character_inventory.item_template, guild_bank_item.item_entry and mail_items.item_template and created item_instance.itemEntry column instead of them.
As a side effect moved related queries to prepared statements.
As one more side effect fixed not shown and lost mail items in returned expired mail (patch by Quriq14).

--HG--
branch : trunk
2010-12-15 14:08:12 +06:00
Shauren
58a9b15443 Core: Fixes some warnings
Core/SmartAI: Fixed DamageTaken and DamageDealt hooks

--HG--
branch : trunk
extra : rebase_source : 062f1c68cd1d318d192b294a493db17a1943bee2
2010-12-14 22:45:23 +01:00
Machiavelli
80494d8f64 Core/DBLayer: Fix a possible crash in ProcessQueryCallback functions.
Closes issue #5095

--HG--
branch : trunk
2010-12-14 20:16:09 +01:00
click
300e37fef7 Docs: Add a small info about how to report compilation errors, AND inform how to properly "hunt" for the error.
--HG--
branch : trunk
2010-12-14 19:34:19 +01:00
Machiavelli
3b0297f912 Core/CharacterHandler: Fix ¨[ERROR] GetUInt32() on non-numeric field¨ on a certain query.
Author: toshik.777
Closes issue #5068

--HG--
branch : trunk
2010-12-14 19:14:54 +01:00
Shauren
9a806e63c1 Fixed compile
--HG--
branch : trunk
2010-12-14 16:31:01 +01:00
Shauren
314376e32c Scripts: Fixed uninitialized variables, unreferenced parameters and virtual overrides
--HG--
branch : trunk
2010-12-14 16:24:59 +01:00
Shauren
f4581f67b8 Core: Fixed uninitialized variable warnings
--HG--
branch : trunk
2010-12-14 15:58:45 +01:00
Shauren
0c04b178db Scripts/Icecrown Citadel: Minor adjustments and compile warning fixes
--HG--
branch : trunk
2010-12-14 15:46:54 +01:00
Liberate
6be8446053 Core/Gameobjects: Fix fishing and looting specific chests which were bugged because of revision 044e466d75.
Fixes issue #5116.

--HG--
branch : trunk
2010-12-14 15:02:42 +01:00
click
48b234022f Core: Change HandleEjectPasenger to HandleEjectPassenger (English thank you)
--HG--
branch : trunk
2010-12-14 14:09:14 +01:00
Liberate
09f4eb9e1c Core/Gameobjects: Make a chest not lootable when it still has a respawn time, to avoid cheating using third-party software.
--HG--
branch : trunk
2010-12-14 03:58:59 +01:00
click
2d8e73fab5 Core: Fix up opcode-mess from previous commit, and move CMSG_DECLINE_CHANNEL_INVITE handling to its correct opcode (0x0410)
(Please report back any findings of erranous behaviour to the tracker, or into this commit)

--HG--
branch : trunk
2010-12-14 02:23:28 +01:00
click
2642894342 Core: Add new system for parallelizing client packet processing. Handle WorldSession updates in Map::Update() where we are safe to proceed. Patch by Ambal.
(And clean up tabs and whitespace while rummaging around in there)
Closes issue 5084.

--HG--
branch : trunk
2010-12-13 22:37:56 +01:00
Spp
89a33bbf61 Core/Dungeon Finder: Fix a crash in Join when there are no dungeons available for that group (And probably other random crashes that appear when having DF enabled)
Core/Dungeon Finder: Tab2spaces + remove trailing spaces in LFG* files.

Notes to self:
- assign NULL to a pointer parameter will not change the pointer value outside the scope of the function
- deleting a const_iterator can lead to mem corruption

--HG--
branch : trunk
2010-12-13 21:31:55 +01:00
Spp
865f35a637 Core/Dungeon Finder: Minor optimization in handler code
Note: LfgDungeonSet and LfgLockStatusMap were being used without using the existing typedef (to avoid including LFGMgr.h).
Now those functions use a struct as param that is forward declared so still LFGMgr.h is not needed and redefinition of LfgDungeonSet/LfgLockStatusMap is removed.

--HG--
branch : trunk
2010-12-13 21:28:36 +01:00
Spp
9815847511 Core/Dungeon Finder: Return a copy of cached dungeons set (to avoid being cleared later in code)
--HG--
branch : trunk
2010-12-13 21:28:33 +01:00
click
620cde80cd Core: Fix non-PCH build
--HG--
branch : trunk
2010-12-13 17:44:20 +01:00
Machiavelli
d5f5fa59ab Add missing declarations as of recent merge
--HG--
branch : trunk
2010-12-13 17:34:27 +01:00
Machiavelli
451159cac4 Fix possible compile error under linux
--HG--
branch : trunk
2010-12-13 17:21:06 +01:00
Machiavelli
bd77fb6d47 Fix a typo, thanks to sss.nevan
--HG--
branch : trunk
2010-12-13 17:05:01 +01:00
Machiavelli
d75eaf8e83 Core/Guild: More signed/unsigned comparison fixes. Should fix guild log loading.
--HG--
branch : trunk
2010-12-13 16:58:59 +01:00
Machiavelli
1a4fe4baca Core/Guilds: Fix logic in bank withdrawal method (unsigned comparison with signed value). Should fix certain guild bank related bugs.
--HG--
branch : trunk
2010-12-13 16:42:09 +01:00
Machiavelli
976225a9dd Core/DBLayer: Implement global ExecuteOrAppend methods to DatabaseWorkerPool for executing queries in a diverse context (transaction or non transaction) - instead of local to Guild.cpp
--HG--
branch : trunk
2010-12-13 16:27:14 +01:00
Machiavelli
426b28e344 Fix wrong vsprintf parameter added in merge.
--HG--
branch : trunk
2010-12-13 16:18:07 +01:00
Machiavelli
f1a73e89b8 Merge
--HG--
branch : trunk
2010-12-13 16:13:32 +01:00
Machiavelli
ea29d87dcc Backed out changeset: 8326a2411148
--HG--
branch : trunk
2010-12-13 09:18:49 +01:00
Shauren
dd2602d3ec Fixed line endings in 10623_world_spell_bonus_data
Scripts/Naxxramas: Fixed a possible crash in instance script

--HG--
branch : trunk
2010-12-12 17:32:26 +01:00
Shocker
4b0ffeb0bd Core/ChatHandler: Cleanup in HandleMessagechatOpcode. Now commands are parsed and security checks are made in all channels
--HG--
branch : trunk
2010-12-11 17:47:43 +02:00
azazel
d2d62eab50 Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
NOTE: Initially I just wanted to fix some warnings, but noticed that there is no common method for percentage calculation and various formulas are used many time in the code making it difficult to read and understand what the code actually does. So, I introduced several template methods for calculating percent values and adding those values to the original base. I replaced all the raw calculations throughout the code where found, but I could have missed something or could have made a mistake. So, please report any strange behaviour after this commit.
If you ask me why I did it: for the sake of consistency and exact understanding what code means. If you see CalculatePct method, you clearly understand, that it find the value of x percent of y. And you can easily express, for example, spell behviour "reduces smth by x%" by the means of a method instead of recalling school maths.

--HG--
branch : trunk
2010-12-11 20:37:38 +06:00
click
81db111ffd Core/Spells: Fix mage talent Frost Warding (and a little cleanup on CalcAbsorbResist) - patch by DrTenma
Fixes issue 2715.
Closes issue 3770.

--HG--
branch : trunk
2010-12-11 12:00:57 +01:00
click
0e33e73d39 Core/ChatHandler: Allow GM/server-commands to be executed through whisper-channels - patch by Ramus
Closes issue 5006.

--HG--
branch : trunk
2010-12-11 03:25:31 +01:00
Spp
a791df6415 Core/Dungeon Finder: Fix crash in Join
(trying to delete a const iterator)

Closes issue 5083

--HG--
branch : trunk
2010-12-10 14:58:45 +01:00
Machiavelli
4f468f9552 Core/RA: Calculate password hash internally instead of sending plaintext password to mysql.
Convert tabs to spaces.

--HG--
branch : trunk
2010-12-10 09:02:59 +01:00
azazel
e3c68e4ada Misc: fix CR/LF (my bad, sorry)
--HG--
branch : trunk
2010-12-10 12:06:28 +06:00
azazel
08f205722a Scripts/Quest: implement dummy effects for spells 43882, 50133 and aura 43874 for quests 11396/11399 Bring Down Those Shields (based on code by NoFantasy)
--HG--
branch : trunk
2010-12-10 12:01:57 +06:00
click
7e0dee8cb1 Fix build
--HG--
branch : trunk
2010-12-10 01:44:34 +01:00
click
456f29c089 Core/Worldserver: Remove external dependency to sockets-library after RemoteAccess being converted to ACE, and fix one minor hiccup on non-PCH builds
--HG--
branch : trunk
2010-12-10 00:33:55 +01:00
Derex
ef768a8307 Rewrite remote access console using ACE
--HG--
branch : trunk
2010-12-10 01:01:44 +02:00