ForesterDev
c0f516caee
Core/Packets: updated MSG_RANDOM_ROLL ( #24457 )
...
(cherry picked from commit 5dddfbdb7b )
# Conflicts:
# src/server/game/Handlers/ChatHandler.cpp
# src/server/game/Handlers/GroupHandler.cpp
# src/server/game/Server/Protocol/Opcodes.cpp
# src/server/game/Server/Protocol/Opcodes.h
# src/server/game/Server/WorldSession.h
Co-authored-by: DJScias <djscias@gmail.com >
2020-04-18 14:28:07 +02:00
zartech22
56f20d69a6
Add realm ID for actions based ip logging ( #24453 )
...
* Update SQL queries to insert realm id
* Insert the realm id when logging actions based on IP
* Adding the SQL update file
* Update 9999_99_99_99_auth.sql
* Update auth structure
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com >
2020-04-18 14:26:05 +02:00
Gildor
6c7c2c6cd2
Scripts/Naxxramas: Fix Heigan Eruption spell ( #24470 )
2020-04-17 22:54:36 +02:00
Ovah
cfd63c350f
Core/Movement: various improvements for creature knockbacks
...
* creature knockbacks will no longer generate a full path but instead only use a destination point to reflect sniff data
* calculate the destination by using a mmap raycast instead of using a mmap path which had the chance of creating weird movements when GetNearPosition failed to get a proper collision point (knocking arround a tree for example or just somewhere it should not go at all)
2020-04-17 21:13:18 +02:00
Alan Deutscher
e11a13c755
Core/Players: Improve trade exchange calculations ( #24435 )
...
* Add some comments to Player::CanStoreItems to help me wrap my head around how the method works.
* Experimental fix for incoming trade-stack problem.
* Only add to stacks that aren't already full.
* Use remaining_count instead of static 1.
* Remove debug logging from exploration.
* More uses of remaining_count for consistency.
* Correct space count check
* Correct overflow problem.
* Remove redundant check, handled in existing for statement.
* Store Item pointers in order to be able to merge in multiple incoming stacks.
* Build fix - was continually working locally, but failing in CI.
* Break build in order to keep PR focused on Player.cpp changes.
* Adjust phrasing of how arrays are initialized.
* Fix phrasing of comments to avoid sounding like a ToDo item
* In the spirit of b649273d5f , rephrase an old comment to be a statement rather than a question.
2020-04-16 20:21:01 +02:00
Keader
77dd751499
Scripts/Ulduar: Little improvements in Auriaya
...
* Removed DespawnAtEvade
* Fix Feral Defender Damage
2020-04-15 11:28:46 -03:00
Keader
78dff46bf2
Scripts/Trial of Crusader: Fixed issue with Snobold Vassal and some achiev criteria resets
...
* Fixed snobold behavior when gormok dies
* Fixed UPPER_BACK_PAIN Archiev reset
* Fixed THREE_SIXTY_PAIN_SPIKE Archiev reset
2020-04-15 09:53:46 -03:00
Gildor
8a5b02be0a
Scripts/Quest: The Exorcism of Colonel Jules ( #24459 )
...
* Remove Anchorite Barada gossip when event start
2020-04-15 13:12:28 +02:00
ForesterDev
b712222a08
Core/Packets: ( #24441 )
...
* SMSG_START_MIRROR_TIMER
* SMSG_STOP_MIRROR_TIMER
* SMSG_PAUSE_MIRROR_TIMER -- not used
(cherry picked from commit 79bbca0bbf )
# Conflicts:
# src/server/game/Entities/Player/Player.cpp
# src/server/game/Server/Protocol/Opcodes.cpp
Co-authored-by: Golrag <golrag.jeremy@gmail.com >
2020-04-14 14:15:20 +02:00
ForesterDev
c973c0260f
Core/Packets: updated SMSG_LEVELUP_INFO ( #24440 )
...
* Core/Packets: updated & enabled SMSG_LEVELUP_INFO
(cherry picked from commit bf9024c34180b1e35afb3cc9ef4cf1f3133dedfd#gitext://gotocommit/bf9024c34180b1e35afb3cc9ef4cf1f3133dedfd)
# Conflicts:
# src/server/game/Entities/Player/Player.cpp
# src/server/game/Entities/Player/Player.h
# src/server/game/Server/Protocol/Opcodes.cpp
# src/server/game/Server/Protocol/Opcodes.h
* Remove empty line
* Remove whitespace
Co-authored-by: MitchesD <majklprofik@seznam.cz >
2020-04-14 14:06:16 +02:00
ForesterDev
e1a8ebc064
Core/PacketIO: updated SMSG_DURABILITY_DAMAGE_DEATH ( #24442 )
...
- use RATE_DURABILITY_LOSS_ON_DEATH for death from falling
- add note, that RATE_DURABILITY_LOSS_ON_DEATH doesn't change log message
(cherry picked from commit a1831e0c1e )
# Conflicts:
# src/server/game/Entities/GameObject/GameObject.cpp
# src/server/game/Entities/Player/Player.cpp
# src/server/game/Entities/Unit/Unit.cpp
# src/server/game/Server/Packets/GameObjectPackets.h
# src/server/game/Server/Protocol/Opcodes.cpp
Co-authored-by: MitchesD <majklprofik@seznam.cz >
2020-04-14 14:00:53 +02:00
ForesterDev
37ff15489b
Core/PacketIO: updated SMSG_ENVIRONMENTAL_DAMAGE_LOG ( #24443 )
...
(cherry picked from commit 7b446a28cc )
# Conflicts:
# src/server/game/Entities/Player/Player.cpp
# src/server/game/Server/Packets/CombatLogPackets.cpp
# src/server/game/Server/Packets/CombatLogPackets.h
# src/server/game/Server/Protocol/Opcodes.cpp
# src/server/game/Server/Protocol/Opcodes.h
Co-authored-by: MitchesD <majklprofik@seznam.cz >
2020-04-14 13:58:11 +02:00
Gildor
862097a633
Core/Gameobjects: Improve stealth detection ( #24417 )
...
* Core/Gameobjects: Improve stealth detection
* fix warning: private field 'i_funit' is not used
* Code cleanup
* add comment
Co-authored-by: jackpoz <giacomopoz@gmail.com >
2020-04-12 15:28:01 +02:00
Sven
c3037c3563
Improvements to Pyroguard Emberseer (UBRS) script ( #24405 )
...
* UBRS: Improve Pyroguard Emberseer script
* Remove whitespaces
* More whitespaces removed
* Addressing change requests
Removed cast from constructor
Removing unused member field
* That should be the last white spaces
* Forgot to remove the declaration
* Update boss_pyroguard_emberseer.cpp
* Add break to For loop
* War on white spaces
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com >
2020-04-12 10:00:15 +02:00
ForesterDev
bfd73e7f47
Core/PacketIO: updated SMSG_FEATURE_SYSTEM_STATUS ( #24403 )
...
* Core/Packets: updated SMSG_FEATURE_SYSTEM_STATUS
(cherry picked from commit 231207970b )
# Conflicts:
# src/server/game/Battlegrounds/ArenaTeam.cpp
# src/server/game/Entities/Player/Player.cpp
# src/server/game/Entities/Player/Player.h
# src/server/game/Handlers/CharacterHandler.cpp
# src/server/game/Handlers/GroupHandler.cpp
# src/server/game/Handlers/SpellHandler.cpp
# src/server/game/Server/Packets/SpellPackets.cpp
# src/server/game/Server/Packets/SpellPackets.h
# src/server/game/Server/Packets/SystemPackets.cpp
# src/server/game/Server/Packets/SystemPackets.h
# src/server/game/Server/Protocol/Opcodes.cpp
# src/server/game/Server/Protocol/Opcodes.h
# src/server/game/Server/WorldSession.h
* Define complaint status values and replace magic numbers
* Add missing header
Co-authored-by: joschiwald <joschiwald.trinity@gmail.com >
2020-04-11 19:49:36 +02:00
ForesterDev
3e54e798e6
Core/Opcodes: updated CMSG_SET_SHEATHED to new packet class ( #24393 )
...
* Core/Packets: Added SMSG_LEARNED_SPELLS packet
(cherry picked from commit 51026f28bd )
Co-authored-by: chemicstry <chemicstry@gmail.com >
* Core/Opcodes: updated CMSG_SET_SHEATHED to new packet class
(cherry picked from commit 7eb02e945f )
# Conflicts:
# src/server/game/Entities/Unit/Unit.cpp
# src/server/game/Handlers/CombatHandler.cpp
# src/server/game/Server/Packets/CombatPackets.cpp
# src/server/game/Server/Packets/CombatPackets.h
# src/server/game/Server/Protocol/Opcodes.cpp
* rename opcode name CMSG_SETSHEATHED -> CMSG_SET_SHEATHED
* Revert "Core/Packets: Added SMSG_LEARNED_SPELLS packet"
This reverts commit 7beefdfb162f503067a519193f704ac15809779f.
Co-authored-by: chemicstry <chemicstry@gmail.com >
2020-04-11 19:48:16 +02:00
Sorikoff
194691f7c3
Scripts/Pets: Mojo ( #24431 )
...
* Mojo
* Update
* Rename 9999_99_99_99_world.sql to 2020_04_11_01_world.sql
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com >
2020-04-11 19:47:09 +02:00
NoName
f9d9440577
Core/PacketIO: Updated CMSG_REQUEST_PET_INFO ( #24420 )
...
cherry-picked fd162fb604
Co-authored-by: Carbenium <carbenium@outlook.com >
2020-04-11 18:49:44 +02:00
jackpoz
9cde3ffd14
Core/Pools: Fix crash on startup
2020-04-11 18:17:38 +02:00
Giacomo Pozzoni
4f33fd3932
Core/Pooling: Remove respawn times from the database when despawning a pool ( #24422 )
...
* Core/Pooling: Remove respawn times from the database when despawning a pool
Remove respawn times from the database when despawning a pool. This is needed when a Game Event ends but there are still some respawn times saved in the database.
* Remove respawn time of active pool objects even if they are not spawned
2020-04-11 14:07:57 +02:00
jackpoz
eb31ae9b18
Core/Misc: Fix linux build
2020-04-11 11:45:44 +02:00
jackpoz
9c9f4d6d20
Core/Unit: Ceil damage instead of rounding it
...
a0d5088850 followup, use std::ceil instead of std::round . This ensures at least 1 damage point will be done after applying armor reducing.
2020-04-10 23:24:29 +02:00
Killyana
d0f9ace679
Creature: Gorkun Ironskull & Martin Victus in The Pit of Saron
...
Still some events are missing in this instance
2020-04-10 20:05:26 +02:00
Shauren
f57b1e27d0
Scripts/Eye of Eternity: Fixed The Focusing Iris not respawning on wipe
...
Closes #22948
2020-04-10 17:08:25 +02:00
Shauren
18b36734f6
Core/Spells: Fixed checking free inventory space for some spells that have bad dbc data
...
Closes #24423
2020-04-10 16:38:50 +02:00
jackpoz
a0d5088850
Core/Unit: Round damage instead of truncating it
...
Round damage instead of truncating it when calculating armor-reduced damage. This fixes some level 1 creatures doing 0 damage (displayed as "Miss" ingame)
2020-04-10 00:11:54 +02:00
Giacomo Pozzoni
90b00288c2
Core/SAI: Allow SMART_TARGET_ACTION_INVOKER to target GameObjects ( #24416 )
...
* Core/SAI: Allow SMART_TARGET_ACTION_INVOKER to target GameObjects
* Include new Coalesce(..) template by @Shauren
2020-04-09 11:59:10 +02:00
NoName
566dcfc518
Core/PacketIO: Updated CMSG_DISMISS_CRITTER ( #24412 )
...
based on cherry-pick 6fbfc61de1
Co-authored-by: Carbenium <carbenium@outlook.com >
2020-04-08 21:35:01 +02:00
jackpoz
31018c3652
Core/Log: Log all character kicks to "network.kick" category
2020-04-08 21:05:01 +02:00
jackpoz
68fcd592f8
Core/NetworkIO: Adjust more packet throttling values
...
Thanks @Nefertumm at f5e38a7f57 for the heads-up
2020-04-08 17:43:07 +02:00
jackpoz
67f28adaf7
Core/Movement: Add safety check to avoid C++ undefined behaviour
2020-04-08 14:15:49 +02:00
Shauren
579d41acc5
Core/DBLayer: Fix compilation with mysql 8
2020-04-08 09:44:52 +02:00
Ovah
bea850fb73
Core/Objects: cache current liquid status of objects when updating position data and use it to replace unnecessary vmap lookups ( #24399 )
...
* dropped unneeded IsUnderwater override for players since the default position data update considers collision height already so we don't have to rely on that tempfix anymore. This actually fixes breathing bars showing up depending on your characters size (gnomes get their breathing bar earlier, taurens later etc)
2020-04-07 23:28:44 +02:00
myuzhobcplidtkieno
ae553f8966
Added the ability to use TLS when connecting to a database. ( #24348 )
...
* Added the ability to use TLS when connecting to a database.
* Trying to kickstart CI checks
* Revert the kickstart change
Co-authored-by: myuzhobcplidtkieno <myuzhobcplidtkieno@github.com >
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com >
2020-04-07 22:08:28 +02:00
ForesterDev
97405ceb01
Core/PacketIO: Updated SMSG_LOGIN_VERIFY_WORLD ( #24395 )
...
(cherry picked from commit 7256c7c2c7 )
Co-authored-by: Shauren <shauren.trinity@gmail.com >
2020-04-06 15:18:36 +02:00
Lewis Brumby
caf4c4cf2b
Update AuthSession.cpp ( #24397 )
2020-04-06 00:36:56 +02:00
jackpoz
0844ad2ff0
Scripts/Guards: Fix spell cast spam after killing npc_air_force_bots guards
2020-04-05 20:23:46 +02:00
jackpoz
cb41c8828f
Core/Misc: Replace tabs with spaces
2020-04-05 19:11:01 +02:00
jackpoz
caae3886d2
Core/Misc: Remove whitespace at the end of lines
2020-04-05 19:11:00 +02:00
Giacomo Pozzoni
3def52c1c4
Core/Logs: Log full guid instead of just low guid, part 2
2020-04-05 19:10:58 +02:00
Giacomo Pozzoni
468ecb7252
Core/Logs: Log full guid instead of just low guid
2020-04-05 19:10:57 +02:00
NoName
fbcd244b2f
Core/PacketIO: Handle CMSG_REQUEST_PET_INFO for more cases ( #24364 )
...
+ vehicle
+ charm
+ possession
from 87c6cc19e5
2020-04-05 14:53:23 +02:00
jackpoz
d1f9cf84a5
Core/Battleground: Attempt to fix a crash
...
Please report this error if you get it
2020-04-04 19:50:53 +02:00
ForesterDev
5d70f6ccd4
Core/Packets: update & enabled CMSG_SHOWING_CLOAK, CMSG_SHOWING_HELM ( #24394 )
...
(cherry picked from commit a47d57d1db )
Co-authored-by: DJScias <zumbak04@gmail.com >
2020-04-04 18:34:43 +02:00
Rushor
3da8f37ddb
Scripts/BlackfathomDeeps: Kelris will now channel his spell ( #24300 )
...
* Scripts/BlackfathomDeeps: Kelris will now channel his spell
* Scripts/BlackfathomDeeps: Kelris will now channel his spell
2020-04-04 15:38:23 +02:00
Jozef Dúc
936ff574c5
Fixes #22884 ( #24338 )
...
Fix issue 22884 with non stacking necrotic plague debuff after dispell//death
2020-04-04 15:30:55 +02:00
Sorikoff
264a583903
Scripts/Pet: Baby Blizzard Bear & Egbert ( #24349 )
...
* Baby Blizzard Bear & Egbert
* SQL
* Update 9999_99_99_99_world.sql
SQL fix
* Rename 9999_99_99_99_world.sql to 2020_04_04_00_world.sql
Co-authored-by: Eridium <6587064+Killyana@users.noreply.github.com >
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com >
2020-04-04 15:29:21 +02:00
Sorikoff
a513922fc1
Core/DB: Add DB error for missing gossip npcflag ( #24375 )
...
* Add DB error for missing npcflag
* Improvements
* Update ObjectMgr.cpp
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com >
2020-04-04 15:27:42 +02:00
Eridium
0e2342c169
Core/Movement: Formation Rewrite ( #24379 )
...
* Core/Movement: Formation Rewrite
* Add a missing include
* fixed another warning
* meh
Co-authored-by: Ovahlord <Ovahlord@users.noreply.github.com >
Co-authored-by: Ovah <dreadkiller@gmx.de >
2020-04-04 15:08:42 +02:00
ForesterDev
0f506f0dea
Core/Locales: Optimize locale loading - move the strings ( #24385 )
...
* Core/Locales: Optimize locale loading - move the strings
(cherry picked from commit 5dd686c080 )
Signed-off-by: ForesterDev <gmmunchkinbox@gmail.com >
# Conflicts:
# src/server/game/Globals/ObjectMgr.cpp
* Fix AchievementReward locales build
Co-authored-by: Shauren <shauren.trinity@gmail.com >
2020-04-04 15:05:00 +02:00