Commit Graph

2573 Commits

Author SHA1 Message Date
Keader
7787c97513 Core/Scripts: Illidari Council Rewrite
Thanks to Sirikfoll, Krudor and Offl for all help
2017-01-02 07:47:26 +01:00
Aokromes
719a317a67 Update copyright note for 2017 2017-01-02 07:26:38 +01:00
xinef1
2f43df388d Core/Spell: Fixed bug where spell could fail to hit a target properly even if all conditions were met (#18596) 2017-01-01 13:29:19 +01:00
ariel-
38754b396e Core/Spell: do not proc auras on SPELL_AURA_OBS_MOD_HEALTH healing ticks
Closes #14726
2016-12-30 01:16:41 +01:00
Keader
5f2fa73f7a Core/Scripts: Fixed Suppresser behavior in Valithria Dreamwalker encounter
Closes #18530
* Fixed range issue
* Fixed weave spawn when Summon Timmer Suppresser(70912) is casted
* Fixed spawn count
2016-12-28 16:04:38 +01:00
Aokromes
949ce2d576 Core/Units: Cleanup hardcoded magic numbers for byte field offsets
(cherry picked from commit ac1dc75)
2016-12-16 19:54:22 +01:00
ariel-
eb3a90a4e8 Core/Spell: implemented dispel reflection
Closes #18323
2016-12-16 19:24:01 +01:00
ariel-
21583f1cb9 Core/Spell: do not downscale certain auras 2016-12-16 19:21:17 +01:00
Keader
21cc1fd280 Core/Scripts: Rewrite Magtheridons Lair 2016-12-16 19:15:24 +01:00
ariel-
1066fe59c9 Core/Auras: calculate periodic bonuses before specific mods, fixes Imp. Devouring Plague damage 2016-12-06 11:10:30 +01:00
ariel-
bb8068febb Core/Spells: fix a pretty edge case of creatures being put in combat by evaded spells
Closes #18369
2016-12-06 11:07:15 +01:00
Aokromes
296bd71c79 build fix 2016-11-27 05:34:51 +01:00
ariel-
009adc4324 Revert "Core/Spell: add EquipedItemClass/EquippedItemSubClass check to passive spell casts"
This reverts commit f188ff1ce4.

Was breaking Titan's Grip.
Spells are loaded before items, and they CAST the spell on the player.
When items are then loaded, Player::ApplyItemDependentAuras only has AddAura on it. Titan's Grip is an effect, no auras involved.

In turn reverting this commit will now allow Two-handed weapon specialization and similar from spells load. Which is the lesser of two evils.
2016-11-27 03:11:27 +01:00
ariel-
f348c015c0 Core/Spell: add EquipedItemClass/EquippedItemSubClass check to passive spell casts
- Was adding auras on login that didn't satisfy requirements (like Two-Handed Weapon Specialization)
2016-11-27 03:09:47 +01:00
Aokromes
c0ba6c2dfe Core/Auras: Rewritten conditionally applying SPELL_AURA_MOD_WEAPON_CR…
…IT_PERCENT, SPELL_AURA_MOD_DAMAGE_DONE and SPELL_AURA_MOD_DAMAGE_PERCENT_DONE auras

* Now the entire aura is removed when changing equipment
* All aura types can now depend on equipped items
2016-11-27 03:09:29 +01:00
Aokromes
ba8791ddcd Core/Player: recheck shapeshift bonus auras when switching spec.
- Fixes Leader of the Pack stuck when switching specs while shapeshifted
2016-11-27 01:53:19 +01:00
ariel-
bc25bbcd42 Core/Spell: register items received through SPELL_EFFECT_SUMMON_CHANGE_ITEM for quest credit
- Also sends proper SMSG_ITEM_PUSH_RESULT packet

Closes #3505
2016-11-27 01:42:18 +01:00
ariel-
331a88ef8f Core/Spell: Fixed Drain Soul incorrectly downscaling ranks when targetting lower level enemies 2016-11-27 01:41:58 +01:00
Aokromes
6c76eff031 Core/Unit: fix some SPELL_AURA_MOD_DAMAGE_PERCENT_DONE effects being …
…applied more than once

No more overpowered dps for you
2016-11-27 01:36:22 +01:00
ariel-
de4aec3204 Core/Spell: fix a potential null dereference crash 2016-11-27 01:09:37 +01:00
ariel-
2f1910476e Core/Spell: fix warning 2016-11-19 07:40:32 +01:00
Aokromes
abea2d8d3f Core/Misc: Missing part 2016-11-19 07:27:22 +01:00
Aokromes
66b91e07fa Core/Misc: Compile fix try 2016-11-19 07:19:38 +01:00
Aokromes
d9e8c7a285 Core/Spell: Missing change, partialy revert change 2016-11-19 06:59:05 +01:00
Aokromes
dbd4fc3eca Core/Spell: Compile fix try 2016-11-19 06:35:33 +01:00
Aokromes
b1d4f802ef Core/Spell: move attribute helpers to spellInfo
- Renamed CheckEffectExecuteData to AssertEffectExecuteData and made const, better reflects its purpose
- Added missing attribute check to IsNextMeleeSwingSpell
- Reworked SPELL_ATTR4_CAST_ONLY_IN_OUTLAND attr check (researched behavior)
2016-11-19 06:23:06 +01:00
Aokromes
e4dd97765e Core/Spell: revamp of immunities system
- Spell attributes research
- Container optimization
- Do not skip damage immunity checks on SPELL_ATTR0_UNAFFECTED_BY_INVULNERABILITY present
- Added additonal arguments support to SendCastResult / CheckCast, spells can now send proper error messages
- Loads spell immune masks/states/effects at startup.
- This cached info is used whenever a spell cast requires immunities to be known beforehand (to see if an aura could be applied for example)
2016-11-19 06:10:14 +01:00
ariel-
ad927acae4 Core/Spell: do not fail triggered Charge effects in case a root is present.
Fixes Master's call when pet is rooted
2016-11-15 05:47:59 +01:00
ariel-
66fb271921 Core/Spell: use SpellEntry to select implicit targets in case RadiusEntry wasn't set for the current effect.
Closes #15388
2016-11-15 05:46:42 +01:00
ariel-
760bef2453 Core/SpellScript: allow optional parameters to be passed to FinishCast
followup of 50a3ce5703
2016-11-15 05:45:56 +01:00
Aokromes
8a4bda8c9f Core/Spell: apply SPELLFAMILY_GENERIC mods to all spells by default 2016-11-05 02:29:56 +01:00
Aokromes
1659ea03cf Core/GameObject: spawn linked traps at gameobject creation instead of…
… using DB spawns.
2016-11-02 04:01:09 +01:00
ariel-
1ec9685547 Core/Auras: fix elixir aura saving 2016-11-02 03:48:24 +01:00
Aokromes
a81a44174b Core/Auras: don't save auras casted by items
- Drop useless field from DB (itemGuid was being saved, but never used, see Prepared Statements)
- This type of auras (like Water Bucket, Precious Ribbon, etc) will be recasted on login anyways.
2016-11-02 03:36:16 +01:00
Aokromes
065b6fdc2c Core/GameObjects: Handle despawning and respawning of nearby linked t…
…raps on gameobject despawn and respawn
2016-11-02 03:27:25 +01:00
Aokromes
5157c87198 Core/Spell: fix range for Ancestral Healing (shaman) and Grace (priest) 2016-11-02 03:22:59 +01:00
ariel-
b70a713311 Core/SpellMgr: fix Abolish Disease/Poison targets
Spells were failing due to "out of range"
2016-11-02 03:18:07 +01:00
ariel-
b6f3457458 Core/Auras: only apply shapeshift aura passives when changing forms
Closes #14845
Closes #17617
2016-11-02 03:12:38 +01:00
Aokromes
0be1e9c4d5 Core/SpellMgr: overwrite DBC RangeEntry for Safeguard 2016-11-02 02:54:50 +01:00
ariel-
7d04331322 Core/Spell: do positivity spell checks only against actually hitted effects instead of the whole spell
Closes #18097
2016-10-24 14:03:08 +02:00
ariel-
162eaad0ee Core/Spell: clear auras of channeled spells if channeling is cancelled due to invalid targets (dead or w/e)
Closes #14859
Closes #15186
2016-10-24 13:59:54 +02:00
ariel-
657aea3d5b Core/Spells: mark Arcane Missiles aura as negative. Was downranking the spell when targetting low level mobs due to effect 1 flagged as possitive.
Closes #12152
2016-10-24 13:59:38 +02:00
SnapperRy
f28c778788 Core/Spell: allow SPELL_EFFECT_QUEST_COMPLETE to set a quest to rewarded only if that quest is used as internal flag by the server (has flag 1024 - QUEST_FLAGS_TRACKING). 2016-10-24 13:55:33 +02:00
SnapperRy
5497eebe29 Script/Quest: Stop the Ascension! 2016-10-24 13:02:50 +02:00
ariel-
171738b70e Core/Auras: don't ignore SPELL_ATTR3_ONLY_TARGET_PLAYERS in area auras.
Also, start abusing the arbitrary containers for searchers introduced in 8775f8b28a
2016-10-24 13:01:59 +02:00
Aokromes
2057e6de4a Core/Items: Defined all item flags
(cherry picked from commit ef29f32)
2016-10-24 13:01:00 +02:00
Krudor
2a607f6ce1 Core/Spells: Effect leap back fix (#18057)
* Fixed unintentional typo?

Seemed to fix the issues related to the effect for the spells I tried.
Sometimes the caster triggers leapback onto targets, and with the old
code, it instead made the caster leap back instead of its targets

(cherry picked from commit 08aab73c7f)
2016-10-24 11:03:23 +02:00
ariel-
3bc1f35614 Core/Auras: stop some compilers from complaining 2016-10-21 09:15:18 +02:00
Aokromes
686a9eeef9 Core/Spells: add Target Processing (SMSG_SPELLLOGEXECUTE) to LAUNCH_T…
…ARGET phase.

Move EffectInterruptCast to LAUNCH_TARGET Phase.
2016-10-21 08:23:40 +02:00
Aokromes
57d0a5d16d Revert "Core/Spells: Implementation of QAston proc system"
This reverts commit a70e4e26b3.
2016-10-21 07:27:04 +02:00