Commit Graph

21353 Commits

Author SHA1 Message Date
jackpoz
cc0f20f73d Core/Misc: Fix no-pch build 2019-02-16 18:28:25 +01:00
Shauren
cd6d57e2e7 Core/Misc: Improved error message reported by ASSERT_NOTNULL
(cherry picked from commit d184768bbc)
2019-02-16 17:26:57 +01:00
jackpoz
78f70cbff2 Core/Misc: Fix static analysis issues
Fix static analysis issues reported by Coverity
2019-02-16 13:40:39 +01:00
Heaven31415
9db50f05cb Refactor SendSysMessage, SendGlobalSysMessage, SendGlobalGMSysMessage (#23029) 2019-02-16 13:29:22 +01:00
Sorikoff
f0f4d0280d Scripts/Scarlet Enclave: Stable Master Kitrik's spell Repo (#23023) 2019-02-16 13:28:31 +01:00
Shauren
ab22619f46 Fix build 2019-02-15 21:55:52 +01:00
Shauren
7515553c29 Fix build for older compilers 2019-02-15 21:37:31 +01:00
Shauren
813f693768 Core/Misc: Added lambda support to EventProcessor
Closes #22909
2019-02-15 21:34:56 +01:00
Giacomo Pozzoni
5b7ead65bb Core/Scripts: Change PlayerScript and CreatureScript inheritance (#23048)
Remove UnitScript from PlayerScript and CreatureScript classes as that's how the original system that was PR'd worked, see https://github.com/TrinityCore/TrinityCore/pull/7867 for reference.
Please note these are used as global hooks and should really just invoke stateless functions.
If you need to hook methods from PlayerScript/CreatureScript and UnitScript, just define 2 different scripts (this is how the original system worked and how it was designed to work)
2019-02-15 20:29:14 +01:00
TheWinchesters
a0056951f7 [3.3.5] Commands: lookup player shows which character is online (#23039)
* Show 'online' for every online player in lookup player commands
2019-02-15 20:18:58 +01:00
Giacomo Pozzoni
cb8ff7976b 3.3.5 threat assert (#23034)
* Core/Creature: Change assert about Threat to log
2019-02-15 20:03:26 +01:00
Giacomo Pozzoni
c79811de4f Shared/Utilities: Handle string format exceptions
Handle StringFormat() exceptions in case of malformed string format to avoid causing unhandled exception crashes
2019-02-15 20:01:10 +01:00
Rushor
d69ef2ab1d Creature/Script: Move "Bartleby" script to SAI 2019-02-13 09:30:55 +01:00
Aokromes
2d22c027fe Core/Misc: Add categories to 3 logs 2019-02-08 10:58:33 +01:00
Aokromes
1cba363360 Core/Spells: Add categories to 2 logs 2019-02-08 10:32:11 +01:00
Aokromes
578c796625 Core/Entities: Add categories to 2 logs
Closes #22922
2019-02-08 10:05:33 +01:00
jackpoz
c8ec2dd95d Core/MMaps: Fix infinite loop in Detour
Fix an infinite loop in Detour happening in Dalaran Sewers.
This is more of an emergency patch until we figure out why dtNodes have a circular reference (A -> B -> C -> A) happening quite often in this place
2019-02-06 19:32:31 +01:00
jackpoz
2fda1572d2 Core/Misc: Fix issues reported by static analysis
Fix issues reported by Coverity Scan
2019-02-05 21:10:39 +01:00
jackpoz
9942047c72 Core/Misc: Fix issues reported by dynamic analysis
Closes #23021
2019-02-05 20:29:39 +01:00
jackpoz
f04e90f638 Core/Group: Fix memory leak
Fix memory leak happening when disbanding a group with an ongoing roll.
Please note this is not blizz-like but at least we don't leak memory anymore.
2019-02-02 21:51:04 +01:00
jackpoz
c40c60572c Scripts/ScarletEnclave: Fix no pch build 2019-02-02 21:41:24 +01:00
Sorikoff
d5f565f429 Scripts/Scarlet Enclave: Grand Theft Palomino (#22967)
* Grand Theft Palomino

* Cosmetic issues

* Address CR
2019-02-02 21:28:18 +01:00
Chaouki Dhib
f9ed72e351 Core/Movement: Implement move time skipped handler (#22994)
* Implement CMSG_MOVE_TIME_SKIPPED handler and move it to MovementHandler.cpp

* Add better error handling

* Update MovementHandler.cpp
2019-02-02 21:15:19 +01:00
jackpoz
46c7446bd4 Core/Spells: Fix assert triggered
Fix assert triggered when a spell would trigger another spell in OnEffectHitTarget that would kill the aura owner, then processing the main spell effects. The triggered spell can kill the aura owner, changing its death state to CORPSE and removing auras created.

Fix #21856
Ref 518e6299ca
2019-02-02 21:00:28 +01:00
Sorikoff
806dd940ce DB/Quest: Sniff Out the Enemy
Closes #23006
2019-02-02 15:06:11 +01:00
Keader
33b0654f8e Scripts/Magister Terrace: Fixed a enum mistake 2019-02-01 08:21:12 -03:00
Keader
6545cd33b9 Core/Misc: Fixed shaman elementals and magister terrace first boss access 2019-01-30 14:48:46 -03:00
Keader
71dde16ce9 Scripts/Utgarde Keep: Fix Ingvar Evading (again)
UNIT_FLAG_NON_ATTACKABLE makes ingvar become a invalid target and lose threatlist, so me->IsThreatened() will return false.
We dont need it at all, since UpdateAI will handle evade already.
2019-01-28 17:42:00 -03:00
Keader
06078e30c6 Scripts/Temple of Ahn Qiraj: Scripted doors of AQ40
Doors added in 1ba09572b5
2019-01-28 17:13:59 -03:00
Keader
b244fe0d40 Make Travis Happy :) 2019-01-28 16:19:55 -03:00
Ovah
1b346485e4 Scripts/Magister Terrace: Update InstanceScript and more fixes
Cherrypicked of https://github.com/Ovahlord/TrinityCore/commits/4.3.4
2019-01-28 16:15:38 -03:00
Keader
6bd3af56dc Build fix ³ 2019-01-28 15:23:28 -03:00
Keader
ae99a38ef2 Build fix² 2019-01-28 15:20:57 -03:00
Keader
355ba87402 Build fix 2019-01-28 15:15:18 -03:00
Ovah
00958c9178 Scripts/Magister Terrace: Felblood Kaelthas rewrite
Cherrypick of ae440400aa
2019-01-28 15:03:46 -03:00
Keader
fd69c133b1 Scripts/Black Temple: Mother Shahraz fatal attraction need be random
Higher distance showed in my sniffs is 48 yards (rounding 50 yards). If someone find more then that, please let me know.
Ty killerwife
2019-01-28 11:19:23 -03:00
Keader
ef6240312c Scripts/Black Temple: Fixed some issues in Illidari Council
Ty killerwife for all help :)
2019-01-28 10:15:00 -03:00
jackpoz
e4658a1307 Tools/MMaps: Allow to specify different Recast settings for different maps
Allow to specify different Recast settings for different maps, currently handled in GetMapSpecificConfig() as a switch statement.
Set walkableRadius to 0 in Blade's Edge Arena (Map ID 562) so the pets can walk on the thin rope between the bridge and the pillar.
2019-01-27 15:20:38 +01:00
jackpoz
5ff88ea04a Dep/Recast: Update recastnavigation to 14b2631527
Rebuilding mmaps IS required
2019-01-26 20:44:27 +01:00
jackpoz
813cf761fc Core/MapScripts: Allow GameObjects to be caster of SCRIPT_COMMAND_CAST_SPELL 2019-01-21 21:14:27 +01:00
jackpoz
518e6299ca Core/Spells: Fix assert triggered
Fix assert triggered when a spell would trigger another spell in OnEffectHitTarget that would kill the target, then processing the main spell effects. The triggered spell can kill the target, changing its death state to CORPSE and removing auras created.
Fix #22306
2019-01-19 17:41:03 +01:00
jackpoz
dc628b23e2 Core/Misc: Fix clang 6.0 warnings
Ported from e9bcae1fad
2019-01-19 15:02:47 +01:00
jackpoz
d05ab073cb Core/Misc: Update 85e3169fbd about SOAP
Change again how SOAP is stopped if SOAP successfully binds but worldserver fails to bind its sockets.
A crash remains if SOAP fails to bind because it calls exit() and that triggers asserts everywhere.
2019-01-18 22:57:23 +01:00
jackpoz
46f2595f51 Core/Networking: Set SO_REUSEADDR on *nix platforms 2019-01-18 20:31:47 +01:00
jackpoz
85e3169fbd Core/Misc: Fix shutdown with SOAP enabled
Fix worldserver entering a loop when having SOAP enabled but failing to bind both SOAP and worldserver listened socket. SOAP thread would keep trying to bind the socket over and over checking World::IsStopped() condition that was never set to true
2019-01-18 17:58:24 +01:00
ccrs
d8819147b0 Core/Misc: update SMSG_UPDATE_WORLD_STATE uses 2019-01-17 11:52:38 +01:00
ccrs
bcb0b03fac Server/Packets: port WorldStatePackets from master 2019-01-17 11:06:35 +01:00
ccrs
c5423fa474 Scripts/ICC: npc_suppresser corrections
closes #22908
2019-01-16 23:30:23 +01:00
Shauren
63ea6a50e8 Core/Creatures: Only allow class and pet trainers to reset talents and teach dual spec
Closes #22953
2019-01-16 21:58:21 +01:00
Kittnz
d1c3ee9579 Core/Objects: increase sight range of objects & correct general default visibility distance (#22891)
This can be used for anything really.
Note: This does not make the object active.

#21111 #21681
2019-01-16 20:47:25 +01:00