Commit Graph

380 Commits

Author SHA1 Message Date
megamage
d205ff9e06 [8377] Resolve some spell_area problems in GM and non-GM mode. Author: VladimirMangos
* Make spell 40216 and 42016 casted/remove at aura 40214 apply/remove.
      And drop related spell_area possible existed data.
    * In general restore apply area limitations to spell casting in GM mode.

--HG--
branch : trunk
2009-08-17 16:34:02 -05:00
megamage
6a9693a1e4 [8369] Some step back in triggered effect caster selection. Author: VladimirMangos
(I do not know what spells this will fix)

--HG--
branch : trunk
2009-08-17 15:54:39 -05:00
QAston
b8993423b5 *Implement aura type SPELL_AURA_MOD_CRIT_PCT(290).
--HG--
branch : trunk
2009-08-17 16:30:14 +02:00
QAston
41c12d173b *Add spell_bonus_data for lightwell - by Elron
*Add aura_required, aura_forbidden, user_type columns to npc_spellclick_spells table for additional requirement checks
*Remove workarounds from lightwell code and use new npc_spellclick_spells fields instead.

--HG--
branch : trunk
2009-08-17 02:53:39 +02:00
megamage
b8222df247 *Make sure spell 52479 (gift of the harvester) always works.
--HG--
branch : trunk
2009-08-14 21:45:54 -05:00
megamage
c40be3e50a *Script of Netherspite. By Iskander
--HG--
branch : trunk
2009-08-14 18:34:16 -05:00
megamage
17b5663a36 [8359] Make effect from item 20414 positive. Author: VladimirMangos
--HG--
branch : trunk
2009-08-12 20:58:58 -05:00
megamage
603685a2d2 * Some cleanups and better checks in IsPositiveEffect. Author: VladimirMangos
--HG--
branch : trunk
2009-08-12 20:42:07 -05:00
megamage
8ee1e20acd [8345] corrected startup-checks for spell_area table
old problem was that, for example
    a single spell couldn't be cast
    at aura OR quest (so 2 entries in this table)

    .. will be now possible

    Signed-off-by: balrok <der-coole-carl@gmx.net>

--HG--
branch : trunk
2009-08-12 20:38:24 -05:00
QAston
ba91c78ceb *Update Mana Shield Spell Power Coefficient - by fukifat.
*Add function void AuraEffect::HandleAuraEffectSpecificMods(bool apply, bool Real, bool changeAmount), and aura effect specific stuff to it.
*More correct aura scaling with lvl for area auras.
*Prevent exploits with relog while having auras with modified amount.

--HG--
branch : trunk
2009-08-13 00:52:05 +02:00
QAston
bee1dff87f *Use #defines instead of spellids for often used spells.
*Make recently broken talent Improved Healthstone work again - by iadus3.

--HG--
branch : trunk
2009-08-12 18:51:19 +02:00
megamage
177f78be1a *Correctly check ispositive for spells.
--HG--
branch : trunk
2009-08-11 13:11:16 -05:00
QAston
e2e70b936b *Cleanups and obsolete spell handlers remove.
--HG--
branch : trunk
2009-08-11 19:57:27 +02:00
megamage
08d4aac161 *Consider all non-existing spells as negative. This fixes the broken Forbearance.
--HG--
branch : trunk
2009-08-11 11:32:32 -05:00
QAston
6b4772207f *Cleanups, remove obsolete code and minor optimizations in spellauras.cpp and spelleffects.cpp
*Remove GetDummyAura(uint32 spellid) function - it is faster to use GetAuraEffect or GetAura if id is known than iterate threw dummy auras list
*Move Death Strike code from HandleDummyAuraProc to Spell::EffectDummy - original patch by hununza.

--HG--
branch : trunk
2009-08-08 16:18:05 +02:00
megamage
7dd131a293 *Use flags for positive spell check to reduce calculation.
--HG--
branch : trunk
2009-08-06 11:24:14 -05:00
megamage
907342d5b0 [8308] More generic code for new continent spell casting including fly form/mounts. Author: VladimirMangos
* Check new continent requirement by SPELL_ATTR_EX4_CAST_ONLY_IN_OUTLAND in
      SpellMgr::GetSpellAllowedInLocationError.
    * Also in this function let ignore any area requirement in GM-mode (except client side checks ofc if use spellbook/item)
    * For fly form/mount auras check only speciaal reqirement like special fly skill and ignore it for dead state.
    * Drop explicit fly auras drop at zone update, now this part GetSpellAllowedInLocationError functionality.
    * Allow in `spell_area` have data deepndent from ghost auras

    This all allow implement apply spells 55173/55164 to player ghost wiht DB support in `spell_area`

--HG--
branch : trunk
2009-08-05 16:33:34 -05:00
megamage
e7ebddfc9a [8306] Implement single-per-caster limitation for paladin "hand of" spells. Author: VladimirMangos
--HG--
branch : trunk
2009-08-05 16:11:12 -05:00
QAston
afd9eb77aa *Make cleansing totem remove poisons - by Them
--HG--
branch : trunk
2009-08-05 02:45:35 +02:00
QAston
d95e9c1027 *Fix Gargoyle feeding behaviour - original patch by thenecromancer.
*Add SPELL_TARGET_TYPE_CONTROLLED for spell_script_target table for fast search of units(grid search skipped) and to prevent applying effects to not owned summons

--HG--
branch : trunk
2009-08-04 19:28:31 +02:00
megamage
c1d94ad607 [8279] Fixed paladin auras for SpellSpecific. Author: nos4r2zod
--HG--
branch : trunk
2009-08-02 09:51:11 +08:00
Nevan
03604a2567 *Fix Spell 1852 (This is a GM tool for silencing players.)
--HG--
branch : trunk
2009-08-01 12:06:06 +02:00
QAston
0fdd7cd5de *Remove data from world.sql - it exists now only for structure documentation.
*Remove debug spell_check command - such things shouldn't belong to core.

--HG--
branch : trunk
2009-07-31 15:35:31 +02:00
QAston
b212461f95 *Merge after backout.
--HG--
branch : trunk
2009-07-31 13:21:32 +02:00
QAston
1f53433c6c Backed out changeset "[8251] Store in some DB tables only data for first rank. Author: VladimirMangos" until support for different values for ranks and for custom ranks is added.
--HG--
branch : trunk
2009-07-31 13:21:01 +02:00
megamage
e1571c0492 *Handle target area path as area cone for now.
--HG--
branch : trunk
2009-07-31 11:12:04 +08:00
megamage
519ab6af82 [8265] Add boss spells 64422 and 64688 to divided damage spells list. Author: Lutik
--HG--
branch : trunk
2009-07-31 11:06:35 +08:00
megamage
2bddcc4303 [8251] Store in some DB tables only data for first rank. Author: VladimirMangos
* Allow add to DB data only for first rank in table `mangos_spell_bonus_data` and `mangos_spell_proc_event`.
    * Copy data for other ranks for speedup use at loading for this data and data from `spell_proc_item_enchant`.

--HG--
branch : trunk
2009-07-31 10:21:57 +08:00
QAston
13758fcae1 *Fix per-caster aura state based on [8218] (Author: VladimirMangos;almost nothing left from original patch):
*Fixes all per caster aurastates instead of only conflagrate
*Adds a holder for aura state auras for speedup search
*Save some memory space by removing m_auraStateMask from aura class.

--HG--
branch : trunk
2009-07-30 17:16:56 +02:00
QAston
2a402ff6c7 *Merge required after backout.
--HG--
branch : trunk
2009-07-30 11:52:40 +02:00
QAston
9c52a12e08 Backed out changeset 6ba74f274cb9 - mangos [8249]
--HG--
branch : trunk
2009-07-30 11:44:23 +02:00
megamage
af2d5e3fd4 [8250] Cleanup code and data for spell_threat Author: nos4r2zod
* Load table data to std::map instead SQLStorage and add check loaded spell existance.
    * Drop from table not existed spells.

--HG--
branch : trunk
2009-07-30 11:37:08 +08:00
megamage
7121d98480 [8249] Implement support spell_proc_item_enchant table for ppm item enchantments triggering at hit.
* Added a new SQL table, spell_proc_item_enchant, for "custom" ppmRates on Item Enchants that do not use auras.
      With table data this must fix ppm for effect from 8033 and ranks enchanting, and item 6947/10918 and ranks enchanting.

    * Implemented SPELLMOD_FREQUENCY_OF_SUCCESS (26).
      That must fix work talent 14113, spell 32645 with ranks, glyph 41094 and item set effect 64917 in frequency part.

    Thanks to MaS0n as author alternative patch that partly used in this patch.
    Thanks to Thenecromancer as author alternative patch that ideas inspire MaS0n's patch writing and then this patch also.

Author: nos4r2zod

*Note: has been implemented before. Only use part of the patch.

--HG--
branch : trunk
2009-07-30 11:33:28 +08:00
megamage
e864cbed8c [8243] Fixed problems with unexpected set diminishion return level at arena for fear/turn spells. Author: VladimirMangos
--HG--
branch : trunk
2009-07-30 11:06:31 +08:00
megamage
c5fa7219c5 [8201] Apply PvP duration limit to spell 15286 Author: Alez
--HG--
branch : trunk
2009-07-24 09:14:22 +08:00
QAston
4a17224a65 *Creature eventAI cancast power check - by smellbee.
--HG--
branch : trunk
2009-07-23 18:32:32 +02:00
megamage
2126ec3395 *Let MECHANIC_SHACKLE has DIMINISHING_CONTROL_STUN. By VladimirMangos
--HG--
branch : trunk
2009-07-23 09:34:10 +08:00
megamage
f481e7b14d [8191] Drop code related to use long time empty spell_affect table. Author: XTZGZoReX
After switch to 3.x.x all data get explcitly from ClassMask fields in spell.dbc
    and no need in custom values.

--HG--
branch : trunk
2009-07-23 09:30:05 +08:00
QAston
b16ffa91b1 *Correct diminishing returns for charge and linked spell for Stoneform.
--HG--
branch : trunk
2009-07-19 14:56:18 +02:00
QAston
94992adb64 *Fix DK presences and their improved versions - original patch by thenecromancer
*Port player to homebind if instance cannot be created in WorldSession::HandleMoveWorldportAckOpcode.

--HG--
branch : trunk
2009-07-19 14:02:52 +02:00
QAston
51ed0f00cf *Set one charge for Elune's Wrath - by Drethek.
--HG--
branch : trunk
2009-07-19 00:27:03 +02:00
QAston
bc4d862263 *Add new column to spell_bonus_data table to store ap bonus for periodic auras.
*Use -1 to mark entries, for which default spell bonus calculation should be used.
*Move periodic auras ap bonuses from core to db.
*Add coefficient for Black Arrow.

--HG--
branch : trunk
2009-07-18 22:18:47 +02:00
QAston
6c8f54c4a6 *Fix Master Shapeshifter - original patch by Drethek
--HG--
branch : trunk
2009-07-17 19:09:08 +02:00
megamage
e1762e3e6d [8169] Implement new optional table spell_check and console command .debug spellcheck Author: VladimirMangos
* Table expected to be store data mirror same data in code:
      - explicit spell ids with related expected spell properties like effects, spell family or auras
      - implicit requirements for select some spell sets like spell family masks, icons or visual values
    * For check can be used .debug spellcheck _console_ only command.
    * Main purpose table and related command check code parts for outdated data at client switch.
      It also can be used for check data in patch writing time to be sure code correctness.

--HG--
branch : trunk
2009-07-16 10:13:12 +08:00
QAston
2120bc0d30 *Fix a bug that creatures with owner chase their enemies after death.
*fix a typo breaking procflags on aura remove - shattered barrier and master of subtlety work again

--HG--
branch : trunk
2009-07-13 18:05:53 +02:00
QAston
84644b7644 *Some improvements in procflags:
-handle proc_flag_death
 -allow trap selection in spell proc event entry for proc_flag_on_trap
*Add spell_proc_event entry for Lock and Load - by Bengan
*Add spell_proc_event entry for Improved Spell Reflection.

--HG--
branch : trunk
2009-07-11 20:06:02 +02:00
QAston
4dc5242a69 *Fix Desecration.
*Correct a typo which made some of charged auras to be not dropped.

--HG--
branch : trunk
2009-07-11 13:03:06 +02:00
QAston
107e7eafbd *Add new procExFlag: PROC_EX_ONLY_ACTIVE_SPELL - which allows only damaging/healing spells to proc - this fixes double proc of judgement auras in some cases.
--HG--
branch : trunk
2009-07-09 23:49:46 +02:00
QAston
f28810576d *Fix the bug that freezing trap has not diminished duration.
--HG--
branch : trunk
2009-07-08 00:16:51 +02:00
QAston
8090b33025 *Implement attribute flag SPELL_ATTR_EX3_STACKS_FOR_DIFFERENT_CASTERS.
--HG--
branch : trunk
2009-07-07 21:48:25 +02:00