Commit Graph

21682 Commits

Author SHA1 Message Date
ccrs
eb6ea57e7f Scripts/ICC: 94b60ff followup 2019-06-29 19:38:16 +02:00
ccrs
14788ce026 Core/Instance: add new method 2019-06-29 19:32:13 +02:00
ccrs
953b05459a Core/Instance: add new hook & method 2019-06-29 19:24:05 +02:00
ccrs
303811399f Build: fix error
/var/lib/jenkins/jobs/tc_335_release_clang40_boost_1.63.0_nopch/workspace/src/server/scripts/Kalimdor/CavernsOfTime/CullingOfStratholme/npc_arthas.cpp:583:132: warning: format specifies type 'unsigned int' but the argument has type 'float' [-Wformat]
                TC_LOG_TRACE("scripts.cos", "npc_arthas_stratholmeAI::AdvanceToState: has snapback for this state, distance = %u", target.SnapbackPosition->GetExactDist(me));
                                                                                                                              ~~   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                                                                                                              %f
/var/lib/jenkins/jobs/tc_335_release_clang40_boost_1.63.0_nopch/workspace/src/common/Logging/Log.h:176:56: note: expanded from macro 'TC_LOG_TRACE'
    TC_LOG_MESSAGE_BODY(filterType__, LOG_LEVEL_TRACE, __VA_ARGS__)
                                                       ^~~~~~~~~~~
/var/lib/jenkins/jobs/tc_335_release_clang40_boost_1.63.0_nopch/workspace/src/common/Logging/Log.h:159:32: note: expanded from macro 'TC_LOG_MESSAGE_BODY'
                    check_args(__VA_ARGS__);                            \
                               ^~~~~~~~~~~
2019-06-29 18:40:31 +02:00
ccrs
22b3b21ae3 Core/Instances: improve DoRemoveAurasDueToSpellOnPlayers & DoCastSpellOnPlayers handling 2019-06-29 18:36:11 +02:00
ccrs
626a24822b Misc: some corrections after recent merges 2019-06-29 16:01:58 +02:00
Sorikoff
33b4ad5a89 Scripts/Spells: Ultrasafe Transporter: Toshley's Station (#23537)
* Scripts/Spells: Ultrasafe Transporter: Toshley's Station

* Rename 9999_99_99_99_world.sql to 2019_06_29_01_world.sql
2019-06-29 14:02:04 +02:00
Sorikoff
8d1a5fa126 Scripts/Spells: Remove Collapsing Cave Aura (#23533)
* Scripts/Spells: Remove Collapsing Cave Aura

* Rename 9999_99_99_99_world.sql to 2019_06_29_00_world.sql
2019-06-29 13:35:11 +02:00
Wyrserth
eb7a6391aa Core/Loot: fix issue that prevented players from rolling for an unique-category item while an equipped item shares the same unique-category. 2019-06-29 01:46:54 +02:00
Wyrserth
37bcf343e2 Add forgotten break to High Priest Thekal's script, thanks jackpoz! 2019-06-28 22:46:25 +02:00
jackpoz
de88691e25 Core/Misc: Fix static analysis issues reported by Coverity Scan 2019-06-28 22:18:30 +02:00
Sorikoff
62b2c379b3 Scripts/Spells: Deathbolt (#23531)
* Scripts/Spells: Deathbolt

* Rename 9999_99_99_99_world.sql to 2019_06_28_01_world.sql
2019-06-28 20:18:02 +02:00
Sorikoff
63f548921c Scripts/Spells: Dimensional Ripper - Area 52 (#23505)
* Scripts/Spells: Dimensional Ripper - Area 52

* Rename 9999_99_99_99_world.sql to 2019_06_28_00_world.sql
2019-06-28 20:15:16 +02:00
Wyrserth
cd73664f53 Core/GameObject: do not allow consumable chests to restock while partially looted. 2019-06-28 19:28:30 +02:00
Wyrserth
9f0ac0c243 Core/GameObject: fix some cases where summoned gameobjects of a type different than chest or goober would behave wrongly. 2019-06-28 16:53:39 +02:00
Wyrserth
5dc2dfd60c Core/Spell: fix some issues with taunt spells (#23425) 2019-06-27 22:08:39 +02:00
Wyrserth
cf223370f3 Core/Mail: include 100g in the mail sent after turning in the quest The Wrath of Neptulon (#23500) 2019-06-27 22:07:00 +02:00
Wyrserth
365e2f191e Script/ZulGurub: rewrite High Priest Thekal's encounter script (#23429) 2019-06-27 21:03:29 +02:00
Wyrserth
cb524a06b7 Core/GameObject: trigger an update of nearby objects when the player completes a quest objective.
Prevents quest-related gameobjects from staying lootable after the player looted the last quest item from another gameobject.
2019-06-27 20:30:26 +02:00
Wyrserth
e77c2d55c4 Core/GameObject: implement restock mechanic for non-consumable gameobjects (#23526) 2019-06-27 20:27:04 +02:00
Wyrserth
eeba12778b Core/SAI: add param3 to SMART_ACTION_CALL_TIMED_ACTIONLIST to allow it to override a currently running actionlist. 2019-06-27 01:48:12 +02:00
Wyrserth
50c5d30d13 Core/GameObject: restore old behavior for non-consumable chests with restock timer (make them despawn). 2019-06-26 22:02:27 +02:00
Wyrserth
2b1e8d135b Core/GameObject: don't allow non-consumable goobers to despawn on use (#23469)
Closes #15730.
2019-06-26 18:28:08 +02:00
Wyrserth
efc999227d Core/Spell: allow damage from binary spells to go through elemental resistance's damage reduction. (#23479) 2019-06-26 18:25:06 +02:00
Wyrserth
7a71127da9 Core/SAI: allow creatures to handle gameobject spellhit SAI events. (#23492) 2019-06-26 18:08:19 +02:00
Wyrserth
8967cc96df Core/SAI: do not pass old creatureData to UpdateEntry() and keep current health when changing a NPC's entry. (#23493) 2019-06-26 18:03:03 +02:00
Keader
079b77b5fc Script/FoS: prevent Wailing Souls from becoming desynched in the Devourer of Souls encounter. 2019-06-26 17:32:06 +02:00
Wyrserth
22b222b44e Script/CoS: fix DB error and remove wrong on-death text for Chrono-Lord Epoch. 2019-06-26 12:06:45 +02:00
Aokromes
fe744977c9 Coding standards (#23514)
* Coding standards

* revert part
2019-06-26 08:56:20 +02:00
Treeston
63383da36e fix comment, 3cdf274 follow-up 2019-06-26 01:06:01 +02:00
Treeston
3cdf27494f Core/AI: Actually accurately reproduce the logic from before 849943 that determines what summons start following on appearance. Third time's the charm?
Closes #23513.
2019-06-26 01:04:27 +02:00
ccrs
ca62280675 Script/CoS: full instance rewrite (#23388) 2019-06-25 20:56:43 +02:00
Wyrserth
c95531595e Core/SAI: silence wrong SAI error when using SMART_ACTION_SET_DATA on a creature using CreatureAI.
This behavior is fully allowed and should not report any kind of error.
2019-06-25 18:06:20 +02:00
Shauren
c0b25c9a83 Core/Creatures: Fixed crash in CreatureAI::JustAppeared caused by scripted summons without SummonProperties
Closes #23507
2019-06-24 18:47:04 +02:00
ccrs
337de2b61e Core/Player: 72fc79a followup
safer approach, please report any returning issue
2019-06-24 14:32:59 +02:00
Aokromes
9817bb55a3 Core/Groups: Delete duplicate semicolon
thx elon.
2019-06-24 13:54:56 +02:00
ccrs
4a8736b829 Scripts/Misc: couple corrections to the recent PRs 2019-06-24 13:32:43 +02:00
ccrs
3c77c04b05 Core/AI: remove extra empty line 2019-06-24 12:52:35 +02:00
ccrs
ebd438883e Core/AI: minimize further undesired behaviours (e3e4b97 followup)
Those Category checks come from checking all Spell::SummonGuardian uses
2019-06-24 12:49:15 +02:00
Treeston
e3e4b975ce AI/TotemAI: Tell Shaman Totems to stay put and stop moving. Closes #23498. 2019-06-24 02:30:07 +02:00
Treeston
854a113fc7 AI/SmartAI: Properly forward to inherited CreatureAI::JustAppeared in SmartAI::JustAppeared. Fixes #23491. 2019-06-23 23:32:21 +02:00
Treeston
1158f267df Combat/Threat: Split ThreatManager::NotifyDisengaged off from ThreatManager::ClearAllThreat. NotifyDisengaged signifies intent to clear the engagement flag, and should only be called from AI. Fixes #23490. 2019-06-23 23:31:51 +02:00
jackpoz
00575221e3 Core/Misc: Code cleanup
(cherry picked from commit eeced9ae15)
2019-06-23 22:27:28 +02:00
Treeston
37fc38b917 AI/SmartAI: Move SMART_EVENT_RESPAWN invocation from ::InitializeAI() to ::JustAppeared(). Closes #23313. 2019-06-23 17:37:35 +02:00
Treeston
8499434340 Core/AI: Remove EnterEvadeMode calls from Guardian/Summon spell handlers. Add follow logic to CreatureAI::JustAppeared. Closes #23270. 2019-06-23 17:18:42 +02:00
Treeston
aeed616c22 Entities/Unit: Adjust an overzealous assert to not catch self references, and add the inverse assert too. 396f87c follow-up. 2019-06-23 16:56:15 +02:00
Treeston
f4b06fd0b7 Entities/Unit: Fix an issue where Unit pointers could be left dangling if a channeled Charm was interrupted by a control aura application. Closes #23440. 2019-06-23 16:45:32 +02:00
Treeston
396f87c30d Entities/Unit: Cleanup all the direct accesses to m_unitMovedByMe. Refactor the field to be protected. Add assertions to catch dangling pointers. 2019-06-23 16:44:37 +02:00
Treeston
b3ee407707 Core/Misc: Add static versions of GetGUID and ToX methods to Object. The static versions return Empty/nullptr for null objects. 2019-06-23 16:01:51 +02:00
Treeston
00728cef15 some more cleanup, a5f8c0d follow-up 2019-06-23 13:28:45 +02:00