Commit Graph

22893 Commits

Author SHA1 Message Date
Giacomo Pozzoni
d7459ccced CI/GitHub: Switch to GCC 8 (#25610)
* CI/GitHub: Switch to GCC 8

Build on GitHub Actions using GCC 8 as it's the oldest supported GCC

* Core/Misc: Attempt to fix GCC 8 build
2020-10-25 10:31:29 +01:00
Trond B. Krokli
22a1797731 Scripts/Stormwind City: Tyrion talks to player (#25613)
Add player parameter to the `Talk()` command to resolve an issue where
the creature_text `SAY_TYRION_1` shows $n in-game during the course of
events of the quest "The Attack!" in Stormwind City.

Soon to be replaced by SAI scripting. This is a temp solution.

Ref. #25608 & #24735

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-10-25 10:10:07 +01:00
offl
7fd12cc722 DB/Instance/AQ40: Update gossips
Closes #25577
2020-10-25 01:35:35 +03:00
Shauren
53482f7299 Core/DBLayer: Fixed memory leaks with existing SQLQueryHolder uses and eliminated the possibilty of adding more in future (replaced manual memory management with smart pointers) 2020-10-24 17:37:24 +02:00
Keader
5e9a856ad7 Game/Player: Fixed Backlash/Backdraft priority (#25564)
Update #18516
2020-10-19 11:27:02 -03:00
Keader
5fee99bdbc Scripts/ICC: Some fixes in Valkyr Shadowguard (#25572)
- Added missing transformation spell
- Fixed Soul Siphon casted in random targets. It should always cast in top threat player.
- Fixed combat reach of transformation
2020-10-14 08:31:15 -03:00
Treeston
684910a230 AI/CreatureAI: Properly update Victim even while spell focusing 2020-10-13 23:44:37 +02:00
Keader
3c0766df54 Scripts/ICC: Fixed Chocking Gas killing Abomination (#25565) 2020-10-12 19:56:56 -03:00
Gildor
b70314b075 Script/Commands: .character changeaccount now disconnects player before transferring (PR #25560) 2020-10-12 20:16:23 +02:00
Keader
182fcc919e Scripts/UtgardPinnacle: Implemented Beast's Mark (#25557) 2020-10-11 13:35:33 -03:00
Keader
dadc0c98c0 Scripts/IcecrownCitadel: Implemented Vampiric Might spell (#25556)
Closes #21294
2020-10-11 13:33:02 -03:00
jackpoz
3947e4cb57 Core/MMAPs: Restore single slope angle of 55°
Re-generating MMAPs IS required.
Partially reverts 995a443da2 .

Having 2 different slope angles of 55° and 85° created too many polygons to fit in the current mmtile structure. This caused some polygons to become disconnected from each other, creating the old "invisible walls" effect. Because of this and because of the performance hit when loading a mmtile caused by the increase of polygon numbers, this commit reverts the recent changes and sets by default the slope angle to 55°.
Feel free to restore the previous behaviour by running .\mmaps_generator --maxAngle 85 --maxAngleNotSteep 55 , specifying the map id as number if a single map should have different slope values.
This is the last commit that will change MMAPs version to force re-generating them. Any future change that will affect only the generation settings will be optional (but recommended).
2020-10-10 23:03:09 +02:00
Gildor
c13ccaab5c Core/Spells: Aura refresh improvements (#25511) 2020-10-08 20:36:50 +02:00
Gildor
ce2d441304 Scripts/Ulduar: Implemented Realm First! Death's Demise (#25530)
* Scripts/Ulduar: Implemented Realm First! Death's Demise

* comment line

* Rename 9999_99_99_99_world.sql to 2020_10_08_01_world.sql

Co-authored-by: offl <11556157+offl@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-10-08 19:57:41 +02:00
Treeston
3ec98bf241 Core/ChatCommands: Fix a potential crash if a custom chat command does not have a specified help string 2020-10-08 17:01:42 +02:00
Shauren
c09ab08ddd Core/Guilds: Fixed crash when kicking guild members
Closes #25537
2020-10-04 22:35:14 +02:00
Giacomo Pozzoni
b6e205f7ef Tools/MMapsGenerator: Add some more input parameters to improve mmaps load performances (#25520)
* Some research about mmaps load performances

* Tools/MMapsGenerator: Add some more input parameters

Add some more input parameters which affect the resulting mmaps:
- --smallOutputSize: sets both walkableSlopeAngle and walkableSlopeAngleNotSteep to 55°, reducing by a lot the .mmtile size and the number of polys. A rcFilterLedgeSpans() call is included too to filter out some polys. Default to false.
- --maxAngle: Restore this parameter removed some commits ago. Specifies the max walkable angle of a Creature when in combat. Default to 85
- --maxAngleNotSteep: Max walkable angle of a Player and of a Creature out of combat. Must be less or equal than --maxAngle. Default to 55.

A performance profiling comparison highlighted that .mmtile load grows exponential with the number of polys. A small server with GridUnload enabled and without preloading all grids on startup will be more affected than a big server with GridUnload disabled and preloading grids on startup.
2020-10-04 21:08:54 +02:00
jackpoz
5be7c2ad4f Core/SAI: Fix SMART_ACTION_WP_RESUME actually pausing next waypoint if the current path was not paused
Fixes #25519
2020-10-04 19:43:49 +02:00
jackpoz
59bb822f78 Core/SAI: Allow to debug SmartAI methods 2020-10-04 17:00:23 +02:00
offl
60ded4ea47 DB/Instance/Auchenai Crypts: Complete overhaul part 1 2020-10-03 02:37:58 +03:00
Ovah
77aa058504 Core/Spells: unify OnSpellCastInterrupt and OnSuccessfulSpellCast hooks into OnSpellCastFinished (#25522)
* added support for calling the hook when completing a channeled spell as well
2020-10-03 00:48:32 +02:00
robinsch
53cb57b864 Core/Aura: Fixed thread-unsafe return from Aura::GetCaster() (#25524) 2020-10-02 09:43:06 +02:00
Ovah
e811b9cdc2 Core/Movement: fix units falling through the ground when hover mode is disengaged (PR #25518) 2020-10-01 04:41:08 +02:00
Ovah
31abdc6ecf Core/Movement: add optional velocity argument for MoveLand and MoveTakeoff (PR #25516) 2020-10-01 02:50:45 +02:00
Shauren
0152878de5 Core/Pets: Add missing nullptr check 2020-09-29 19:50:29 +02:00
Shauren
d163735abd Core/Pets: Fixed crash happening when current pet is forcibly removed while being temporarily unsummoned (like on a mount) 2020-09-29 17:31:50 +02:00
Shauren
a415540775 Core/PacketIO: Add missing ByteBuffer operator overload 2020-09-28 10:37:32 +02:00
Shauren
868c82aa6c Dep/Boost: Support for boost 1.74 - heap
Closes #25470
2020-09-27 21:24:38 +02:00
Shauren
155e37831e Dep/Boost: Partial support for boost 1.74 - asio
Ref #25470
2020-09-27 20:20:59 +02:00
Shauren
7de23e4619 Warning fix 2020-09-27 18:52:13 +02:00
Shauren
0a9e239c12 Core/Mail: Replaced blocking db query in mail sending with async version 2020-09-27 17:07:47 +02:00
Shauren
93f6e7431a Core/PacketIO: Convert mail packets to classes 2020-09-27 15:29:32 +02:00
Shauren
d0d0f51f32 Core/Auction House: Eliminate blocking db queries for account permissions when expiring auctions that have offline bidders 2020-09-27 00:51:52 +02:00
Shauren
dc56f0a1d9 Core/Misc: nopch fixes 2020-09-26 20:51:32 +02:00
jackpoz
6f6cec89e5 Core/Commands: Enable .debug loadcells on console and allow to load a specific tile
Specify the tile as XY. Note that this is not Grid XY
2020-09-26 16:23:26 +02:00
jackpoz
34af088c9b Core/Commands: Fix typo in .mmap loc command
The displayed "tileloc" value is a "swapped" Tile XY, not to be confused with Grid XY.
2020-09-26 16:14:32 +02:00
Treeston
837e32fe11 whitespace to make CI happy, 7bf9a06 follow-up 2020-09-24 22:22:40 +02:00
Treeston
7bf9a0640e Scripts/Commands: Fix a potential crash in cs_account.cpp 2020-09-24 22:12:46 +02:00
Gildor
a770ad0476 Core/Spells: SPELL_AURA_MOD_HEALING_PCT should be negative if TargetType is enemy or BasePoints are negative (#25490) 2020-09-24 13:58:47 +02:00
Treeston
f45600fb2e Scripts/ChatCommands: Rename 'lookup itemset' to 'lookup item set' to remove ambiguity. 2020-09-24 00:06:17 +02:00
Shauren
d29274f3a1 Core/Pets: Fixed crash happening when summoning a different pet than one that was unsummoned by summoning a guardian (imp -> infernal -> felhunter)
Closes #25478
2020-09-23 22:37:11 +02:00
jackpoz
24018b7a74 Core/Creature: Ignore combat reach when looking for assisting creatures
Fixes #25487
2020-09-23 20:17:35 +02:00
Treeston
a6d8a7ad1e Core/ChatCommand: Improve feedback for ambiguous commands 2020-09-23 14:39:39 +02:00
jackpoz
16292f9d94 Core/Pet: Fix GetDebugInfo() output 2020-09-22 20:41:00 +02:00
Treeston
899932a275 Scripts/Commands: Move .account to trinity_string 2020-09-22 20:26:51 +02:00
Giacomo Pozzoni
e2d643f551 Core/Quest: Fix wrong feedback sent to the quest sharing sender with auto-accept quests. (PR #25477) Closes #25474.
Co-authored-by: Treeston <treeston.mmoc@gmail.com>
2020-09-22 00:34:41 +02:00
Treeston
26c510775c Core/ChatCommands: Add trinity_string support for chat command help 2020-09-21 02:37:18 +02:00
Treeston
e11b466897 Scripts/Commands: Rename .additemset to .additem set to avoid ambiguity 2020-09-20 22:29:09 +02:00
Treeston
9fda67d016 Scripts/ChatCommands: Constrain how char const* may be used as a command handler parameter. It may now only be used in the legacy configuration, as the only argument. 2020-09-20 15:01:46 +02:00
Treeston
991dc8e050 1eca51b follow-up, nuke command.permission from orbit; it was only duplicating data already stored in the core. 2020-09-20 03:31:54 +02:00