Commit Graph

357 Commits

Author SHA1 Message Date
Kandera
d98f36194b Core/Spells: attempt to correct issue with triggered spells happening before the spell actually hits the target. reply with any bugs that this causes please! 2012-05-24 17:34:51 -04:00
Kandera
d1e0dc3fe0 Core/Spells: fix dispel aggro in a less hacky way! 2012-05-18 13:49:59 -04:00
Kandera
e897bb59f7 Core/SpellEffects: successful dispel effects on hostile targets should put you in combat. Closes #656 Closes #678 2012-05-18 12:25:13 -04:00
Vincent-Michael
e122f9fd30 Core/Spell:
* Fix Nourish heal calculation
* Fix some codestyle
2012-05-13 18:08:57 +02:00
Vincent-Michael
79a735fb01 Core/Spell:
* Fix Spells with DmgClass SPELL_DAMAGE_CLASS_NONE
* Fix SPELL_AURA_PERIODIC_HEAL calculation
* Fix Swiftmend heal calculation
* Fix some codestyle
2012-05-13 16:29:01 +02:00
joschiwald
4e354d6ca9 Core/Spells: fix damage mods from caster on target 2012-05-11 22:43:06 +02:00
Chaplain
469ba0b0e7 Clean up for 58f63509cd
*restore const methods in spellauraeffects
*fix typo in Unit::CalculateMeleeDamage thx bytewarrior
*minor speed up in SpellInfo::GetMaxTicks() thx Warpten
*deleted duble ';;' thx bytewarrior
*speed up in SpellInfo::GetMaxTicks() thx goes to Vincent-Michael
2012-05-10 20:42:07 +03:00
QAston
58f63509cd Merge pull request #6314 from Chaplain/spells
Core/Spells: Separation of caster/target part damage/heal bonus calculation.
2012-05-09 15:10:33 -07:00
Chaplain
879070bc80 Core/Spells: Separation caster/target part damage/heal bonus calculations.
*Implement HoT/DoT save caster side bonuses and apply target mods on each tick
2012-04-28 23:32:25 +03:00
Shauren
51656d7e60 Scripts/Icecrown Citadel: Fixed Scent of Blood on heroic mode of Deathbringer Saurfang encounter 2012-04-27 15:38:09 +02:00
Vincent-Core
408c78dcd7 Core/Spells
* Converted percent based damage dealing spell effects to scripts
 * Fix Leviroth Self-Impale damage

Closes #6085

Signed-off-by: Shauren <shauren.trinity@gmail.com>
2012-04-21 12:17:45 +02:00
kaelima
9559a48877 Core/Spell: Attempt to fix some rare steady shot crashes
ref issue #5689
2012-04-21 02:42:59 +02:00
Subv
20a09c5857 Core/Spells: Fixed Lifebloom's final bloom benefit from Empowered Rejuvenation
closes #244
Signed-off-by: Subv <s.v.h21@hotmail.com>
2012-04-12 05:54:33 -05:00
Subv
e309c4fe1b Core/Spells: Fixed Riptide bonus on Chain Heal
closes #1152

Signed-off-by: Subv <s.v.h21@hotmail.com>
2012-04-08 19:09:30 -05:00
Subv
38d5fbac0e Core/Spells: You should be able to revive pets from anywhere without summoning them first
Closes #1090
Signed-off-by: Subv <s.v.h21@hotmail.com>
2012-04-08 16:22:19 -05:00
Machiavelli
bc96df1aae Core/Shared: Move container functions to shared project under Trinity::Container namespace. Also implement RandomResizeList which takes a predicate function as parameter.
Core/ScriptedAI: Extend SummonList::DoAction to take a predicate function as parameter and allow specifying a maximum number of units to be selected.
2012-04-08 17:40:05 +02:00
Gyx
360014856d Core/Game: Code style.
Signed-off-by: Gyx <2359980687@qq.com>
2012-03-29 13:42:04 +08:00
Gyx
72cdcbfced Core/Game: Code style.
Signed-off-by: Gyx <2359980687@qq.com>
2012-03-28 19:11:50 +08:00
Gyx
1e94ab8d51 Core/Game: Code style and remove unused core.
Signed-off-by: Gyx <2359980687@qq.com>
2012-03-17 20:13:37 +08:00
Kandera
01bc6c483b Core/Spells: add correct checking for dispeling errors. Fixes spammable cleanse. 2012-03-15 10:56:56 -04:00
leak
2a5caef4a6 Revert "Core: more more cleanup" - Build test anyone?
This reverts commit 20cd4c71ee.
2012-03-14 18:51:51 +01:00
thomas33
20cd4c71ee Core: more more cleanup 2012-03-14 17:51:11 +01:00
QAston
a08fe16d69 Core/Spells: Allow spell effects to have multiple destinations. Spells like: 49814, 10869 and similar are now properly selecting destination targets. 2012-03-03 00:19:48 +01:00
Spp
d38bc3a178 Core: Rename GetCreatureInfo to GetCreatureTemplate and minor cleanup here and there 2012-02-27 14:58:47 +01:00
QAston
a0de042efe Core/Spells: Remove SpellSelectTargetTypes enum - it's not needed anymore. 2012-02-25 14:07:07 +01:00
Kandera
c517806a23 Scripts/Spells: Convert code from Spell::EffectDummy to spell scripts. 2012-02-18 12:12:49 +01:00
QAston
cd3ed111c9 Core/Spells: Fix recently broken feral spirit and force of nature. Closes #5278. 2012-02-17 11:45:21 +01:00
leak
1b506c18ee Core/Spells: Remove pointless check 2012-02-15 17:06:31 +01:00
Subv
ff9830c18d Core/Spells: Blink wont be able to trespass solid objects anymore (walls/doors)
Refactored some code

Signed-off-by: Subv <s.v.h21@hotmail.com>
2012-02-11 19:23:18 -05:00
Shauren
5251daf01a Core/Spells: Summoning players will now teleport them directly on summoner, not near him 2012-02-10 11:32:33 +01:00
Subv
4ba341e892 Core/Spells: Removed deprecated code, fixed duration bonus of the Glyph of Dancing Rune Weapon 2012-02-09 15:27:12 -05:00
QAston
800cf73750 Core/Spells: Fix some problems with spells summoning to many objects. 2012-02-09 20:27:26 +01:00
QAston
6b12f39b35 Merge pull request #4821 from devilcoredev/fix_001
Core/AuraScript: Add OnDispel and AfterDispel hook to AuraScript
2012-02-04 06:09:57 -08:00
Giuseppe Montesanto
271feb587f Add hook on AuraScript called when an aura is dispelled 2012-02-04 13:32:40 +01:00
QAston
c7ea952a47 Core/Entities: Rename UNIT_FLAG_OOC_NOT_ATTACKABLE and UNIT_FLAG_PASSIVE to UNIT_FLAG_IMMUNE_TO_PC and UNIT_FLAG_IMMUNE_TO_NPC respectively. New names tell much more about what those flags do. 2012-02-03 18:46:05 +01:00
Shocker
08be716ef8 Core/Misc: Rename UNIT_STAT_* enums to UNIT_STATE_* 2012-02-03 19:02:17 +02:00
Souler
75992143c1 Scripts/Spells: Fix Argent Tournament mount spells:
* Break-Shield
 * Charge
 * Defend (visual)
 * Mounted duel
 * Faction Pennants when riding argent tournament mounts
Closes #4917.
2012-01-30 00:21:42 +01:00
Subv2112
3d4f55723c Core/SAI: Linked events should be executed after the event that linked them is executed.
Core/SAI: Allow SMART_EVENT_GO_STATE_CHANGED to use ActionInvoker target

Signed-off-by: Subv2112 <s.v.h21@hotmail.com>
2012-01-22 20:36:01 -05:00
Machiavelli
dbbac0bdaa Core/Movement: Implement spline movement subsystem.
Spline movement controls movements of server-side controlled units (monster movement, taxi movement, etc).
Proper implementation of effects such as charge, jump, cyclic movement will rely on it.
However, need improve our states system before.

Technical changes:

* Added linear, catmullrom and bezier3 splines which based on client's algorthims. They can be reused for proper transport position interpolation.
* Precission increased. There are no more position desync issues since client's position calculation formulas used.
* Now possible to move by paths with multiple points, send whole path to client.

--
Original author of research and implementation: SilverIce. Massive kudos.
Original port for Trinity (ref #4629) Chaplain and Venugh
With the following incremental fixes during my review:

- Restore flightmaster end grid pre-loading
- Fix uninitialized Creature::m_path_id
- Add missing trinity_string entries for .movegens command
- Fix a bug in WaypointMovementGenerator that would trigger unexpected pausing at waypoints for various amounts of time

Known issues:
- Errors like WaypointMovementGenerator::LoadPath creature XXX (Entry: YYYYY GUID: ZZZZZZ) doesn't have waypoint path id: 0.
This is caused by bad DB data. This commit didn't "break" it.

Do not forget to re-run CMake before compiling.
2012-01-14 15:36:07 +01:00
Subv2112
f7276a95de Scripts/Achievements: Fixed achievement Shocking! on 10-man and 25-man
closes #4751

Signed-off-by: Subv2112 <s.v.h21@hotmail.com>
2012-01-09 20:36:56 -05:00
Kaelima
a79ea3dcdf Merge pull request #4672 from Subv/fix004
Fixed gossip menu displaying for gameobjects with type GAMEOBJECT_TYPE_QUESTGIVER
2012-01-06 06:37:20 -08:00
Subv2112
d3b1c51b6e Core/Gossips: Fixed gossip menu displaying for gameobjects with type GAMEOBJECT_TYPE_QUESTGIVER, closes #4488
Signed-off-by: Subv2112 <s.v.h21@hotmail.com>
2012-01-05 21:41:17 -05:00
Shocker
00e1de4c0a Merge pull request #3478 from Havenard/fix0011
Core/Spells: Fix Divine Storm
2012-01-04 13:35:29 -08:00
kandera
34c437e973 [Core/Spells] Fix Blood Tap (finally fixes full spell)
ignore removal of aura provided by Souler thanks!
2012-01-04 11:50:31 -05:00
zwerg
5884f4be31 Core/Spells: Add barfing to Spell::EffectInebriate.
Signed-off-by: Machiavelli <machiavelli.trinity@gmail.com>
2012-01-03 13:15:33 +01:00
kiper
8299627ed9 Update headers for 2012. HAPPY NEW YEAR!!! 2012-01-01 00:32:13 +01:00
QAston
eecc4b58a7 Core/Spells: Use better check for target type in Spell::EffectSendEvent - SpellEffect::GetProvidedTargetMask() is much more accurate than hardcoded dbc index. 2011-12-23 23:52:22 +01:00
megamage
8cf2062c1f Update grid system. Try to fix some crashes and transport passengers (now they are despawned after a while). 2011-12-20 17:07:09 -05:00
Machiavelli
7e94cae867 Merge pull request #4260 from wilds/fix_charge
Core/Spells: fix charge and chargedest effect through textures
2011-12-16 04:10:24 -08:00
kaelima
929ad95525 Core/Spells: Fixed Envenom damage
- The players AP should stack with combo points, not deadly poison stack.
+ some cleanup
Thanks @Cepox (and some others at google code issue tracker)

Closes #2929
2011-12-16 08:15:55 +01:00