Commit Graph

24345 Commits

Author SHA1 Message Date
ccrs
dbe54973fb Core/Movement: cleanup MovementGeneratorType
(cherry picked from commit fce974c3b3)
2020-04-24 17:18:49 +02:00
Gustavo
6f523b4fb6 Core/Scripts: minor fixes in boss_the_lich_king (#19311)
Closes #4427
Closes #7091

(cherry picked from commit 2792046dc7)
2020-04-24 17:18:49 +02:00
ariel-
7a561ad045 Core/Scripts: Updated Ulduar instance model
- Codestyle/indent fixes
- Added ObjectData for some GOs
- Added GetUlduarAI to creatures
- Fixed possible out-of-bounds access in boss_razorscale_controllerAI (boss AI number beyond allocated boss size)

(cherry picked from commit b74cc80859)
2020-04-24 17:18:49 +02:00
Chaouki Dhib
5d076cfe29 Core/Spells: fix wrong distance calculations in AoE spells [Needs testing] (#16290)
Core/Spells: Fix wrong distance calculations in AoE spells.
Pull request #16290 by chaodhib.
God bless, finally.

(cherry picked from commit a1f2f30c14)
2020-04-24 17:18:49 +02:00
S.V
b8b6fd9ca0 Core/Creatures: Fixed GMs being considered in party/raid with nearby creatures without CREATURE_TYPE_FLAG_TREAT_AS_RAID_UNIT
Ref #19340

(cherry picked from commit eea16ce356)
2020-04-24 17:18:49 +02:00
Keader
b234658617 Core/Scripts: Fixed wrong calculation of Aura of Desire
Closes #19322

(cherry picked from commit 333a403409)
2020-04-24 17:18:49 +02:00
xinef1
ca4720662d Core/Items: Fixed durability problems for wrapped item (#19003)
(cherry picked from commit 81d011170d)
2020-04-24 17:18:49 +02:00
ariel-
e44d0c8873 Core/Spell: fix an issue with vehicle spells changing orientation of base vehicle
Closes #17234

(cherry picked from commit 4096b02a56)
2020-04-24 17:18:49 +02:00
ariel-
786bb561ca Core/AchievementMgr: fix integer underflow neglecting already completed realm firsts
Closes #19334

(cherry picked from commit 9cfa7c752e)
2020-04-24 17:18:49 +02:00
ariel-
848f0d1323 Core/Entities: don't finalize movesplines before deleting.
- The whole MotionMaster will be destroyed along with the unit, freeing the allocated memory.

Closes #19324

(cherry picked from commit b53d0530cd)
2020-04-24 17:18:49 +02:00
robinsch
8874a3ac5d Core/Social: Implement FRIEND_STATUS_RAF (#19317)
(cherry picked from commit d209aaa00f)
2020-04-24 17:18:49 +02:00
Golrag
b8c8dcdbfc Core/Object: Fix Line of Sight issue with object edges
Fixes: https://github.com/TrinityCore/TrinityCore/pull/15807#issuecomment-268077802
(cherry picked from commit 020a6b984d)
2020-04-24 17:18:48 +02:00
jackpoz
bfcb276781 Core/Crash: Refactor and fixes
Code cleanup.
Fix buffer overflow crash.
Fix type being truncated to 199 characters.

(cherry picked from commit 9226e21205)
2020-04-24 17:18:48 +02:00
ariel-
6098c4549c Core/Spell: add assert checks on SpellMgr::CheckSpellGroupStackRules
Ref #19319

(cherry picked from commit 36bb4cabae)
2020-04-24 17:18:48 +02:00
ariel-
053d0cfda5 Core/Pet: load template immunities when creating (except for hunters)
Fixes #19275

(cherry picked from commit e33263c677)
2020-04-24 17:18:48 +02:00
ariel-
c16cebca64 Core/Unit: properly reset displayIds when having a shapeshift aura active
Closes #19309

(cherry picked from commit 7a38eaa5a1)
2020-04-24 17:18:48 +02:00
ariel-
1536f01a74 Core/Quests: fixed exclusivegroup interaction with prevquestId and nextQuestId.
- They should work as documented by wiki now.
- Add some consts to Player methods
- Fixed negative PrevQuestID to mean only active quest (ie not rewarded/complete, as those quests are required to complete another)

Closes #19300

(cherry picked from commit 3b27a06265)
2020-04-24 17:18:48 +02:00
ariel-
c03373c59f Core/Quests: changed quest_template_addon.NextQuestID to unsigned
- No reason to keep this anymore after 4349adf0f2, this is a broken functionality.

(cherry picked from commit dca276716f)
2020-04-24 17:18:48 +02:00
ariel-
feb8205d6a Core/Globals: some changes in quest loading
- Made load/reload associated quest tables data-driven, so removed a bunch of similar looking code from ObjectMgr (yay!)
- Codestyle and encapsulation for ExclusiveQuestGroups

(cherry picked from commit 076293f1f2)
2020-04-24 17:18:48 +02:00
ariel-
4472a3cbf3 Core/Globals: Fix Quest codestyle and member variable initialization
(cherry picked from commit 09701b0229)
2020-04-24 17:18:48 +02:00
ariel-
a098b454b8 Core/Entities: virtualize CheckAttackFitToAuraRequirement
- Should've been like this to begin with

(cherry picked from commit 21d95a1d76)
2020-04-24 17:18:47 +02:00
ariel-
5979f4f396 Core/Auras: fix more unused parameter warnings
(cherry picked from commit 7de5befbc3)
2020-04-24 17:18:47 +02:00
ariel-
1c4b1ba498 Core/Auras: fix comparison of integers of different signs warning
(cherry picked from commit 9047d8bd6f)
2020-04-24 17:18:47 +02:00
ariel-
e39ea201ce Core/Auras: fix unused parameter warning
(cherry picked from commit 40489b8d57)
2020-04-24 17:18:47 +02:00
ariel-
ebc06b1d04 Core/Auras: reworked multiplicative AuraEffects calculation
- Splitted containers for flat modifiers and pct modifiers, as they now have different handling
- Amount is now multiplied only on apply; on unapply, iterate through auras and reset the counter
- Fixes many cases of rounding error due to applying/unapplying of small factors
- Allows amounts to be zeroed (ie with an AuraEffect of amount -100)
- Do a partial revert of 6dc37a9add, auras should update amounts only for items allowed (ie no more giving crit to a sword while having an axe in the other hand and being Poleaxe spec'd)
- SPELL_AURA_MOD_SCALE now scales additively, rather than multiplicatively (checked in sniffs)

Closes #18687

(cherry picked from commit c69a7d1223)
2020-04-24 17:18:47 +02:00
ariel-
73ea9ecec1 Core/Misc: moved WeaponAttackType definition to SharedDefines to avoid including Unit.h
(cherry picked from commit 6d991e9361)
2020-04-24 17:18:47 +02:00
ariel-
cdbe16fabe Core/Scripts: implemented Gnomish Harm Prevention Belt
Updates #18542

(cherry picked from commit 2db3e86d9b)
2020-04-24 17:18:47 +02:00
Keader
f3d946cee9 Core/Spell: Fixed Val'kyr Target Search exploit
Closes #16347
by ariel-

(cherry picked from commit 28b955bd25)
2020-04-24 17:18:46 +02:00
Shauren
bbfbb7d4bf Core/PacketIO: Implement building SMSG_UPDATE_OBJECT only for selected fields and use that to fix quest objects not glowing after accepting quests 2020-04-23 20:22:53 +02:00
Shauren
fb0a29131d Core/AuctionHouse: Add separate auction house throttle period for requests from auction house addons tainting default ui 2020-04-23 14:03:17 +02:00
Shauren
fea5cb4525 Core/PacketIO: Fixed WorldPackets::Addon::AddOnInfo structure 2020-04-22 23:59:20 +02:00
Shauren
aced88b09b Core/AuctionHouse: After taking a break at the start of patch 8.3 auction house is now back in business. 2020-04-20 20:36:24 +02:00
Shauren
7ef9acd765 Warning fix 2020-04-19 11:59:37 +02:00
Shauren
b702401978 Core/Items: Check required level to use items including any bonuses that modify it 2020-04-19 01:18:17 +02:00
Shauren
ecdf3d1a14 Core/Items: Add helper function to get item name including suffix 2020-04-18 10:59:35 +02:00
Shauren
d7524928e5 Core/Mail: Updated mailbox limit to 8.3 value 2020-04-17 17:36:24 +02:00
Shauren
01c68b2aa2 Core/Player: Wait for correct transaction on character creation 2020-04-15 12:30:06 +02:00
Shauren
b8966561e3 Add missed change 2020-04-14 23:50:09 +02:00
Shauren
fc9d2e728e Core/Misc: Fixed char enum packet sometimes not showing newly created character when client latency is too low 2020-04-14 16:24:53 +02:00
Shauren
0f0ca3a919 Core/DBLayer: Implement async transaction completion callbacks 2020-04-14 16:23:44 +02:00
Shauren
34b393ab64 Fix dynamic build 2020-04-12 20:06:15 +02:00
Shauren
676eb6d77f Core/Entities: ObjectGuid improvements
* Support creation of all guid types
* Change ToString to output client compatible text (fixes calendar and auction mails)
* Fix saving and loading item soulbound trade allowed traders
* constexpr EnumClassFlag
2020-04-12 17:50:33 +02:00
Shauren
3b6e5a87d8 Core/Spells: Fixed Spell::CheckCast for targeting items trade with lockpicking 2020-04-11 11:51:12 +02:00
Shauren
427b5ba468 Core/Guilds: Send item flags for guild bank contents 2020-04-10 22:33:29 +02:00
Shauren
361946419e Core/Items: Fixed learning 2nd and 3rd copies of battle pets from items (not caged pets) 2020-04-08 13:36:59 +02:00
Shauren
3700e0ef5d Core/Misc: Defined new summon properties titles 2020-04-07 17:27:40 +02:00
Shauren
e20bfe3f4b Core/Items: Initialize m_randomBonusListId in constructor 2020-04-06 15:17:56 +02:00
Shauren
c81de0eb4e Core/Misc: Removed old incorrect define 2020-04-04 00:28:49 +02:00
trarman
1b53a87d49 Fix gcc build (#24383)
Closes #24381
2020-04-03 23:31:50 +02:00
Shauren
70188c4fe1 nopch fix 2 2020-04-03 18:12:07 +02:00