* Prefer prefix ++/-- operators for non-primitive types.
* Variable 'ownerBonus' is reassigned a value before the old one has been used.
* Fix a wrong type of ownerBonus, sometimes it is float sometimes uint32
* Possible inefficient checking for 'list' emptiness.
* Variable '_scheduledScripts' is assigned in constructor body.
Consider performing initialization in initialization list.
* Variable 'Text' is assigned in constructor body.
Consider performing initialization in initialization list.
* Possible inefficient checking for 'm_loadedScripts' emptiness.
* Either inefficient or wrong usage of string::find(). string::compare() will
be faster if string::find's result is compared with 0, because it will not scan the whole string.
If your intention is to check that there are no findings in the string,
you should compare with std::string::npos.
* C-style pointer casting detected. C++ offers four different kinds of casts as replacements:
static_cast, const_cast, dynamic_cast and reinterpret_cast.
Documentation Used:
- Thank you @MitchesD for providing some extra information, much appreciated.
Core/Packets: Fix CMSG_EMOTE opcode handler
Documentation used:
- Thanks thumsoul from TC IRC for providing extra information.
Documentation used:
- Thanks @rocverde for providing sniffs through TC IRC.
- Each opcode checked and works positively, feel free to apply and check yourself.
Documentation Used:
- Thanks @rocverde for providing sniffs through TC IRC.
- Thank you very much @MitchesD, @DDuarte, @Carbenium and @Vincent-Michael (+ Trinity as a whole) for the help with my very first opcode structure update.
Documentation:
- Taken from 92a9fe77b0.
- /played opcodes from sniffs provided by @rocverde through TC IRC.
Note: opcode handlers for "CMSG_PLAYED_TIME" & "SMSG_PLAYED_TIME" still need a proper structure change. CMSG is using _OLD and both are on _UNHANDLED.
Documentation used:
- Taken from 1a96b78972.
Note: I only change opcodes.cpp status to what they were before they were all put back to 'STATUS_UNHANDLED' for update 6.1. The ones that were 'UNHANDLED' before I don't change the status of.
Added more tables to pdump:
* character_queststatus_objectives
* character_spell_charges
* pet_spell_charges
Fixed crash on pdump write at character_currency (thanks @Luzifix)
Fixed reguiding items in character_equipmentsets on pdump load
Fixed some column mismatches at characters on pdump load
