Commit Graph

20202 Commits

Author SHA1 Message Date
jackpoz
e28cc4660b Core/Movement: Fix invalid memory access
Fix the stack implementation used in MotionMaster and added few sanity checks to ensure no underflows will be made.

Valgrind log:
 Invalid read of size 8
  at : MotionMaster::top() const (MotionMaster.h:115)
  by : MotionMaster::pop() (MotionMaster.h:91)
  by : MotionMaster::~MotionMaster() (MotionMaster.cpp:74)
  by : Unit::~Unit() (Unit.cpp:296)
  by : Player::~Player() (Player.cpp:880)
  by : WorldSession::HandleCharCreateCallback(Trinity::AutoPtr<PreparedResultSet, ACE_Thread_Mutex>, CharacterCreateInfo*) (CharacterHandler.cpp:665)
  by : WorldSession::HandleCharCreateCallback(Trinity::AutoPtr<PreparedResultSet, ACE_Thread_Mutex>, CharacterCreateInfo*) (CharacterHandler.cpp:516)
2013-12-14 16:51:47 +01:00
Malcrom
9d9d1fb6c6 DB/SAI: Fix an error in Bladespire Mystic SAI 2013-12-14 09:35:36 -03:30
Discover-
4ca63412c8 Core/SmartAI: SMART_ACTION_UPDATE_TEMPLATE will no longer ignore the target type and force the source creature (creature only) to be updated; from now on it updates the given targets to the given entry (actionparam1) 2013-12-13 09:45:58 +01:00
Malcrom
c045d4c7f4 Core/SmartAI: Reset Actions will not be processed until creature reaches home. 2013-12-12 21:23:14 -03:30
Malcrom
9f741432a3 Core/AI: Some code cleanup 2013-12-12 18:09:07 -03:30
Malcrom
9d95351118 Core/SmartAI: Fixed issue where ranged caster would switch to combat ready state between cast. 2013-12-12 16:39:30 -03:30
Aokromes
3cee0b7dc7 Merge pull request #11309 from Lartza/master
DB/SAI: Fix typo
2013-12-12 04:20:31 -08:00
Lartza
d9dac7b9ca Fix typo 2013-12-12 13:46:22 +02:00
Shauren
54fd53f7e3 Core/Movement: Fixed possible invalid memory access 2013-12-12 09:50:52 +01:00
Malcrom
385e2dba37 DB/SAI: Fix one linking error and updated a few to use CMC "Combat Movement Control" 2013-12-11 17:07:59 -03:30
Vincent_Michael
fb26e18523 Core: Fix warnings 2013-12-11 20:30:15 +01:00
Malcrom
e7e708eb0a DB/Misc: fixed comment in one SAI script. 2013-12-11 15:34:57 -03:30
Malcrom
a20c89feee DB/Misc: Some Combat AI, Remove spawns, and aura fixes. 2013-12-11 15:32:59 -03:30
Malcrom
551e51bcb9 DB/Waypoints: Some Outlands waypoints. Mostly Blade's Edge. 2013-12-11 15:10:05 -03:30
joschiwald
a40e814240 Core/SmartScripts: speedup loading/validating sai scripts from db
Before:
>> Loaded 6953 SmartAI scripts in 3543 ms

After:
>> Loaded SmartAIMgr Helpers in 4 ms
>> Loaded 6953 SmartAI scripts in 95 ms
2013-12-11 18:53:05 +01:00
Shauren
488841dd2c Merge pull request #11306 from trickerer/fixaggro
Don't allow units to enter combat upon death
2013-12-11 00:40:46 -08:00
Malcrom
fc7e335d3b Scripting/Obsidian Sanctum: Updated scripts to use Events. 2013-12-11 01:13:23 -03:30
trickerer
91ebea4a77 Don't allow units to enter combat upon death 2013-12-11 09:38:24 +07:00
joschiwald
eddf1b5a64 Scripts: replace some SetOrientation() calls with spline packets and some random changes 2013-12-10 18:46:11 +01:00
joschiwald
bb45db65a0 Merge pull request #11275 from Carbenium/UtgardePinnacle
Scripts/UtgardePinnacle: Convert Svala Sorrowgrave to event system
2013-12-10 07:29:00 -08:00
Carbenium
000bfbb732 Convert Svala Sorrowgrave to event system 2013-12-10 16:05:02 +01:00
Malcrom
74facef60d Scripting/Storm Peaks: Renamed npc_brann_bronzebeard script because name has already been used. 2013-12-10 00:11:33 -03:30
Malcrom
6af40a28b1 DB/Misc: Mostly cosmetic for Storm Peaks with a few SAI updates.
"It's like eye liner for your TC server"
2013-12-09 23:35:37 -03:30
Kinzcool
ceaa6c332e Core/Enums: Few inns/zones use the zone itself for the resting state instead of an areatrigger. 2013-12-09 20:40:22 -05:00
Malcrom
bdcbcc5987 DB/Waypoints: Fix error in previous sql. 2013-12-09 18:56:30 -03:30
Malcrom
1b7f41a531 DB/Waypoints: All pathing for Stormforged War Golem. 2013-12-09 17:22:45 -03:30
jackpoz
822755ca87 Core/Misc: Fix some static analysis issues
Fix some static analysis issues about uninitialized values.
2013-12-09 21:10:42 +01:00
Malcrom
b6f4ab491f DB/Waypoints: Add missing waypoints for Stormforged Taskmaster and 3 missing spawns 2013-12-09 15:08:13 -03:30
Malcrom
a3ff7eaae9 Scripting/Storm Peaks: Tested all my sql but not the title :P 2013-12-09 03:32:19 -03:30
Malcrom
755283ac8d Scripting/Storm Peaks: Quest 13285 "Forging the Keystone" now scripted.
Closes #6921
2013-12-09 03:28:40 -03:30
Malcrom
f33023b853 DB/Misc: Darkspeaker R'khem now has chains.
Closes #7316
2013-12-08 22:24:42 -03:30
Malcrom
dd4aee2c10 Scripting/Howling Fjord: Fix Quest 11310 Warning: Some Assembly Required
Quest is doable and completeable with the following Issues:
Aura not being removed from player after Abomination explodes.
Camera angle should not changes after Abomination explodes.
Can't check if Abomination leaves Halgrind. GetAreaId returns players area id.
2013-12-08 18:46:06 -03:30
jackpoz
f418f4cf94 Core/Misc: Fix some static analysis issues
Fix some static analysis issues about uninitialized values in scripts.
Add spell id validation in Unit::SpellNonMeleeDamageLog() .
2013-12-08 22:04:30 +01:00
Vincent_Michael
b76d141ce0 Core: Fix warning 2013-12-08 20:53:06 +01:00
Malcrom
0e37faf202 Scripting/Razorfen Downs: That emote shouldn't have slipped in there. 2013-12-08 15:10:28 -03:30
Malcrom
ae597c3594 Scripting/Razorfen Downs: Discovered some missing text for boss Glutton. 2013-12-08 15:07:49 -03:30
Malcrom
5c15e88da9 Core/Unit: Add switch to prevent COMMAND_ATTACK being added to action bar for supplied creature entries. 2013-12-08 11:55:28 -03:30
Warpten
98d2dbbd3f Core/Spells: Fixed rare issues where spell modifiers would not be correctly restored.
Happens in case of a spell having more than one modifier granted by an aura.
2013-12-08 15:06:10 +01:00
Malcrom
0447806812 DB/SAI: Grimscale Murloc shouldn't fear Closes #11259 2013-12-08 00:12:01 -03:30
Malcrom
a05b7b430e DB/SAI: Aokromes likes to inform me of one typo at a time :) 2013-12-07 23:30:37 -03:30
Malcrom
1fa8c6e3bf DB/Misc: Fix typo 2013-12-07 23:21:27 -03:30
Malcrom
877ad17f19 DB/SAI: Fix my stupid mistake 2013-12-07 23:11:41 -03:30
Malcrom
997dcf0ea4 DB/SAI: Remove bad unneeded Springpaw Stalker & Elder Springpaw SAI 2013-12-07 23:09:09 -03:30
Vincent_Michael
2ed05e487d Core: Fix non pch build 2013-12-08 02:06:55 +01:00
Malcrom
89de7e7419 Scripting/Razorfen Downs: Additions and fixes for instance.
Moved bosses Glutton, Mordresh Fire Eye, Tuten Kash to cpp.
Cleaned up code for boss Amnennar The Coldbringer.
Fixed up gong event for gong to have sound and proper spawning.
Scripted quest 3525 "Extinguishing the Idol" so you can now fight Plagmaw the Rotting.
2013-12-07 21:19:46 -03:30
Malcrom
2b8fb0d8f6 DB/SAI: Fix for QUEST 12512 "Leave no one behind" by Pitcrawler
Closes #6583
2013-12-05 16:57:16 -03:30
Malcrom
067f0f9331 DB/SAI: Add SAI for Val'kyr Guardian & Val'kyr Protector
Closes #3280
2013-12-05 13:37:10 -03:30
Malcrom
e667c96cfc Scripting/Grizzly Hills: Add missing include "SpellScript.h" 2013-12-05 13:24:34 -03:30
Malcrom
af5d3daeab Core/Vehicle: Add an extra check for required energy before setting power. 2013-12-05 13:07:15 -03:30
Malcrom
621ba87917 Grizzly Hills/Scripting: Fix Quest 12244 "Shredder Repair" and 12270 "Shred the Alliance"
Closes #1942 #3754
2013-12-05 13:04:11 -03:30