Commit Graph

21301 Commits

Author SHA1 Message Date
Shauren
ec1cfa36f4 Core/Commands: Fixed creature/gameobject move commands not updating which cell they belong to
Closes #22720
2019-01-15 16:54:57 +01:00
Giacomo Pozzoni
6859dfa2d1 Core/Quest: Fix crash in GetQuestDialogStatus()
Fix possible NULL dereference in GetQuestDialogStatus()
Fixes #22516
2019-01-15 15:37:12 +01:00
Killyana
772a68d624 DB/Creature: Update Lord Victor Nefarius gossips with the correct entry
Closes #22946
2019-01-14 18:03:01 +01:00
ccrs
954fd2639a Core/Unit: rename & cleanup GetCreatePowers
it hurted my eyes too much
2019-01-14 07:07:06 +01:00
Giacomo Pozzoni
8f9654d817 3.3.5 UnitAI (#22911)
* Core/AI: Revamp how UnitAI changes are applied

Revamp how UnitAI changes are applied by storing current AI in a variable and all previous AIs plus current in a stack.
The callers can push/pop AIs on the stack that will take effect only in next Unit::Update() call.
The current AI will be a valid object for the whole duration of Unit::Update() and until next Unit::Update() call.

* Core/AI: Apply new AI change code

* Core/AI: Fix build

* Core/AI: Fix crash on Creature::AIM_Create()

* Core/AI: Fix crash

* Core/AI: Restore ASSERT

* Core/AI: Fix UnitAI not being popped properly when restoring a charmed AI
2019-01-13 20:25:02 +01:00
Trond B. Krokli
a8558c4361 Scripts/Borean Tundra: Corastrasza gossip menu improvements (#22942)
- split the quest status check, the quest gossips are different
- remove old hardcoded text (deprecated method)
- enumerate already existing DB gossip menu option items
2019-01-13 16:48:55 +01:00
Shauren
901af6546b Core/CLI: Fixed utf-8 console input on windows 2019-01-12 18:03:50 +01:00
jackpoz
bdb7e6e5e8 Core/Utils: Handle UTF-8 conversion errors
Replace the output string when a UTF-8 conversion error happen with an error message instead of using an empty string, swallowing any message that the caller wanted to log.
2019-01-12 12:05:48 +01:00
Killyana
fb28083b3b DB/Creature: Wrath Corruptor
Thanks to Keader for the spell_script
Original sql by Tobschinski c8f1753834
2019-01-12 00:11:59 +01:00
Shauren
7fb52334b2 Core/LFG: Ignore LFG cooldown when joining queue to replace missing party member when dungeon is already in progress 2019-01-11 22:31:02 +01:00
Trond B. Krokli
95398fadf9 Scripts/Quest: make Wounded Skirmisher reply talk show class & race (#22936)
Quest 12288: Overwhelmed!
- Upon casting the healing quest spell, Wounded Skirmisher (npc_wounded_skirmisher)
  shows $r and $c in their reply talk text because of the missing target argument,
  hence not targeting the player on the quest (or the specific caster, in this case).

Text used by the NPC Wounded Skirmisher:
    0  Ahh.... better.
    1  Whoa - I nearly died there. Thank you, $r!
    2  Thank you, $c.

Solution: add the missing target name, caster, to the Talk() script line.
2019-01-11 17:52:21 +01:00
ccrs
9695c3d46d Core/Movement: 9080e7863c followup
not the desired optimization I was aiming at, ty Shauren
2019-01-10 23:02:43 +01:00
ccrs
9080e7863c Core/Movement: correct logic wrongly ported in 2a84562dc8
I'm referencing line 97 from ChaseMovementGenerator.
That commit introduced a modification in this use case:
- Chasing target is not my current victim, I should stop moving till it is my victim again
Changed To:
- Chasing target is not my current vicitm, I should stop chasing
My correction:
- I dont care about the relation of my current victim and my chasing target, I'm commanded to chase, something will tell me to stop chasing
--> Most likely: evade, new attackstart, etc.

the rest are just minor changes
2019-01-10 22:51:47 +01:00
Killyana
4c53dd930e Rename spell correctly 2019-01-10 21:58:00 +01:00
Giacomo Pozzoni
57d7b19452 Core/Networking: Fix memory leak (#22923)
Fix memory leak reported by ASan happening when ports fail to bind in Authserver
2019-01-10 20:02:09 +01:00
Giacomo Pozzoni
545bee0496 Scripts/Spells: Fix infinite loop in Power Word Shield (#22918)
Fix infinite loop in Power Word Shield triggering back and forth the damage spell between 2 players, both with Power Word Shield
2019-01-10 19:21:20 +01:00
Killyana
21030d0cd0 Creature/Script: Add missing abilities for Ghostly Citizen and Spectral Citizen
Closes #22662
2019-01-10 16:23:49 +01:00
Rynem Storm
a057d26f20 DB/Spell: fix mistake in Blood Draining's CheckProc and remove Attack Power scaling (#22862) 2019-01-10 14:11:07 +01:00
Shauren
755133d860 Core/Spells: Fixed crash with some gameobject spell casters 2019-01-09 20:41:35 +01:00
Killyana
5e73647c84 Quest/Script: Kodo Roundup
Fix faction issue and handle the gossip correctly via the script
2019-01-09 17:24:30 +01:00
Shauren
c4f2c88a9c Core/Objects: Properly ASSERT when trying to access invalid updatefields 2019-01-08 23:03:53 +01:00
Giacomo Pozzoni
08dcee0cf9 Scripts/Misc: Fix LoadMinionData() dynamic analysis issues
Fix issues reported by Address Sanitizer about LoadMinionData() calls on arrays that don't end with a {0, 0} pair.
2019-01-07 10:17:05 +01:00
Rochet2
d9ba611651 Fix non pch (#22915) 2019-01-06 20:07:41 +01:00
Keader
a0de602d38 Core/Spell: Fixed some negative spells showing as positive
Closes #22840
Revert 9ecce33192 and 7611242530
Update #22757
2019-01-05 11:26:29 -03:00
Shauren
f93a23adc5 Core/Spells: Fixed unapplying rockbiter weapon
Closes #22528
2019-01-05 13:04:21 +01:00
Keader
dd81978f43 Scripts/Icecrown Citadel: Some fixes for Valithria Dreamwalker's encounter
Closes #22754 #21887 #17882
Ty sirikfoll for all help
Bonus fixes: Abomination letting worms when fight end, visual missing, archmages stop respawn if corpse despawn
2019-01-05 01:14:57 -03:00
DanVS
8051ff13df Core/Scripts: Move some spells to scripts (#22332) 2019-01-05 01:54:33 +01:00
PolarCookie
fb19f7be1f That's Abominable for the 3 other quests, and knockbacks for all. (#22127) 2019-01-05 01:43:53 +01:00
Keader
9ecce33192 Core/Spells: Malleable Goo need be negative
Closes #22757
2019-01-04 14:58:17 -03:00
Shauren
74d51b9263 Core/Creatures: Fixed trainer requirements
Closes #22906
2019-01-04 00:08:26 +01:00
Ghaster
19791a35df Core/Creature: Profession trainer fixes (PR #22904)
Closes #22903
2019-01-03 16:52:22 +01:00
Keader
b283565d8a Scripts/The Steamvault: Fixed Chambers Access Panel and Main Chambers Door
Closes #21067
Ty Kittnz, killerwife, Aokromes (sniffs)
2019-01-02 11:57:33 -03:00
jackpoz
f11117584d Core/Handlers: fix ".whisper on" with opposite faction/low level
Closes #22283
2019-01-01 15:57:35 +01:00
Treeston
fcfcb0eb6f Happy New Year, folks. It's 2019! 2019-01-01 15:45:25 +01:00
Giacomo Pozzoni
20ea24bf5c Scripts/Commands: Fix crash caused by .set npc model (#22877)
* Scripts/Commands: Fix crash caused by .set npc model

Fix crash caused by .set npc model with invalid model id
2019-01-01 15:00:27 +01:00
Shauren
3b5014fdae Core/Spells: Fixed ErrorCube spell missiles 2018-12-31 21:41:25 +01:00
PolarCookie
66720e5fd9 Spell/Script: Scourge Disguise and Haunting Phantoms (#22727) 2018-12-31 11:50:16 +01:00
Shauren
1c4cdfd325 Renamed SQL with proper date 2018-12-30 20:07:04 +01:00
Shauren
baebb2d602 Core/Players: Fixed some spells appearing as available at trainer when they are already known
Closes #16482
2018-12-30 19:51:36 +01:00
Shauren
bd21917ad6 Core/PacketIO: Fixed naming for SMSG_TRAINER_LIST profession related fields 2018-12-30 19:51:36 +01:00
Ghaster
bf3ab6d9c4 Core/Creatures: Port trainer changes from master
Closes #20493
2018-12-30 19:51:36 +01:00
Treeston
4c3af3b636 Core/Utils: some code style adjustments, 6d6077e follow-up 2018-12-25 12:36:20 +01:00
Treeston
6d6077e36f Core/Utils: Fix Unicode handling 2018-12-25 01:47:24 +01:00
Giacomo Pozzoni
afdbc5ffe3 Revert "Core/Handlers: fix ".whisper on" with opposite faction/low level (#22298)"
This reverts commit 950e50ec4d.
2018-12-21 13:19:12 +01:00
Giacomo Pozzoni
cb13638721 Scripts/Nagrand: Fix crash added in PR #22806 (#22878)
Fix crash added in PR #22806 happening in quest "Ruthless Cunning and Returning the Favor"
2018-12-19 16:08:35 +01:00
Giacomo Pozzoni
166bb31163 Shared/Misc: Use C99 conformant snprintf and vsnprintf in Visual Studio (#22876) 2018-12-19 11:27:44 +01:00
Gooyeth
950e50ec4d Core/Handlers: fix ".whisper on" with opposite faction/low level (#22298) 2018-12-18 08:03:52 +01:00
Shauren
c7445669e8 Core/Units: Fixed crash happening when charm was removed by its own charmed AI during update 2018-12-17 15:49:32 +01:00
Shauren
b09390e575 Core/Spells: Corrected haste affecting GCDs to match 3.3.5 client logic 2018-12-16 18:52:45 +01:00
jackpoz
eee1f2cadf Core/Misc: Fix vsnprintf usage in ASSERT()
Fix vsnprintf to follow standard definition and not some old VC++ behavior, not requiring to include the '\0' character in the count parameter
2018-12-16 12:09:20 +01:00