Commit Graph

21268 Commits

Author SHA1 Message Date
Shauren
d8391f23b1 Build fix after cherry-picks 2015-10-31 00:05:09 +01:00
Shauren
7f09392ccc Warning fix 2015-10-30 20:18:09 +01:00
Shauren
d72293bdf7 Core/Corpses: Fixed a crash happening when a corpse is added to a grid that was not yet fully loaded
Closes #15684

(cherry picked from commit 8c9ea7782a)
2015-10-30 18:05:35 +01:00
Shauren
b96bb15042 Core/Corpses: Prevent deleting corpses by ObjectGridUnloader, fixes accessing freed memory in multiple places due to the corpse still being registered in Map containers
Closes #15775
Closes #15781

(cherry picked from commit a94bdd00a9)
2015-10-30 18:05:26 +01:00
Shauren
60370d0c03 Core/Corpses: Fixed map crash happening during map unload when there are corpses inside
(cherry picked from commit 1d17475791)
2015-10-30 18:04:58 +01:00
MitchesD
26d362febc Revert "DB/NPC: Stable Masters" Please in the future mark 335 only commits with *_335 in the end of SQL file, if it has any.
This reverts commit 18f511431a.
2015-10-30 14:46:14 +01:00
Killyana
18f511431a DB/NPC: Stable Masters
Closes #15505

(cherry picked from commit a513abc02c)

# Conflicts:
#	src/server/scripts/World/npcs_special.cpp
2015-10-30 14:34:46 +01:00
joschiwald
b459b10b0f Core/Scripts: fixed startup errors
Closes #14730

(cherry picked from commit 497aa4425b)

# Conflicts:
#	src/server/scripts/Northrend/Ulduar/Ulduar/boss_flame_leviathan.cpp
2015-10-30 14:01:26 +01:00
treeston
7886fafbdc Heigan cleanup:
- NearTeleportTo hack -> proper spell with DB coordinates
- Add boss emotes
- Some code streamlining using event phases and IN_MILLISECONDS instead of large constants
- Improvement to eruption hitbox and delimiters to match retail layout more closely
- Spell timers adjusted from sniffs

(cherry picked from commit 3e2014a958)
2015-10-30 12:24:26 +01:00
treeston
f3b5bdc0b3 Scripts/Naxxramas: Bugfixes to the Noth encounter.
- Added missing raid boss emotes
- Fixed an issue where Noth would stand idly after blinking if his current target stood still
- Fixed some reset edge cases
- Prevent Noth from dying during Balcony phase
- Fix targeting of 25-man Curse of the Plaguebringer (now has 8 targets, down from 10)
- Fix balcony/ground phase durations to be blizzlike
- Fix an issue where summoned mobs would sometimes not be aggroed automatically
- Get rid of ugly millisecond values in favor of seconds times constant
- Moved the chance to yell on kill to the database
- Prevent AoE abilities from hitting Noth during the balcony phase
- General cleanup of events handling
- Generally make @Nayd happy

(cherry picked from commit 3fc1bb1abf)

# Conflicts:
#	src/server/scripts/Northrend/Naxxramas/boss_noth.cpp
2015-10-30 11:46:37 +01:00
treeston
dba753b0ef Scripts/Naxxramas: Adjustments to the Loatheb encounter
- Adjusted doom cast timings as per boss mod timers.
- Add Deathbloom's final tick using spellscript
- Move Spores' Fungal Creep cast handling to Loatheb's cpp instead of handling it in SmartAI
- Fungal Creep should also be cast if the spore expires (important for Spore Loser achievement)
- Remove Fungal Creep from players on reset to avoid cheesy strats

(cherry picked from commit ea1c783b84)
2015-10-30 11:42:19 +01:00
tkrokli
3d9b2d8de2 Core/Scripts: The Endless Hunger & Death's Challenge, creature text
This PR solves the following say text issues:
In quest ID 12733, Death's Challenge, the creature script npc_death_knight_initiate is supposed to target the player and refer to the player character's name in the following 2 lines from `creature_text`.`entry` 28406:

- "You don't stand a chance, $n." (`BroadcastTextId` 29267)
- "Remember this day, $n, for it is the day that you will be thoroughly owned." (`BroadcastTextId` 29270)

In quest ID 12848, The Endless Hunger, the creature script npc_unworthy_initiate is supposed to target the player and refer to the player character's race in the following 2 lines from `creature_text`.`entry` 29519, 29520, 29565, 29566 and 29567:

- "You are hopelessly outmatched, $r."  (`BroadcastTextId` 30212)
- "Sate your hunger on cold steel, $r!" (`BroadcastTextId` 30214)

The untargeted variables $r and $n appear in the say lines because the existing script assigns the text to the player character instead of the creatures. This does not produce any race or name information in /say or chat.

This Pull Request closes issue #14700 and replaces PR  #15678.

(cherry picked from commit 89107c3a8e)
2015-10-30 11:33:40 +01:00
Zedron
bd04a46011 Core/Spells: Fixed a mistake in SpellInfo::CalcPowerCost
Fixed a mistake which caused some SPELLMOD_COST modifiers to give (lots) of power instead of taking power in Spell::TakePower
2015-10-28 16:57:52 -05:00
Shauren
bd16520ecc Core/Corpses: Fixed leaking bones
Ref #15765
2015-10-28 21:43:44 +01:00
MitchesD
9617da7249 Core/Player: remove unused method prototypes 2015-10-28 19:18:16 +01:00
Shauren
3fd15ed22a Core/Misc: Removed manually defined ObjectGuid copy/move constructors. This will cause the compiler to automatically generate trivial constructors allowing them to be treated as simple integers 2015-10-27 22:55:57 +01:00
Shauren
f7dba226fe Core/PacketIO: Started work on updating last bunch of packets still using old ObjectGuid::operator[] to remove it entirely 2015-10-26 17:06:30 +01:00
Shauren
db0c48c17f Core/Conditions: Optimizations part 3 changed ConditionStore to a simple array 2015-10-25 13:35:45 +01:00
Shauren
b09e63e9de Core/Conditions: Optimizations part 3 removed copying condition containers all over the place 2015-10-25 13:20:28 +01:00
Shauren
2cce998e90 Core/Conditions: Add const to methods not modifying ConditionMgr 2015-10-25 12:22:53 +01:00
Shauren
e5c1e7d71c Core/Conditions: Optimizations part 2 removed unneeded code 2015-10-25 12:22:04 +01:00
Shauren
9fa938f3e0 Core/Conditions: Optimizations part 1 - use containers more suited for their role 2015-10-25 12:00:05 +01:00
Shauren
5e0cee85dd Core/Conditions: Type renaming 2015-10-25 10:59:58 +01:00
Shauren
52d5de1a7f Core/Conditions: Phase condtion changes
* SourceGroup defines which phase should the condition affect
* SourceEntry limits the area of the phase (alternatively 0 means all areas)
2015-10-25 00:22:21 +02:00
Shauren
783e8299cc Core/Misc: Fix for builds linked with libc++ instead of libstdc++ 2015-10-24 15:39:32 +02:00
Shauren
262809b5ad Core/PacketIO: Marked a bunch of packets for sending through instance connection 2015-10-23 18:04:29 +02:00
Shauren
2d942ddcc5 Core/Commands: Refactored chat command script hook, fixes a crash when building with gcc 5
Closes #15616
Closes #15740
2015-10-22 20:26:56 +02:00
Shauren
935c93e099 Core/Player: Fixed being teleported into void when on a transport 2015-10-21 22:37:02 +02:00
MitchesD
c85647e699 Core/CollectionMgr: changed loop to range-based for 2015-10-20 21:42:40 +02:00
Shauren
a3814d4937 Core/Player: Removed currency precision flag value manipulations, this is all handled clientside 2015-10-20 17:03:37 +02:00
treeston
12e90350e4 Script/BoreanTundra: Fix dialog and final waypoint for quest 11570: "Escape from the Winterfin Caverns"
This fixes the following bugs:

Escortee NPC quotes are out of order (see #15396 (comment))
Final escort waypoint is located incorrectly and causes the escorted NPC to drop all the way to the bottom of the ocean before quest completion is awarded.

Closes #15396

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
(cherry picked from commit a83437af3d)
2015-10-20 15:39:42 +02:00
Shauren
d03ff1433f Core/PacketIO: Updated and enabled item refund opcodes 2015-10-19 21:18:48 +02:00
MitchesD
f399b1222d Core/Opcodes: assigned value to SMSG_ACCOUNT_HEIRLOOM_UPDATE 2015-10-18 13:30:58 +02:00
Shauren
82db416b5d Warning fixes 2015-10-17 16:35:37 +02:00
Naios
13654bac2c Core/Tools: Fix brutal linking in mmaps extractor.
* caused warnings with shared linking
* ref #15671
2015-10-17 13:14:20 +02:00
MitchesD
9fe29de260 Core/Player: implemented Heirloom Collection
* implemented all things related to that collection
* you can create heirloom by click on item in collection
* also you can upgrade heirlooms by using specific kits
* old heirlooms are converted to new ones
2015-10-16 23:09:42 +02:00
StormBytePP
e4cf0a0a58 Core/Scripts: Fix noPCH compile
(cherry picked from commit 68e6c95f16)
2015-10-16 13:15:06 +02:00
Nyeriah
07c10ded2e Scripts/TheEye: Update Kael'thas Sunstrider's script
Closes #4180
Closes #4181
Closes #8479
Updates #1885

(cherry picked from commit fe07614916)

# Conflicts:
#	src/server/scripts/Outland/TempestKeep/Eye/boss_kaelthas.cpp
2015-10-16 13:13:09 +02:00
sirikfoll
59742469fb Core/Scripts: Friend or Fowl Achievement
Change AURA_EFFECT_HANDLE_REAL to AURA_EFFECT_HANDLE_REAL_OR_REAPPLY_MASK, the hook needs to be called on every apply/reapply to keep tracking the stack amount.

(cherry picked from commit f877b6af0a)
2015-10-16 12:50:51 +02:00
MitchesD
68d725e211 Scripts/ZulAman: fix build after cherry pick 2015-10-16 12:49:25 +02:00
treeston
0bf78d5761 Custom logic for putting people in combat instead of relying on CreatureAI or Creature methods.
(cherry picked from commit 6a8524c068)
2015-10-16 12:45:53 +02:00
treeston
89357f5425 Core/Creature: Add facilities to the Creature class to allow setting an automated, periodic pulse that puts every player in the zone in combat and on the creature's threat list.
Scripts/BossAI: Set the BossAI parent class to make use of this in its _EnterCombat and _Reset methods. Combat pulses happen every 5 seconds.

(cherry picked from commit d57193df44)

# Conflicts:
#	src/server/game/AI/ScriptedAI/ScriptedCreature.cpp
#	src/server/game/Entities/Creature/Creature.cpp
2015-10-16 12:44:17 +02:00
treeston
c64b71d01e Clean up SmartAI::MoveInLineOfSight. Remove tons of duplicate logic and forward to CreatureAI::MoveInLineOfSight instead of using its own (incorrect) implementation.
Move the removal of the 'distracted' state from SmartAI to UnitAI.cpp.

Fixes and closes #7197 and #15482.

(cherry picked from commit f446538cb1)
2015-10-16 12:37:42 +02:00
joschiwald
2bc4dea4da Core/Misc: renamed sGossipSelect parameters
(cherry picked from commit ad38c27124)

# Conflicts:
#	src/server/scripts/EasternKingdoms/ZulAman/zulaman.cpp
#	src/server/scripts/Kalimdor/zone_azshara.cpp
2015-10-16 11:56:53 +02:00
Tomatoes
3874178da8 Server/Game/AuctionHouse
Fixes world config value of less than 1 being ignored by deposit formula.

Had problems with the last commits and pr, sorry

Update AuctionHouseMgr.cpp

Adds another check to config to handle values over 1 and properly adjust the minimum higher. Thanks jackpoz!

(cherry picked from commit 817a2ce4f7)
2015-10-16 11:49:01 +02:00
Incorrect
7b1249270b Core/Misc: Fix a typo
(cherry picked from commit e99e69d31f)

# Conflicts:
#	src/server/game/Entities/Player/Player.h
2015-10-16 11:46:57 +02:00
ShinDarth
e9a4e4cfa4 Core/Misc split Rate.XP.Kill and Rate.XP.BattlegroundKill settings
(cherry picked from commit 2185165e84)
2015-10-16 11:32:06 +02:00
Shauren
4c866a0af0 Core/Crash reporting: Fixed windows version detection for 8.1 and newer 2015-10-16 00:50:49 +02:00
Shauren
45994a177c Core/Players: Check if player can enter the instance during login before trying to add him to map
* Fixes name displaying as "Unknown"
2015-10-15 23:29:19 +02:00
Shauren
b808910a89 Core/Auras: Fixed auras limited to a single target not being removed in all cases as expected
* Fixes possible assertion failure in Aura::UnregisterSingleTarget
Closes #15696
Ref #15668
2015-10-14 08:29:19 +02:00