Commit Graph

2349 Commits

Author SHA1 Message Date
ariel-
efeae33495 Core/Spells: rework part 1: Improved positive detection logic 2018-03-09 14:41:28 -03:00
ariel-
6e0b9a7916 Core/Creatures: port power type updates from master branch
Core/Misc: Added helper function Unit::SetFullPower
Cherry-picked from 8199eef81c

Core/Creatures: Updated power type handling (#20981)
Cherry-picked from 16a7a414ab
2018-03-07 03:34:45 -03:00
ariel-
ad796318e8 Core/Spells: explicitly disable non proccing auras when generating default procs
Closes #21529
2018-03-02 02:57:23 -03:00
ariel-
2d10429a2d Core/Auras: remove too strict checks in area auras, since a few aren't owned by its caster
Closes #21528
2018-03-02 02:56:55 -03:00
ariel-
0a249bda43 Core/Misc: fix bad dbc data for lock 'Locked ball and chain'
Closes #12260
2018-03-02 01:28:51 -03:00
ariel-
1904016ce0 Core/Auras: travis fix 2018-03-01 23:27:45 -03:00
ariel-
23808fe349 Core/Auras: fixed SPELL_AURA_MOD_HIT_CHANCE honoring stack rules in all cases
Updates #21367
2018-03-01 23:18:49 -03:00
ariel-
54e8418886 Core/Auras: added sanity checks for area auras having a different owner unit than caster
Closes #21517
2018-03-01 20:38:07 -03:00
Treeston
e79c595b69 Core/VMap: Add outdoor state to Map::GetFullTerrainStatusForPosition. Add WorldObject::IsOutdoors, basic member access.
Ref #21479.
2018-02-26 17:40:40 +01:00
ariel-
83292cd983 Core/Auras: check conditions against referer caster, just as spells do
Closes #21492
2018-02-24 02:55:49 -03:00
ariel-
7cff1b540c Core/Auras: restrict target map update only to area auras as player requires to have auras registered on load
Closes #21472
2018-02-22 01:35:01 -03:00
ariel-
640dd138a5 DB/Spells: fix proc regression with Missile Barrage
Closes #21466
2018-02-21 10:33:50 -03:00
jackpoz
e482d9f303 Core/Spells: Revert SPELL_ATTR2_IGNORE_ITEM_CHECK to unknown
Revert SPELL_ATTR2_IGNORE_ITEM_CHECK to unknown, too many spells unrelated to items have this attribute and the current handling was causing exploits with "Mote of Water" and other elements.
Fix #19547
2018-02-18 12:20:25 +01:00
ariel-
1ac87b6c60 Core/Auras: fixed Drain Mana breaking early if caster has Mana Feed talent but no active pet 2018-02-17 17:50:05 -03:00
Cannix
7e71b4535a Core/Spells: Execute item casts immediately instead (#21396) 2018-02-17 16:46:26 +01:00
Jeremy
9e0faace9a Core/Entities: Reduce the probability of units dropping under the map (#21322)
Reduce the probabilty of going under the map
2018-02-16 20:59:19 +01:00
ariel-
5f38b92340 Core/Auras: remove obsolete check that was preventing some auras to proc even if they met conditions otherwise 2018-02-16 00:54:53 -03:00
ariel-
29f7258dc8 Core/Spells: prevent creatures to focus channeled spells without SPELL_ATTR1_CHANNEL_TRACK_TARGET
- Creatures stuck here wouldn't try attacking because of this
- Remove one workaround in halion script, now it's unneeded

Ref #11311
2018-02-15 17:50:15 -03:00
ariel-
a36be9ebdb Core/Auras: skip target map update for one world tick if owner is not yet in world
Closes #21426
2018-02-15 13:53:41 -03:00
ariel-
f1f6976f91 Core/Auras: make area and dynauras condition compliant by using the spellarea searcher instead of script searchers
Closes #17317
2018-02-15 03:07:41 -03:00
ariel-
93cbe815cb Core/Spells: fixed server being too overzealous with autoshot
- Interrupting it when casting another spell and switching targets

Ref #21390
2018-02-14 23:10:41 -03:00
ariel-
1edd81f9d5 Core/Scripts: fix Healing Stream Totem coefficient and animation 2018-02-14 22:07:06 -03:00
ariel-
4101bc287d DB/Spell: clear spell_bonus_data of redundant entries, now read from DBCs
Ref #21415
2018-02-14 05:58:56 -03:00
ariel-
1826437c09 Core/Spells: implemented bonus SP coefficient from DBC
Ref #21415
2018-02-14 05:58:56 -03:00
ariel-
59fb0a581c Core/Spells: fix Vampiric touch dispel effect inheriting damage done pct twice 2018-02-12 19:32:59 -03:00
ariel-
c7095375c3 Core/Unit: kill unused parameter from SpellxxxBonusTaken 2018-02-12 18:36:10 -03:00
ariel-
e73bfe8df8 Core/Spells: implemented SpellPriority field from SpellEntry to cleanup charged mod proc behaviour
- Only one charged mod will be consumed per SpellMod apply, and it'll be compared against other mod priority
- This is proper way of handling Backdraft/Backlash and Deathchill/Killing Machine

Thanks to killerwife for info
2018-02-12 03:09:22 -03:00
ariel-
dfa861593e Core/Spells: add log on load about improper use of attribute PROC_ATTR_REQ_SPELLMOD 2018-02-12 00:21:26 -03:00
ariel-
546a605bd0 Core/Spells: implement SPELLVALUE_CRIT_CHANCE and SPELL_ATTR4_INHERIT_CRIT_FROM_AURA
Closes #18813
2018-02-12 00:21:26 -03:00
ariel-
52873a7072 Core/Spells: calculate crit chance only for spells that do damage/healing
Refs #18813
2018-02-12 00:21:26 -03:00
ariel-
9d0e90829c Core/Auras: fix periodic ticks proc after previous commit 2018-02-11 21:09:41 -03:00
ariel-
b42ade918a Core/Spells: require phasemask set for periodic damage procflag
Closes #21379
2018-02-11 20:42:06 -03:00
ariel-
303efcf0e4 Core/Spells: remove 'Vanish Purge' hack, the spell is present on DB and is copy of one in vanilla DBC
Thanks to killerwife for the heads-up
2018-02-08 23:18:45 -03:00
ariel-
ed931cfa19 Core/ScriptSystem: AfterHit hook can't modify damage/healing, so log it
- Also added const to getter members
2018-02-05 14:43:11 -03:00
ariel-
65709e1c30 Core/Spells: fix logic error causing near teleports to drop combat for players
Closes #21362
2018-02-04 22:47:53 -03:00
ariel-
e979a58d17 Core/Spells: remove duplicated LowerPlayerDamageReq call on reflected spells
- It is already called at Unit::DealDamage
2018-02-04 22:07:10 -03:00
ariel-
2d2c43f4b9 Core/Spells: fix SPELLMOD_DAMAGE application order for melee spells
Closes #20597
2018-02-04 21:28:15 -03:00
ariel-
9fc732eb97 Core/Spells: kill unused parameter from Spell constructor
Added in 1f2292af79
2018-02-04 20:15:38 -03:00
Killyana
8f71307e56 Spell/Script: Torch 52953 and 58121 must hit only one target 2018-01-30 13:04:25 +01:00
ariel-
b1072faa50 Core/Spell: killed deprecated code which randomly changed powercost for missed spells
Added in 80d3cd43f6

Closes #5954
2018-01-24 13:07:01 -03:00
ariel-
c099174ff7 Core/Misc: fix some /W4 warnings and some reported by GCC 6.3 2018-01-22 23:55:33 -03:00
ariel-
4402f71eb7 Core/Spells: fix Spirit of Redemption
- Who would have suspected GetAuraEffect (iconId override) did a check against null spellfamilyflags?
- Remove mirror timers hack (triggered spell already allows underwater breathing)
2018-01-21 21:18:02 -03:00
ariel-
f1896144c0 Core/Auras: fixed EquippedItemClass check
follow-up to 29c3b7d8f6
2018-01-18 19:14:38 -03:00
ariel-
29c3b7d8f6 Core/Auras: define and implement attribute SPELL_ATTR3_IGNORE_PROC_SUBCLASS_MASK
Closes #20148
2018-01-18 16:08:24 -03:00
ariel-
b75ff7d4bf Core/Globals: revert back to unordered_map for templates
Partial revert of commit b64c504314
See discussion on b64c504314
2018-01-18 01:07:29 -03:00
ariel-
b64c504314 Core/Globals: throw some RAII into ObjectMgr, and load templates into vectors
Ref #14274
2018-01-17 02:17:49 -03:00
ariel-
5153f464d8 Core/Auras: fix static analysis issues
CID 1384433
CID 1384436
2018-01-14 17:23:48 -03:00
ariel-
01537e1dfb Core/Unit: fix mess-up with CalcArmorReducedDamage parameter order 2018-01-14 17:19:26 -03:00
ariel-
f1986c6aaf Core/Entities: implement secondary damage for some weapons and removal of old voodoo
- Fixed correct Retaliation damage spell according to sniffs is 20240
- CalcArmorReducedDamage insisted on dealing a minimum of 1 damage even if damage was 0
- CalculateDamage was zero-phobic too: it defaulted to arbitrary max 5 damage

Closes #19081
2018-01-14 09:23:34 -03:00
ariel-
22b24d8dae Core/Unit: fixed crash
Closes #21231
2018-01-13 21:36:06 -03:00