Commit Graph

21698 Commits

Author SHA1 Message Date
Treeston
f6f1c48aa5 Entities/Player: Clean up client control handling behavior around possession. Mind Control should no longer cause various weirdness. Closes #23539. 2019-07-02 11:58:12 +02:00
Wyrserth
a8b8a43b8d Script/HallsOfLightning: fix mistake related to Shattering Stomp in Volkhan's script, introduced in 3bb0abcd52.
Closes #23337.
2019-07-02 11:12:34 +02:00
ForesterDev
b47bb59e2a Core/Player: add helper methods GetNativeGender/SetNativeGender/SetGender (#23520)
* Core/Player: add helper methods GetNativeGender/SetNativeGender/SetGender and fix some cases, where we should get player gender, instead of modified by display gender

* fix merge

* Add virtual methods for Unit class
2019-07-02 10:17:02 +02:00
ccrs
401777d024 Core/Unit: rename several getters to follow codestyle
uint8 GetLevel()
        uint8 GetLevelForTarget(WorldObject const* /*target*/)
        void SetLevel(uint8 lvl)
        uint8 GetRace()
        uint32 GetRaceMask()
        uint8 GetClass()
        uint32 GetClassMask()
        uint8 GetGender()
2019-07-01 21:36:32 +02:00
Sorikoff
5c09ff51f7 Scripts/Spells: Dimensional Ripper - Everlook (#23547) 2019-07-01 20:55:30 +02:00
Wyrserth
028d16a812 Script/DarkmoonFaire: fix logical error in go_darkmoon_faire_music.
Closes #23548.
2019-07-01 14:39:52 +02:00
Wyrserth
c8289ada7f Core/Quest: do not send SMSG_QUESTGIVER_OFFER_REWARD right after SMSG_QUESTGIVER_QUEST_FAILED.
Allows the gossip window to close after the client receives a quest failed error (for example: not enough inventory space to store the reward).
2019-07-01 01:19:31 +02:00
ccrs
4c398743b9 Scripts/ICC: cleanup ReadSaveDataMore definition 2019-07-01 01:08:21 +02:00
ccrs
b19a23a5c6 Scripts/ICC: 3dbf3fe followup
repeat timer typo
2019-07-01 00:56:05 +02:00
Wyrserth
61ba1351e0 Core/Quest: if a quest rewards a title, show it in the offer reward screen too.
Also fix delete query in fa0fc13fd0, thanks Aokromes for noticing!
2019-07-01 00:46:55 +02:00
Wyrserth
39aa91f982 Core/Spell: Challenge Flag should only hit one target. 2019-06-30 22:47:17 +02:00
ccrs
aabf181bdf Build: fix error
/home/circleci/project/src/server/scripts/Northrend/IcecrownCitadel/boss_sister_svalna.cpp:211:5: fatal error: redefinition of enumerator 'NPC_YMIRJAR_BATTLE_MAIDEN'
    NPC_YMIRJAR_BATTLE_MAIDEN = 37132,
    ^
/home/circleci/project/src/server/scripts/Northrend/IcecrownCitadel/icecrown_citadel.h:274:5: note: previous definition is here
    NPC_YMIRJAR_BATTLE_MAIDEN                   = 37132,
    ^
1 error generated.
2019-06-30 19:54:05 +02:00
ccrs
3dbf3fed7c Scripts/ICC: base support for Ymirjar Vrykuls AI 2019-06-30 19:48:50 +02:00
ccrs
3e9b553618 Scripts/ICC: 1eb2aef followup 2019-06-30 18:10:23 +02:00
ccrs
1eb2aef179 Scripts/ICC: move Sister Svalna to her own file
I've almost guttered her, so lets try it more gently this time
2019-06-30 17:50:30 +02:00
ccrs
b9a8095967 Core/Instance: 14788ce followup
No need to repeat code
2019-06-30 15:47:17 +02:00
ccrs
eb6ea57e7f Scripts/ICC: 94b60ff followup 2019-06-29 19:38:16 +02:00
ccrs
14788ce026 Core/Instance: add new method 2019-06-29 19:32:13 +02:00
ccrs
953b05459a Core/Instance: add new hook & method 2019-06-29 19:24:05 +02:00
ccrs
303811399f Build: fix error
/var/lib/jenkins/jobs/tc_335_release_clang40_boost_1.63.0_nopch/workspace/src/server/scripts/Kalimdor/CavernsOfTime/CullingOfStratholme/npc_arthas.cpp:583:132: warning: format specifies type 'unsigned int' but the argument has type 'float' [-Wformat]
                TC_LOG_TRACE("scripts.cos", "npc_arthas_stratholmeAI::AdvanceToState: has snapback for this state, distance = %u", target.SnapbackPosition->GetExactDist(me));
                                                                                                                              ~~   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                                                                                                              %f
/var/lib/jenkins/jobs/tc_335_release_clang40_boost_1.63.0_nopch/workspace/src/common/Logging/Log.h:176:56: note: expanded from macro 'TC_LOG_TRACE'
    TC_LOG_MESSAGE_BODY(filterType__, LOG_LEVEL_TRACE, __VA_ARGS__)
                                                       ^~~~~~~~~~~
/var/lib/jenkins/jobs/tc_335_release_clang40_boost_1.63.0_nopch/workspace/src/common/Logging/Log.h:159:32: note: expanded from macro 'TC_LOG_MESSAGE_BODY'
                    check_args(__VA_ARGS__);                            \
                               ^~~~~~~~~~~
2019-06-29 18:40:31 +02:00
ccrs
22b3b21ae3 Core/Instances: improve DoRemoveAurasDueToSpellOnPlayers & DoCastSpellOnPlayers handling 2019-06-29 18:36:11 +02:00
ccrs
626a24822b Misc: some corrections after recent merges 2019-06-29 16:01:58 +02:00
Sorikoff
33b4ad5a89 Scripts/Spells: Ultrasafe Transporter: Toshley's Station (#23537)
* Scripts/Spells: Ultrasafe Transporter: Toshley's Station

* Rename 9999_99_99_99_world.sql to 2019_06_29_01_world.sql
2019-06-29 14:02:04 +02:00
Sorikoff
8d1a5fa126 Scripts/Spells: Remove Collapsing Cave Aura (#23533)
* Scripts/Spells: Remove Collapsing Cave Aura

* Rename 9999_99_99_99_world.sql to 2019_06_29_00_world.sql
2019-06-29 13:35:11 +02:00
Wyrserth
eb7a6391aa Core/Loot: fix issue that prevented players from rolling for an unique-category item while an equipped item shares the same unique-category. 2019-06-29 01:46:54 +02:00
Wyrserth
37bcf343e2 Add forgotten break to High Priest Thekal's script, thanks jackpoz! 2019-06-28 22:46:25 +02:00
jackpoz
de88691e25 Core/Misc: Fix static analysis issues reported by Coverity Scan 2019-06-28 22:18:30 +02:00
Sorikoff
62b2c379b3 Scripts/Spells: Deathbolt (#23531)
* Scripts/Spells: Deathbolt

* Rename 9999_99_99_99_world.sql to 2019_06_28_01_world.sql
2019-06-28 20:18:02 +02:00
Sorikoff
63f548921c Scripts/Spells: Dimensional Ripper - Area 52 (#23505)
* Scripts/Spells: Dimensional Ripper - Area 52

* Rename 9999_99_99_99_world.sql to 2019_06_28_00_world.sql
2019-06-28 20:15:16 +02:00
Wyrserth
cd73664f53 Core/GameObject: do not allow consumable chests to restock while partially looted. 2019-06-28 19:28:30 +02:00
Wyrserth
9f0ac0c243 Core/GameObject: fix some cases where summoned gameobjects of a type different than chest or goober would behave wrongly. 2019-06-28 16:53:39 +02:00
Wyrserth
5dc2dfd60c Core/Spell: fix some issues with taunt spells (#23425) 2019-06-27 22:08:39 +02:00
Wyrserth
cf223370f3 Core/Mail: include 100g in the mail sent after turning in the quest The Wrath of Neptulon (#23500) 2019-06-27 22:07:00 +02:00
Wyrserth
365e2f191e Script/ZulGurub: rewrite High Priest Thekal's encounter script (#23429) 2019-06-27 21:03:29 +02:00
Wyrserth
cb524a06b7 Core/GameObject: trigger an update of nearby objects when the player completes a quest objective.
Prevents quest-related gameobjects from staying lootable after the player looted the last quest item from another gameobject.
2019-06-27 20:30:26 +02:00
Wyrserth
e77c2d55c4 Core/GameObject: implement restock mechanic for non-consumable gameobjects (#23526) 2019-06-27 20:27:04 +02:00
Wyrserth
eeba12778b Core/SAI: add param3 to SMART_ACTION_CALL_TIMED_ACTIONLIST to allow it to override a currently running actionlist. 2019-06-27 01:48:12 +02:00
Wyrserth
50c5d30d13 Core/GameObject: restore old behavior for non-consumable chests with restock timer (make them despawn). 2019-06-26 22:02:27 +02:00
Wyrserth
2b1e8d135b Core/GameObject: don't allow non-consumable goobers to despawn on use (#23469)
Closes #15730.
2019-06-26 18:28:08 +02:00
Wyrserth
efc999227d Core/Spell: allow damage from binary spells to go through elemental resistance's damage reduction. (#23479) 2019-06-26 18:25:06 +02:00
Wyrserth
7a71127da9 Core/SAI: allow creatures to handle gameobject spellhit SAI events. (#23492) 2019-06-26 18:08:19 +02:00
Wyrserth
8967cc96df Core/SAI: do not pass old creatureData to UpdateEntry() and keep current health when changing a NPC's entry. (#23493) 2019-06-26 18:03:03 +02:00
Keader
079b77b5fc Script/FoS: prevent Wailing Souls from becoming desynched in the Devourer of Souls encounter. 2019-06-26 17:32:06 +02:00
Wyrserth
22b222b44e Script/CoS: fix DB error and remove wrong on-death text for Chrono-Lord Epoch. 2019-06-26 12:06:45 +02:00
Aokromes
fe744977c9 Coding standards (#23514)
* Coding standards

* revert part
2019-06-26 08:56:20 +02:00
Treeston
63383da36e fix comment, 3cdf274 follow-up 2019-06-26 01:06:01 +02:00
Treeston
3cdf27494f Core/AI: Actually accurately reproduce the logic from before 849943 that determines what summons start following on appearance. Third time's the charm?
Closes #23513.
2019-06-26 01:04:27 +02:00
ccrs
ca62280675 Script/CoS: full instance rewrite (#23388) 2019-06-25 20:56:43 +02:00
Wyrserth
c95531595e Core/SAI: silence wrong SAI error when using SMART_ACTION_SET_DATA on a creature using CreatureAI.
This behavior is fully allowed and should not report any kind of error.
2019-06-25 18:06:20 +02:00
Shauren
c0b25c9a83 Core/Creatures: Fixed crash in CreatureAI::JustAppeared caused by scripted summons without SummonProperties
Closes #23507
2019-06-24 18:47:04 +02:00