Commit Graph

8796 Commits

Author SHA1 Message Date
Shocker
f106db551b Forgotten file from previous commit regarding magic numbers cleanup
--HG--
branch : trunk
2010-09-28 08:41:24 +03:00
Shocker
78803c9f09 Magic numbers cleanup:
- Replace many magic numbers with constants
- Use enum for vehicle flags/seat flags
- Correct structure for ItemRandomSuffixEntry

--HG--
branch : trunk
2010-09-28 08:21:51 +03:00
Shocker
192e972a59 Core/Spells: Remove outdated code for Vampiric Embrace
--HG--
branch : trunk
2010-09-28 04:13:48 +03:00
Spp
b1c97f15bf Core/Dungeon Finder: Remove Spell 72221 when leaving a dungeon using the portal
--HG--
branch : trunk
2010-09-27 23:27:52 +02:00
Spp
1afdd143d9 Core/Dungeon Finder: Fix bad use of iterator that made LFG inconsistent and sometimes crash
Closes issue 4009

--HG--
branch : trunk
2010-09-27 23:19:22 +02:00
Xanadu
781592d63a Core/Spells: * Removed special handling of SPELL_AURA_ABILITY_IGNORE_AURASTATE, now handled by the proc system (again).
* Fixed Fingers of Frost buff display. Closes issue #3324.

--HG--
branch : trunk
2010-09-27 20:30:47 +02:00
click
8c9501286f Scripts/Vazruden: Stop the infinite respawning of the lootable chest after the Vazruden fight. (Fix by Leak)
Closes issue 4186.

--HG--
branch : trunk
2010-09-27 05:44:50 +02:00
click
88420cdcd1 Core/Spells: Do not allow adding USE-enhancements on items that already has a Use: spell. Fixes a possible exploit (original fix by Leak)
(Cleaned up to adhere to codingstandards)
Closes issue 4185.

--HG--
branch : trunk
2010-09-27 05:41:13 +02:00
click
ee705bba32 Core/OjectMgr: Properly load guildbank items (and some minor cleanups)
- fixes issues where guildbanks looked empty but weren't
- kudos to Linencloth for the discussion and thorough breakdown of this issue
Closes issue 4199.

--HG--
branch : trunk
2010-09-27 04:16:41 +02:00
Shocker
ede2a1c5ed Core/Quests: Make sure itemcount doesn't get to be negative.
Since this is an old issue and probably there are various entries with huge values as itemcounts already, a cleanup must be done before changing structure of character_queststatus which was done in r9be097c482, thus I'll include the SQL cleanup in that revision's .sql file or MySQL will thrown an error regarding out of bounds values

--HG--
branch : trunk
2010-09-27 02:57:01 +03:00
Machiavelli
a9e9a2c884 Core/DBLayer:
- DB Threading model update
* Get rid of ThreadBundleMask and bundled connection
* Implement configurable amount of Synch threads for databasepools
* Use modulus based algorithm to check for free synchronous connections instead of previous ¨get connection by thread key or bundlemask¨ feature
* Locks on mysql context objects are now managed outside the mysql query methods

Fixes issue #4058
Fixes issue #4059
Introduces a ton of more issues. Use at own risk. You were warned. Really.

Don´t forget to update your worldserver.conf

--HG--
branch : trunk
2010-09-27 00:20:56 +02:00
Shocker
894b2081b3 Core/DB: Adjust max values for some columns in character_queststatus
--HG--
branch : trunk
2010-09-27 00:38:22 +03:00
Shocker
75f5e9756e Core/Commands: Allow .gobject near to print gameobject entry too
--HG--
branch : trunk
2010-09-26 23:46:31 +03:00
silinoron
7375951ea8 merge
--HG--
branch : trunk
2010-09-26 12:25:01 -07:00
silinoron
ededb13915 Core/World: Move some packet code out of World.cpp
--HG--
branch : trunk
2010-09-26 12:23:29 -07:00
Shauren
2e2951d037 Core/Players: Fixed action bar issues when changing active spec
--HG--
branch : trunk
2010-09-26 21:15:15 +02:00
silinoron
64378832c8 Core: Some cleanup in AddonHandler.
--HG--
branch : trunk
2010-09-26 12:06:16 -07:00
silinoron
0722348240 Core: Coding style cleanup.
--HG--
branch : trunk
2010-09-26 12:04:47 -07:00
Rat
bbf86641a1 Core/Scripts/SmartAI: removed test code
Core/CreatureTextMgr: added reload command
handle text from DB
handle grouped texts
handle repeatable/single texts based on probability
todo: sound/emote, code cleanup

--HG--
branch : trunk
2010-09-26 20:48:25 +02:00
Spp
133ab88f8c Core/Groups: Add missing parentesis from 5f4b58ea4b
Fixes issue 4194

--HG--
branch : trunk
2010-09-26 17:50:11 +02:00
Spp
ef74eb171d Core/Dungeon Finder: Fix a typo in 2a4986d5a0 that made server crash
Fixes issue 4193

--HG--
branch : trunk
2010-09-26 15:13:21 +02:00
Spp
c2a4c39060 Core/Dungeon Finder: Allow 1 member groups
--HG--
branch : trunk
2010-09-26 14:51:42 +02:00
Spp
2718701708 Core/Dungeon Finder: Add support for dungeon cooldown and luck of the draw spells
--HG--
branch : trunk
2010-09-26 14:49:55 +02:00
Spp
ef16cc9109 Core/Dungeon Finder: Add lfg state to know if a player is using lfg or lfr
- Do not allow to join battleground if using lfg/lfr

Closes issue 4189

--HG--
branch : trunk
2010-09-26 13:59:51 +02:00
Shauren
07fc33a083 Core/Commands: Fixed crashes in .ban info and .ban list
--HG--
branch : trunk
2010-09-26 13:00:44 +02:00
Rat
9ea9effadd Core/Scripts/SmartAI: add test for TextMgr (temp)
Core/CreatureTextMgr: added basic chat function, you can now experiment with it if bored

--HG--
branch : trunk
2010-09-25 23:52:17 +02:00
Machiavelli
a1358880c2 Core/Commands: Fix a crash in .gm list
--HG--
branch : trunk
2010-09-25 23:09:53 +02:00
click
461590832a Core: Generic cleanup (tab2spaces/whitespace removal)
--HG--
branch : trunk
2010-09-25 22:03:57 +02:00
click
a596cae1d9 Tools/Vmap3Assembler: Clean up vmap3-assembler (patch by dasblub/lynx3d)
- drop dead code
- use std::string and std::cout instead of char*/printf() -methods

--HG--
branch : trunk
2010-09-25 21:59:01 +02:00
click
3f9dd596f7 Tools/Mapextractor: Output each processed map to a separate line (more output) - thanks to imbecile
Closes issue #4116

--HG--
branch : trunk
2010-09-25 21:48:17 +02:00
click
f077277aa1 Buildsystem: Set revision.h as a required dependency build before building game, shared, worldserver and authserver
--HG--
branch : trunk
2010-09-25 21:42:11 +02:00
Shocker
87ff64431c Core/Maps: Fix crash in ExistMap, fixes issue 4115
--HG--
branch : trunk
2010-09-25 20:09:20 +03:00
Rat
28e90bbb60 Core/Scripts/SmartAI: added SmartAI files
Core/DBLayer/Texts: added CreatureTextMgr files
BuildSystem: added cmake for above files
Note: these are still under development and NOT USABLE
should not effect anything now

--HG--
branch : trunk
2010-09-25 18:47:03 +02:00
Machiavelli
562e3955a9 Core/Logging: Change some spell log output to debug level instead of error level. Author svetilo12
Fixes issue #3793

--HG--
branch : trunk
2010-09-25 17:53:20 +02:00
Shocker
6b65e886f2 Core/Chat: Use universal language for party leader too when allowing twoside groups
--HG--
branch : trunk
2010-09-25 18:50:36 +03:00
Machiavelli
fec6143f42 Core/SocialMgr: Do not load recently deleted (but existant) characters to social (friend/ignore) lists.
Fixes issue #3870
Fixes issue #3610

--HG--
branch : trunk
2010-09-25 17:34:26 +02:00
Machiavelli
6bb5823836 Core/Player: Fix achievements loading from DB
--HG--
branch : trunk
2010-09-25 17:10:00 +02:00
Machiavelli
a312a667cb Core/Player: Correctly send social list to player on login. Fixes display of number of online friends in the icon on the chat pane.
Fixes issue #3807.

--HG--
branch : trunk
2010-09-25 17:08:55 +02:00
click
5aaef4601a Buildsystem: Reinstate the revision.h target (as always outdated target, will be regenerated on each run)
Fixes issue 4054

--HG--
branch : trunk
2010-09-25 16:42:55 +02:00
Shauren
dfeb41f7d9 Core/Items: Readded enchantment loading fix
--HG--
branch : trunk
2010-09-25 15:45:52 +02:00
Shauren
57df06c7f5 Core/Spells: Fixed power burn effects showing mana restored to caster
Closes issue #4078.

--HG--
branch : trunk
2010-09-25 15:03:48 +02:00
Machiavelli
311ae331ad Core/InstanceSaveMgr: Statically define ResetTimeDelay as class member instead of redefining it in different functions
--HG--
branch : trunk
2010-09-25 14:47:24 +02:00
Shauren
24e24020d1 Core/Players: This should fix crashes related to trading soulbound items
Updates issue #4162.
Updates issue #4165.

--HG--
branch : trunk
extra : rebase_source : eb30f245cb3a24ade6823d2fbb025cc9998870df
2010-09-25 14:12:50 +02:00
Machiavelli
a24b84e6f7 Core/Commands: Fix a crash in .account onlinelist
Fixes issue #4176

--HG--
branch : trunk
2010-09-25 13:58:29 +02:00
Machiavelli
477b30a1ad Core/DBLayer: Fix a memory leak in Field class, properly clear buffer before repopulating it.
Fixes many issues (from wrong subnames on NPCs to absent GO/Creature spawns)
Thanks to Rat for helping find the issue

--HG--
branch : trunk
2010-09-25 13:12:12 +02:00
Machiavelli
62946f9ef6 Core/DBLayer:
- Rewrite KeepAlive method for DatabaseWorkerPool. Use mysql_ping instead of explicit select queries, and also schedule KeepAlives for asynchronous threads.
NOTE: While the function is implemented and previous keepalive calls were transformed, it´s possible the keepalive call will need to be placed in several other locations in the code. Please leave feedback on whether or not this fixes your timeout issues.

Update issue #4062

--HG--
branch : trunk
2010-09-25 01:05:24 +02:00
Machiavelli
154d11acc0 Core/DBLayer:
- Fix another pesky linux specific compile error. (Thanks to Derex/Aokromes)
- Fix a typo in an assertion. (Thanks to Derex/Aokromes)
- Add proper zero termination in SetStructuredValue to get rid of memory issues that arose in the last few commits.
- Fix a crash caused by vsprintf´ing std::string in SystemMgr::LoadVersion()

--HG--
branch : trunk
2010-09-25 01:02:40 +02:00
Machiavelli
09aeff1027 Core/DBLayer: Return proper connection handle from DatabaseWorkerPool<T>::GetConnection
Updates issue #4062
Updates issue #4058

--HG--
branch : trunk
2010-09-24 22:41:24 +02:00
Machiavelli
e3bf89b6f7 Core/DBLayer:
- Fix memory leak introduced in previous rev
- Fix linux compile, thanks to Playon for reporting

--HG--
branch : trunk
2010-09-24 22:36:35 +02:00
Machiavelli
3c6dc32030 Core/DBLayer:
- Rewrite Field class to be able to store both binary prepared statement data and data from adhoc query resultsets
- Buffer the data of prepared statements using ResultSet and Field classes and let go of mysql c api structures after PreparedResultSet constructor. Fixes a race condition and thus a possible crash/data corruption (issue pointed out to Derex, basic suggestion by raczman)
- Conform PreparedResultSet and ResultSet to the same design standards, and using Field class as data buffer class for both
* NOTE: This means the fetching methods are uniform again, using ¨Field* fields = result->Fetch();¨ and access to elements trough fields[x].
* NOTE: for access to the correct row in prepared statements, ¨Field* fields = result->Fetch();¨ must ALWAYS be called inside the do { }while(result->NextRow()) loop.
* NOTE: This means that Field::GetString() returns std::string object and Field::GetCString() returns const char* pointer.

Still experimental and all that jazz, not recommended for production servers until feedback is given.

--HG--
branch : trunk
2010-09-24 22:16:21 +02:00