Commit Graph

8569 Commits

Author SHA1 Message Date
joschiwald
f1bfd43c58 Core/Misc: remove error log, which returns false positives 2014-02-02 16:15:07 +01:00
Discover-
e59f3f7333 Core/Chat: Fix a new issue caused by c0224dd7ca which would trigger false positives for CHAT_MSG_AFK and CHAT_MSG_DND. 2014-02-02 15:13:53 +01:00
jackpoz
8f29fb9aee Core/Spell: Handle SPELL_AURA_FORCE_REACTION missing cases
Always check forced reputation ranks before any other faction check to get the reaction between 2 units.
Fixes #5790
2014-02-01 21:21:47 +01:00
joschiwald
11b48569c8 Core/Spells: fix crash when loading custom spell attr with invalid spellid 2014-02-01 19:23:20 +01:00
w1sht0l1v3
2df3fe3a00 Core/Scripts: Fix quest The Totem of Kar'dash alliance version.
Remove some hungarian notation for horde side version.

Closes #11035
2014-02-01 19:07:48 +02:00
Discover-
c0224dd7ca Core/Chat: Fix an exploit where it was possible to speak in universal language in say/yell/emote by sending CMSG_MESSAGECHAT using cheats. 2014-02-01 13:27:16 +01:00
Shauren
19172ee4c2 Build: Use override/final keywords for VS 2012 and newer. (VS 2013 still defines __cplusplus as 199711L) 2014-01-31 23:30:25 +01:00
jackpoz
b054275fb2 Shared/Logs: Fix crash in Console log output
Correctly handle the return value of vsnprintf() which returns -1 if the buffer is too small http://msdn.microsoft.com/en-us/library/1kt27hek.aspx . In this case just truncate the output.
This caused a crash on character delete if Logger.entities.player.dump was enabled and set to 3.
Fixes #11539
2014-01-31 22:11:49 +01:00
jackpoz
68d48ecbd1 Core/Arena: Fix arena season not always appearing to clients
Arena season sent to client with SMSG_INIT_WORLD_STATES opcode was not sent if Player was on a zone with id 0 on login. Initializing the zone id to -1 will always trigger UpdateZone() properly on login.
Fixes #10623
2014-01-31 20:47:47 +01:00
Duarte Duarte
5666c7cc35 Core/Achievs: Rename a few unknown achievement criteria flags
Source tomrus88, Mangos
2014-01-31 15:43:24 +00:00
Discover-
a242662ae6 Core/Spells: Fix DK Ghoul's damage after ad8eb434c0. I misread 'SpellScript::m_damage' for 'SpellScript::damage'.
By @joschiwald
2014-01-31 10:37:55 +01:00
Duarte Duarte
d749b72193 Core&DB/Spells: Move custom spell attributes from code to DB, spell_custom_attr table
`spell_custom_attr`
- `entry` uint PK
- `attributes` uint (enum SpellCustomAttributes of SpellInfo.h)
2014-01-31 04:32:03 +00:00
QAston
9495194bf2 Fix warnings introduced on littleendian in 2134cb610d
This fix prevents possible issues on bigendian machines. Don't use c style casts ppl, it's evul.
2014-01-30 23:43:37 +01:00
jackpoz
856e0933b5 Scripts/HoR: Fix log error
Fix "DoZoneInCombat called for creature that has empty threat list" error caused by DoZoneInCombat() called by IsSummonedBy() in a script before the Creature is allowed to enter combat.
2014-01-30 21:29:37 +01:00
jackpoz
378d27f9bc Core/Splines: Fix "velocity > 0.1f" error
Updates #6191.
2014-01-30 20:03:13 +01:00
Discover-
ad8eb434c0 Core/Misc: Missing changes and get rid of useless method in acd46085d1 2014-01-30 10:28:05 +01:00
joschiwald
acd46085d1 Core/Spells: drop last leftovers of hardcoded spell target selection and move it into spellscripts
Closes #1719
Closes #3186
2014-01-30 02:40:12 +01:00
joschiwald
166f7d41da Core/Spells: addition to 96060bf007 2014-01-27 23:01:37 +01:00
joschiwald
6dc15294e2 Core/Spells: move paladins judgements to spellscripts 2014-01-26 23:56:53 +01:00
QAston
139ee0c8b7 Fix incorrect debug log in authserver 2014-01-26 22:04:45 +01:00
w1sht0l1v3
38436f21c6 Core/Gameobjects: Fix not being able to use the fishing node/float after 6b25c2b414 2014-01-26 22:46:10 +02:00
QAston
2134cb610d Remove unneeded bigendian checks (they're already part of EndianConvert). 2014-01-26 21:32:07 +01:00
Vincent_Michael
79a2a0c434 Core/Spell: Fix logic fail in 96ae4caf62 2014-01-26 16:42:02 +01:00
Aokromes
d2e782a13b Core/Spells: Add SPELL_ATTR0_CU_REQ_CASTER_BEHIND_TARGET to some Backstab spells
Original fix by Bruescrues

Closes #10767

Signed-off-by: Duarte Duarte <dnpd.dd@gmail.com>
2014-01-26 14:26:25 +00:00
Vincent_Michael
96ae4caf62 Core/Spells: Fix typo in 955fb907c5 2014-01-26 03:56:41 +01:00
Vincent_Michael
955fb907c5 Core: Fix warnings 2014-01-26 03:48:33 +01:00
joschiwald
fbddda52e7 Core/Spells: move more spells to spellscripts 2014-01-26 02:24:57 +01:00
joschiwald
96060bf007 Core/Spells: move some spells so spellscripts 2014-01-26 01:02:20 +01:00
jackpoz
88a5d01016 Core/Calendar: Crash fix
Attempt to fix #11512 crash by adding a NULL check since GetEvent() can return NULL.
2014-01-25 21:28:01 +01:00
Discover-
6b25c2b414 Core/Gameobjects: Fix an exploit where it was possible to use gameobjects from any distance. Fixes for example picking up the WSG flag from any distance using hacking tools. 2014-01-25 16:59:01 +01:00
Vincent_Michael
c6650ecc71 Core/Spells: Move Pilgrims Bounty BuffFood in AuraScript (mimimi) 2014-01-25 16:28:29 +01:00
Dehravor
e619246d58 Core/SkillHandler: Check if player is using proper NPC on talent reset 2014-01-25 10:55:29 +01:00
Vincent_Michael
9531073b77 Scripts: Gossip can crash with null instance 2014-01-24 17:08:17 +01:00
Discover-
d7f76f2eda Merge pull request #11396 from natepizzle/master
SpellAuraEffects
2014-01-24 02:32:02 -08:00
Discover-
08bc9da22e Merge pull request #11499 from Dehravor/taxi-node
Core/Taxi: Fix exploit related to unexplored nodes
2014-01-24 02:15:14 -08:00
Vincent_Michael
abc1effd80 Core: Fix non pch build 2014-01-24 06:19:52 +01:00
joschiwald
b169d6bafb Fix build 2014-01-24 01:47:24 +01:00
joschiwald
f0c4224603 Core/Spells: move killing spree to spellscript
Closes #10597
Closes #11468
2014-01-24 01:32:15 +01:00
Vincent_Michael
46e1b93c2b Scripts: A lots of changes here and there (maybe useless?!?) 2014-01-23 22:54:01 +01:00
jackpoz
92c3ca7828 Core/CrashHandler: Add more informations about locals
Log "NULL" for NULL pointers.
Log the correct type instead of <user defined> for pointers and log its fields recursively.
Log locals of all threads.
Log the address if retrieving the value threw an exception.
Increase buffer sizes to avoid buffer overflows.
2014-01-23 21:41:15 +01:00
joschiwald
d6c5307a81 Scripts/Spells: use new hook in some spellscripts 2014-01-23 20:55:47 +01:00
Discover-
7d8b65b3cc Core/Chat: Disallow sending CMSG_MESSAGECHAT with CHAT_MSG_SAY, CHAT_MSG_EMOTE or CHAT_MSG_YELL while the sender is not alive.
Also replaced all WorldSession::_player calls by 'sender'

By @TakenBacon
2014-01-23 20:22:37 +01:00
Discover-
cb1964770e Core/Loot: Fix an exploit with CMSG_LOOT using non-creature guids which would allow you to loot despawned chests in some cases.
By @Kiddie
2014-01-23 20:09:13 +01:00
joschiwald
f731116766 Scripts/AhnKahet: fix some issues on prince taldaram script 2014-01-23 18:21:17 +01:00
joschiwald
a5b04e06f7 Core/SpellScripts: Implemeted SpellScript hook OnDestinationTargetSelect to easier modify SpellDestinations 2014-01-23 18:15:59 +01:00
Dehravor
e8e23ef03d Core/Taxi: Fix exploit related to unexplored nodes 2014-01-23 15:29:02 +01:00
MitchesD
57e599fa02 Scripts/ZulGurub/Jeklik: fixed flying in first phase, reworked spawn and rewritten to EventMap
Closes #11277
2014-01-22 23:46:45 +01:00
Gacko
678814836d Shared/OpenSSLCrypto: Add switch to fix build under Mac 2014-01-22 21:46:41 +01:00
Vincent_Michael
516a6344fe Misc: Fix warnings 2014-01-22 07:31:37 +01:00
Vincent_Michael
101ac7f511 Misc: Minor cosmetic changes here and there 2014-01-21 20:20:38 +01:00