Commit Graph

29783 Commits

Author SHA1 Message Date
Aokromes
f2fdbd81d6 fix build 2016-11-27 03:12:08 +01:00
ariel-
009adc4324 Revert "Core/Spell: add EquipedItemClass/EquippedItemSubClass check to passive spell casts"
This reverts commit f188ff1ce4.

Was breaking Titan's Grip.
Spells are loaded before items, and they CAST the spell on the player.
When items are then loaded, Player::ApplyItemDependentAuras only has AddAura on it. Titan's Grip is an effect, no auras involved.

In turn reverting this commit will now allow Two-handed weapon specialization and similar from spells load. Which is the lesser of two evils.
2016-11-27 03:11:27 +01:00
ariel-
6283cce52f Core/Player: fix build 2016-11-27 03:10:07 +01:00
ariel-
f348c015c0 Core/Spell: add EquipedItemClass/EquippedItemSubClass check to passive spell casts
- Was adding auras on login that didn't satisfy requirements (like Two-Handed Weapon Specialization)
2016-11-27 03:09:47 +01:00
Aokromes
c0ba6c2dfe Core/Auras: Rewritten conditionally applying SPELL_AURA_MOD_WEAPON_CR…
…IT_PERCENT, SPELL_AURA_MOD_DAMAGE_DONE and SPELL_AURA_MOD_DAMAGE_PERCENT_DONE auras

* Now the entire aura is removed when changing equipment
* All aura types can now depend on equipped items
2016-11-27 03:09:29 +01:00
Aokromes
0ca62b97e0 Core/Spells: Updated spell required items check, EquippedItemInventor…
…yTypeMask should only be used for enchantments
2016-11-27 02:45:32 +01:00
Aokromes
b2c17b4881 Core/Guild: avoid data integrity problems wrapping delete+insert statements in a transaction 2016-11-27 02:41:25 +01:00
Aokromes
ba8791ddcd Core/Player: recheck shapeshift bonus auras when switching spec.
- Fixes Leader of the Pack stuck when switching specs while shapeshifted
2016-11-27 01:53:19 +01:00
ariel-
bc25bbcd42 Core/Spell: register items received through SPELL_EFFECT_SUMMON_CHANGE_ITEM for quest credit
- Also sends proper SMSG_ITEM_PUSH_RESULT packet

Closes #3505
2016-11-27 01:42:18 +01:00
ariel-
331a88ef8f Core/Spell: Fixed Drain Soul incorrectly downscaling ranks when targetting lower level enemies 2016-11-27 01:41:58 +01:00
ariel-
b1b31fd685 Core/Gameobject: fixed sometimes not found linked trap
Closes #18256
2016-11-27 01:39:22 +01:00
Aokromes
6c76eff031 Core/Unit: fix some SPELL_AURA_MOD_DAMAGE_PERCENT_DONE effects being …
…applied more than once

No more overpowered dps for you
2016-11-27 01:36:22 +01:00
ariel-
227dc4d907 Core/Unit: fix build
Ctrl-S failure
2016-11-27 01:24:19 +01:00
Killyana
61df6ae629 DB/GameObjects: Cursed Egg
Add missing spawns with pooling and replace a hack script: d90a161619
2016-11-27 01:12:07 +01:00
ariel-
de4aec3204 Core/Spell: fix a potential null dereference crash 2016-11-27 01:09:37 +01:00
Aokromes
b5e37e956d DB/Vendor: Darnassus Quartermaster - no dialog
By Keldo
2016-11-26 04:01:39 +01:00
Krudor
64763f86de Core/Creatures: Enable swimming creatures to chase targets in 3d (#18298)
Closes #11060
2016-11-23 11:18:06 +01:00
ariel-
2f1910476e Core/Spell: fix warning 2016-11-19 07:40:32 +01:00
Aokromes
abea2d8d3f Core/Misc: Missing part 2016-11-19 07:27:22 +01:00
Aokromes
66b91e07fa Core/Misc: Compile fix try 2016-11-19 07:19:38 +01:00
Aokromes
d9e8c7a285 Core/Spell: Missing change, partialy revert change 2016-11-19 06:59:05 +01:00
Aokromes
dbd4fc3eca Core/Spell: Compile fix try 2016-11-19 06:35:33 +01:00
Aokromes
b1d4f802ef Core/Spell: move attribute helpers to spellInfo
- Renamed CheckEffectExecuteData to AssertEffectExecuteData and made const, better reflects its purpose
- Added missing attribute check to IsNextMeleeSwingSpell
- Reworked SPELL_ATTR4_CAST_ONLY_IN_OUTLAND attr check (researched behavior)
2016-11-19 06:23:06 +01:00
Aokromes
e4dd97765e Core/Spell: revamp of immunities system
- Spell attributes research
- Container optimization
- Do not skip damage immunity checks on SPELL_ATTR0_UNAFFECTED_BY_INVULNERABILITY present
- Added additonal arguments support to SendCastResult / CheckCast, spells can now send proper error messages
- Loads spell immune masks/states/effects at startup.
- This cached info is used whenever a spell cast requires immunities to be known beforehand (to see if an aura could be applied for example)
2016-11-19 06:10:14 +01:00
Aokromes
ab289e8494 DB/Misc: Rename files 2016-11-15 05:53:50 +01:00
ariel-
b7761ec52a DB/Spell: Vampiric Embrace proc
Closes #18250
2016-11-15 05:51:07 +01:00
Keader
04920d9422 :) 2016-11-15 05:50:06 +01:00
ariel-
50d7befa86 DB/Creature: correct 2 npc walk/run speed
Closes #18207
2016-11-15 05:49:58 +01:00
ariel-
b6f8ecbefc Core/GameObject: use a friendly trigger for positive spells.
Fixes an issue with Skadi Harpoons.

Note to self: should actually implement GameObject casting already :/
2016-11-15 05:48:22 +01:00
ariel-
ad927acae4 Core/Spell: do not fail triggered Charge effects in case a root is present.
Fixes Master's call when pet is rooted
2016-11-15 05:47:59 +01:00
ariel-
66fb271921 Core/Spell: use SpellEntry to select implicit targets in case RadiusEntry wasn't set for the current effect.
Closes #15388
2016-11-15 05:46:42 +01:00
ariel-
1fcb8e0b4e Core/Unit: consider creatures with same faction to be on the same party/raid for the purposes of spell/aura targets
Ref #18233
2016-11-15 05:46:05 +01:00
ariel-
760bef2453 Core/SpellScript: allow optional parameters to be passed to FinishCast
followup of 50a3ce5703
2016-11-15 05:45:56 +01:00
ariel-
0037363f3a Core/Battleground: Fix issue reported by static analysis 2016-11-15 05:45:08 +01:00
Keader
1dfc1f4d3b laze mind 2016-11-15 05:45:01 +01:00
Keader
444d43a62e duplicates 2016-11-15 05:44:53 +01:00
Keader
74b47932e7 Oops 2016-11-15 05:44:46 +01:00
Keader
f25038babb filter by nick/email and sorted 2016-11-15 05:44:38 +01:00
Keader
390d57d18f Added missing names in THANKS file 2016-11-15 05:44:20 +01:00
Killyana
6e46d801dd DB/Misc: Dark portal Event
Original work: 2f2f8a6110/sql/events/stair_of_destiny.sql
2016-11-15 05:43:55 +01:00
Keader
d6f31175f3 Core/Scripts: Cleanup in instance_black_temple and added missing datas (#18246)
* Core/Scripts: Cleanup in instance_black_temple and added missing datas

* Fixed door timing issue

* Remove redundant call
2016-11-15 05:43:45 +01:00
Shauren
5ddf50bdee Core/Auras: Fixed removing auras triggered by aurastates
Closes #17868

(cherry picked from commit f94e6cee38)
2016-11-15 05:43:30 +01:00
tkrokli
67edf04835 DB/gameobject: set positive spawntimesecs for 2 quest objects
176088 Scarlet Crusade Forward Camp (quest 5096 Scarlet Diversions)
180659 Drop-Off Point (for quest 8606 Decoy!)

by offl

Closes #18205
2016-11-15 05:42:00 +01:00
Aokromes
688942feec Missing part 2016-11-11 01:42:48 +01:00
Aokromes
a7d378689d Core/Auth: Resolved authentication bypass 2016-11-10 23:53:49 +01:00
Keader
8a94094c26 Core/Scripts: Fixed a typo and removed randtime of Shade of Akama events (#18231) 2016-11-10 23:45:11 +01:00
ariel-
03c3279395 Core/Gameobject: remove immune flags from trigger used to cast GO spells
Spells were failing flags check in Unit::_IsValidAttackTarget

Closes #18206
2016-11-10 23:42:29 +01:00
Aokromes
493dc8ed8f TDB 4.3.4.14 2016/11/06 2016-11-06 17:22:37 +01:00
Aokromes
958d5f2ca2 DB/Misc: rename files 2016-11-05 02:32:40 +01:00
Dr-J
8e068977be DB/SAI: Misc Summon spells
Update some sql scripts to summon creatures via spell instead of just summoning and kill the startup errors caused by my last commit to fix the spells.
2016-11-05 02:30:16 +01:00